| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=68657
TEST=XXXX
Review URL: http://codereview.chromium.org/7278026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=65540
TEST=net_unittests --gtest_filter=X509CertificateTest.VerifyReturn*
Review URL: http://codereview.chromium.org/6874039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
message.
R=gauravsh@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7541008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additionally, add more aggressive checks for invalid certificates in the chain.
This re-lands the portion of r93346 that was reverted in r94007.
BUG=88135, 90146
TEST=none
Review URL: http://codereview.chromium.org/7467038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7522014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=wtc@chromium.org
BUG=91051, 49377, 89703, 89899
TEST=Visit an HTTPS site which can be cached, such as https://bugs.webkit.org. Revisit the site, ensuring the item is loaded from the cache. Viewing the certificate viewer should show the entire certificate chain.
Review URL: http://codereview.chromium.org/7457025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7481009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Intended for the Beta branch.
(this is a reland of 88690)
BUG=91040
TEST=none
TBR=gavinp@chromium.org
Review URL: http://codereview.chromium.org/7518006
TBR=rvargas@google.com
Review URL: http://codereview.chromium.org/7453035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Intended for the Beta branch.
(this is a reland of 88690)
BUG=91040
TEST=none
TBR=gavinp@chromium.org
Review URL: http://codereview.chromium.org/7518006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The newly added sync perf tests fail on mac 10.5, but succeed on all other platforms.
On mac 10.5, the sync test server cannot be launched due to a syntax error. It turns
out that the sync test server had two instances of the except-as syntax, which was
added in Python3 and ported to 2.6, but not 2.5, which is the default on mac 10.5.
BUG=91006
TEST=sync_performance_tests, sync_integration_tests
Review URL: http://codereview.chromium.org/7531031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remove the getting cookies call inside ResourceDispatcherHost::CanGetCookies.
BUG=68657
TEST=XXXX
Review URL: http://codereview.chromium.org/7461121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unfortunately some URLFetchers were still alive. We have to kill them all before we kill the Profiles.
BUG=64339
TEST=none
Review URL: http://codereview.chromium.org/7533014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=90078
TEST=none
Review URL: http://codereview.chromium.org/7529017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which are
specified at http://balfanz.github.com/tls-obc-spec/draft-balfanz-tls-obc-00.html.
The code is based on cookie_monster.{cc,h} and sqlite_persistent_cookie_store.{cc,h}.
Add NET_API which caused previous compile failure in win-shared build.
BUG=88782
TEST=None
Review URL: http://codereview.chromium.org/7530015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
certificates, which are
specified at http://balfanz.github.com/tls-obc-spec/draft-balfanz-tls-obc-00.html.
The code is based on cookie_monster.{cc,h} and sqlite_persistent_cookie_store.{cc,h}.
BUG=88782
TEST=None
Review URL: http://codereview.chromium.org/7342021
TBR=rkn@chromium.org
Review URL: http://codereview.chromium.org/7523039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which are
specified at http://balfanz.github.com/tls-obc-spec/draft-balfanz-tls-obc-00.html.
The code is based on cookie_monster.{cc,h} and sqlite_persistent_cookie_store.{cc,h}.
BUG=88782
TEST=None
Review URL: http://codereview.chromium.org/7342021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
synchronous resolution.
BUG=90547,60149
TEST=net_unittests
Review URL: http://codereview.chromium.org/7520026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7531002
TBR=agayev@chromium.org
Review URL: http://codereview.chromium.org/7529008
TBR=agayev@chromium.org
Review URL: http://codereview.chromium.org/7530012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7531002
TBR=agayev@chromium.org
Review URL: http://codereview.chromium.org/7529008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7531002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL creates the following types of entries in the NetLog:
+URL_REQUEST_BLOCKED_ON_DELEGATE [dt= 59]
CHROME_EXTENSION_MODIFIED_HEADERS
--> deleted_headers = ["User-Agent"]
--> extension_id = "jclggdidhhmidgnnpcjjeggphijcajeg"
--> modified_headers = ["Foo: Bar"]
-URL_REQUEST_BLOCKED_ON_DELEGATE
+URL_REQUEST_BLOCKED_ON_DELEGATE [dt= 8]
CHROME_EXTENSION_ABORTED_REQUEST
--> extension_id = "jclggdidhhmidgnnpcjjeggphijcajeg"
-URL_REQUEST_BLOCKED_ON_DELEGATE
+URL_REQUEST_BLOCKED_ON_DELEGATE [dt=11]
CHROME_EXTENSION_REDIRECTED_REQUEST
--> extension_id = "mnadcejkmhgmdndhmplcebaplgddbhdi"
-URL_REQUEST_BLOCKED_ON_DELEGATE
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/7497033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL enables conflict resolution for the webRequest API.
- If any extension tries to cancel a request, this request is honored.
- If two extensions try to redirect the request, the one installed last wins, the other ones are ignored and reported (to stderr at the moment)
- If two extensions try to modify the *same* request header, the extension installed last wins, all header modifications of the other extension are ignored and the extension is reported (to stderr at the moment)
BUG=60101
TEST=no
Review URL: http://codereview.chromium.org/7499002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, some of the test case are moved for pr_time_unittests to time_unitests.
BUG=77962
TEST=base_unittests:TimeTest.*
Review URL: http://codereview.chromium.org/7470038
TBR=shinyak@google.com
Review URL: http://codereview.chromium.org/7520021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, some of the test case are moved for pr_time_unittests to time_unitests.
BUG=77962
TEST=base_unittests:TimeTest.*
Review URL: http://codereview.chromium.org/7470038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
List the --enable-origin-bound-certs switch in alphabetical order.
Remove the inaccurate description of origin-bound certificates.
R=rkn@chromium.org
BUG=88782
TEST=none
Review URL: http://codereview.chromium.org/7482001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
request to do synchronous resolution.
BUG=90547,60149
TEST=net_unittests --gtest_filter="HostResolverImplTest*"
Review URL: http://codereview.chromium.org/7465046
TBR=agayev@chromium.org
Review URL: http://codereview.chromium.org/7524018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
synchronous resolution.
BUG=90547,60149
TEST=net_unittests --gtest_filter="HostResolverImplTest*"
Review URL: http://codereview.chromium.org/7465046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
structures have a sin*_len member.
The SIN6_LEN macro is required by RFC 3493 Section 3.4. Since
Chrome requires the IPv6 socket API, it is fine to use SIN6_LEN
for the IPv6 sockaddr_in structure also.
R=agayev@chromium.org,cbentzel@chromium.org,eroman@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7461105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=XXXX
TEST=XXXX
Review URL: http://codereview.chromium.org/7465044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that may occur when using the server's public key in NSS's
ssl3_HandleServerKeyExchange and ssl3_SendClientKeyExchange functions.
R=agl@chromium.org
BUG=88044
TEST=none
Review URL: http://codereview.chromium.org/7495006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert r94208 (re-land r94196), add missing NET_API decl.
TBR=willchan@chromium.org
BUG=84078
TEST=everything compiles
Review URL: http://codereview.chromium.org/7477035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content/browser/debugger.
Add Observer concept to net::NetLog.
Use net::NetLog::Observer in ChromeNetLog.
Remove ChromeNetLog dependency in content/browser/debugger.
Forked from http://codereview.chromium.org/7310029/ to finish Jói's
patch.
BUG=84078
TEST=existing
Review URL: http://codereview.chromium.org/7468019
TBR=dpranke@chromium.org
Review URL: http://codereview.chromium.org/7517004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=base_unittests --gtest_filter=MD5.ContextWithStringData*
Review URL: http://codereview.chromium.org/7466003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add Observer concept to net::NetLog.
Use net::NetLog::Observer in ChromeNetLog.
Remove ChromeNetLog dependency in content/browser/debugger.
Forked from http://codereview.chromium.org/7310029/ to finish Jói's
patch.
BUG=84078
TEST=existing
Review URL: http://codereview.chromium.org/7468019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change gets rid of the asymmetry between Resolve() calls that complete synchronously and those that complete asynchronously. Makes code more readable/understandable, allows to embed OnStart/OnFinish/OnCancel calls within the Request::Request()/Request::On{Sync,Async}Complete/Request::~Request() so that we do not miss these inadvertently. As a result of this, I found out that code logic as well as the unit test was not notifying the observer of the cancellation due to object destruction.
BUG=60149
TEST=net_unittests --gtest_filter="AsyncHostResolverTest*"
Review URL: http://codereview.chromium.org/7492028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7477008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also addresses some follows up from previous CLs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7493056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed the comments from Wan-Teh in CL
http://codereview.chromium.org/7349023/
BUG=89094
R=wtc
TEST=net unit tests.
Review URL: http://codereview.chromium.org/7471056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* BrowserTest.WindowSessionEnd has been failing since r94047
TBR=willchan@chromium.org
BUG=none
TEST=none
Notably this makes ChromeURLRequestContextGetter not own its ChromeURLRequestContext, and instead it keeps a base::WeakPtr. If anything is holding onto a ChromeURLRequestContextGetter longer than it should, and tries to use it, then it will crash. Currently no tests fail with this assumption, so hopefully this will prevent regressions. All ChromeURLRequestContextGetters should not outlive the Profile to which they belong.
Note that this will cause problems if there are any URLRequests which outlive the Profile to which they belong, as they will reference URLRequestContexts which point to deleted memory. AFAICT this never happens, and I will enforce this later on by making URLRequests acquire weak pointers to URLRequestContexts. After that, I can stop refcounting URLRequestContext.
I'm hopeful this changelist will fix a large number of leaks in browser_tests. Removing the refcounting of ProfileIOData will bring sanity to the lifecycle management of ProfileIOData and a large number of objects it owns. I've used base::WeakPtr in a number of places in order to prevent use-after-free bugs and force them to be NULL dereferences (crashes). In previous changelists, I've flushed out bugs revealed by this behavior. So currently, this changelist is clean on the trybots, although it's possible new code paths will be discovered via crash reports.
Next steps:
* URLRequests use base::WeakPtr<URLRequestContext>
* Fix all other URLRequestContextGetters not to acquire references to URLRequestContext.
* Stop refcounting URLRequestContext.
Review URL: http://codereview.chromium.org/7495035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notably this makes ChromeURLRequestContextGetter not own its ChromeURLRequestContext, and instead it keeps a base::WeakPtr. If anything is holding onto a ChromeURLRequestContextGetter longer than it should, and tries to use it, then it will crash. Currently no tests fail with this assumption, so hopefully this will prevent regressions. All ChromeURLRequestContextGetters should not outlive the Profile to which they belong.
Note that this will cause problems if there are any URLRequests which outlive the Profile to which they belong, as they will reference URLRequestContexts which point to deleted memory. AFAICT this never happens, and I will enforce this later on by making URLRequests acquire weak pointers to URLRequestContexts. After that, I can stop refcounting URLRequestContext.
I'm hopeful this changelist will fix a large number of leaks in browser_tests. Removing the refcounting of ProfileIOData will bring sanity to the lifecycle management of ProfileIOData and a large number of objects it owns. I've used base::WeakPtr in a number of places in order to prevent use-after-free bugs and force them to be NULL dereferences (crashes). In previous changelists, I've flushed out bugs revealed by this behavior. So currently, this changelist is clean on the trybots, although it's possible new code paths will be discovered via crash reports.
Next steps:
* URLRequests use base::WeakPtr<URLRequestContext>
* Fix all other URLRequestContextGetters not to acquire references to URLRequestContext.
* Stop refcounting URLRequestContext.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7432002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an error is returned synchronously, next_state_ is not STATE_CLOSE.
In such case, we should just close the socket stream with the error.
BUG=83950
TEST=net_unittest --gtest_filter=SocketStreamTest.* pass
Review URL: http://codereview.chromium.org/7484065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change !verify_result->cert_status to
!IsCertStatusError(verify_result->cert_status) because
verify_result->cert_status may contain non-error status bits,
such as whether revocation checking was done.
because it introduced a bug.
TBR=rsleevi@chromium.org
BUG=88135,90146
TEST=none
Review URL: http://codereview.chromium.org/7513005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68657
TEST=XXX
Review URL: http://codereview.chromium.org/7210046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=83950
TEST=net_unittest --gtest_filter=SocketStreamTest.* pass
Review URL: http://codereview.chromium.org/7468025
TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/7489039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=83950
TEST=net_unittest --gtest_filter=SocketStreamTest.* pass
Review URL: http://codereview.chromium.org/7468025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88130
TEST=
Review URL: http://codereview.chromium.org/7485015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a protocol change to allow the server to operate on top of
an eventually consistent store. Rather than having the server do
a lookup of the sibling position to generate an absolute position,
the client will now be responsible for doing that same operation.
As implemented here, math of interpolation is the same as what the
server has historically done.
The client will continue sending the insert_after_item_id, for
interoperation with server implementations that depend on the
old behavior.
Implement the new behavior in the testserver.
TEST=sync_integration_tests,included unittests
Review URL: http://codereview.chromium.org/7481003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although the transferred bytes are supposed to match the advertised Content-Length, in practice a small but non-trivial number of sites do not obey this behavior.
BUG=52847
TEST=None
Review URL: http://codereview.chromium.org/7482005
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/7461040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although the transferred bytes are supposed to match the advertised Content-Length, in practice a small but non-trivial number of sites do not obey this behavior.
BUG=52847
TEST=None
Review URL: http://codereview.chromium.org/7482005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93704 0039d316-1c4b-4281-b951-d872f2087c98
|