| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
since code's changed a lot. I've changed it so as not to flush the host resolver too. I suspect there might have been a bug there. I was unable to reproduce the crash here on network change, so I think either that fixed it or something else changed under the hood. In any case, I want to reland this and see if anyone encounters any problems with it.
BUG=40455,40457
Review URL: http://codereview.chromium.org/2114004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Display it on the about:net-internals page
- Collect it in the histogram Net.OSErrorsForGetAddrinfo.
Review URL: http://codereview.chromium.org/2134004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the merge issue this time. Also fixes a TODO in another change that was blocked on this one.
Support SpdySession as a new NetLog source type. Start logging some more SPDY control frames.
Original code review: http://codereview.chromium.org/2102003/show
BUG=43237
Review URL: http://codereview.chromium.org/2114003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After issuing the PASS command, we should never issue
earlier commands again. The code was sending USER when it
received "503 Bad command sequence" error code.
TEST=added to net_unittests
BUG=38707
Review URL: http://codereview.chromium.org/2094002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
For streams that already have delegates, they have their own NetLogs so use those.
For streams that don't have delegates, just write out to the session's NetLog.
TODO(willchan): Use a different event type once the SpdySession NetLog tracker is landed.
Review URL: http://codereview.chromium.org/2101003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logging some more SPDY control frames.
BUG=43237
Review URL: http://codereview.chromium.org/2102003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/2118003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SPDY control frames.
BUG=43237
Review URL: http://codereview.chromium.org/2102003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1480002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37421
Review URL: http://codereview.chromium.org/2108003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2131001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1992005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(The "extra" was redundant. And "params" is a well understood abbreviation of "parameters").
Review URL: http://codereview.chromium.org/2110001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests,
by releasing the V8 lock while executing the JS bindings functions.
I don't fully understand how the deadlock happens, but this is a desirable change anyway as it increases the parallelism when running concurrent proxy resolvers.
BUG=44013,44005
Review URL: http://codereview.chromium.org/2023009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2073004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43237
Review URL: http://codereview.chromium.org/2004010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2101001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Behavioral changes are small; this is mostly a syntactic sugar change. But
there are a few behavioral changes:
* If a web site replies with different schemes for the same realm, we'll have two entries in the cache.
* There will not be a log entry in HttpNetworkTransaction::SelectNextAuthIdentityToTry when we have the wrong authentication scheme (we don't see that entry any more)
* We will no longer return ERR_TUNNEL_CONNECTION_FAILED from SocketStream::HandleAuthChallenge when there's an entry in the cache with a non-basic authentication scheme (we won't know it's there).
Contributed by rdsmith@chromium.org
BUG=33433
TEST=HttpAuthCacheTest.* (as modified in this commit), HttpNetworkTransactionTest.*, SocketStreamTest.*, only on Linux.
Review URL: http://codereview.chromium.org/1949004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The format for --host-rules is identical to --host-resolver-rules.
The difference is that --host-rules affects the endpoint of the HttpNetworkTransaction, not just the host resolver. So, this means the host passed to the host resolver and the TCP connect(), the tunnel CONNECT, and the SOCKS connect will be different.
Review URL: http://codereview.chromium.org/2057007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2015019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
has more control about the backend instantiation.
BUG=none
TEST=current unit tests.
Review URL: http://codereview.chromium.org/2000011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TODO(willchan): Start logging events for SpdySession.
Review URL: http://codereview.chromium.org/2059004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes problem where cached negative DNS entries were being used on a regular page refresh.
BUG=34737
TEST=HttpNetworkTransactionTest.BypassHostCacheOnRefresh*
Review URL: http://codereview.chromium.org/2051006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43812
Review URL: http://codereview.chromium.org/2015011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
last patch.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1989011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
more than one name so that we can move a user from one
group to another within the same session.
BUG=none
TEST=unittest
Review URL: http://codereview.chromium.org/2044007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We need to convert the file name back to server encoding.
BUG=38016
TEST=see bug
Review URL: http://codereview.chromium.org/1857002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2003010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
these to be useful, and they just add noise to the log.
Review URL: http://codereview.chromium.org/2033008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43812
Review URL: http://codereview.chromium.org/2035013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43812
Review URL: http://codereview.chromium.org/2010009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(DNS request tracing is the only feature lost in this transition; it needs to be added back under the new framework).
BUG=37421
Review URL: http://codereview.chromium.org/2008007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that we always use a completion callback when making
disk cache requests, and add new states to truncate the
entry's metadata.
BUG=26729
TEST=unittests
Review URL: http://codereview.chromium.org/2006007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
OnAvailableSocketSlot() was dereferencing a NULL pointer. Add a NULL check. Add a test.
BUG=42267
Review URL: http://codereview.chromium.org/2050005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to enable MP4 and MP3 support on tegra2 boards. This change will let us enable this support via a flag in make.conf.
Patch by jneddo@nvidia.com:
http://codereview.chromium.org/1942003/show
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2001004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=valgrind --leak-check=yes net_unittests --gtest_filter="*SpdySessionTest.GetPushStream*"
Review URL: http://codereview.chromium.org/1951001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid using wall clock time, which can be changed by the user,
or impacted by Daylight Savings transitions etc.
BUG=14193
r=eroman
Review URL: http://codereview.chromium.org/1253005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixing 35050, one of the tests I wrote for EPSV required NULS go through the
testing framework. That created issue 42432 which covers permitting NULs through
our socket tests. I added an interface to SimulateRead which passes in an explicit
length, and moved as much of that into ftp_network_transaction_unittest as possible.
BUG=42432
TEST=see the modified Epsv test in ftp_network_transaction_unittest.cc
Review URL: http://codereview.chromium.org/1949003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was we assumed ProcessPendingRequest() would always make progress once the group's releasing socket went down to zero. However, in OnAvailableSocketSlot(), since the top stalled group might still have a releasing socket, it won't necessarily make progress. The algorithmic solution is to simply never do any socket slot processing in DoReleaseSocket() if there are any releasing sockets. This requires us to search for any stalled groups after releasing sockets gets back down to 0, so it requires the full group scan each time num_releasing_sockets goes back to 0. There is a performance hit here, but I think a linear search through 256~ groups in the worst case is ok.
TODO(willchan): evaluate the perf hit and consider adding a secondary data structure to improve the stalled group search.
BUG=42267
Review URL: http://codereview.chromium.org/2013009
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/1992010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
issued by AddTrust External CA Root because it causes
CertGetCertificateChain to report CERT_TRUST_IS_NOT_VALID_FOR_USAGE.
This is a temporary workaround. The proper fix is to modify
NSS to provide all the certificates sent by the server to
the certificate verification callback.
Fix a certificate context leak.
R=agl,willchan
BUG=43538
TEST=On a Windows computer that doesn't have the
COMODO EV SGC CA certificate issued by COMODO Certification
Authority, visit https://mixi.jp/ . Chrome should not
display the "certificate invalid" error page.
Review URL: http://codereview.chromium.org/2036005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code did not handle cancellation properly, and DCHECKs
were firing. Recrafted code to avoid checking for runs
"on origin_thread" after a cancellation (which destroys
the record of the orgin_thread_).
BUG=43600
r=willchan
Review URL: http://codereview.chromium.org/2050002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ideally this dependency on chrome from net should not exist, but
until that is resolved, we can at least avoid the dependency when
using net.gyp from the standalone webkit build (which lacks a
checkout of chrome/).
R=nick
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1996010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The problem was we assumed ProcessPendingRequest() would always make progress once the group's releasing socket went down to zero. However, in OnAvailableSocketSlot(), since the top stalled group might still have a releasing socket, it won't necessarily make progress. The algorithmic solution is to simply never do any socket slot processing in DoReleaseSocket() if there are any releasing sockets. This requires us to search for any stalled groups after releasing sockets gets back down to 0, so it requires the full group scan each time num_releasing_sockets goes back to 0. There is a performance hit here, but I think a linear search through 256~ groups in the worst case is ok.
TODO(willchan): evaluate the perf hit and consider adding a secondary data structure to improve the stalled group search.
BUG=42267
Review URL: http://codereview.chromium.org/2013009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22588
Review URL: http://codereview.chromium.org/1998008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
backend. We queue all trasnactions that reach Start before
we are done creating the disk cache.
BUG=26729
TEST=unittests.
Review URL: http://codereview.chromium.org/2002002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The interface (for perf reasons) snapshots the histogram
name, and reuses it in future calls. As a result, any attempt
to modulate (change) the name between call is ignored.
This change uses a DCHECK to detect such abuse.
BUG=43377
BUG=43375
r=vandebo
Review URL: http://codereview.chromium.org/2019001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the other "Network Solutions Certificate Authority" to work
around NSS bug 564334.
R=ukai
BUG=41730
TEST=on a Linux distribution with NSS 3.12.6, visit
https://blackboard.mines.edu and then https://www.networksolutions.com.
We should not get the certificate revoked error page.
Review URL: http://codereview.chromium.org/2011007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/2025003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and WorkerPool.
Also add a warning for users of WorkerPool that they need to be
very careful about subtle issues.
Also see discussion in http://codereview.chromium.org/1834002/show
TEST=none
BUG=30177
Review URL: http://codereview.chromium.org/2033001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
better use of CryptoAPI.
Contributed by Ryan Sleevi <ryan.sleevi@gmail.com>.
Original review URL: http://codereview.chromium.org/1934001
R=wtc
BUG=148
TEST=Keygenhandler.SmokeTest
Review URL: http://codereview.chromium.org/2021003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=non
Review URL: http://codereview.chromium.org/1748015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46625 0039d316-1c4b-4281-b951-d872f2087c98
|