| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> A speculative fix for the TLS 1.2 client authentication bug with the
> CAC card on Mac OS X.
>
> Manually encode the ASN.1 DigestInfo structure and pass CSSM_ALGID_NONE
> as the digestAlg argument to CSSM_SignData. The theory is that the CAC
> card may not support a digestAlg argument of CSSM_ALGID_SHA256 passed to
> CSSM_SignData.
>
> Set the OS error when CDSA/CSSM functions fail and log the OS error when
> we get ERR_SSL_CLIENT_AUTH_SIGNATURE_FAILED.
>
> R=rsleevi@chromium.org
> BUG=255579
> TEST=manual testing
>
> Review URL: https://chromiumcodereview.appspot.com/18055011
TBR=wtc@chromium.org
Review URL: https://codereview.chromium.org/18323009
git-svn-id: svn://svn.chromium.org/chrome/branches/1547/src@209481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This has the happy side-effect of improving an existing test.
Review URL: https://chromiumcodereview.appspot.com/17596003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Pull out querying the cache and the network in MDnsTransaction::Start into
two separate methods.
BUG=233821
Review URL: https://chromiumcodereview.appspot.com/16972009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce new SpdyWebSocketTestUtil class and use it in all
SPDY WebSocket tests.
BUG=226192
R=rch@chromium.org
Review URL: https://codereview.chromium.org/17601002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1.) The header is now in base/mac instead of base/memory
2.) The class is now in namespace base.
This CL was created programmatically by running:
1.)
git grep -l memory/scoped_nsobject.h | xargs sed -i -e 's/memory\/scoped_nsobject.h/mac\/scoped_nsobject.h/g'
for f in $(git diff --name-only origin); do tools/sort-headers.py $f -f; done
git commit -a -m headers
# manually undo changes to gypi file
git cl upload # patch set 1
2.)
git grep -l 'scoped_nsobject<' | xargs sed -i -e 's/scoped_nsobject</base::scoped_nsobject</g'
# manually undo comment changes in scoped_nsobject.h, tracking_area.h
git commit -a -m format
git cl upload # patch set 2
# Manually audit all files, file bugs and clean up bad clang-format decisions
git cl upload # patch set 3
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/17593006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See https://bugs.gentoo.org/show_bug.cgi?id=426630 for more info.
The behavior of the test server was different depending on whether
m2crypto Python module is available on the system.
BUG=none
R=wtc@chromium.org
Review URL: https://codereview.chromium.org/17143007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created fully mechanically by running
git grep -l base::mac::ScopedCFTypeRef | xargs sed -i -e 's/base::mac::ScopedCFTypeRef/base::ScopedCFTypeRef/g'
git commit -a -m.
git clang-format HEAD^ --style=Chromium
git commit -a -m.
git cl upload -t $TITLE
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/16917011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With r208081 (https://codereview.chromium.org/16879015), it is safe to
re-enable TLS 1.2 for USE_OPENSSL.
> Disable TLS 1.2 if USE_OPENSSL is defined (such as on Android) to
> prevent ClientHello from being larger than 256 bytes. Some broken
> servers can't handle a large ClientHello.
>
> R=agl@chromium.org,rsleevi@chromium.org
> BUG=90392,245500,247691
> TEST=none
>
> Review URL: https://chromiumcodereview.appspot.com/17094016
TBR=wtc@chromium.org
Review URL: https://codereview.chromium.org/17575013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also refactor SpdyStream and SpdySession.
Specifically:
Rename some states and functions in SpdyStream. Also
consistently reset the stream on error. Define
IsIdle() to mean idle but not closed.
Restrict inputs to Close{Active,Created}Stream and
ResetStream in SpdySession. Add helper functions for
internal uses of those functions.
Fix erroneous test revealed by the changes above.
BUG=250841
Review URL: https://chromiumcodereview.appspot.com/17134004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename OnResponseHeadersReceived() to
OnResponseHeadersUpdated() and remove some of
its extraneous parameters. Document its semantics and that
of the other delegate functions.
Fix bug in PushedStreamReplayData() where the stream being
closed/deleted wasn't handled correctly. Also fix memory leaks
of the pending frames.
Use continue_buffering_data_ only for push streams.
Rename request_/response_ to request_headers_/response_headers_.
Keep track of whether all required response headers are complete,
and send data to the delegate only after that becomes true.
Rename OnResponseHeadersReceived() and OnHeaders() to
On{Initial,Additional}ResponseHeadersReceived(), respectively.
Add MergeWithResponseHeaders() utility function and call it
from On{Initial,Additional}ResponseHeadersReceived(). Always convert
ERR_INCOMPLETE_SPDY_HEADERS to OK for push streams.
Rename ContainsUpperAscii() (ambiguous) to ContainsUppercaseAscii().
Move some tests from SpdyNetworkTransaction to SpdyStream.
Some other miscellaneous renaming and cleanup.
BUG=251442
R=rch@chromium.org
Review URL: https://codereview.chromium.org/17382012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
return OK without actually having a stream ready
TBR=jar@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17587005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We plan to use this from content_shell's --log-net-log commandline option.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/16818027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We synthesize the response headers and ignore the body anyway, so there's
no point to using a real one.
This lets us avoid having to call SetDelegate() twice on a SpdyStream,
so remove support for that.
BUG=252433
Review URL: https://chromiumcodereview.appspot.com/17068018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was used in two places; one place, it was used correctly so I inlined
it. In the other place, I replaced it with a call to the ConstructSpdyPush()
overload that takes a URL.
BUG=
Review URL: https://chromiumcodereview.appspot.com/16972013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a..."" (r208102).
seems to be causing Android failures in content_tests: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Tests%20%28dbg%29&number=12049
BUG=
TBR=wtc@chromium.org
Review URL: https://codereview.chromium.org/17444018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With r208081 (https://codereview.chromium.org/16879015), it is safe to
re-enable TLS 1.2 for USE_OPENSSL.
> Disable TLS 1.2 if USE_OPENSSL is defined (such as on Android) to
> prevent ClientHello from being larger than 256 bytes. Some broken
> servers can't handle a large ClientHello.
>
> R=agl@chromium.org,rsleevi@chromium.org
> BUG=90392,245500,247691
> TEST=none
>
> Review URL: https://chromiumcodereview.appspot.com/17094016
TBR=wtc@chromium.org
Review URL: https://codereview.chromium.org/17553016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for the QUIC job to finish.
Review URL: https://chromiumcodereview.appspot.com/17247006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/17518002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TestShellWebMimeRegistryImpl has been replaced in lieu of content_shell calling net::RemoveProprietaryMediaTypesAndCodecsForTests().
BUG=251306
Review URL: https://chromiumcodereview.appspot.com/17447011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/17518003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=agl@chromium.org
Review URL: https://codereview.chromium.org/17563009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update all callers of InitLogging() to use LoggingSettings, only
setting fields that need a non-default value.
Turn LoggingDestination enum into a bit field and define add
LOG_DEFAULT and LOG_ALL constants.
Fix erroneous comment saying that the default was to not lock
the log file.
BUG=247594
TBR=brettw@chromium.org, cpu@chromium.org, gene@chromium.org, jam@chromium.org, rch@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, sky@chromium.org, tkent@chromium.org, yfriedman@chromium.org, zea@chromium.org
Review URL: https://codereview.chromium.org/16519003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes sync and net compile with no "using *Value".
BUG=
Review URL: https://codereview.chromium.org/17034006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It sent the wrong error code for duplicate SYN_REPLY frames. Also,
it didn't trigger an error for data frames sent before SYN_REPLY.
Update tests to match.
Add {Active,Pushed}StreamInfo structs and use them in
{Active,Pushed}StreamMap.
Be defensive when closing expired push streams.
Give the correct name to SpdyHttpStream tests.
BUG=252556
R=rch@chromium.org
Review URL: https://codereview.chromium.org/17004007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically three new file block types appear: One for normal
entries, one for deleted entries and one for keeping track
of external files.
BUG=241277
TEST=net_unittests
R=gavinp@chromium.org
Review URL: https://codereview.chromium.org/16837003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crash on startup in the referenced bug is very bad in part because
the corrupt index which caused it is left on disk, so all startups
until user data is cleared will crash. For maximum safety, we should
unlink the index file ASAP after finding it is corrupt.
R=rdsmith@chromium.org
BUG=251465
Review URL: https://codereview.chromium.org/17265007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert a workaround commit r20158 for a Use-After-Free issue (http://crbug.com/244746) because a cleaner CL r207218 is landed.
URLRequestContext does not inherit SupportsWeakPtr now.
R=mmenke
BUG=244746
Review URL: https://chromiumcodereview.appspot.com/16870008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When adding response to the cache, it removes "http://",
but when getting response from the cache, it does not.
As a result, no content is fetched out from the cache
even for urls in the cache.
BUG=
Review URL: https://chromiumcodereview.appspot.com/16354006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/17333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prevent ClientHello from being larger than 256 bytes. Some broken
servers can't handle a large ClientHello.
R=agl@chromium.org,rsleevi@chromium.org
BUG=90392,245500,247691
TEST=none
Review URL: https://chromiumcodereview.appspot.com/17094016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=252051
r=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16999008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Introduce RequestWebSocketStream into HttpStreamFactory to reuse its functionality that handles socket pool, proxy and SSL.
BUG=237444
Review URL: https://chromiumcodereview.appspot.com/14813024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also, since we expect QUIC for HTTP URLs to run on port 80, changed the tests to use that port.
Review URL: https://chromiumcodereview.appspot.com/17410014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove duplicate mock socket from service discovery and mdns tests, put it in
its own file so it can be used by tests of various dependent components.
BUG=
Review URL: https://chromiumcodereview.appspot.com/17244004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class provides a somewhat similar interface to BlockFiles but
operates exclusively with data in memory so it can be used on
any thread because it never blocks. It encapsulates the header
of a block file.
BUG=241277
TEST=net_unittests (as in BlockFiles are implemented using BlockHeader)
R=gavinp@chromium.org
Review URL: https://codereview.chromium.org/16843007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prevent ClientHello from getting too big.
Print more error info when we get SSL_ERROR_SYSCALL.
R=agl@chromium.org,digit@chromium.org,rsleevi@chromium.org
BUG=245500
TEST=none
Review URL: https://chromiumcodereview.appspot.com/17427003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
And remove the forwarding file.
TBR=darin@chromium.org, eroman@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/16835007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
No intended behavior change.
BUG=249803
Review URL: https://chromiumcodereview.appspot.com/17274012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NO code change. This is just preparation for landing real code.
BUG=241277
TEST=none
TBR=gavinp@chromium.org
Review URL: https://codereview.chromium.org/17512003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/17451010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some new histograms didn't deal with the failure case properly. Now fixed.
BUG=251465
R=pasko@chromium.org, rdsmith@chromium.org
Review URL: https://codereview.chromium.org/17420004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=everything compiles OK
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/17390010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The default counts were not useful, since they stop at 1MB, and all eviction
operated on sizes more than that. So compute this in KB, which whould provide
the range of 1MB - 500MB. Not ideal, but relatively OK.
This will probably break the consistency of the number across builds, but it
should be fine for our purposes. Just want to double-check if this careless mode
is supported by the processing pipeline.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/17112008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests in net_unittests, now that Windows can temporarily trust certificates for the duration of tests.
In addition, add unittests for net::TestRootCerts, which depend on the certs being tested not being trusted by the system beforehand.
BUG=8470, 5552
TEST=TestRootCertsTest.*
TBR=zelidrag
Review URL: https://chromiumcodereview.appspot.com/5535006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dev Tools displays the raw request and response headers. Right now, it gets
them by snarfing them out of the NetLog, which is bad, as the NetLog is for
huamn consumption only. I'm trying to refactor the DevToolsNetLogObserver
away; providing an alternate, supported path to get the request headers is the
first step.
BUG=196304
TEST=added to URLRequest, HttpTransaction, and HttpNetworkTransaction unittests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199535
Review URL: https://chromiumcodereview.appspot.com/12621011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=246066
TEST=see test sites in CL. All should be marked EV on (Win, Linux, iOS,
CrOS)
Review URL: https://chromiumcodereview.appspot.com/16922012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is being destroyed.
SocketStreamDispatcherHost attached to a worker process should be notified that
the process will be down, before the profile it refers is destroyed.
This CL depends on the current WorkerProcessHost implementation that never add a WorkerInstance
to a WorkerProcessHost once it is created.
SocketStreamHost calls SocketStreamJob::set_context(NULL) which cancels the job.
Since SocketStreamHost::socket_ can be NULL, a NULL pointer guard is added there.
BUG=244746
Review URL: https://chromiumcodereview.appspot.com/16034010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the notification structure in the MDnsListener to notify listeners after
the whole packet is processed. This should allow listeners to issue cache
queries for other records in the same packet in a synchronous manner.
In order to not issue invalid notifications in case the packet contains multiple
records that cancel each other out (and thus delete each other), store cache
keys in the list of notifications to send, rather than storing record pointers
directly.
BUG=
TEST=MDnsCacheTest.*,MDnsTest.*
Review URL: https://chromiumcodereview.appspot.com/17379009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207161 0039d316-1c4b-4281-b951-d872f2087c98
|