| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> On Windows, prefer to generate SHA-1 signatures for TLS 1.2 client
> authentication if the client private key is in a CAPI service provider.
>
> R=rsleevi@chromium.org,agl@chromium.org
> BUG=278370
> TEST=will require manual testing by the bug reporter.
>
> Review URL: https://chromiumcodereview.appspot.com/23545010
TBR=wtc@chromium.org
Review URL: https://codereview.chromium.org/23880004
git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@221227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Sparse IO: Allow failover to network in debug builds
>
> In case a backend does not support Sparse IO, a failover to network should
> happen, it does so via unsuccessful validation of headers, but debug builds have
> a DCHECK on this seemingly working path. Remove it.
>
> BUG=263642
>
> Review URL: https://chromiumcodereview.appspot.com/22926031
TBR=pasko@chromium.org
Review URL: https://codereview.chromium.org/23613004
git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@220822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Reland r219017: Avoid fragmenting the heap too much while reconstructing...
>
> The previous attempt failed due to a cherry-pick (cache_mem_test) on my local
> branch that was committed through 'git cl dcommit' and caused a build breakage
> on iOS. Surprisingly 'git cl dcommit' doesn't actually commit the remote CL.
> This is being addressed by the infrastructure team.
>
> Memory analysis exposed that FileEnumerator doesn't scale well on very large
> directories (e.g. ~80 000 entries) due to the high amount of heap allocations
> it is performing causing unexpectedly high heap fragmentation (e.g. ~5 MBytes
> with a 80 000 files directory).
>
> This CL makes SimpleIndexFile::SyncRestoreFromDisk() use directly readdir_r()
> on POSIX and fallback to FileEnumerator on Windows. The code path triggered for
> reconstructing the index from disk now causes a 40 KBytes RAM overhead (on the
> cache that was used for testing) vs the 5 initial MBytes.
>
> BUG=272062
> TBR=gavinp@chromium.org, pasko@chromium.org
>
> Review URL: https://codereview.chromium.org/22831030
TBR=pliard@chromium.org
Review URL: https://codereview.chromium.org/23591007
git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@220054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
older STREAM frames.
Merge internal CL: 50558774
Add the QuicVersionMin() function.
Change some unit tests to use QuicVersionMin().
Merge internal CL: 50630692
R=rch@chromium.org
BUG=none
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/22311013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://www.viva64.com/en/b/0205/#ID0EXRFM
R=rsleevi@chromium.org
BUG=271530
TEST=none
Review URL: https://chromiumcodereview.appspot.com/22883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=270192
Review URL: https://chromiumcodereview.appspot.com/22702003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This ensures that both sides' flow control states stay in sync even if one side resets a stream.
BUG=269873
R=rch@chromium.org
Review URL: https://codereview.chromium.org/22610006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
INVALID_SOCKET for failure.
R=rsleevi@chromium.org
BUG=271530
TEST=none
Review URL: https://chromiumcodereview.appspot.com/22824005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=270735
R=wtc
Review URL: https://chromiumcodereview.appspot.com/22758002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add unittests for net::BalsaFrame, net::BalsaBuffer and net::BalsaHeaders.
This CL does not change any behavior.
R=rch@chromium.org
BUG=267354
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216572
Review URL: https://chromiumcodereview.appspot.com/22573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Simple Cache index initialization path was making far too
many allocations, which caused an unneeded early peak in the
heap during index initialization. By reserving memory for
table resizes and making merges from small sets into big sets,
this peak is cut significantly.
R=pliard,ttuttle
BUG=None
Review URL: https://chromiumcodereview.appspot.com/22406005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=259097
Review URL: https://chromiumcodereview.appspot.com/22731002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http_network_transaction.cc, so that it applies to SSLClientSockets
based on both NSS and OpenSSL.
R=agl@chromium.org,rsleevi@chromium.org
BUG=260358
TEST=net_unittests, plus manual testing: visit https://www.web-secured.com/.
Should get a successful TLS 1.0 connection, rather than
ERR_SSL_BAD_RECORD_MAC_ALERT.
Review URL: https://chromiumcodereview.appspot.com/22633004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that encapsulates the platform-specific alarm setting/canceling
functionality. This moves all the various alarm definition/management
code from QuicConnectionHelper to QuicConnection. Since there are
Chrome and GFE implementations of the helper, this reduces the
risk of implementation-specific bugs, like the recent Chrome
SendAlarm bug.
Merge internal change: 50513435
BUG=
Review URL: https://chromiumcodereview.appspot.com/22545005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MemoryCache and FileData have memory leak, so I fixed it in this CL.
I added some unittests for MemoryCache and fixed some problems detected by the tests.
R=rch@chromium.org
BUG=267354
TESTS=net_unittests
Review URL: https://chromiumcodereview.appspot.com/22325012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/22477003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/22394005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the salt length to the digest length.
This is recommended by RFC 4055, Section 3.1:
saltLength
The saltLength field is the octet length of the salt. For a
given hashAlgorithm, the recommended value of saltLength is the
number of octets in the hash value. ...
OpenSSL's default salt length is the special value -2. When signing,
-2 sets the salt length to the maximum permissible value. When
verifying, -2 causes the salt length to be automatically determined
based on the PSS block structure.
Merge internal CL: 50532662
R=rch@chromium.org,rtenneti@chromium.org
BUG=none
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/22647002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This happens when the port is already in use.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/22368003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add unittests for balsa classes.
>
> Add unittests for net::BalsaFrame, net::BalsaBuffer and net::BalsaHeaders.
> This CL does not change any behavior.
>
> R=rch@chromium.org
> BUG=267354
>
> Review URL: https://chromiumcodereview.appspot.com/22573002
TBR=yhirano@chromium.org
Review URL: https://codereview.chromium.org/22398006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add unittests for net::BalsaFrame, net::BalsaBuffer and net::BalsaHeaders.
This CL does not change any behavior.
R=rch@chromium.org
BUG=267354
Review URL: https://chromiumcodereview.appspot.com/22573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Minor logging improvement to FEC revived packets.
Merge internal change: 50495854
Fixed existent typo: existant becomes existent.
Merge internal change: 50439145
Fix a bug in quic_connection where an Ack could be sent in response to
an ack before the packet was registered as having been received in
OnPacketComplete(), causing an entropy to be generated which was
incorrect.
Merge internal change: 50396820
Added a TODO to support "Rate limiting a warning log."
Merge internal change: 50395138
Fixing two bug where we could kill off a session twice, one of which
could "easily" happen, and one of which should only ever happen with
horrible configuration.
The first, is processing packets via MaybeProcessUndecryptablePackets or
MaybeProcessRevivedPacket after the connection had disconnected. The
likliest way for this to happen would be to lose the CHLO and have two
'bad' packets buffered such that we'd loop on both, both would cause a
connection close which would get passed to the session and the
dispatcher, causing unhappiness.
The second is kind of silly and caught by the DCHECK I added to detect
double-disconnect: when we register idle alarms we check for timeouts.
In the case of our timeouts test we set the timeout so small the
session is basically timed out before it's created. In this case when
we create the session we'd close it when registering the first timeout
and close again registering the second. This should only ever be hit
if you have a horrible config or a 10 second machine hiccup.
Merge internal change: 50393796
Actually waiting for server SHLO before upping packet loss.
Merge internal change: 50384306
Fixing a crashing bug in quic_session: if a pointer is NULL maybe we
shouldn't dereference it...
Merge internal change: 50378549
Remove mostly unused set_max_open_streams method from QuicSession.
Merge internal change: 50275870
Reducing/removing test flakeiness due to SHLO being particularly
important.
Merge internal change: 50272102
Small formatting fix.
Merge internal change: 50262875
Fixing a bug in protocol negotiation where the verion flag would always
be sent.
Basically if we immediately transition to NEGOTIATED_VERSION, we never
enter the if block in OnPacketHeader and call StopSendingVersion
Merge internal change: 50182524
Added max_tcp_congestion_window_ to TcpCubicSender for testing.
Decrease the maximum congestion window to 50 from 10000 until the RTO
logic is improved. The intent is to handle cases when the RTT is
larger than the RTO specially and not retransmit agressively then.
Merge internal change: 50080104
Change kMaxRetransmissionTimeMs to 60 seconds (from 10 seconds) to
match TCP.
Merge internal change: 50073957
Add comments to point out it is OK to specify both kX509 and kX59R, and
to document the new ecdsa_ok parameter of ProofSource::GetProof.
Merge internal change: 50071950
Do not send acks in response to acks.
Merge internal change: 50064954
R=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22661002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The histograms were only considering the expiration date, as that is
all that Appendix B lists as applicable for key sizes. However,
Appendix B is only relevant if the certificate is in scope of the BRs,
which itself is gated on issuance date (BRs 1.0 were adopted with an
effective date of 2012-01-07, although root programs were slower to
require audit compliance).
BUG=102949
R=wtc,asvitkine
Review URL: https://chromiumcodereview.appspot.com/22606007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NPN defines the first protocol in the client's list to be the protocol that the
client will select when there's no overlap - i.e. it's the fallback protocol.
However, then the NPN data is used for ALPN, it was becoming the most
preferable protocol because ALPN says that they are in preference order.
This change causes NSS to be aware that the data that is set by
SSL_SetNextProtoNego is in NPN's order and thus the first element should be
moved to the end when sending an ALPN extension.
BUG=267858
Review URL: https://chromiumcodereview.appspot.com/22237002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=269744
Review URL: https://chromiumcodereview.appspot.com/22407009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is failing on Android bots.
> net: add a test to ensure that our TLS handshake doesn't get too large.
>
> (I would like the test to assert that we have some headroom too, but we don't
> have any to assert!)
>
> BUG=none
> R=rsleevi@chromium.org, wtc@chromium.org
>
> Review URL: https://codereview.chromium.org/19557004
TBR=agl@chromium.org
Review URL: https://codereview.chromium.org/22371007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Simple Cache uses directory and file mtimes at high granularity to
determine index freshness. As well, for linux process creation times,
a high resolution ctime from /proc is useful; so high resolution ctime
makes process creation times accurate.
R=darin
Review URL: https://chromiumcodereview.appspot.com/22582009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(I would like the test to assert that we have some headroom too, but we don't
have any to assert!)
BUG=none
R=rsleevi@chromium.org, wtc@chromium.org
Review URL: https://codereview.chromium.org/19557004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Make simple cache index take hashes in rather than key strings.
>
> The index was re-hashing keys that were already hashed.
>
> This CL also adds an ImmutableArray helper class for testing.
>
> BUG=257616
> R=gavinp@chromium.org, pasko@chromium.org
>
> Review URL: https://codereview.chromium.org/21037003
TBR=pliard@chromium.org
Review URL: https://codereview.chromium.org/22458009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The index was re-hashing keys that were already hashed.
This CL also adds an ImmutableArray helper class for testing.
BUG=257616
R=gavinp@chromium.org, pasko@chromium.org
Review URL: https://codereview.chromium.org/21037003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r216233 introduced an issue where, upon successful asynchronous completion
of a lookup in the ServerBoundCertStore, the ServerBoundCertService would
return the existing domain-bound cert for the domain to the caller,
then generate a new domain-bound cert for that domain.
Fix it, by returning without generating a new cert upon successful
asynchronous store lookup, and add unit tests to prevent this in the future.
Additionally, r216233 introduced debug checks on shutdown in the asynchronous
store tests, which this fixes.
BUG=259097
Review URL: https://chromiumcodereview.appspot.com/22603004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update dependency to NSS >= 3.14.3 and NSPR >= 4.9.2
Technically NSS 3.14.3 depends on NSPR 4.9.5, but Debian stable still
ships 4.9.2 on stable, so this is the lower bound.
3.14.3 contains a number of important security fixes, and support for
older systems is no longer desirable.
BUG=245370
TBR=thestig@chromium.org, wtc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/20615002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the queue of operation in SimpleEntryImpl to store metadata for each
operation. This is needed for future performance improvements.
BUG=
Review URL: https://chromiumcodereview.appspot.com/21373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In MDns cache lookups with multiple results return the first result over and
over again. This is the result of a simple oversight. Fix this and add
regression test.
BUG=
Review URL: https://chromiumcodereview.appspot.com/22472002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
supports a single type.
BUG=259097
Review URL: https://chromiumcodereview.appspot.com/20456002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
only for EC P256v1 (which is used for TLS channel IDs.)
BUG=259097
Review URL: https://chromiumcodereview.appspot.com/21561003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move calls to dispatcher->ProcessPacket into a unit-testable method
inside QuicServer. Currently checks if GUID is readable (and drops
packet if not).
Further checks on packet validity can be added here in future if this
refactor looks ok.
Added quic_server_test.cc for QuicServerDispatchPacketTest.
Merge internal change: 50037642
QUIC - Added a comment to add getter/setter for Config class.
Merge internal change: 50024203
Minor fix to finish using the retransmission_it before inserting a new
entry into the retransmission_map_. Found when doing a code review for
internal bug 10031572.
Merge internal change: 49988308
Minor change to improve readability of CreateStreamFrame's sizing test.
Merge internal change: 49942445
Added a comment to port LOG_IF_EVERY_N and control quic_packet_manager warnings.
Merge internal change: 49834369
R=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22253008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were incorrectly removing cookies /w all origins while deleting cookies
for a specific origin within a range (storage_partition_impl.cc,
ClearCookiesOnIOThread).
BUG=180118
Test=MultiThreadedCookieMonsterTest.ThreadCheckDeleteAllCreatedBetweenForHost
Review URL: https://chromiumcodereview.appspot.com/20745004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=265815
R=rch@chromium.org
Review URL: https://codereview.chromium.org/22474003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=268089
Review URL: https://chromiumcodereview.appspot.com/22068002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flip_in_mem_edsm_server should have unittests.
BUG=267354
R=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/21743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a bunch more (brand-new) NetLog events to Simple Cache entries.
Use individual non-paired events for the steps of an event, since they
can overlap and BeginEvent/EndEvent don't handle that well.
BUG=
Review URL: https://chromiumcodereview.appspot.com/18668005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Minor style change for initialization of hdr.msg_flags.
Merge internal change: 49828095
Enabled MaxNumStreams in quic/tools area.
Renamed MaxNumConnections to MaxNumStreams. Initialize
set_max_streams_per_connection only in MaxNumStreams, not for all tests.
Merge internal change: 49728455
QUIC - Adding a bit more information to a logged DFATAL.
Merge internal change: 49724887
Always expecting certificates for secure quic (test) clients. Changing
the end_to_end test to be insecure as it doesn't configure certs.
Merge internal change: 49723287
QUIC - Adding back a comment change that was deleted in the following CL.
https://chromiumcodereview.appspot.com/22020002/diff/1/net/quic/quic_connection.cc
Merge internal change: 49713074
Fail to process a header when the fec group offset is larger than the
packet sequence number.
Merge internal change: 49677837
Added a test to ensure that if the QuicPacketCreator has room for the
stream frame it can be added.
Merge internal change: 49620569
Adding support to QUIC for QUIC_VERSION_7, enabling lower overhead stream frames.
Merge internal change: 49540337
Rearrange code to match spdy_protocol.h SpdyFrameType declaration
order: mostly method declarations and definitions and case statements.
Merge internal change: 49503521
Refactor QuicReceivedEntropyManager and the other received packet code
into Quic ReceivedPacketManager to allow the entropy state and the ack's
received info to stay in sync.
Merge internal change: 49440136
Made a copy of QuicReceivedEntropyManager*.* code into QuicReceivedPacketManager*.*
Doing a better job of detecting unrecoverable compression state.
This is really tricky to get right.
We don't want to unilaterally close the connection if a stream closes before
headers are decompressed. If, for example, a server gets a protocol-layer
error while processing a request it could kill of a stream with something
like QUIC_MULTIPLE_TERMINATION_OFFSETS without sending the http/spdy
response. In this case, the client could continue processing on that
connection.
We basically want to kill off the connection if we get any packets for a
stream we've closed without processing complete headers. Which means
tracking state for every stream which closes without processing complete
headers which is a very unlikely OOM attack vector. I'm capping it at 20
somewhat arbitrarily, and calling it a day.
Merge internal change: 49373258
Removing logspam from quic connection.
Merge internal change: 49370853
Altering the server to not process headers until full headers have been read.
This fixes a problem where if we parsed partial headers, found an error, and
rejected the stream before getting full headers it would be possible to doom
the entire connection.
Merge internal change: 49239328
R=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22122002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Baseline Requirements
Track the (Leaf, Intermediate Root) certificate (algorithm) x (size),
based on whether or not the certificate was issued before or after the
BR compliance date of 2012-12-31.
This is in advance of considering changes to security indicators.
BUG=102949
TBR=jar@chromium.org,wtc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22203003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The name SimpleCacheWorker wasn't a great choice, as in the profiler,
this was showing up as SimpleCacheWorkerWorker. This new name should
be a bit less silly in the profiler.
R=rdsmith
BUG=None
Review URL: https://chromiumcodereview.appspot.com/22053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a crash that occurred by navigating to
https://accounts.google.com/?service=chromiumsync&continue= <invalid url>.
The problem
SyncPromoUI::GetSourceForSyncPromoURL passes the invalid URL to net::GetValueForKeyInQuery, which calls GURL::spec() on it. A DCHECK is made in GURL::spec() to check that the URL is valid. A crash occurs when it's not the case.
The fix
Make net::GetValueForKeyInQuery() return false instead of crashing when it receives an invalid URL. Similarly, many methods from GURL (query(), host(), port(), path(), ref()) don't crash when called on an invalid URL.
With this change, SyncPromoUI::GetSourceForSyncPromoURL will return SOURCE_UNKNOWN when it receives an invalid URL. This is the existing behavior for the case where the continue URL is valid, but unknown.
TEST=
1. Navigate to https://accounts.google.com/?service=chromiumsync&continue=http:%01%3F%01
Expected result: Chromium doesn't crash and an account management page
is loaded.
BUG=247977
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215309
Review URL: https://chromiumcodereview.appspot.com/20491002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rewrite it as an array of chars to emphasize that it's binary data.
This lands server change 50367344.
R=rch@chromium.org
Review URL: https://codereview.chromium.org/22061003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=260527
TBR=rtenneti@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22090002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215543 0039d316-1c4b-4281-b951-d872f2087c98
|