| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
algorithm to monitor the time between the connect and the first
byte on a new connection.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome extensions.
Last time I tried to check this in, I had to roll
it back because it made installing extensions from
file:// URLs not work.
Turned out that we just have to add a single line
mapping the ".crx" extension to our mimetype.
BUG=13296
TEST=Install an extension from the interweb, it should install. Install an extension from disk, it should install.
Review URL: http://codereview.chromium.org/174380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a field-group trial for testing it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This typo causes us to call GetServerCert at the wrong time. We found
that SSLCopyPeerCertificates may succeed (return noErr) but return a
nil CFArrayRef. So we check for that to avoid a crash.
Finally, errSSLIllegalParam means we received an SSL invalid_parameter
error alert message, rather than an invalid function argument. It
should be mapped to ERR_SSL_PROTOCOL_ERROR.
R=avi
BUG=http://crbug.com/19837
TEST=Visit https://stud.infostud.uniroma1.it:4445/Sest/Log/Corpo.html.
Chromium should not crash.
Review URL: http://codereview.chromium.org/173328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=run base_unittests.exe
Review URL: http://codereview.chromium.org/173181
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
In particular, don't do it on ERR_CONNECTION_ABORT or ERR_CONNECTION_CLOSED.
Fix spelling error in ClientSocketHandle comment.
Review URL: http://codereview.chromium.org/173278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
mime type is unsupported. We have cases where supported mime types like javascript/html urls end in .gz. These files should go through the gzip filter.
I manually tested the behavior with Firefox and a fake web server, and wrote unit tests based on them.
BUG=16430
TEST=see bug
Review URL: http://codereview.chromium.org/165035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add Net.SocketIdleTimeBeforeNextUse histograms to track how long a socket is idle before being requested again.
Replace Net.SocketIdleTimeOnIOError with Net.SocketIdleTimeOnIOError2 which raises the sample max to 6 seconds and increases to 100 buckets. I had incorrectly misread the code and assumed we closed idle sockets after 10 seconds. We close idle sockets between 5 minutes and 5 minutes and 10 seconds of idle time.
Review URL: http://codereview.chromium.org/173256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we varied the number of elements in the method_flags
array to enable/disable OCSP. It turns out that's the wrong way.
Between CRLs and OCSP, we prefer OCSP.
R=ukai
BUG=http://crbug.com/10911
TEST=none
Review URL: http://codereview.chromium.org/174283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Requires --enable-byte-range-support
BUG=12258
TEST=covered by unit tests.
Review URL: http://codereview.chromium.org/173231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
According to UMA data, late bound sockets that were idle are significantly more likely to get (reset/close/abort) errors. Currently, we don't resend on late bound sockets that were idle because they weren't reused. This changes that.
TODO: determine how long a socket has to be idle before it is likely to get a TCP RST if we try to reuse it.
Also document the ClientSocketHandle::ReuseSocketType values.
BUG=http://crbug.com/18192.
Review URL: http://codereview.chromium.org/174287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
error.
R=abarth
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/171056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix leaks of (encoded) certificate extensions returned by
CERT_FindCertExtension. They can be freed as soon as they
are decoded.
R=ukai
BUG=http://crbug.com/10911
TEST=none
Review URL: http://codereview.chromium.org/173154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
request failed and there is no response. This fixes the crashes in
OCSPTrySendAndReceive.
R=willchan
BUG=http://crbug.com/19915
TEST=See issue 19915 for steps to reproduce the crash.
Review URL: http://codereview.chromium.org/174248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Requires --enable-byte-range-support
BUG=12258
TEST=covered by unit tests.
Review URL: http://codereview.chromium.org/173173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make SSLConfig.rev_checking_enable default to true (which also affects the defaults set by SSLConfigServicePref.)
Add static SSLConfigService::CreateSystemSSLConfigService which creates a standalone SSLConfigService (either SSLConfigServiceWin or SSLConfigServiceDefaults.)
Use CreateSystemSSLConfigService in fetch_client and test_shell_request_context.
Merge SSLConfigServiceManagerWin and SSLConfigServiceManagerDefaults into SSLConfigServiceManagerSystem, which uses CreateSystemSSLConfigService.
BUG=11507,19290
TEST=only visible change should be linux defaults to having rev checking option enabled.
Review URL: http://codereview.chromium.org/173097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=16507
TEST=Unittests
Review URL: http://codereview.chromium.org/173170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixing a net_unittest case that wasn't updated when googleurl code was changed (but not down integrated to chrome).
BUG=5490
Review URL: http://codereview.chromium.org/174093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
FtpAuthCache.
TEST=Covered by net_unittests.
BUG=none
Review URL: http://codereview.chromium.org/174184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We redirect a file URL that corresponds to a directory when the file URL does
not end in a slash. We redirect to the same URL with a slash appended to
simplify other code, which can then rely on the presence of a trailing slash
for all file URLs that correspond to a directory.
It turns out that following the redirect could result in the job being used
after free. The code in URLRequestJob::FollowDeferredRedirect clears some
fields after calling FollowRedirect. For all other jobs this is not a problem
since the process of following a redirect causes the job to be killed, and
URLRequestJob::Kill takes a reference to the job. It turns out that
URLRequestFileDirJob was not calling URLRequestJob::Kill, and so this extra
reference was not being taken.
The fix is two-fold:
1- Make URLRequestFileDirJob call URLRequestJob::Kill just like the rest of
the jobs. This seems like a good idea for other reasons as well.
2- Make URLRequestJob::FollowDeferredRedirect not depend on itself being alive
after the FollowRedirect call. This just seems good for future cases where a
special URLRequestJob subclass might not call URLRequestJob::Kill for some
reason or another.
Finally, some minor changes were rqeuired to URLRequestFileDirJob to support
the call to Kill. See changes to OnListDone.
Writing a unit test for this was a bit tricky. It turns out that while the
URLRequestFileDirJob is waiting for the client to call FollowDeferredRedirect,
it is still traversing the directory. It does not pause the directory listing.
The crash could only happen if the directory listing completed before the
consumer called FollowDeferredRedirect because a reference to the job was taken
on behalf of the DirectoryLister. To test this condition, I made it possible
for a test to poll the URLRequestFileDirJob::list_completed_ flag. Once that
is set, I then have the test call FollowDeferredRedirect.
NOTE: When running within net_unittests, NetModule::SetResourceProvider has not
been called. So, I downgraded a NOTREACHED to a DLOG(WARNING). NOTREACHED was
a bit excessive since it is a condition that can be reached, and I don't see
any problem with allowing unit tests to function without a resource provider.
R=wtc
BUG=18686
TEST=URLRequestTest.FileDirRedirectNoCrash
Review URL: http://codereview.chromium.org/174076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=willchan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/174205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, make sure that only the main cache runs an experiment.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=16507
TEST=Unittests
Review URL: http://codereview.chromium.org/171085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
config utilities.
Currently it still only ever starts gnome-network-properties but it is now easy to update.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Changed the indentation for long lines of "ExpectLogContains()".
* Moved host_resolver_impl_unittest into the net namespace to avoid lots of redundant net:: prefixes.
Review URL: http://codereview.chromium.org/173137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a range from the cache.
BUG=12258
TEST=unittests
Review URL: http://codereview.chromium.org/174039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in an -O3 experiment.
Review URL: http://codereview.chromium.org/173125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14478
Review URL: http://codereview.chromium.org/174101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This fixes the shared build.
Review URL: http://codereview.chromium.org/173083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of the Core class and merge into OCSPRequestSession.
OCSPCreate adds ref to the OCSPRequestSession and OCSPFree calls
OCSPRequestSession::Cancel and releases a reference to it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=5724
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
previous CL.
BUG=8198
TEST=Building all targets succeed without an error.
TBR=darin
Review URL: http://codereview.chromium.org/173076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Makes SSLConfigService into a ref-counted interface, and makes Profile own an SSLConfigServiceFactory which is used to create the SSLConfigService and pass it through the URLRequestContext on down to where it is actually used.
R=eroman,wtc
BUG=11507,19290
Review URL: http://codereview.chromium.org/165003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a REGISTER_SOCKET_PARAMS_FOR_POOL macro to register valid SocketParams for a ClientSocketPool subtype.
Update HttpNetworkSession's ClientSocketPool to return the concrete TCPClientSocketPool instead of the parent interface. Renamed the member variable&accessor.
Updated tests.
BUG=http://crbug.com/13289
Review URL: http://codereview.chromium.org/173018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure OCSPRequestSession::Core is cancelled when OCSPRequestSession
is deleted as URLFetcher does.
Revert http://src.chromium.org/viewvc/chrome?view=rev&revision=23575
BUG=18907,10911
TEST=none
Review URL: http://codereview.chromium.org/165362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
track down all callers, also removes the
deprecated function that uses std::wstring.
BUG=3078 (http://crbug.com/3078)
TEST=run base_unittests, installer_util_unittests, net_unittests, setup_unittests, and unit_tests.
Review URL: http://codereview.chromium.org/164537
Patch from Thiago Farina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
than the constructor. The purpose of this change is to allow ClientSocketHandle to be able to accept ClientSocketPools of different types, since we will want to pass a TCPClientSocketPool or an SSLClientSocketPool or whatever to it.
BUG=http://crbug.com/13289
Review URL: http://codereview.chromium.org/171003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164545
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on 'using namespace icu'.
This is Chrome's counterpart to the ICU header change that disables
'using namespace icu' (http://codereview.chromium.org/171010/show), which is required to avoid the name colission between Chrome's StringPiece (in base) and ICU's StringPiece.
The webkit change (which is minor) will be dealt with in the webkit bugzilla.
This can go in before the ICU change/upgrade without affecting anything.
BUG=8198
TEST=All the targets are built without an error on all platforms.
Review URL: http://codereview.chromium.org/171012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary since ProxyService is getting shared between chrome's url request contexts (off the record, media), and the current way it is being shared could result in free memory read/writes during shutdown.
This is a step towards fixing http://crbug.com/15289.
BUG=http://crbug.com/15289
TEST=The existing tests should continue to pass following this refactor.
Review URL: http://codereview.chromium.org/165430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Now we can serve byte range requests from cached 200s.
* When we receive 304 we make sure that we were expecting it.
* A range request that doesn't fit the currently stored entry
only deletes the entry if the server confirms that it has
changed.
* Make sure that LOAD_ONLY_FROM_CACHE causes cache misses for
byte range requests.
BUG=12258
TEST=unittests
Review URL: http://codereview.chromium.org/165479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Hopefully this will fix issue 12711.
R=eroman,mark
BUG=http://crbug.com/12711
TEST=covered by existing unit tests and normal browsing on Mac
Review URL: http://codereview.chromium.org/172061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EV checks must fail because EV requires revocation checking. (We aren't
downloading CRLs yet.)
R=willchan
BUG=18907,10911
TEST=Visit EV websites such as https://www.paypal.com/ and
https://www.verisign.com/. Chromium must not show the EV status because
it is not doing OCSP checks.
Review URL: http://codereview.chromium.org/172050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I gained at least 30s by doing that, and there is still room for improvement!
I'm doing changes step-by-step to make sure it won't break mysteriously.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/172057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14478
Review URL: http://codereview.chromium.org/172020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TCPClientSocketPool.
Tracks the number of each socket type returned by the TCPClientSocketPool.
Also tracks the number of recoverable IO errors (resets, aborts, closes) per socket type.
Also tracks the idle time of a socket before a recoverable IO happens.
Review URL: http://codereview.chromium.org/171048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23570 0039d316-1c4b-4281-b951-d872f2087c98
|