| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Merge internal CL: 66548143
R=rtenneti@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/277523008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failures.
BUG=61827
NOTRY=true
NOTREECHECKS=true
R=asanka@chromium.org
Review URL: https://codereview.chromium.org/274193004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=build/android/test_runner.py gtest -s net_unittests --gtest_filter=FilenameUtilTest*
BUG=362608
Review URL: https://codereview.chromium.org/269033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New tests use SpdyBuffer callbacks to enqueue additional writes,
to verify that re-entrancy is allowed and that guards are not hit.
Also confirmed that reverting r268730 causes these tests to fail.
BUG=369539
Review URL: https://codereview.chromium.org/269423003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
support
This was accidentally landed in r268766
BUG=362608
Review URL: https://codereview.chromium.org/269343011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a bug where if a crypto packet is spuriously retransmitted and then
neutered, it remains in missing_packets until the end of the connection.
Merge internal change: 66262890
https://codereview.chromium.org/270213002/
Minor QUIC cleanup to combine QuicUnackedPacketMap's RemovePacket and
NeuterPacket into RemoveOrNeuterPacket.
This prevents potential bugs where a packet can be set not pending, then
neuter'd, which cuases the packet to never be removed from the unacked
packet map.
Merge internal change: 66306887
https://codereview.chromium.org/271443008/
Change QUIC's slow start CWND increase to match recent TCP improvements
to tweak the algorithm for IsCwndLimited.
Merge internal change: 66256837
https://codereview.chromium.org/261423003/
Re-add the PacingSenderTests accidentally removed in cr/65742790
Merge internal change: 66156383
https://codereview.chromium.org/269953009/
Simple cleanup to combine HandleAckForSentPackets and
MaybeRetransmitOnAckFrame into one method.
Merge internal change: 66155839
https://codereview.chromium.org/269213005/
Cleanup: Remove redundant string conversions.
Merge internal change: 66108555
https://codereview.chromium.org/268643008/
Add bytes_in_flight to QUIC's OnPacketSent for the BBR implementation.
Merge internal change: 66091843
https://codereview.chromium.org/269233005/
Minor cleanup to TcpCubicSender now that OnCongestionEvent contains all
the relevent congestion information in one call.
Merge internal change: 66086997
https://codereview.chromium.org/273463002/
R=rch@chromium.org
Review URL: https://codereview.chromium.org/267293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/270573006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The basic idea is that the webstore will provide signed expected hashes
of file content that can be checked during runtime in the browser to
detect corruption due to disk errors or malware.
This CL has a lot of the high-level pieces, with several of the details
left out for subsequent CLs to make this one more easily digestible.
The design is that there is a ContentVerifier for each BrowserContext
which can be used anywhere we read from files inside an extension. It
vends out ContentVerifyJob's, which need to be informed of the bytes
read from each file, and will know how to check those against a set of
expected block hashes. If the job detects contents that don't match what
was expected, it will notify the verifier.
BUG=369895
R=rvargas@chromium.org, yoz@chromium.org
Review URL: https://codereview.chromium.org/266963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The image/x-png is a non-standard mimetype, now replaced by image/png.
Adding support to be backward compatible and also match the behavior
of other browsers like Firefox.
BUG=25293
Review URL: https://codereview.chromium.org/264043018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make it clear that the caller is responsible for the object lifetime, and document cancellation semantics.
BUG=371201
Review URL: https://codereview.chromium.org/270683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed QUIC_VERSION_19 from kSupportedQuicVersions. Will
submit a separate CL after making sure all tests pass with
QUIC_VERSION_19.
Introduces QUIC_VERSION_19, connection level flow control.
QuicConnection now has its own flow_controller_ which aggregates bytes
sent/received/consumed from all the streams on a given connection.
WINDOW_UPDATE and BLOCKED frames are sent with a stream_id of 0 when
they refer to the connection.
On receipt of a WINDOW_UPDATE which unblocks the connection level flow
control, all blocked streams are given a chance to write through a call
to OnCanWrite.
QUIC_VERSION_19: connection flow control. Protected behind
--FLAGS_enable_quic_connection_flow_control
Merge internal change: 66020935
https://codereview.chromium.org/265953003/
New QUIC SendAlgorithmInterface which replaces OnPacketAcked,
OnPacketLost, OnPacketAbandoned, and OnRttUpdated with a single
OnCongestionEvent method.
Merge internal change: 66018835
https://codereview.chromium.org/264743011/
Move TransmissionInfo from QuicUnackedPacketMap to QuicProtocol and add
a simple bytes_in_flight accessor.
Merge internal change: 65886839
https://codereview.chromium.org/265993003/
If stream N is added to the write blocked list, and later a
WINDOW_UPDATE frame arrives for the same stream, then stream N will
added for a second time to the write blocked list.
This is wrong - a stream should only be on the write blocked list once.
The write blocked list is implemented as a deque. This CL adds a
parallel set<QuicStreamId> which also keeps track of blocked streams,
but allows more efficient membership testing. This is used to ensure no
duplicate stream IDs end up in the write blocked list.
Don't allow duplicate IDs in QUIC write blocked list.
Merge internal change: 65878293
https://codereview.chromium.org/261983003/
Sync'ing changes with internal source tree. Minor formatting changes.
Merge internal change: 65851919
https://codereview.chromium.org/265813010/
Test-only change to clean up QuicSentPacketManagerTest in order to make
changing the SendAlgorithmInterface easier.
Merge internal change: 65816291
https://codereview.chromium.org/268623010/
R=rch@chromium.org
Review URL: https://codereview.chromium.org/265833015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=329386
TEST=With a fresh profile, ensure that accounts.google.com and twitter.com
have public keys pinned. (Check chrome://net-internals/#hsts.) Then visit
those sites. Close the browser, re-launch it, and check that the pins are
still present in a query in chrome://net-internals/#hsts.
Review URL: https://codereview.chromium.org/103803012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If this change breaks some bots, please try restarting the
bot before reverting it. http://crrev.com/264460 may not be
effective yet until restarting.
See the bug and http://crrev.com/255129 for the details.
BUG=345554
Review URL: https://codereview.chromium.org/258433005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61827
Review URL: https://codereview.chromium.org/263803011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
encryption level of the data and FEC in the group.
Set last_decrypted_packet_level_ to the FEC group's effective encryption
level before processing a revived packet.
Merge internal CL: 66335962
Allow 0-RTT handshakes for QUIC HTTPS requests.
R=rch@chromium.org,rtenneti@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/268343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't build base/keygen_handler_openssl.cc when using
OpenSSL while leaving certificate handling to the OS. Keygen handler
will in these cases be implemented in OS specific code.
BUG=None
Review URL: https://codereview.chromium.org/267133004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(By request of CloudFlare.)
BUG=none
Review URL: https://codereview.chromium.org/267913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a step towards making it possible to build net/
without ICU. ICU is used by directory_lister.cc, which
is used for creating file directory listings.
BUG=362608
R=mef@chromium.org
Review URL: https://codereview.chromium.org/253603004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/270183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ClusterFuzz will pass an empty input path to test validity of a build.
BUG=353237
Review URL: https://codereview.chromium.org/266423005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed to reduce binary size of net/ when build as a
library.
BUG=362608
Review URL: https://codereview.chromium.org/257673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the linked bug for more background info.
Adding this field has been approved by privacy team (see #5 in the linked bug).
This CL depends on
https://codereview.chromium.org/238793007/
BUG=355604
Review URL: https://codereview.chromium.org/246553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=369539
Review URL: https://codereview.chromium.org/265933007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While the cache is being destroyed it is possible for some cache transactions
to be notified about completion/cancellation. This means that the code from
the transaction may attempt to use the cache even though its state is not well
known at that point.
This CL notifies all transactions that they should not use the cache anymore.
BUG=368984
Review URL: https://codereview.chromium.org/265413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix users, NativeMessageProcessHost and PipeReader.
BUG=322664, 369183
TEST=For NativeMessageProcessHost: unit_tests --gtest_filter="NativeMessagingTest.*"
TEST=For PipeReader: On a Chromebook, open chrome://tracing and start recording with "System tracing" checked, see "Kernel" section appears on the result.
Review URL: https://codereview.chromium.org/265703004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke GN bot
> Reduce footprint of registry controlled domain table
>
> The perfect hash table containing all registry controlled domains is
> replaced by a compact graph (a dafsa) to reduce binary size and PSS
> of the running process. Size of the new structure is about 33kB
> compared to 380kB for the perfect hash table.
>
> Patch by Olle Liljenzin <ollel@opera.com>, originally at https://codereview.chromium.org/197183002/
>
> BUG=370672
>
> Review URL: https://codereview.chromium.org/274443003
TBR=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/270503004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The perfect hash table containing all registry controlled domains is
replaced by a compact graph (a dafsa) to reduce binary size and PSS
of the running process. Size of the new structure is about 33kB
compared to 380kB for the perfect hash table.
Patch by Olle Liljenzin <ollel@opera.com>, originally at https://codereview.chromium.org/197183002/
BUG=370672
Review URL: https://codereview.chromium.org/274443003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 268461 "Disable flaky EndToEndTest.LargePostLargeBuffer u..."
>
> > Disable flaky EndToEndTest.LargePostLargeBuffer unit test.
> >
> > TBR=rch@chromium.org, thestig@chromium.org
> > BUG=370087
> >
> > Review URL: https://codereview.chromium.org/262093009
>
> Will disbale asap.
>
> TBR=rtenneti@chromium.org
>
> Review URL: https://codereview.chromium.org/272473002
TBR=rtenneti@chromium.org
Review URL: https://codereview.chromium.org/271573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Disable flaky EndToEndTest.LargePostLargeBuffer unit test.
>
> TBR=rch@chromium.org, thestig@chromium.org
> BUG=370087
>
> Review URL: https://codereview.chromium.org/262093009
Will disbale asap.
TBR=rtenneti@chromium.org
Review URL: https://codereview.chromium.org/272473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rch@chromium.org, thestig@chromium.org
BUG=370087
Review URL: https://codereview.chromium.org/262093009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In proxy_config_service_linux, disabled glib deprecation warnings. The
function g_settings_list_schemas got deprecated in 2.40, but its
replacement is not available in older glib versions (such as the one the
build bots currently use, 2.32), so for now, disable the warnings.
BUG=351911
Review URL: https://codereview.chromium.org/264963005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates to the following revision:
ba86f988fb17 2014-03-10 08:57 -0400
It includes changes from revision ba86f988fb17 (2014-03-10 08:57 -0400)
to revision e5572fc5c754 (2014-04-02 16:58 +0100), listed at
http://hg.mozilla.org/mozilla-central/filelog/e5572fc5c754/netwerk/dns/effective_tld_names.dat
BUG=37436
R=pkasting@chromium.org
Review URL: https://codereview.chromium.org/262363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also move hpack fuzz targets to build on mac & win,
and tweak fuzzer tools to build on win.
Re-applied patch from issue 266003005.
TESTED=Manually built on windows.
BUG=353237
Review URL: https://codereview.chromium.org/268943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/268703003/)
Reason for revert:
We still need this feature on ios and android
Original issue's description:
> Remove Referrer Policy from URLFetcher.
>
> There were no consumers of this.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267757
TBR=mmenke@chromium.org,noyau@chromium.org,cbentzel@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/265253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/262013003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Besides the additional wiring, this included the addtion
of a proxy config service and tracker, which are implemented in
data_reduction_proxy/browser/data_reduction_config_service.{cc,h} and
data_reduction_proxy/browser/data_reduction_config_service_unittest.cc.
BUG=363403
Review URL: https://codereview.chromium.org/237643005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297040
R=rch@chromium.org
Review URL: https://codereview.chromium.org/269543021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's no need to use recursion when getting the data from a filter.
This version uses a loop instead.
The issue with recursion is that it opens the door to stack exhaustion
if there is no way to limit its depth. In this case, that would be a
hard thing to do given that it basically depends on interactions outside
of our control.
BUG=366149
Review URL: https://codereview.chromium.org/267793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke windows compile:
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_fuzz_wrapper.hpack_fuzz_wrapper.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_fuzz_wrapper.cc /Foobj\net\spdy\fuzzing\hpack_fuzz_wrapper.hpack_fuzz_wrapper.obj /Fdobj\net\hpack_fuzz_wrapper.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_wrapper.cc(38) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_example_generator.hpack_example_generator.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_example_generator.cc /Foobj\net\spdy\fuzzing\hpack_example_generator.hpack_example_generator.obj /Fdobj\net\hpack_example_generator.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(51) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(52) :error C2664: 'base::File::File(base::File::RValue)' : cannot convert argument 1 from 'int' to 'base::File &'
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(68) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_example_generator.cc(69) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\net\spdy\fuzzing\hpack_fuzz_mutator.hpack_fuzz_mutator.obj.rsp /c ..\..\net\spdy\fuzzing\hpack_fuzz_mutator.cc /Foobj\net\spdy\fuzzing\hpack_fuzz_mutator.hpack_fuzz_mutator.obj /Fdobj\net\hpack_fuzz_mutator.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(53) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(56) :error C2440: '<function-style-cast>' : cannot convert from 'std::string' to 'base::FilePath'
No constructor could take the source type, or constructor overload resolution was ambiguous
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(57) :error C2664: 'base::File::File(base::File::RValue)' : cannot convert argument 1 from 'int' to 'base::File &'
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(72) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
c:\b\build\slave\cr-win-rel-x64\build\src\net\spdy\fuzzing\hpack_fuzz_mutator.cc(73) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
> Add hpack_fuzz_wrapper to chromium_builder_asan.
>
> BUG=353237
>
> Review URL: https://codereview.chromium.org/266003005
TBR=jgraettinger@chromium.org
Review URL: https://codereview.chromium.org/268863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=353237
Review URL: https://codereview.chromium.org/266003005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically only look for re-entrancy that shrinks the queue. We know
that other types of iterator invalidation happens due to growing the
queue, but that doesn't match the symptom we're seeing.
BUG=369539
Review URL: https://codereview.chromium.org/265093004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a FileStream is deleted while Open is in progress, the file was being
closed on the wrong thread because it was not being transferred to the
FileStream::Context.
This CL transfers the file to the context even if it is orphaned.
BUG=322664
TEST=net_unittests
Review URL: https://codereview.chromium.org/250783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=361791
R=pauljensen@chromium.org
Review URL: https://codereview.chromium.org/265813005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of using a custom, hand-made function, it is better to use a
function which has unit tests (in base_unittests) and thus is more
likely to have less bugs.
TEST=flip_in_mem_edsm_server_unittests
R=wtc@chromium.org
Review URL: https://codereview.chromium.org/261063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
There were no consumers of this.
Review URL: https://codereview.chromium.org/268703003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
HttpStreamFactoryImpl::Job since that already happens (more correctly)
in QuicStreamFactory.
Fix a bug where QuicStreamFactory would not mark Alternate-Protocol broken
under all circumstances.
Review URL: https://codereview.chromium.org/255713004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Merge internal change: 65913245
R=rch@chromium.org
Review URL: https://codereview.chromium.org/266723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
url_util -> url
url_parse -> url
url_canon -> url
BUG=364747
TBR=estade
Review URL: https://codereview.chromium.org/260903011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
provided to clients of net::GetNetworkList.
Windows API which provides these details are exposed via IP_ADAPTER_UNICAST_ADDRESS.
(http://msdn.microsoft.com/en-us/library/windows/desktop/aa366058(v=vs.85).aspx)
BUG=361791
R=pauljensen@chromium.org
TBR=justinlin@chromium.org,vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/232343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267586 0039d316-1c4b-4281-b951-d872f2087c98
|