summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* Alter the forward declarations so they match the definition. Unbreaks clang, ↵avi@chromium.org2011-02-022-2/+2
| | | | | | | | | | | broken by r73491. BUG=none TEST=none Review URL: http://codereview.chromium.org/6250117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73522 0039d316-1c4b-4281-b951-d872f2087c98
* Split flip_in_mem_edsm_server into a gazillion pieces.mbelshe@chromium.org2011-02-0225-3216/+3612
| | | | | | | | | | | For the most part, this is a straight refactor. I'm sure I broke something. BUG=monolithic code TEST=none Review URL: http://codereview.chromium.org/6392011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73491 0039d316-1c4b-4281-b951-d872f2087c98
* Fix device management testservergfeher@chromium.org2011-02-021-2/+3
| | | | | | | | | | | Fix serving of policies after the recent config file format change. BUG=none TEST=Run the testserver with Chrome and check that policies are applied to Chrome. Review URL: http://codereview.chromium.org/6246043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73448 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 73402 - Disk cache: Disable the throttling experiment.rvargas@google.com2011-02-021-1/+12
| | | | | | | | | | | | | | | This is intended for the beta/stable channels. BUG=none TEST=none TBR=gavinp Review URL: http://codereview.chromium.org/6286036 TBR=rvargas@google.com Review URL: http://codereview.chromium.org/6250097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73405 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Disable the throttling experiment.rvargas@google.com2011-02-021-12/+1
| | | | | | | | | | | | This is intended for the beta/stable channels. BUG=none TEST=none TBR=gavinp Review URL: http://codereview.chromium.org/6286036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73402 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the nits I pointed out in the review ofwtc@chromium.org2011-02-022-23/+34
| | | | | | | | | | | http://codereview.chromium.org/6002003/ R=hclam BUG=none TEST=net_unittests --gtest_filter=X509* Review URL: http://codereview.chromium.org/6049010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73384 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the CertDatabaseNSSTest SetUp creating multiple NSS DBs (regressed in ↵mattm@chromium.org2011-02-011-5/+15
| | | | | | | | | | | r69107). BUG=none TEST=none Review URL: http://codereview.chromium.org/6264016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73366 0039d316-1c4b-4281-b951-d872f2087c98
* Unreverting: First steps towards webRequest extension API.mpcomplete@chromium.org2011-02-013-0/+15
| | | | | | | | | | | | | | Only an asynchronous version of onBeforeRequest is implement, with limited data being passed. Original CL: http://src.chromium.org/viewvc/chrome?view=rev&revision=73196 BUG=60101 TEST=no Review URL: http://codereview.chromium.org/6246032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73344 0039d316-1c4b-4281-b951-d872f2087c98
* Silence testserver logs when tests are run in non-verbose modersimha@chromium.org2011-02-012-1/+13
| | | | | | | | | | | | | The console output from testserver.py, chromiumsync.py and xmppserver.py during sync integration test runs is pretty chatty, and could do with being disabled by default. In addition, testserver.py spits out logs for non-sync tests even when the tests are run in non-verbose mode. This patch adds a switch to testserver.py called "log-to-console", and ties it up to the logging level returned by logging::GetMinLogLevel(). This way, testserver logs are printed on the console (in addition to being written to testserver.log) when tests are run in verbose mode. However, when tests are run in non-verbose mode, testserver logs are only written to the log file, but not to the console. BUG=71241 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6404003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73330 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 73265 - Check that uncompressed data passed to zlib is defined, and ↵danno@chromium.org2011-02-011-8/+0
| | | | | | | | | | | | | | | | | | | | | mark compression result as defined. This way, we suppress benign reports from zlib (see http://www.zlib.net/zlib_faq.html#faq36), without losing coverage of spdy code. This patch was prepared by eugenis@chromium.org (doesn't have a committer access yet) and reviewed at http://codereview.chromium.org/6310016/ BUG=70098 TEST=run automated_ui_tests with random action lists under Valgrind for a few hours at least. TBR=wtc Review URL: http://codereview.chromium.org/6287040 TBR=glider@chromium.org Review URL: http://codereview.chromium.org/6392044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73266 0039d316-1c4b-4281-b951-d872f2087c98
* Check that uncompressed data passed to zlib is defined, and mark compressionglider@chromium.org2011-02-011-0/+8
| | | | | | | | | | | | | | | | result as defined. This way, we suppress benign reports from zlib (see http://www.zlib.net/zlib_faq.html#faq36), without losing coverage of spdy code. This patch was prepared by eugenis@chromium.org (doesn't have a committer access yet) and reviewed at http://codereview.chromium.org/6310016/ BUG=70098 TEST=run automated_ui_tests with random action lists under Valgrind for a few hours at least. TBR=wtc Review URL: http://codereview.chromium.org/6287040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73265 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: fix directory listing parser when server fails to separate the first ↵phajdan.jr@chromium.org2011-02-012-4/+11
| | | | | | | | | | | two columns. BUG=70394 TEST=net_unittests Review URL: http://codereview.chromium.org/6396005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73261 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to Sdch* classes.tfarina@chromium.org2011-02-016-63/+94
| | | | | | | | | BUG=64263 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/6347033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73249 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Real* to Double* in values.* and dependent filesarv@chromium.org2011-02-011-4/+4
| | | | | | | | | BUG=None TEST=Compiles and passes all tests Review URL: http://codereview.chromium.org/6248026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73232 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "First steps towards webRequest extension API."mpcomplete@chromium.org2011-01-313-15/+0
| | | | | | | | | | | | | | | Seems to have broken the sync_integration_tests. This reverts commit d6f8d16cd6a5ebdf019c4755e7d42aee8136abf1. TBR=aa BUG=60101 TEST=no Review URL: http://codereview.chromium.org/6287029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73219 0039d316-1c4b-4281-b951-d872f2087c98
* First steps towards webRequest extension API.mpcomplete@chromium.org2011-01-313-0/+15
| | | | | | | | | | | | Only an asynchronous version of onBeforeRequest is implement, with limited data being passed. BUG=60101 TEST=no Review URL: http://codereview.chromium.org/6288014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73196 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete files from 'sources'. This causes needless work on ↵jeanluc@chromium.org2011-01-311-2/+0
| | | | | | | | | | | incremental builds in VS2010. BUG=71130 TEST=Check that Chrome builds. Review URL: http://codereview.chromium.org/6386019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73190 0039d316-1c4b-4281-b951-d872f2087c98
* net: disable DNS lookup tests.agl@chromium.org2011-01-313-51/+1
| | | | | | | | | | | | | These tests have yielded useful data and I'll probably tweak them for the future. However, I want a CL which disables them so that I can merge it into the release branch for M10. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/6287023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73189 0039d316-1c4b-4281-b951-d872f2087c98
* net: update False Start blacklist.agl@chromium.org2011-01-311-0/+3
| | | | | | | | | These sites are using Brocade hardware which should be updated in a few months. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73157 0039d316-1c4b-4281-b951-d872f2087c98
* Require NTLM identity earlyasanka@chromium.org2011-01-312-26/+42
| | | | | | | | | | | Don't wait until we receive an NTLM challenge to request username/password BUG=22845 TEST=net_unittests --gtest_filter=HttpNetworkTransactionTest.NTLMAuth* Review URL: http://codereview.chromium.org/6326016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73150 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 73121 - Remove obsolete files from 'sources'. This causes needless ↵nsylvain@chromium.org2011-01-311-0/+2
| | | | | | | | | | | | | | | | | | work on incremental builds in VS2010. This is breaking clobber builds with this error : e:\b\build\slave\google-chrome-rel-win\build\src\chrome_frame\iids.cc(6) : fatal error C1083: Cannot open include file: 'chrome_tab.h': No such file or directory BUG=71130 TEST=Check that Chrome builds. Review URL: http://codereview.chromium.org/6307018 TBR=jeanluc@chromium.org Review URL: http://codereview.chromium.org/6347032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73124 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete files from 'sources'. This causes needless work on ↵jeanluc@chromium.org2011-01-301-2/+0
| | | | | | | | | | | incremental builds in VS2010. BUG=71130 TEST=Check that Chrome builds. Review URL: http://codereview.chromium.org/6307018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73121 0039d316-1c4b-4281-b951-d872f2087c98
* Add the include <iterator> or change the usage of back_inserter to avoid ↵jeanluc@chromium.org2011-01-301-6/+6
| | | | | | | | | | | compilation errors in Visual Studio 2010. See http://blogs.msdn.com/b/vcblog/archive/2009/05/25/stl-breaking-changes-in-visual-studio-2010-beta-1.aspx for details. BUG=71134 TEST=Run the related tests. Review URL: http://codereview.chromium.org/6260024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73118 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to GZip* classes.tfarina@chromium.org2011-01-305-30/+46
| | | | | | | | | BUG=64263 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/6260029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73112 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes eol on http_stream_parser.ccmaruel@chromium.org2011-01-291-1/+1
| | | | | | | NO CODE CHANGE. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73095 0039d316-1c4b-4281-b951-d872f2087c98
* The way I was closing when we detected an invalid frame was incorrect;mbelshe@chromium.org2011-01-291-32/+41
| | | | | | | | | | | | | | | it was closing the socket while in the middle of IO callbacks which could crash. Instead, set a flag which will cleanup and dropout after we've finished processing IO. BUG=none TEST=n/a Review URL: http://codereview.chromium.org/6269025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73078 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak when cleaning the queued data frames.mbelshe@chromium.org2011-01-281-41/+19
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6298021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73024 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2:mbelshe@chromium.org2011-01-281-38/+50
| | | | | | | | | | | | | | | | | | Optimizations to fill packets better for the edsm server. Problems: - the SETTINGS frame was the first packet we'd send, uncorked (~45B). This was wasting the first packet of our cwnd. - uncork was overaggressive. We now only uncork when there are no more packets in our queue. - rework the packet sizing to fully fill packets better. BUG=none TEST=n/a Review URL: http://codereview.chromium.org/6245015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72983 0039d316-1c4b-4281-b951-d872f2087c98
* New protocol and testserver for the Chrome-DMServer protocolgfeher@chromium.org2011-01-284-16/+230
| | | | | | | | | | | | | | | New features: -Message to ping DMServer and ask if a user is managed -Signed policy responses -Server assigns names to ChromeOS devices A temporary version of cloud_policies.proto is also checked in (it will be auto-generated later). BUG=chromium-os:11253,chromium-os:11254 TEST=none Review URL: http://codereview.chromium.org/6161007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72975 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes OpenSSL build: adds missing include filebulach@chromium.org2011-01-281-0/+2
| | | | | | | | | BUG=none TEST=compiles with use_openssl Review URL: http://codereview.chromium.org/6340020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72962 0039d316-1c4b-4281-b951-d872f2087c98
* The HttpRequestInfo object must outlive the HttpNetworkTransaction object ↵satish@chromium.org2011-01-281-309/+309
| | | | | | | | | | | | | | because HttpRequestInfo is passed to HttpNetworkTransaction::Start() and HttpNetworkTransaction access the request info object in many places. With the current code UploadData gets deleted before HttpStreamParser and that causes read-after-free cases as shown in the below bug. BUG=70825 TEST=verify that the valgrind issue mentioned in the bug gets fixed Review URL: http://codereview.chromium.org/6327020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72954 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify HttpCache/HttpNetworkLayer/HttpNetworkSession interaction.willchan@chromium.org2011-01-289-319/+186
| | | | | | | | | | | | | Eliminate lazy initialization of HttpNetworkSession in HttpNetworkLayer. * This eliminates the need to update parameters for HttpNetworkLayer, it just takes a HttpNetworkSession. * It is OK to eliminate lazy initialization since these variables are cheap. BUG=none TEST=none Review URL: http://codereview.chromium.org/6402002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72931 0039d316-1c4b-4281-b951-d872f2087c98
* Add checkout.google.com to STS list, with permission from Checkout team.cevans@chromium.org2011-01-281-0/+1
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6299020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72925 0039d316-1c4b-4281-b951-d872f2087c98
* Change UTF8ToUTF16 to accept const StringPiece&.suzhe@google.com2011-01-284-0/+7
| | | | | | | | | BUG=70936 TEST=All unit tests should pass. Review URL: http://codereview.chromium.org/6317016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72921 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the crash in SpdyNetworkTransactionTest.CorruptFrameSessionError.wtc@chromium.org2011-01-271-6/+5
| | | | | | | | | | | | | | | Instead of changing the frame length to a huge number, which would require that many bytes of frame data to match, I change the frame length to a smaller number, so that we won't read beyond the end of a valid data buffer. R=mbelshe,willchan BUG=48588 TEST=net_unittests --gtest_filter=*.CorruptFrameSessionError* should not crash in memcpy. Review URL: http://codereview.chromium.org/6286008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72880 0039d316-1c4b-4281-b951-d872f2087c98
* The server will happily propagate invalid SPDY headers, which Chrome willmbelshe@chromium.org2011-01-271-0/+5
| | | | | | | | | | | reject. Strip headers with 0 length header names or 0 length header values. BUG=none TEST=none Review URL: http://codereview.chromium.org/6286012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72858 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72844 - Optimizations to fill packets better for the edsm server.mbelshe@chromium.org2011-01-271-50/+38
| | | | | | | | | | | | | | | | | | | | | | Problems: - the SETTINGS frame was the first packet we'd send, uncorked. This was wasting the first packet of our cwnd. - uncork was overaggressive. We now only uncork when there are no more packets in our queue. - rework the packet sizing to fully fill packets better. Question - should I remove the MSG_MORE code now? It seems to be an alternative way to do corking, but it just doesn't work with the SSL layer. BUG=none TEST=n/a Review URL: http://codereview.chromium.org/6327022 TBR=mbelshe@chromium.org Review URL: http://codereview.chromium.org/6359016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72849 0039d316-1c4b-4281-b951-d872f2087c98
* Optimizations to fill packets better for the edsm server.mbelshe@chromium.org2011-01-271-38/+50
| | | | | | | | | | | | | | | | | | | Problems: - the SETTINGS frame was the first packet we'd send, uncorked. This was wasting the first packet of our cwnd. - uncork was overaggressive. We now only uncork when there are no more packets in our queue. - rework the packet sizing to fully fill packets better. Question - should I remove the MSG_MORE code now? It seems to be an alternative way to do corking, but it just doesn't work with the SSL layer. BUG=none TEST=n/a Review URL: http://codereview.chromium.org/6327022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72844 0039d316-1c4b-4281-b951-d872f2087c98
* Add histogram for HTTP response codesgavinp@chromium.org2011-01-271-0/+46
| | | | | | | | | | | | | | | | | | | | | | | This adds an histogram to the HTTP response header parser. I reviewed the code, and I've convinced myself that this captures the two main cases of HTTP header parsing (tunneling, and normal HTTP), and that double-calls aren't occuring. I liked having all the code in the one translation unit. But, I might have missed one, and we might still be getting called twice for the same load: so the statistics might be off. Alternatively, I could put a static function on HttpResponseHeader, to be called from the site of parse. But this might miss a parse. All in all, I wanted to be sure to catch all distinct response codes we get, so we can be sure not to stomp on anything. So I chose the approach using the HttpResponseHeaders constructor. TEST=none BUG=70428 Review URL: http://codereview.chromium.org/6317011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72801 0039d316-1c4b-4281-b951-d872f2087c98
* Abstracts SHA256 context for NSS / OpenSSL.bulach@chromium.org2011-01-273-1/+63
| | | | | | | | | | | Stubs out SslServerSocket for OpenSSL. BUG=none TEST=Sha256Test.TestContext (and compiles with openssl flag). Review URL: http://codereview.chromium.org/6276002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72782 0039d316-1c4b-4281-b951-d872f2087c98
* Add health.google.com to hardcoded STS list, with permission from the Healthcevans@chromium.org2011-01-271-0/+1
| | | | | | | | | | | team. BUG=none TEST=none Review URL: http://codereview.chromium.org/6393009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72754 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for chunked encoding in ChromeFrame for POST requests. This ↵ananta@chromium.org2011-01-262-1/+10
| | | | | | | | | | | | | | | | | | | | fixes the URLRequestTestHTTP.TestPostChunkedDataBeforeStart net test failure in ChromeFrame. To support chunked encoding we need to marshal the corresponding information in the net::UploadData object to ensure that this object gets reconstructed correctly on the other side (CF). Disabled the URLRequestTestHTTP.TestPostChunkedDataAfterStart for ChromeFrame as this test modifies the UploadData object after it has been marshaled over to CF which we don't support in ChromeFrame. BUG=none TEST=Covered by existing net tests. Review URL: http://codereview.chromium.org/6357017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72723 0039d316-1c4b-4281-b951-d872f2087c98
* More net/ method ordering.erg@google.com2011-01-2650-2801/+2838
| | | | | | | | | BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6339012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72710 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up net unit testing code.erg@google.com2011-01-2630-916/+1248
| | | | | | | | | | | | | | | | | | | | (Reapply r72562 with willchan's nits + locally tested shlib fixes + removing duplicate code that was partially responsible for the failure.) - Move code included from blah_unittest.h (where blah_unittest.cc has actual unittests) into their own files, often completely out-of-lining the definitions. - Remove anonymous namespaces from headers. - Reorder method declarations. - Make other unit test link against net_test_support instead of reaching in and including .h files in their targets directly. BUG=68682 TEST=compiles First Review URL: http://codereview.chromium.org/6264013 Review URL: http://codereview.chromium.org/6248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72682 0039d316-1c4b-4281-b951-d872f2087c98
* Remove hresolvcbentzel@chromium.org2011-01-262-471/+0
| | | | | | | | | | | I added this when I first started working on Chrome, and never use it. It's a command line utility to issue DNS commands. BUG=None TEST=None Review URL: http://codereview.chromium.org/6320014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72641 0039d316-1c4b-4281-b951-d872f2087c98
* Log source ip and port in NetLog.willchan@chromium.org2011-01-264-30/+126
| | | | | | | | | | | This will make it easier to identify specific TCP connections in a wireshark trace. BUG=70649 TEST=Connect somewhere, check about:net-internals to see that source ip and port are logged. Review URL: http://codereview.chromium.org/6394004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72607 0039d316-1c4b-4281-b951-d872f2087c98
* Fix comment in http_stream_request.cc.willchan@chromium.org2011-01-261-2/+2
| | | | | | | | | BUG=66472 TEST=none Review URL: http://codereview.chromium.org/6313014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72604 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent over-preconnecting when we already have a SpdySession.willchan@chromium.org2011-01-262-5/+41
| | | | | | | | | | | Note, this isn't a complete fix for the bug. We need to persist information for that. BUG=66472 TEST=none Review URL: http://codereview.chromium.org/6340016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72600 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up net unit testing code." since it breaks the shlib builder.erg@google.com2011-01-2530-1248/+916
| | | | | | | | | | This reverts commit 006f377bbb65ece3490b7c76e58e0dc4cb330909 (r72562). BUG=68682 TEST=compiles TBR=thomasvl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72564 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Prevent obscure file corruption and dealrvargas@google.com2011-01-259-49/+255
| | | | | | | | | | | | | | | | | | | | | | | | | | | with the result of that corruption. 1. Now we mark any open entry as dirty, even if we are supposed to delete the entry right away because if we crash before that, we may end up clearing the dirty flag of a dirty entry. 2. When we look for a parent of a given entry we now double check that the entry is the one that we want (and not just another entry with the same key). 3. If we have a loop on the hash collision list (result of failing to do 1 and 2 above), we figure that out. 4. Now every time we open an entry from an LRU list we end up using the same code path (with the proper handling of dirty entries). BUG=69135 TEST=net_unittests Review URL: http://codereview.chromium.org/6292011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72563 0039d316-1c4b-4281-b951-d872f2087c98