| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=29471
Review URL: http://codereview.chromium.org/467031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to a state machine.
BUG=26729
TEST=current unit tests.
Review URL: http://codereview.chromium.org/464028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/465061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a) When the SSL handshake completes, pass the error through
and close the session.
b) When the Connect returns error, we were returning OK anyway.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/463032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/462040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It exposed problems with some tests which manifest as flakiness.
Will debug offline.
BUG=12710
TBR=wtc
Review URL: http://codereview.chromium.org/465066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the certificate just expired.
TBR=cpu
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/464040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21468,22520
For the explanation why these are data races,
see http://code.google.com/p/data-race-test/wiki/PopularDataRaces
Review URL: http://codereview.chromium.org/251027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This turns out to be much better code organisation strategy. We're going
to have even more parsers.
TEST=Covered by net_unittests.
BUG=25520
Review URL: http://codereview.chromium.org/465035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the mocksocket so that we can test connection statuses.
Verified that the test case crashes without the flip_session.cc fix.
BUG=none
TEST=FlipNetworkTransaction.ConnectFailure
Review URL: http://codereview.chromium.org/462023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/467014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/463009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL only implements the states that are related to
current asynchronous operations.
BUG=26729
TEST=current unit tests.
Review URL: http://codereview.chromium.org/410005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
code (always a negative number). The most likely reason for
memio_CreateIOLayer or SSL_ImportFD to fail is that we ran
out of memory, so just return ERR_OUT_OF_MEMORY.
R=dank
BUG=none
TEST=no compilation errors.
Review URL: http://codereview.chromium.org/464024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Make it explicit that it only supports ASCII (since it iterates
character by character).
2) Limit the recursion to 16 levels. We could allow more, but in the
case of a ?, it has exponential complexity, so I figured 16 was a good
stopping point. It seems rare that someone would have more than 16
'?' and '*'s.
BUG=28645
Review URL: http://codereview.chromium.org/460047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This menu item only exists in the Mac build, but the code is cross-platform so it could be hooked up on other platforms as well, if desired.
It works by generating a URL of the form
mailto:?subject=Fwd:%20PAGETITLE&body=%0A%0APAGEURL
and telling platform_utils to open it.
This is my first patch involving command handling; I've tried to follow the way similar menu commands
like Print are implemented, but feel free to tell me if there are better ways.
I didn't find any place for unit tests for TabContents; if this needs tests, let me know where they should go.
BUG=29232
TEST=none
Review URL: http://codereview.chromium.org/466019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29288
TEST=play this file: http://www.louderproductions.com/mp3/Killshot.mp3 and make sure controls work.
Review URL: http://codereview.chromium.org/455044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
request_ to NULL, otherwise Cancel() may fail to post a CancelURLRequest
task because io_loop_ is NULL but request_ is not NULL. (That task adds
a reference to the OCSPRequestSession object to ensure that it lives
longer than the URLRequest object.)
R=ukai
BUG=28526
TEST=none
Review URL: http://codereview.chromium.org/460040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some highlights:
- more tests (including non-ASCII characters in different encodings)
- handling more variants of "ls" listing
- handling spaces in file names in "ls" listings
TEST=Covered by net_unittests.
BUG=25520
Review URL: http://codereview.chromium.org/449011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=willchan
BUG=29241
TEST=none
Review URL: http://codereview.chromium.org/455029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This fixes decompression failures with some sites.
R=wtc
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests and test_shell_tests.
BUG=12710
Review URL: http://codereview.chromium.org/460014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the transaction to mode NONE and deletes the entry_.
BUG=28994
TEST=unittests
Review URL: http://codereview.chromium.org/449069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of resource loading from WebKit into the network stack.
In order to fully make these work, webkit changes are needed
as well.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/452033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=FlipProtocolTest
Review URL: http://codereview.chromium.org/449065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PROXY_SERVICE_POLL_CONFIG_SERVICE_FOR_CHANGES
which measures how much time was spent per request retrieving the system proxy settings.
On Windows this corresponds with the function:
WinHttpGetIEProxyConfigForCurrentUser().
Which seems to be very slow on some systems.
BUG=12189
Review URL: http://codereview.chromium.org/452034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetServerCert only when we're about to verify a certificate or
SSLHandshake fails with a certificate error. This allows us to
remove the null pointer test for |certs| in GetServerCert.
Remove the TAB characters reported by cpplint.py.
R=hawk
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/351033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NSS 3.12.3 or later.
R=ukai
BUG=none
TEST=No compilation errors.
Review URL: http://codereview.chromium.org/452014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
server doesn't revalidate a partially stored entry, in other
words, after we issued a conditional byte range request.
BUG=27276, 28850
TEST=unittests
Review URL: http://codereview.chromium.org/452017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=mbelshe
BUG=none
TEST=no compilation errors
Review URL: http://codereview.chromium.org/450026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
full duplex, a closed socket will cause both read and write completions. Unifying
the cleanup code allows both codepaths to safely cleanup the socket.
In the process, consolidated several flags on the session into a single State
variable.
BUG=29004
TEST=WriteError
Review URL: http://codereview.chromium.org/450025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
well as HTTP connections. This is used for benchmarking.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/454009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/450021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rather than as OK.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/457014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
we create SSL tunnels through a proxy. The patch is contributed by
Kaspar Brand <googlecontrib@velox.ch>.
R=hawk,wtc
BUG=28732
TEST=none
Review URL: http://codereview.chromium.org/437046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/384062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an experimental, client only implementation of
next-protocol-negotiation:
http://www.imperialviolet.org/binary/draft-agl-tls-nextprotoneg-00.html
This only affects the internal copy of libssl and is only active when
built with use_system_ssl=0, which is not currently the default.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I left the one API because based on the comment, it should eventually be
removed. Updated the callers to use UTF16ToWideHack until more work can be done
to remove std::wstring. I also updated net/base/escape_unittest.cc to use the
same hack until a proper solution can be coded.
Original patch submission here:
http://codereview.chromium.org/402085
Patch by Patrick Scott (phanna@android.com)
R=darin
BUG=23581
TEST=escape_unittest
Review URL: http://codereview.chromium.org/452015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
platforms, in preparation for using SSLClientSocketNSS on Windows.
nss_memio.c does not need to include <unistd.h>
Fix style nits.
R=eroman
BUG=28744
TEST=none
Review URL: http://codereview.chromium.org/440031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29004
TEST=none
Review URL: http://codereview.chromium.org/453008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Accidentally already checked in the flip_session.cc reordering
of member variables in the constructor. So checking this in now.
BUG=none
TEST=none
TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/449017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix chromium.patch so that it's possible to apply it.
It turns out my editor removed whitespace from ParseFTPList.cpp anyway,
and somehow the patch itself was corrupted.
The plan is to remove this code after our own LIST parsing code is ready,
but for now we still need it.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/450008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
status or version headers would crash.
BUG=none
TEST=FlipNetworkTransactionTest.InvalidSynReply
Review URL: http://codereview.chromium.org/455003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
method factory for the DelayedSocketDataProvider.
The problem which crashed was that the lifecycle of
the socket and the data provider are not coupled; and
the posted message for a delayed ReadCompletion could
be left hanging.
BUG=none
TEST=WriteError
Review URL: http://codereview.chromium.org/452010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
were forgetting to release the in_flight_write,
which holds a reference to the FlipStream.
BUG=none
TEST=WriteError (coming)
Review URL: http://codereview.chromium.org/453005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=ukai
BUG=28744
TEST=none
Review URL: http://codereview.chromium.org/437080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/455001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
method factory for the DelayedSocketDataProvider.
The problem which crashed was that the lifecycle of
the socket and the data provider are not coupled; and
the posted message for a delayed ReadCompletion could
be left hanging.
Running test on bots at night.
BUG=none
TEST=WriteError
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/453001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
server doesn't revalidate a partially stored entry, in other
words, after we issued a conditional byte range request.
BUG=27276, 28850
TEST=unittests
Review URL: http://codereview.chromium.org/434052
TBR=rvargas@google.com
Review URL: http://codereview.chromium.org/452003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33253 0039d316-1c4b-4281-b951-d872f2087c98
|