summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* Switch DCHECK() guarding against URLRequest::Read() failurerdsmith2014-09-241-1/+2
| | | | | | | | | | | in SdchDictionaryFetcher to DLOG(FATAL). BUG=416639 R=rch@chromium.org Review URL: https://codereview.chromium.org/599143002 Cr-Commit-Position: refs/heads/master@{#296465}
* Enable SDCH over HTTPS.rdsmith2014-09-242-7/+14
| | | | | | | | | BUG=357769 R=mef@chromium.org Review URL: https://codereview.chromium.org/593863002 Cr-Commit-Position: refs/heads/master@{#296451}
* Reland of "Remove void** from disk_cache interface" w/ blockfile iter fix.gavinp2014-09-2423-383/+403
| | | | | | | | | | | | | Enumeration and iteration were passing around void**. With this CL, we instead use an Iterator object. TBR=jkarlin@chromium.org,rvargas@chromium.org,clamy@chromium.org,piman@chromium.org BUG=413644,416059 TEST=None Review URL: https://codereview.chromium.org/588243002 Cr-Commit-Position: refs/heads/master@{#296415}
* Add debugging information to the SSL blocking pagefelt2014-09-245-4/+8
| | | | | | | | | | | | | | | | | | | | If you click on the SSL interstitial's error code, the following is now shown: * subject * issuer * validity end date * current date * pem encoded chain This CL adds a placeholder for debugging information to the security interstitial. It's intentionally meant to be flexible, so that it could support other debugging information in the future from other warnings. BUG=413838 Review URL: https://codereview.chromium.org/584463005 Cr-Commit-Position: refs/heads/master@{#296349}
* Use sidestep to detour CertVerifyCertificateSignatureEx on Windows versions ↵rsleevi2014-09-246-0/+373
| | | | | | | | | | | | | | earlier than Vista (excluding XP SP3), adding in SHA-256 support by deferring to NSS. The canonical path to supporting SHA-256 is to install XP SP3 or the appropriate hotfixes for XP x64 / Windows Server 2003. However, as not all users may do so, and there's enough of a usability hurdle, provide an interception hook until we fully drop support for these systems. XP is already outside of MSFT EOL (April 2014). Windows Server 2003 is EOL'd July 2015. BUG=401365 Review URL: https://codereview.chromium.org/561613002 Cr-Commit-Position: refs/heads/master@{#296335}
* Replace forward_dependent_configs with public_depsBrett Wilson2014-09-232-20/+15
| | | | | | | | | | | | This is the new name. It has the same meaning but additionally with a "you can use the headers" permission. Rename direct_dependent_configs to public_configs. This is the new name with identical meaning. TBR=jamesr Review URL: https://codereview.chromium.org/595073002 Cr-Commit-Position: refs/heads/master@{#296302}
* Cast: Allow extension to control wifi options on windowshubbe2014-09-236-87/+322
| | | | | | | | | | | | | This allows the cast extension to turn off wifi scan while streaming is in progress, and also set the "media streaming mode" further experimentation is need to see if these options are actually useful. BUG=410500 Review URL: https://codereview.chromium.org/566243005 Cr-Commit-Position: refs/heads/master@{#296253}
* Fix dictionary domain check problem.rdsmith2014-09-232-4/+74
| | | | | | | | | | | | | | Previous to this change, suffixing a "." to the URL from which a dictionary was being suggested would allow servers to bypass the check against a subdomain (e.g. evil.protected.good.com) setting a dictionary to be used by a superdomain (.good.com). BUG=389451 R=rsleevi@chromium.org Review URL: https://codereview.chromium.org/574283006 Cr-Commit-Position: refs/heads/master@{#296246}
* Handle URLRequest::Read() returning false without an error or ERR_IO_PENDING.rdsmith2014-09-232-0/+9
| | | | | | | | | | | | | | This is a possible cause for a failure being seen in the field in the associated bug; this change is a quick fix for that failure + UMA to determine if the failure is real. BUG=416639 R=mef@chromium.org R=asvitkine@chromium.org Review URL: https://codereview.chromium.org/597633002 Cr-Commit-Position: refs/heads/master@{#296241}
* net: manual HSTS addition by request of the site.Adam Langley2014-09-232-0/+6
| | | | Cr-Commit-Position: refs/heads/master@{#296237}
* DCHECK -> CHECK for UDPSocket Read/Write calls when previous in progress.vitalybuka2014-09-232-4/+4
| | | | | | | | | | | Crashes in net::AssertEventNotSignaled() are hard reproduce, but looks like this is the primary reason. With crash on CHECK(..._callback_.is_null()) we could identify incorrect code. BUG=415753 Review URL: https://codereview.chromium.org/580163003 Cr-Commit-Position: refs/heads/master@{#296234}
* net: another batch of HSTS updates.Adam Langley2014-09-232-0/+74
| | | | Cr-Commit-Position: refs/heads/master@{#296211}
* Changed URLRequest::received_response_content_length() to be a const method.sclittle2014-09-231-1/+1
| | | | | | | | BUG=416673 Review URL: https://codereview.chromium.org/592903002 Cr-Commit-Position: refs/heads/master@{#296128}
* Add data reduction functionality to all platforms.kundaji2014-09-237-66/+8
| | | | | | | | | | | | | | * Remove all #if defined guards from data reduction proxy functionality. * Hard code proxy urls in params rather than providing them in gyp files. * Add DataCompressionProxyRollout field trial to all platforms. * Pass in bypass duration into UpdateRetryInfoOnFallback rather than computing it based on SPDY_PROXY_AUTH_ORIGIN. Remove unused UMAs. BUG=384394,384397 Review URL: https://codereview.chromium.org/382313003 Cr-Commit-Position: refs/heads/master@{#296122}
* Enqueue mDns requests if send on socket in progress.vitalybuka2014-09-223-57/+128
| | | | | | | | BUG=415753 Review URL: https://codereview.chromium.org/581813004 Cr-Commit-Position: refs/heads/master@{#296094}
* Interface change for net_util.h for WebRTC IPv6 support.guoweis2014-09-224-16/+51
| | | | | | | | Migrated from https://codereview.chromium.org/538243003/ as it was created under wrong identity. Review URL: https://codereview.chromium.org/580283002 Cr-Commit-Position: refs/heads/master@{#296068}
* The non-tracking mode in AddressTracker will be used as a way to get a ↵guoweis2014-09-223-64/+200
| | | | | | | | | | snapshot of current system configuration from GetNetworkList whose current implementation doesn't provide IPv6 address attributes. BUG=411086 Review URL: https://codereview.chromium.org/571743002 Cr-Commit-Position: refs/heads/master@{#296048}
* Revert of Reland of "Remove void** from disk_cache interface." (patchset #2 ↵dcheng2014-09-2019-346/+327
| | | | | | | | | | | | | | | | | | | | | | | | | | | | id:40001 of https://codereview.chromium.org/583283002/) Reason for revert: Suspected for causing accessibility tests to flake. Original issue's description: > Reland of "Remove void** from disk_cache interface." > > Enumeration and iteration were passing around void**. With this CL, we > instead use an Iterator object. > > TBR=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org > BUG=413644 > > Committed: https://crrev.com/edbfba945a76d97383122a01529abfe3ce63d34d > Cr-Commit-Position: refs/heads/master@{#295870} TBR=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org,rvargas@chromium.org,gavinp@chromium.org NOTREECHECKS=true NOTRY=true BUG=413644 Review URL: https://codereview.chromium.org/592503002 Cr-Commit-Position: refs/heads/master@{#295887}
* Reland of "Remove void** from disk_cache interface."gavinp2014-09-2019-327/+346
| | | | | | | | | | | | Enumeration and iteration were passing around void**. With this CL, we instead use an Iterator object. TBR=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org BUG=413644 Review URL: https://codereview.chromium.org/583283002 Cr-Commit-Position: refs/heads/master@{#295870}
* QUIC - Don't close the QUIC connection if server config update messagertenneti2014-09-201-3/+7
| | | | | | | | | | is not handled. Added a histogram to track how often this happens. R=rch@chromium.org,rjshade@chromium.org, asvitkine@chromium.org Review URL: https://codereview.chromium.org/583063002 Cr-Commit-Position: refs/heads/master@{#295824}
* Only use the platform cert in verification in SSLClientSocketOpenSSL.davidben2014-09-195-173/+170
| | | | | | | | | | | | | | | Align with SSLClientSocketNSS's behavior around the PeerCertificate object. Within the sandbox for Chromoting, the platform certificate may be unavailable while the SSL-layer certificate is. Match NSS in using the SSL-layer certificate for many operations. Also check appropriately for the platform certificate being NULL in DoVerifyCert rather than simply crashing. BUG=414315 TEST=Install Chromoting app. Connecting to another computer works. Review URL: https://codereview.chromium.org/576233002 Cr-Commit-Position: refs/heads/master@{#295764}
* Only add pdb to isolate when fastbuild!=2.John Abd-El-Malek2014-09-191-1/+1
| | | | | | | | | | BUG=414808 R=scottmg@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/589633002 Cr-Commit-Position: refs/heads/master@{#295754}
* Revert of Remove void** from disk_cache interface. (patchset #30 id:650001 ↵vasilii2014-09-1919-341/+327
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/542733002/) Reason for revert: Introduced memory leaks on linux asan http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5892: Direct leak of 80 byte(s) in 2 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x309f8d7 in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:620:5 #2 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #3 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #4 0x2e3b0bf in Run base/callback.h:401:12 #5 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #6 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #7 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #8 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #9 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #10 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #11 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #12 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #13 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #14 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Indirect leak of 64 byte(s) in 2 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x30ebaaf in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:435:5 #2 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36 #3 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11 #4 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #5 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #6 0x2e3b0bf in Run base/callback.h:401:12 #7 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #8 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #9 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #10 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #11 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #12 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #13 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #14 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #15 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #16 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Indirect leak of 36 byte(s) in 1 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x30c0696 in AllocateData net/disk_cache/blockfile/storage_block-inl.h:179:5 #2 0x30c0696 in disk_cache::StorageBlock<disk_cache::RankingsNode>::Load() net/disk_cache/blockfile/storage_block-inl.h:121 #3 0x30e6fe9 in disk_cache::Rankings::GetRanking(disk_cache::StorageBlock<disk_cache::RankingsNode>*) net/disk_cache/blockfile/rankings.cc:586:8 #4 0x30ebd5a in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:440:8 #5 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36 #6 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11 #7 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #8 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #9 0x2e3b0bf in Run base/callback.h:401:12 #10 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #11 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #12 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #13 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #14 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #15 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #16 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #17 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Original issue's description: > Remove void** from disk_cache interface. > > Enumeration and iteration were passing around void**. With this CL, we > instead use an Iterator object. > > R=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org > BUG=413644 > > Committed: https://crrev.com/732c8306d4864296511e7a3a252724b1bb34c342 > Cr-Commit-Position: refs/heads/master@{#295659} TBR=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org,rvargas@chromium.org,pasko@chromium.org,piman@chromium.org,michaeln@chromium.org,cbentzel@chromium.org,gavinp@chromium.org NOTREECHECKS=true NOTRY=true BUG=413644 Review URL: https://codereview.chromium.org/585833002 Cr-Commit-Position: refs/heads/master@{#295677}
* Remove void** from disk_cache interface.gavinp2014-09-1919-327/+341
| | | | | | | | | | | | Enumeration and iteration were passing around void**. With this CL, we instead use an Iterator object. R=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org BUG=413644 Review URL: https://codereview.chromium.org/542733002 Cr-Commit-Position: refs/heads/master@{#295659}
* Don't immediately timeout upon range request cache lock.dalecurtis2014-09-191-4/+8
| | | | | | | | | BUG=408765 TEST=back-to-back requests don't bypass the cache lock. Review URL: https://codereview.chromium.org/579393002 Cr-Commit-Position: refs/heads/master@{#295640}
* Correctly fix a bug when a QUIC session is closed during the call torch2014-09-181-1/+7
| | | | | | | | | | | | | InitializeSession. This seems to be able to happen if too much time elapses between the call to the constructor and the call to InitializeSession. This fixes the fix from https://codereview.chromium.org/560913002 BUG=399147 Review URL: https://codereview.chromium.org/579533003 Cr-Commit-Position: refs/heads/master@{#295601}
* Fix Mac GN build.brettw2014-09-181-2/+7
| | | | | | | | | | These files were being removed twice from the sources. TBR=viettrungluu Review URL: https://codereview.chromium.org/568153006 Cr-Commit-Position: refs/heads/master@{#295600}
* Persist the server config that is received via kSCUP.rtenneti2014-09-183-48/+121
| | | | | | | | R=rjshade@chromium.org, rch@chromium.org, asvitkine@chromium.org, rvargas@chromium.org Review URL: https://codereview.chromium.org/427313002 Cr-Commit-Position: refs/heads/master@{#295582}
* net: update HSTS header file for e271e606.Adam Langley2014-09-181-0/+44
| | | | | | | | I was hoping to make a change to the way that the header was generated before doing this but, as it turns out, I need to do this in order to make that change cleaner. Cr-Commit-Position: refs/heads/master@{#295513}
* Detect whether a PAC url is present on Androidxunjieli2014-09-183-13/+54
| | | | | | | | | | | This CL detects whether a PAC url is set in Android's system settings. If there is a PAC url, use that PAC url to construct a ProxyConfig. BUG=372475 Review URL: https://codereview.chromium.org/573013002 Cr-Commit-Position: refs/heads/master@{#295489}
* Display Alternate Protocol Probability Threshold in net-internals.rch2014-09-182-0/+7
| | | | | | | | Also, add a comment to SetAlternateProtocolProbabilityThreshold. Review URL: https://codereview.chromium.org/577103002 Cr-Commit-Position: refs/heads/master@{#295471}
* Fix typo in NetLogQuicAckFrameCallback where recieved packets wererch2014-09-171-1/+1
| | | | | | | | being logged as revived packets. Review URL: https://codereview.chromium.org/576283002 Cr-Commit-Position: refs/heads/master@{#295365}
* Make the net logging code more compact.bratell2014-09-173-29/+56
| | | | | | | | | | | | | | | | | | | The generation of the lookup table between errors and strings for the net log expanded to 37 KB, due to the repeated code. Rewriting the code to a loop and it shrank by roughly 75%. Total change: -32087 bytes ========================== 3 added, totalling +960 bytes across 1 sources 60 removed, totalling -1143 bytes across 1 sources 1 shrunk, for a net change of -31904 bytes (36336 bytes before, 4432 bytes after) across 1 sources BUG= R=mmenke@chromium.org Review URL: https://codereview.chromium.org/574433002 Cr-Commit-Position: refs/heads/master@{#295338}
* use base::Time constants in net module instead of using static constantsprashhir2014-09-171-3/+3
| | | | | | | | | | use base::Time constants in net module instead of using static constants in file BUG=412254 Review URL: https://codereview.chromium.org/578703003 Cr-Commit-Position: refs/heads/master@{#295292}
* Remove obsolete FRIEND statements.bnc2014-09-171-4/+0
| | | | | | | | | | | HttpNetworkTransactionSpdy*Test has been removed in https://crrev.com/17028007, making these FRIEND statements obsolete. BUG=118883 Review URL: https://codereview.chromium.org/580473002 Cr-Commit-Position: refs/heads/master@{#295271}
* QUIC - minor cleanup changes to keep code in sync with the internalrtenneti2014-09-175-3/+2
| | | | | | | | | | source - fixes to includes. R=rch@chromium.org Review URL: https://codereview.chromium.org/579643002 Cr-Commit-Position: refs/heads/master@{#295217}
* One missed #ifdef and some comments cleaned up.jri2014-09-162-13/+13
| | | | | | | | BUG=402005 Review URL: https://codereview.chromium.org/571533004 Cr-Commit-Position: refs/heads/master@{#295171}
* Move handling of invalid referrer to the network delegatejochen2014-09-166-8/+79
| | | | | | | | | | | | | | We now always abort invalid loads. According to UMA, they don't happen anymore, so this should only affect future bugs. Also, move the UMA reporting to the right thread. BUG=none R=mmenke@chromium.org,mef@chromium.org,nasko@chromium.org Review URL: https://codereview.chromium.org/572273002 Cr-Commit-Position: refs/heads/master@{#295107}
* Remove some unused proxy-related histograms.eroman2014-09-164-236/+1
| | | | | | | | | | | | | | | | These histograms are no longer being monitored, so removing them from Chromium. - Net.DhcpWpad* - Net.MTPR_* - Net.ProxyResolver* - Net.ProxyPollConfigurationTime [1] - Net.GetProxyForURL*: [1] [1] Removed from histograms.xml; the histogram is not present in the code. Review URL: https://codereview.chromium.org/573893004 Cr-Commit-Position: refs/heads/master@{#295105}
* This CL adds a NetLog observer, and uses the newly addedxunjieli2014-09-164-0/+532
| | | | | | | | | | | | | | | | NESTABLE_ASYNC APIs (https://codereview.chromium.org/536503002/) to log NetLog entries in Tracing. This CL is a part of the effort to get NetLog data into Tracing. Design Doc: https://docs.google.com/document/d/1Z2uqj59UEts5IiXX78mkdU4kd6e7kE3JUKPoDK97bVs/edit?usp=sharing BUG=399701 Review URL: https://codereview.chromium.org/468083004 Cr-Commit-Position: refs/heads/master@{#295089}
* Add SetSupportsQuic method to explicitly specify server that supports QUIC.mef2014-09-162-1/+5
| | | | | | | | | BUG=411010 TEST=build/android/test_runner.py instrumentation --test-apk=CronetSampleTest -f *Quic* Review URL: https://codereview.chromium.org/544223003 Cr-Commit-Position: refs/heads/master@{#295063}
* Log SPDY protocol specific setting IDs (alternate).bnc2014-09-161-14/+38
| | | | | | | | | | | | | | | | | This is an alternate way of achieving the same as https://crrev.com/568093002. In this version, instead of calling ToEventParametersCallback to get a callable, then passing it around, then calling it, the body of SourceEventParametersCallback is duplicated in NetLogSpdyInitializedCallback. This yields faster, simpler, more direct code, at the expense of code duplication. Only one of this CL and https://crrev.com/568093002 should be committed. BUG=413369 Review URL: https://codereview.chromium.org/567403002 Cr-Commit-Position: refs/heads/master@{#295059}
* Introduce new SPDY Version UMA histogram.bnc2014-09-163-11/+18
| | | | | | | | | | | | | | | | The Net.SpdyVersion UMA histogram directly tracks internal NextProto enum values, which change, for example, when protocols are deprecated, e.g., https://chromium.googlesource.com/chromium/src/+/13621d68bc4096987471ec698468a972af2fa1de%5E%21/#F9. This CL obsoletes Net.SpdyVersion, and introduces Net.SpdyVersion2, which uses values that are specifically generated for this purpuse, with the intent that later versions will not change or reuse them. BUG=412495 Review URL: https://codereview.chromium.org/560573002 Cr-Commit-Position: refs/heads/master@{#295053}
* Landing Recent QUIC Changes.rtenneti2014-09-1631-288/+607
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Discard all useless QUIC retransmissions instead of only the most recent useless retransmission. May reduce the chances of truncated acks. Merge internal change: 75561951 https://codereview.chromium.org/564663005/ Add a separate QUIC_CONNECTION_OVERALL_TIMED_OUT to identify overall timeouts from idle timeouts and increase the initial overall timeout from 5s to 10s. Merge internal change: 75544619 https://codereview.chromium.org/572083003/ Fix QUIC crash on ConnectionClose, protected behind renamed flag FLAGS_close_quic_connection_unfinished_streams_2 (defaulted to false). With this change we avoid trying to close the connection while driving the QUIC internal server response pipeline, as the call to SendConnectionClose now happens during PostProcessAfterData, which is only ever called after receiving new data. With a hacky client/QUIC internal server combo (sending > 100 requests, but never sending FIN/RST) I've verified that with this change we don't hit the DFATAL from the attached bug. Still not entirely sure why Chrome would trigger this, b/17402744 is open to investigate why it ever opens more than kMaxStreams. Merge internal change: 75541290 https://codereview.chromium.org/575593002/ Add a LOG(DFATAL) to a case where packets are acked before being sent. Merge internal change: 75537267 https://codereview.chromium.org/575573003/ Allow number of open QUIC streams to grow 10% beyond configured limit at the QUIC internal server before closing connection. In the following situation Chrome may open more streams than the configured limit: * opens kMaxStreams streams * sends a FIN for one of the streams, now has kMaxStreams-1 streams open * opens a new stream * FIN gets lost on way to QUIC internal server * QUIC internal server terminates connection when new stream packet arrives Rather than making Chrome keep track of when the server has acknowledged a FIN, just give 10% breathing room which should avoid this case. Merge internal change: 75393293 https://codereview.chromium.org/557363003/ client-only - Change QUIC clients to use the initial RTT estimate that they provide to the server instead of the default. Re-enabled LimitCongestionWindowAndRTT end_to_end unittest (since we have fixed lot of flaky tests). Will test chromeos valgrind. Merge internal change: 75389539 https://codereview.chromium.org/573763003/ BUG=321870 Increase flow control receive window of quic_client_bin.cc, by adding a flag that defaults to 10 Mb. Added --flow-control-window-bytes as argument. Merge internal change: 75381087 https://codereview.chromium.org/569353003/ Call QuicSentPacketManager's OnPacketSerialized or OnRetransmittedPacket right before OnPacketSent, in preparation for combining the three methods into one. Merge internal change: 75340764 https://codereview.chromium.org/566743003/ Instead of initializing QuicSession::next_stream_id_ to 3 in the construct, and then setting it to 5 in InitializeSession simply initialize it to 5 in the constructor. Merge internal change: 75335114 https://codereview.chromium.org/562793003/ Do not allow a QUIC connection to timeout if no packets have been sent or received. Protected by FLAGS_quic_timeouts_require_activity. This seems to happen on windows from time to time and causes problems there. Merge internal change: 75304108 https://codereview.chromium.org/571993002/ Minor change to QUIC's retransmission to not link old retransmissions with new ones when the version or encryption changes. Allows the least_unacked to be raised more quickly, preventing spurious acks. Merge internal change: 75290729 https://codereview.chromium.org/572703003/ Removed unnecessary static_cast and replaced it with "lu". Minor change to keep the code similar to internal code. Merge internal change: 75263809 https://codereview.chromium.org/566373003/ QUIC cleanup to remove an unused bool argument in SendOrQueuePacket and OnSerializedPacket. Merge internal change: 75208575 https://codereview.chromium.org/553583007/ R=rch@chromium.org Review URL: https://codereview.chromium.org/559373003 Cr-Commit-Position: refs/heads/master@{#295014}
* IpcNetworkManager in renderer/p2p didn't specify the right network prefix,guoweis2014-09-152-3/+3
| | | | | | | | | | | | | which prevent grouping mechanism in MergeNetworkList from working. The end result is that each Network after MergeNetworkList contains only 1 ip address. With this change, the grouping will happen correctly. WebRTC has logic to only retrieve single IP from each network for connectivity check already. This CL is a dup of https://codereview.chromium.org/536133003/ which was created under the wrong identity. BUG= Review URL: https://codereview.chromium.org/565773003 Cr-Commit-Position: refs/heads/master@{#294912}
* Remove implicit conversions from scoped_refptr to T* in netdcheng2014-09-152-25/+29
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Review URL: https://codereview.chromium.org/574513003 Cr-Commit-Position: refs/heads/master@{#294891}
* net: another batch of HSTS preloads.Adam Langley2014-09-151-0/+44
| | | | Cr-Commit-Position: refs/heads/master@{#294886}
* Plumbing for TCP FastOpen field trial.jri2014-09-153-18/+25
| | | | | | | | BUG=413370,402005 Review URL: https://codereview.chromium.org/557373002 Cr-Commit-Position: refs/heads/master@{#294829}
* Cleanup: Use base/files/file_util.h instead of base/file_util.h in [c-n]*/thestig2014-09-132-2/+2
| | | | | | | | | TBR=cpu@chromium.org,jochen@chromium.org,piman@chromium.org,rockot@chromium.org,rsleevi@chromium.org,vrk@chromium.org ,zea@chromium.org Review URL: https://codereview.chromium.org/563173002 Cr-Commit-Position: refs/heads/master@{#294712}
* Delete enumerations at Simple Cache backend deletion.gavinp2014-09-133-6/+64
| | | | | | | | | | | | The memory allocated for an enumeration should be freed when a backend is deleted. R=clamy@chromium.org,jkarlin@chromium.org BUG=410276 Review URL: https://codereview.chromium.org/533293002 Cr-Commit-Position: refs/heads/master@{#294705}