summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* Relanding Coverity fixes from http://codereview.chromium.org/159862 ↵phajdan.jr@chromium.org2009-08-067-11/+15
| | | | | | | | | | | | | excluding the broken ones. The change of GURL -> const GURL& caused some nasty crash and the change got reverted. TEST=none BUG=none Review URL: http://codereview.chromium.org/164095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22682 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting http://codereview.chromium.org/164076 for syf1984@gmail.com (aka ↵robertshield@chromium.org2009-08-063-3/+57
| | | | | | | | | | | | miletus): Make the timeout in WaitToStart() of TestServerLauncher parametrized and expose this parameter to HTTPTestServer::CreateServer() TBR=syf1984@gmail.com, tommi@chromium.org Review URL: http://codereview.chromium.org/164090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22667 0039d316-1c4b-4281-b951-d872f2087c98
* Properly handle invalid server control responses.phajdan.jr@chromium.org2009-08-062-1/+28
| | | | | | | | | | | We should immediately stop the ftp network transaction in such case. TEST=Covered by net_unittests. http://crbug.com/18546 Review URL: http://codereview.chromium.org/164067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22664 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add GYP flag to build with system libbz2.agl@chromium.org2009-08-062-2/+12
| | | | | | | | | | | | | This follows the general style of r21663, which we agreed was the way to do this. Note that, currently, one cannot build with system libbz2 on a 64-bit system since it's not part of the ia32-compat package. http://codereview.chromium.org/165016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22640 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add GYP flag to build with system zlib.agl@chromium.org2009-08-064-4/+30
| | | | | | | | | | | | | This follows the general style of r21663, which we agreed was the way to do this. Note that, currently, one cannot build with system zlib on a 64-bit system since it's missing a symlink to libz.so in /usr/lib32. http://codereview.chromium.org/164027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22638 0039d316-1c4b-4281-b951-d872f2087c98
* Disk Cache: Don't depend on the backend being enabled torvargas@google.com2009-08-064-21/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | be able to return the key of an open entry. Whenever a critical corruption is detected by the disk cache, the backend disables itself and starts failing all requests until it's able to re-create the backing store. Key's longer than 928 bytes are not stored inside the entry itself, so a file object is required to access them. The backend will reject any request for a file object after it is disabled, so a user's request for the key of an open entry will also fail. Now we keep a pointer to the related file object (if needed) so that we don't have to ask the backend for it when the user requests the current key. BUG=9952 TEST=unittest Review URL: http://codereview.chromium.org/165030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22637 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize 'processed' to 0 before passing its address to SSLRead orwtc@chromium.org2009-08-062-8/+12
| | | | | | | | | | | | | | | | | SSLWrite. Ignore errSSLClosedNoNotify for site compatibility, even though it makes us potentially vulnerable to truncation attacks. Replace the default ERR_FAILED error code with the more specific ERR_SSL_PROTOCOL_ERROR. R=avi BUG=http://crbug.com/16758 TEST=see bug 16758 for a test case. Review URL: http://codereview.chromium.org/165025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22626 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r22603, which reverts r22591. It seems that the revert doesn't help...hamaji@chromium.org2009-08-063-1517/+10
| | | | | | | | | | TEST=none BUG=none TBR=eroman Review URL: http://codereview.chromium.org/164057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22605 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r22591. It seems to be making purify fail.hamaji@chromium.org2009-08-063-10/+1517
| | | | | | | | | | | | | | r22590: http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/5026 r22591: http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/5030 TEST=none BUG=none TBR=eroman Review URL: http://codereview.chromium.org/165048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22603 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r22559.aa@chromium.org2009-08-067-16/+9
| | | | | | | | | | | | | | | | | | This caused an easily reproducible crash: 1. Start with a fresh profile 2. Navigate to google.com 3. Restart 4. Navigate to google.com 5. crash The change from pass-by-value to pass-by-ref in fav_icon_helper.* seems to be to blame, but I can't see it right off. TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on SingleThreadedProxyResolver from ↵eroman@chromium.org2009-08-063-150/+171
| | | | | | | | | | | | | | resolve_proxy_msg_helper_unittest.cc. Extracts MockAsyncProxyResolver to "mock_proxy_resolver.h". This should be the last unittest that needs cleanup post r21631. BUG=http://crbug.com/11079 Review URL: http://codereview.chromium.org/160619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22591 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the socket is deleted when ConnectJob times out.willchan@chromium.org2009-08-062-1/+48
| | | | | | | | | | | | It's benign since ClientSocketPoolBase has a scoped_ptr that will delete it anyway, but it hits a DCHECK since ConnectJob::ReleaseSocket() should return NULL when the ConnectJob encountered an error. Update TestConnectJobDelegate to call ConnectJob::ReleaseSocket() and EXPECT on its value. Replicate the ConnectJob tests for the late binding case (doesn't add any extra coverage since we're not executing ClientSocketPoolBase code, just ConnectJob, but this way I don't accidentally delete necessary tests when I delete all the old tests after switching over completely to late binding). BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/160664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22580 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an obsolete TODO comment. HostResolver has changedwtc@chromium.org2009-08-061-4/+1
| | | | | | | | | | | significantly. R=eroman BUG=none TEST=none Review URL: http://codereview.chromium.org/147165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22574 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of Coverity fixes, rather minor severity.phajdan.jr@chromium.org2009-08-067-9/+16
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/159862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
* Don't mutate |config_| after failing proxy-autodetect.eroman@chromium.org2009-08-053-5/+113
| | | | | | | | | | | | Otherwise when polling for configuration changes, we think the current configuration is different than the fetched one. This was a recent regression from r22485. BUG=http://crbug.com/18526 TEST=ProxyServiceTest.UpdateConfigAfterFailedAutodetect Review URL: http://codereview.chromium.org/160654 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22504 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle multiple control responses for RETR command.phajdan.jr@chromium.org2009-08-054-25/+54
| | | | | | | | | | | | Re-enable tests which were intermittently failing before this fix and remove debugging code used to track down the issue. TEST=Covered by net_unittests. http://crbug.com/18036 Review URL: http://codereview.chromium.org/160537 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22500 0039d316-1c4b-4281-b951-d872f2087c98
* Update a comment.ericroman@google.com2009-08-041-1/+2
| | | | | | | | | | (This change was supposed to be part of <http://codereview.chromium.org/159463> but I got confused on which client owned the CL, and ended up updating the wrong one!). TBR=darin Review URL: http://codereview.chromium.org/160567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22432 0039d316-1c4b-4281-b951-d872f2087c98
* Better match IE's proxy settings.ericroman@google.com2009-08-0421-290/+1408
| | | | | | | | | | | | | | | | * When BOTH autodetect and custom PAC script are given, try both. * Use successful PAC parsing as the heuristic for determining when a script is valid (rather than first-request). * Only apply the proxy bypass list when using non-PAC. The high level explanation on how this works: http://sites.google.com/a/chromium.org/dev/developers/design-documents/proxy-settings-fallback BUG= http://crbug.com/18271, http://crbug.com/9985 TEST=unit tests. Review URL: http://codereview.chromium.org/160510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22430 0039d316-1c4b-4281-b951-d872f2087c98
* Split out HttpUtil::SpecForRequest() into a more generic function of net_util.h.eroman@chromium.org2009-08-046-21/+94
| | | | | | | | | | This was a TODO, since that function is useful outside of HTTP. In the process, I uncovered some test cases in proxy_service that are passing in invalid URLs (by virtue of the extra DCHECK). This doesn't make much sense to me to support that, so I have changed them. Review URL: http://codereview.chromium.org/160558 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22359 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in ClientSocketPoolBaseTest. Don't create ConnectJobFactory unless ↵willchan@chromium.org2009-08-041-6/+5
| | | | | | | | needed. Review URL: http://codereview.chromium.org/159831 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22349 0039d316-1c4b-4281-b951-d872f2087c98
* Followup after http://codereview.chromium.org/149368phajdan.jr@chromium.org2009-08-034-41/+34
| | | | | | | | | | | Fix minor issues in new ftp code. TEST=none BUG=none Review URL: http://codereview.chromium.org/160541 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22347 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bug number referenced by some TODOs, to point at the new bug for ↵eroman@chromium.org2009-08-033-5/+5
| | | | | | | | | | tracking it. BUG=http://crbug.com/18373 Review URL: http://codereview.chromium.org/160552 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22340 0039d316-1c4b-4281-b951-d872f2087c98
* Add timeouts for ConnectJobs. Limit ConnectJobs per group to number of ↵willchan@chromium.org2009-08-035-18/+161
| | | | | | | | | | Requests per group + 1. In the histograms for Net.SocketRequestTime, late binding has a much longer tail. This is presumably because I didn't implement timeouts and CancelRequest() never cancelled jobs. I'm limiting TCPConnectJobs to 60 seconds and cancelling jobs if there are too many more than there are requests. Review URL: http://codereview.chromium.org/160499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22338 0039d316-1c4b-4281-b951-d872f2087c98
* Add timeouts for ConnectJobs. Limit ConnectJobs per group to number of ↵willchan@chromium.org2009-08-035-154/+18
| | | | | | | | | | Requests per group + 1. In the histograms for Net.SocketRequestTime, late binding has a much longer tail. This is presumably because I didn't implement timeouts and CancelRequest() never cancelled jobs. I'm limiting TCPConnectJobs to 30 seconds and cancelling jobs if there are too many more than there are requests. Review URL: http://codereview.chromium.org/160499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22330 0039d316-1c4b-4281-b951-d872f2087c98
* Support user-constructed conditional requests to HttpCache updating the cache.ericroman@google.com2009-08-032-50/+425
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are requests where conditionalization is specified through |extra_headers| rather than through a load flag (LOAD_VALIDATE_CACHE). The previous behavior was that such requests would disable caching. So any more up-to-date response discovered by an "if-modifed-since" request was never written back to the cache. BUG=http://crbug.com/16199 TEST=HttpCache unit tes Overview for how these requests are dealt with: (1) When starting the request, check for an "if-modified-since" or "if-none-match" request header. If one is found: * let it be called |external_validation_header| * continue to (2). (2) Parse |external_validation_header| to obtain either an |etag| or a |last_modified_date|. (3) Read the HTTP cache entry for URL. Call the result |entry|. (4) Now that we have read the cache entry, check if |external_validation_header| defines a validation request for |entry|. We cannot assume that |external_validation_header| makes sense in the context of |entry|, since the headers are free-form text originating from WebCore, and could be unrelated to the cache entry. If any of the following are true, then |external_validation_header| does NOT define a validation request for |entry|: * |entry| is undefined (was not found in step (3)). * |entry| has no "etag" or "last-modified" headers. * |entry| has a "last-modified" header, but it is not equal to |external_validation_header|'s |last_modified_date|. * |entry| has an "etag" header, but it does not match |external_validation_header|'s |etag|. Let |is_validation_request| be the result of this test. If |is_validation_request|, then we can safely use the response from the subsequent network response to update |entry|. If |!is_validation_request|, then we disable caching before proceeding on to the network request. NOTE: we turned off writing back to cache in this case, since a 304 response received from the server doesn't tell us anything about our cache entry. And moreover trying to handle a non-304 response would be awkward to deal with since the transaction would have to enter a "maybe will write to cache" state. (5) Start the network transaction. (6) On completion of the network transaction: if we are doing an internal OR an external validation request: if |http_code == 304| update |entry|'s response headers with the new response headers. if it was externally conditionalized: return the received response (304) to the user else if it was internally conditionalized: return the cached response (200) to the user Review URL: http://codereview.chromium.org/159463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22328 0039d316-1c4b-4281-b951-d872f2087c98
* Add timeouts for ConnectJobs. Limit ConnectJobs per group to number of ↵willchan@chromium.org2009-08-035-18/+154
| | | | | | | | | | Requests per group + 1. In the histograms for Net.SocketRequestTime, late binding has a much longer tail. This is presumably because I didn't implement timeouts and CancelRequest() never cancelled jobs. I'm limiting TCPConnectJobs to 30 seconds and cancelling jobs if there are too many more than there are requests. Review URL: http://codereview.chromium.org/160499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22326 0039d316-1c4b-4281-b951-d872f2087c98
* Move test_file_util out of libbase. Test code should not be mixed with ↵phajdan.jr@chromium.org2009-08-031-2/+3
| | | | | | | | | | | | | | | production code. Rename previous test_support_base to test_support_perf. I couldn't just add things to test_support_base because one file there defined main, and it would produce link conflict for new users of test_support_base. TEST=none http://crbug.com/18101 Review URL: http://codereview.chromium.org/159791 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22291 0039d316-1c4b-4281-b951-d872f2087c98
* add application/ogg mime typefbarchard@chromium.org2009-08-031-0/+1
| | | | | | | | | BUG=18000 TEST=unknown which websites this affects. ask andrew who reported the bug. Review URL: http://codereview.chromium.org/159683 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22275 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ProxyResolverV8::JSBindings --> ProxyResolverJSBindings.eroman@chromium.org2009-08-029-242/+289
| | | | | | | | | (Since it isn't really V8-specific, and could be re-used for impelmentations using a different JS engine). Review URL: http://codereview.chromium.org/159773 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22256 0039d316-1c4b-4281-b951-d872f2087c98
* Modify a temporary hack to be more inclusive.ericroman@google.com2009-08-011-0/+9
| | | | | | | | | | | This papers over a race resulting from the original hack (which itself masks a real problem). I am trying to find the real culprit (so this temp hack can be decomissioned) as part of <http://codereview.chromium.org/160447>. BUG=http://crbug.com/16972 Review URL: http://codereview.chromium.org/160478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22246 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Open the disk cache experiment for new users.rvargas@google.com2009-08-013-9/+25
| | | | | | | | | | | | Also, fix the code that makes the unit tests have consistent results. BUG=none TEST=none Review URL: http://codereview.chromium.org/160485 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22238 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a hang if directory listing size is > 8K, for example,wtc@chromium.org2009-07-312-14/+9
| | | | | | | | | | | | | | | | | | | | | | | | | ftp://ftp.mozilla.org/pub/addons/ The problem is that data was spooling on network stack and after 8K data TCP Window size becomes small and no more data is received after 8K. The fix is to change the ERROR_CLASS_INITIATED case in the ProcessResponseLIST function to not go back to the STATE_CTRL_READ state. In URLRequestNewFtpJob::ProcessFtpDir. construct the std::string from buf->data() and its length so that buf->data() doesn't need to be null-terminated. Author: Ibrar Ahmed <ibrar.ahmad@gmail.com> Original review: http://codereview.chromium.org/146137 R=wtc,phajdan.jr BUG=http://crbug.com/4965 TEST=ftp://ftp.mozilla.org/pub/addons/ Review URL: http://codereview.chromium.org/159663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22217 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FTP tests failing intermittently on Mac.phajdan.jr@chromium.org2009-07-311-2/+4
| | | | | | | | | | | The root cause is a bug in the code. I'm working on a fix. TEST=none http://crbug.com/18036 Review URL: http://codereview.chromium.org/160484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22208 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate OCSP handlers in SSLClientSocketNSS.ukai@chromium.org2009-07-311-1/+6
| | | | | | | | | | | It depends on http://codereview.chromium.org/126046 BUG=none TEST=none Review URL: http://codereview.chromium.org/155912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22147 0039d316-1c4b-4281-b951-d872f2087c98
* Add temporary debugging code to diagnose intermittent net_unittests crashes ↵phajdan.jr@chromium.org2009-07-302-0/+18
| | | | | | | | | | | | | on Mac. I can't reproduce locally, but the code should give enough info after one crash. TEST=none http://crbug.com/18036 Review URL: http://codereview.chromium.org/160421 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22119 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use an assignment as a truth value.wtc@chromium.org2009-07-301-4/+3
| | | | | | | | | | | Original review: http://codereview.chromium.org/159653 R=darin,pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/160419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22106 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 307 redirects of a POST request to actually send the body again, and add adarin@chromium.org2009-07-305-5/+4
| | | | | | | | | | | | | | | test. Note: the fix is trivial, but adding support for a test required teaching the FileHandler of testserver to consume a post body. BUG=16832 TEST=covered by unit test R=abarth Review URL: http://codereview.chromium.org/149710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22100 0039d316-1c4b-4281-b951-d872f2087c98
* gcc >= 4.3 fixesmdm@chromium.org2009-07-301-1/+1
| | | | | | | | | | Patch from joel.stan@gmail.com: http://codereview.chromium.org/160377 BUG=none TEST=none Review URL: http://codereview.chromium.org/159648 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22085 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized memory read in FtpNetworkTransaction.phajdan.jr@chromium.org2009-07-301-2/+0
| | | | | | | | | | The comment is inaccurate anyway. Landing a subset of Ibrar's patch. TBR=wtc Review URL: http://codereview.chromium.org/159652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22082 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Remove remaining uses of RankingsNode.pointer.rvargas@google.com2009-07-3011-47/+118
| | | | | | | | | | | | | We now have a map of open entries so we don't need to do a lookup through the rankings node anymore. This simplifies the 64 bit version of the code. BUG=17881 TEST=unittests Review URL: http://codereview.chromium.org/159643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22074 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable half of new ftp unit tests in url_request_unittest.cc.phajdan.jr@chromium.org2009-07-301-32/+23
| | | | | | | | | | | | This change might introduce flakiness and test hangs, but we have infrastructure in place to quickly detect it. TEST=none http://crbug.com/18036 Review URL: http://codereview.chromium.org/159614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22069 0039d316-1c4b-4281-b951-d872f2087c98
* Add plumbing for allowing the renderer to intercept and cancel redirects beforedarin@chromium.org2009-07-308-32/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | they are sent. A good portion of this CL is to support the new UI test. The IPC to notify the renderer of a redirect now includes a ResponseInfo struct allowing WebURLLoaderImpl to provide detailed response info (including response headers) to WebKit. This isn't strictly necessary, but I thought I'd include this to make the code more future proof. A cross origin restriction is added to SyncResourceHandler::OnRequestRedirected that mimics the code in WebCore/platform/network/cf/ResourceHandleCFNet.cpp. This is most unfortunate, and I filed a bug at bugs.webkit.org about the similar duplication of logic in WebCore. There seemed to be enough code paths leading to request cancellation at the ResourceDispatcher level that I couldn't easily ensure that a request only gets cancelled once. So, I added an is_cancelled flag to record if it is not necessary to send a ViewHostMsg_CancelRequest IPC. This avoids some warnings in the ResourceDispatcherHost. To support my UI test, I needed to change URLRequestMockHttpJob to know how to serve redirects. I moved URLRequestHttpJob::IsRedirectResponse to its base class, URLRequestJob so that the implementation could be shared. This revealed a minor bug in URLRequest. We were never resetting response_info_ upon following a redirect. I added this code consolidated similar code from URLRequest::Redirect and URLRequest::RestartWithJob into a new PrepareToRestart method. To support my UI test, I added a "hit count" field to URLRequestFilter, and I added an associated automation IPC to query the value. The test was a bit challenging to write because there is no way to tell the difference from JS. Before and after, it appears to JS as though the cross-origin redirect failed. However, the server can see the extra redirect request. So, I simply record the number of hits against URLs of the form http://mock.http/foo, and use that to observe if any extra requests were made. I implemented the new IPC message by extending the AutomationResourceMessageFilter. This allowed me to trap the IPC message on the IO thread where it is safe to probe the URLRequestFilter. I then changed the implementation of AutomationMsg_SetFilteredInet to work similarly. I revised URLRequestMockHTTPJob::GetOnDiskPath to support ports. This actually allowed me to reuse URLRequestMockHTTPJob to service URLs in different security origins. My test redirects from http://mock.http/ to http://mock.http:4000/. Please see the comments in cross-origin-redirect-blocked.html for details about how the test functions. R=brettw,wtc BUG=16413 TEST=covered by resource_dispatcher_host_uitest.cc Review URL: http://codereview.chromium.org/159370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22067 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in client_socket_pool_base.cc.phajdan.jr@chromium.org2009-07-293-6/+75
| | | | | | | | | | | | | | | The CHECK that was being hit showed a real problem: group's IsEmpty should take into account the pending requests queue too. I also made IsEmpty check for connecting requests queue emptiness, so we can be sure that IsEmpty really means empty. TEST=Added a regression test ClientSocketPoolBaseTest.GroupWithPendingRequestsIsNotEmpty to net_unittests. http://crbug.com/17985 Review URL: http://codereview.chromium.org/159597 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21988 0039d316-1c4b-4281-b951-d872f2087c98
* If a write is pending, just add it to the buffer. Don't trigger a second ↵avi@chromium.org2009-07-291-0/+11
| | | | | | | | | | | concurrent write. BUG=http://crbug.com/17991 TEST=as in bug Review URL: http://codereview.chromium.org/160333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21981 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: dump the transaction and active entry keyrvargas@google.com2009-07-291-2/+11
| | | | | | | | | | | to check that they are not the same. BUG=9952 TEST=none Review URL: http://codereview.chromium.org/159594 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21974 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: revert dumping the transaction key.rvargas@google.com2009-07-291-9/+2
| | | | | | | | | | TBR=darin TEST=none BUG=9952 Review URL: http://codereview.chromium.org/159591 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21967 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: dump the transaction and active entry keyrvargas@google.com2009-07-291-2/+9
| | | | | | | | | | | | to check that they are not the same. BUG=9952 TEST=none Review URL: http://codereview.chromium.org/159563 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21964 0039d316-1c4b-4281-b951-d872f2087c98
* Make IsIDNComponentSafe in net/base/net_util.cc thread-safe with a lock. jshin@chromium.org2009-07-291-36/+41
| | | | | | | | | | | | | | | DCHECK is fired in the IDN safety check-code (IsIDNCOmponentSafe). It turned out that FormatURL (that leads to IsIDNComponentSafe) is called from both the UI thread and the history thread. BUG=NONE TEST=Build a debug build. Put multiple langauges to the Accept-Language list (Options | Advanced | Fonts&Language button | Languages tab). Browse to a few IDN sites and try to type a website url in the omnibox. Review URL: http://codereview.chromium.org/159213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21963 0039d316-1c4b-4281-b951-d872f2087c98
* Followup after socket tests refactoring http://codereview.chromium.org/155925phajdan.jr@chromium.org2009-07-294-100/+110
| | | | | | | | | | | | | - more complete checks for data validity - private data member with getter instead of public data member, eh - replace some magic numbers with more readable constants TEST=none http://crbug.com/17445 Review URL: http://codereview.chromium.org/159514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21957 0039d316-1c4b-4281-b951-d872f2087c98
* Store the url into a stack variable for the CHECK when connection_group.empty().willchan@chromium.org2009-07-291-3/+11
| | | | | | | | BUG=http://crbug.com/15374. Review URL: http://codereview.chromium.org/160315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21942 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 11:17:44 +0000