summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* TBR: reverting broken commiterikchen@google.com2010-07-129-263/+47
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52113 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate some network classes as non-threadsafe.eroman@chromium.org2010-07-125-5/+13
| | | | | | | | | | This is a defensive change to catch attempts to delete them on a different thread than where they were created (when in Debug mode). Although most classes in net are not thread safe and could be annotated, I chose to annotate these specific ones since they are frequently the top-level objects held by embedders. Review URL: http://codereview.chromium.org/1812007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52111 0039d316-1c4b-4281-b951-d872f2087c98
* Make the various SocketParams reference counted.vandebo@chromium.org2010-07-1220-341/+357
| | | | | | | | | | | This is so that the SSLSocketParam can hold one of any of the existing SocketParams. BUG=30357 TEST=existing unit tests Review URL: http://codereview.chromium.org/2848029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52107 0039d316-1c4b-4281-b951-d872f2087c98
* Streams send a Rst frame upon being closed by client. Some minor editorial ↵erikchen@google.com2010-07-129-47/+263
| | | | | | | | | | | | | fixes. TEST=net_unittests BUG=46589 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51007 Review URL: http://codereview.chromium.org/2804008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52106 0039d316-1c4b-4281-b951-d872f2087c98
* Put HttpProxyClientSocket into a pool.vandebo@chromium.org2010-07-1221-270/+1105
| | | | | | | | | | | | | | | This CL requires http://codereview.chromium.org/2799036 - Cleanup the HttpProxyClientSocket interface a touch. - Make HttpAuthController reference counted. - Enable ClientSocketPool to return recoverable connections. BUG=42795 TEST=existing unit tests Review URL: http://codereview.chromium.org/2817033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52104 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in the unit test. The MockPending jobs actuallymbelshe@chromium.org2010-07-122-4/+8
| | | | | | | | | | | | | induce a slight delay between the time the connect is called and when the posted task can complete. We weren't waiting for the 2ms to elapse before expecting that it had completed. BUG=47836 TEST=self Review URL: http://codereview.chromium.org/2893010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52101 0039d316-1c4b-4281-b951-d872f2087c98
* Implement HttpProxyClientSocket: Http proxie setup is now done in it's own ↵vandebo@chromium.org2010-07-1211-284/+780
| | | | | | | | | | | class (refactor). BUG=42795 TEST=existing unit tests Review URL: http://codereview.chromium.org/2799036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52100 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb SSL connection information into the PageInfo model.agl@chromium.org2010-07-127-3/+72
| | | | | | | | | | | | | | | | | This plumbs two bits of information into the PageInfo model (the dialog which results from clicking on the padlock icon): whether or not we performed SSLv3 fallback and whether or not the server supported the renegotiation extension. It doesn't actually do anything with this information yet (except to add histograms of them), pending future CLs. BUG=none TEST=none http://codereview.chromium.org/2943001/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52079 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix flakey test.mbelshe@chromium.org2010-07-111-3/+8
| | | | | | | | | BUG=43919 TEST=N/A Review URL: http://codereview.chromium.org/2908006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52066 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 51081:mbelshe@chromium.org2010-07-114-307/+387
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is relandable now because we fixed a problem with the backup sockets, which was the real reason for initially reverting. We basically don't do late socket binding when a connect has already been started for a request, even if another socket frees up earlier. The reassignment logic was quite complicated, so I reworked it. Fixing this bug was easy by changing the way FindTopStalledGroup worked, but because that function is called in that loop, changing this case caused the loop to go infinitely in some cases. This led me to look into unwinding the loop. The problem really came down to ReleaseSocket/DoReleaseSocket. Because we allow for a pending queue of released sockets, we had to do this looping (which has been a source of bugs before). To fix, I eliminated the pending_releases queue. I also reworked the routes through OnAvailableSocketSlot to unify them and always run asynchronously. The result is that now we no longer have the loop. So when one socket is released, we hand out exactly one socket. Note also that this logic slightly changes the priority of how we recycle sockets. Previously, we always consulted the TopStalledGroup. The TopStalledGroup is really only interesting in the case where we're at our max global socket limit, which is rarely the case. In the new logic, when a socket is released, first priority goes to any pending socket in the same group, regardless of that group's priority. The reason is why close a socket we already have open? Previously, if the released socket's group was not the highest priority group, the socket would be marked idle, then closed (to make space for a socket to the TopStalledGroup), and finally a new socket created. I believe the new algorithm, while not perfectly matching the priorities, is more efficient (less churn on sockets), and also is more graceful to the common case. Finally OnAvailableSocketSlot does two things. First, it tries to "give" the now available slot to a particular group, which is dependent on how OnAvailableSocketSlot was called. If we're currently stalled on max sockets, it will also check (after giving the socket out) to see if we can somehow free something up to satisfy a stalled group. If that second step fails for whatever reason, we don't loop. In theory, this could mean that we go under the socket max and didn't dish out some sockets right away. To make sure that multiple stalled groups can get unblocked, we'll record the number of stalled groups, and once in this mode, OnAvailableSocketSlot will keep checking for stalled groups until the count finally drops to zero. BUG=47375 TEST=DelayedSocketBindingWaitingForConnect,CancelStalledSocketAtSocketLimit Review URL: http://codereview.chromium.org/2938006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52050 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in backup socket cleanup where when we call RemoveConnectJob,mbelshe@chromium.org2010-07-102-11/+56
| | | | | | | | | | | | | | | | | we didn't necessarily cleanup the pending backup socket task. In addition to this, make the OnBackupSocketTimerFired more robust - in the case that this ever should happen, it will simply fallout rather than triggering a CRASH (and burn). Test case included. BUG=47375 TEST=ClientSocketPoolBaseTest.BackupSocketCancelAtMaxSockets Review URL: http://codereview.chromium.org/2942006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52049 0039d316-1c4b-4281-b951-d872f2087c98
* Change the default number of proxy resolver threads used for evaluating PAC ↵eroman@chromium.org2010-07-102-4/+25
| | | | | | | | | | | scripts from 1 to 4. Also adds a command line flag to override the default: --num-pac-threads=X BUG=11079 Review URL: http://codereview.chromium.org/2893005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52046 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix using pointer to freed string in OCSPTrySendAndReceive.mattm@chromium.org2010-07-101-7/+7
| | | | | | | | | | CID=11514 TEST=builds BUG=none Review URL: http://codereview.chromium.org/2941002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52027 0039d316-1c4b-4281-b951-d872f2087c98
* Add back a flag to disable Alternate-Protocol processing.willchan@chromium.org2010-07-101-2/+8
| | | | | | | | Specifically, provide a no-alt-protocols option to the --use-spdy flag. Review URL: http://codereview.chromium.org/2896003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52022 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that URLRequestJob holds a reference to the read IOBuffer rather ↵eroman@chromium.org2010-07-094-9/+7
| | | | | | | | | | | than just a raw pointer. Addresses a crash where consumer was passing in a "throw-away" buffer that it didn't hold a reference to. BUG=46055 Review URL: http://codereview.chromium.org/2908004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52019 0039d316-1c4b-4281-b951-d872f2087c98
* Client attempts to start a new spdy transaction with a session that is ↵erikchen@google.com2010-07-097-21/+119
| | | | | | | | | | | closing down. TEST=net_unittests BUG=47455,48503 Review URL: http://codereview.chromium.org/2841029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52001 0039d316-1c4b-4281-b951-d872f2087c98
* Add a run_testserver executable to make it easy to run the testserverdarin@chromium.org2010-07-092-0/+84
| | | | | | | | | | | | | | | | | standalone. Example: $ testserver --doc-root=net/data/url_request_unittest --http Also supports --https and --ftp. R=eroman BUG=none TEST=none Review URL: http://codereview.chromium.org/2901006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51993 0039d316-1c4b-4281-b951-d872f2087c98
* Mark differences in the hex dumpsmlloyd@chromium.org2010-07-091-18/+46
| | | | | | | | | BUG=None TEST=net_unittests pass Review URL: http://codereview.chromium.org/2936002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51989 0039d316-1c4b-4281-b951-d872f2087c98
* KDE treats all host patterns as wildcard patternsdavidben@chromium.org2010-07-095-9/+65
| | | | | | | | | | | | | | Also correct a test description that became inaccurate when we supported a reversed bypass list, and remove spaces from host rules earlier. (KDE actually treats both comma and space as valid delimiters anyway.) R=wtc,eroman BUG=48486 TEST=ProxyConfigServiceLinuxTest.KDEConfigParser Review URL: http://codereview.chromium.org/2848041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51971 0039d316-1c4b-4281-b951-d872f2087c98
* Change a FAILS_ to DISABLED_, since FAILS_ doesnt help when the test crashes.eroman@chromium.org2010-07-091-1/+1
| | | | | | | | TBR=cbentzel BUG=48588 Review URL: http://codereview.chromium.org/2909004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51930 0039d316-1c4b-4281-b951-d872f2087c98
* Add the capability to run multiple proxy PAC scripts in parallel.eroman@chromium.org2010-07-0920-594/+1196
| | | | | | | | | | | | | Refactors SingleThreadedProxyResolver into MultiThreadedProxyResolver. New threads are created lazily on demand, up to a fixed maximum. Note that this CL does NOT change the policy in Chrome -- it will continue to use a single thread for proxy resolving, but using the new code to do so. BUG=11079 Review URL: http://codereview.chromium.org/2822043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51924 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up .grds, step 1: Alphabetize.pkasting@chromium.org2010-07-081-1/+1
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51906 0039d316-1c4b-4281-b951-d872f2087c98
* CorrupFrameSessionError Fails.cbentzel@chromium.org2010-07-081-1/+2
| | | | | | | | | BUG=48588 TEST=None Review URL: http://codereview.chromium.org/2955001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51900 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51887 - Disable SpdyNetworkTransactionTest.CorruptFrameSessionError ↵eroman@chromium.org2010-07-081-2/+1
| | | | | | | | | | | | | which is failing on vista modules bot BUG=48588 TBR=willchan Review URL: http://codereview.chromium.org/2950001 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/2933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51897 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51877, since SpdyNetworkTransactionTest.CorruptFrameSessionError ↵eroman@chromium.org2010-07-0820-1192/+594
| | | | | | | | | | | | | | | | | | | | | | | | started failing after this check-in (but only on vista modules builder). BUG=48588 Original CL description: Add the capability to run multiple proxy PAC scripts in parallel. Refactors SingleThreadedProxyResolver into MultiThreadedProxyResolver. New threads are created lazily on demand, up to a fixed maximum. Note that this CL does NOT change the policy in Chrome -- it will continue to use a single thread for proxy resolving, but using the new code to do so. BUG=11079 Review URL: http://codereview.chromium.org/2822043 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/2945004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51893 0039d316-1c4b-4281-b951-d872f2087c98
* Adds tests for the SpdyFramer.Create* frame creation methods.mlloyd@chromium.org2010-07-086-22/+576
| | | | | | | | | | | | | Also tightens up and fixes some of the DCHECKs in the frame creation logic to address issues discovered while writing the tests. BUG=None TEST=net_unittests pass Review URL: http://codereview.chromium.org/2834046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51888 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SpdyNetworkTransactionTest.CorruptFrameSessionError which is failing ↵eroman@chromium.org2010-07-081-1/+2
| | | | | | | | | | on vista modules bot BUG=48588 TBR=willchan Review URL: http://codereview.chromium.org/2950001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51887 0039d316-1c4b-4281-b951-d872f2087c98
* Add the capability to run multiple proxy PAC scripts in parallel.eroman@chromium.org2010-07-0820-594/+1192
| | | | | | | | | | | | | Refactors SingleThreadedProxyResolver into MultiThreadedProxyResolver. New threads are created lazily on demand, up to a fixed maximum. Note that this CL does NOT change the policy in Chrome -- it will continue to use a single thread for proxy resolving, but using the new code to do so. BUG=11079 Review URL: http://codereview.chromium.org/2822043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51877 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51858 - Disk cache: Switch the disk cache to use the cache_thread. rvargas@google.com2010-07-0819-1482/+225
| | | | | | | | | | | | | | | | Add an InFlightBackendIO class that handles posting of cacheoperations back and forth between the IO thread and the cachethread. BUG=26730 TEST=unit tests Review URL: http://codereview.chromium.org/2827043 TBR=rvargas@google.com Review URL: http://codereview.chromium.org/2944002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51874 0039d316-1c4b-4281-b951-d872f2087c98
* Mark two tests flaky.evan@chromium.org2010-07-081-1/+3
| | | | | | | | | | | They triy to use a timeout to reduce flakiness, but that only makes them fail less often; they are still not completely reliable. BUG=48562 Review URL: http://codereview.chromium.org/2901003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51867 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: change order of commands to improve compatibilityphajdan.jr@chromium.org2010-07-083-199/+51
| | | | | | | | | | | | | | | | It turns out some FTP servers react strangely to a RETR for an unexistent file. They send a success reponse followed by a failure response. The solution is to move the file/directory sniffing logic from RETR earlier, to SIZE. BUG=44582 TEST=net_unittests Review URL: http://codereview.chromium.org/2813044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51866 0039d316-1c4b-4281-b951-d872f2087c98
* net/third_party/nss: sync patches/ directory.agl@chromium.org2010-07-083-1/+129
| | | | | | | | | | | * Add a patch for r50960 (Cache the peer's intermediate CA certificates...) No code changes. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51859 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Switch the disk cache to use the cache_thread. rvargas@google.com2010-07-0819-225/+1482
| | | | | | | | | | | | | Add an InFlightBackendIO class that handles posting of cacheoperations back and forth between the IO thread and the cachethread. BUG=26730 TEST=unit tests Review URL: http://codereview.chromium.org/2827043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51858 0039d316-1c4b-4281-b951-d872f2087c98
* net: add jottit.com to the STS preloaded list.agl@chromium.org2010-07-081-9/+9
| | | | | | | | | | | (At the request of Aaron Swartz) BUG=none TEST=Go to http://jottit.com and note that the URL is rewritten to https://jottit.com http://codereview.chromium.org/2867049/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51841 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add SetEnv() to EnvVarGetter class and get rid of the some ifdefs.tfarina@chromium.org2010-07-081-0/+3
| | | | | | | | | | | (Note: This was a TODO) BUG=None TEST=included Review URL: http://codereview.chromium.org/2843048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51840 0039d316-1c4b-4281-b951-d872f2087c98
* Update a comment to be more verbose and explain more cases.eroman@chromium.org2010-07-081-10/+39
| | | | | | | | | | Also removes a TODO which is no longer relevant. BUG=NONE Review URL: http://codereview.chromium.org/2895001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51833 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect style for CL http://codereview.chromium.org/2718011/showrdsmith@google.com2010-07-072-19/+21
| | | | | | | | | | | identified by Darin after commit. BUG=none TEST=net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.* Review URL: http://codereview.chromium.org/2844043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51768 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug in DeleteAllForURL; deletes entire store instead of justrdsmith@google.com2010-07-073-9/+169
| | | | | | | | | | | | | | | cookies related to URL (found by inspection.) Also changed name and semantics to more closely reflect usage of primary caller (extension data deleter), and added test for that set of semantics. BUG=none TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51544 Review URL: http://codereview.chromium.org/2857029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51766 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51081 for causing crashes -willchan@chromium.org2010-07-074-389/+309
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We basically don't do late socket binding when a connect has already been started for a request, even if another socket frees up earlier. The reassignment logic was quite complicated, so I reworked it. Fixing this bug was easy by changing the way FindTopStalledGroup worked, but because that function is called in that loop, changing this case caused the loop to go infinitely in some cases. This led me to look into unwinding the loop. The problem really came down to ReleaseSocket/DoReleaseSocket. Because we allow for a pending queue of released sockets, we had to do this looping (which has been a source of bugs before). To fix, I eliminated the pending_releases queue. I also reworked the routes through OnAvailableSocketSlot to unify them and always run asynchronously. The result is that now we no longer have the loop. So when one socket is released, we hand out exactly one socket. Note also that this logic slightly changes the priority of how we recycle sockets. Previously, we always consulted the TopStalledGroup. The TopStalledGroup is really only interesting in the case where we're at our max global socket limit, which is rarely the case. In the new logic, when a socket is released, first priority goes to any pending socket in the same group, regardless of that group's priority. The reason is why close a socket we already have open? Previously, if the released socket's group was not the highest priority group, the socket would be marked idle, then closed (to make space for a socket to the TopStalledGroup), and finally a new socket created. I believe the new algorithm, while not perfectly matching the priorities, is more efficient (less churn on sockets), and also is more graceful to the common case. Finally OnAvailableSocketSlot does two things. First, it tries to "give" the now available slot to a particular group, which is dependent on how OnAvailableSocketSlot was called. If we're currently stalled on max sockets, it will also check (after giving the socket out) to see if we can somehow free something up to satisfy a stalled group. If that second step fails for whatever reason, we don't loop. In theory, this could mean that we go under the socket max and didn't dish out some sockets right away. To make sure that multiple stalled groups can get unblocked, we'll record the number of stalled groups, and once in this mode, OnAvailableSocketSlot will keep checking for stalled groups until the count finally drops to zero. BUG=47375 TEST=DelayedSocketBindingWaitingForConnect,CancelStalledSocketAtSocketLimit Review URL: http://codereview.chromium.org/2861023 TBR=mbelshe@chromium.org BUG=48094 Review URL: http://codereview.chromium.org/2809052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51755 0039d316-1c4b-4281-b951-d872f2087c98
* Log whenever the network IP address changes.eroman@chromium.org2010-07-072-9/+19
| | | | | | | | | This logs to both LOG(INFO), and also to the NetLog (about:net-internals). BUG=46822 Review URL: http://codereview.chromium.org/2815046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51740 0039d316-1c4b-4281-b951-d872f2087c98
* Add a lock for OS X CSSM wrapper APIsdavidben@chromium.org2010-07-072-21/+40
| | | | | | | | | | | | They're apparently problematic with threads. R=agl BUG=48006 TEST=KeygenHandler.ConcurrencyTest Review URL: http://codereview.chromium.org/2832047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51734 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BackupSocketConnect unittest.cbentzel@chromium.org2010-07-071-1/+2
| | | | | | | | | BUG=43919 TEST=net_unittests Review URL: http://codereview.chromium.org/2810051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51706 0039d316-1c4b-4281-b951-d872f2087c98
* Arm build fix.pfeldman@chromium.org2010-07-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/2829046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51665 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add stub for HTTP-based remote debugger interface.pfeldman@chromium.org2010-07-061-4/+4
| | | | | | Review URL: http://codereview.chromium.org/2802032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51661 0039d316-1c4b-4281-b951-d872f2087c98
* Fix integer underflow in ParseHandshakeHeader in websocket_handshake_handler.ccukai@chromium.org2010-07-063-9/+44
| | | | | | | | | BUG=48330 TEST=WebSocketHandshakeResponseHandlerTest.BadResponse and BadResponse2 don't crash and passes Review URL: http://codereview.chromium.org/2870047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51652 0039d316-1c4b-4281-b951-d872f2087c98
* Brushed up listen socket:pfeldman@chromium.org2010-07-0513-21/+471
| | | | | | | | | | | - Upstreamed support for partial results from devtools' version - Made DidRead receive data and length (in order to support websockets data) - Fixed all the clients. Added net/server with http socket implementation that supports websockets. Will remove net/tools fetch client and server later. Review URL: http://codereview.chromium.org/2868036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51635 0039d316-1c4b-4281-b951-d872f2087c98
* White space changes for grd revertvandebo@chromium.org2010-07-031-1/+1
| | | | | | | BUG=none TEST=green tree git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51576 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51572 - Clean up .grds, step 1: Alphabetize.pkasting@chromium.org2010-07-021-1/+1
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2838041 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/2864039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51575 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where we didn't ever start watching for network address ↵pkasting@chromium.org2010-07-021-0/+1
| | | | | | | | | | changes on Windows. BUG=48204 TEST=NetworkChangeNotifier works on Windows Review URL: http://codereview.chromium.org/2807036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51574 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up .grds, step 1: Alphabetize.pkasting@chromium.org2010-07-021-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2838041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51572 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 03:19:08 +0000