| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
subclasses must override it.
BUG=none
TEST=built chrome and net_unittests
Review URL: http://codereview.chromium.org/6639007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They were reverted due to flaky tests, especially on valgrind. Basically, we kept hitting the backup socket timer (500ms) which would create another socket, which the tests don't expect, so they crash. I disabled the backup socket timer completely for the SPDY tests, because they make it too hard to handle the parallel alternate protocol jobs.
I also deleted the HTTP fallback test from SpdyNetworkTransactionTest, because it had a similar problem. Also, it was already being tested in HttpNetworkTransactionTest.
BUG=69688,75000
TEST=Try connecting to belshe.com with various proxy configurations. Should work still.
Review URL: http://codereview.chromium.org/6635047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fix from Kevin Lindsay (kelindsay@gmail.com)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6623085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=existing unit_tests
Review URL: http://codereview.chromium.org/6639002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=willchan
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/6648010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and disconnect on the same thread. Perform the CHECK
before doing any work in disconnect to catch the
error very early.
Reverting the http://codereview.chromium.org/6627058
The original bug where we added the CHECK is
http://code.google.com/p/chromium/issues/detail?id=65948
BUG=75171
TEST=Access SSL site and exit. Start Windows Chromium,
sign in to Google Cloud Print, quit Chromium,
re-launch Chromium.
R=wtc
Review URL: http://codereview.chromium.org/6647003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I did some measurements with a Release build of chrome, both manually and via the page cycler tests. It seems that a simple empty blocking event listener can add anywhere from a 1 to 30ms delay to request times, largely depending on how many requests are in the queue (when many requests come at once, the last ones to be processed by the extension are delayed the longest).
From page cycler data (on my local machine), the average increase in page load time seems to be around 6ms. This is independent of total page load time (which makes sense).
BUG=60101
TEST=covered by apitests
Review URL: http://codereview.chromium.org/6574049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch by vipul.bhasin@gmail.com.
BUG=3333
TEST=None
Review URL: http://codereview.chromium.org/6625076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This virtual method, implemented only by URLRequestJob and MockFilterContext,
was only used for testing purposes. The kFilterBufSize constant now lives
in filter.cc (the only place it was used), and for the few tests that needed
to override the buffer size, I've added a test-only method in filter.h.
The result is a smaller interface surface in URLRequestJob and simpler tests for most cases in gzip_filter_unittest.cc and sdch_filter_unittest.cc. I've done some further refactoring of the former to remove redundancy (most of Filter's complexity is exercised only in the SDCH test).
Review URL: http://codereview.chromium.org/6516025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(see error at:
http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20%28valgrind%29/builds/2279/steps/memory%20test%3A%20net/logs/stdiohttp://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20%28valgrind%29/builds/2279/steps/memory%20test%3A%20net/logs/stdio)
BUG=none
TEST=mac-valgrind is green
Review URL: http://codereview.chromium.org/6625086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Set-Cookie delimiter was a comma, but should have been a NUL.
- Requests with query strings containing 'http://' caused request url paths
to be truncated.
Fix from Kevin Lindsay (kelindsay@gmail.com)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6628084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
render because we didn't close out the SPDY stream.
Fix from Kevin Lindsay (kelindsay@gmail.com)
http://codereview.chromium.org/6597074/
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6628083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=X509CertificateNameVerifyTest.VerifyHostname, and also compiles with use_openssl=1 flag.
Review URL: http://codereview.chromium.org/6627051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Requested by: Wouter Timmermans
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome sync is dependent on other areas of chrome, and patches committed to
these areas could potentially break sync. In the past, we have seen
sync integration test failures caused by patches to net, jingle and base.
This patch adds a PRESUBMIT.py file to each of these directories, that
will result the sync integration tests being run on any code that
touches these directories as part of their try runs.
BUG=70311
TEST=modify something under base, net or jingle and do a "git try" or "gcl try"
Review URL: http://codereview.chromium.org/6624086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
being called from the same thread to fix the crash
in service process.
The original bug where we added the CHECK is http://code.google.com/p/chromium/issues/detail?id=65948
BUG=75171
TEST=service process
R=wtc
Review URL: http://codereview.chromium.org/6627058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flag in browser.
Conflicts:
chrome/browser/prerender/prerender_contents.cc
chrome/browser/prerender/prerender_manager.cc
BUG=72519, 70957
TEST=Create two html pages A and B with A containing a link rel="prefetch" to B. Enable prerender and navigate to A. Observe that the request for B and all requests from B correctly have the LOAD_PRERENDER load flag set.
Review URL: http://codereview.chromium.org/6588071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds with use_openssl=1
Review URL: http://codereview.chromium.org/6626051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically, after we get an HTTP header giving an Alternate-Protocol, we'll end up in a state where we're probably going to issue more HTTP requests. We have the already warm single HTTP connection. We probably don't have a SPDY session open. Previously, once we notice Alternate-Protocol, we'd block on trying to set up the new SPDY session, even though we still have the HTTP connection. Change this so we keep using HTTP until the SPDY session on the Alternate-Protocol becomes available, then we switch over to it.
BUG=69688,75000
TEST=Browse to belshe.com. Examine net-internals to make sure it works. Test over a variety of connections (direct / various proxy types).
Review URL: http://codereview.chromium.org/6610034
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/6621040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/6626044
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/6621039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/6626044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Basically, after we get an HTTP header giving an Alternate-Protocol, we'll end up in a state where we're probably going to issue more HTTP requests. We have the already warm single HTTP connection. We probably don't have a SPDY session open. Previously, once we notice Alternate-Protocol, we'd block on trying to set up the new SPDY session, even though we still have the HTTP connection. Change this so we keep using HTTP until the SPDY session on the Alternate-Protocol becomes available, then we switch over to it.
BUG=69688,75000
TEST=Browse to belshe.com. Examine net-internals to make sure it works. Test over a variety of connections (direct / various proxy types).
Review URL: http://codereview.chromium.org/6610034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for M11 branch point.
Add boolean to iteration history for whether item was removed from map, to verify something I saw in 11.0.690.0 crash dumps.
Remove copy of command-line as we have seen there is no correlation between command line and these crashes.
BUG=71721
TEST=net_unittests
Review URL: http://codereview.chromium.org/6624028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
result as defined. This way, we suppress benign reports from zlib (see
http://www.zlib.net/zlib_faq.html#faq36), without losing coverage of spdy code.
This patch was originally prepared by eugenis@chromium.org (doesn't have a committer
access yet) and reviewed at http://codereview.chromium.org/6591101/
TBR=wtc
Review URL: http://codereview.chromium.org/6286146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code was reverted because it caused, or exposed
flakiness in sync unit test code (mostly on the Mac).
We need to monitor that closely as we re-land.
See the reviews and history in CLs:
http://codereview.chromium.org/6577013
and
http://codereview.chromium.org/6591052
This code generates CRC checksums for the histogram
bucket-range vectors, and guarantees they remain
intact when the histogram data is about to be
uploaded to UMA. If the data is corrupted, then
we will fail on a CHECK().
r=mbelshe,rvargas
bug=73939
Review URL: http://codereview.chromium.org/6627011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42073
TEST=try to use cert manager with "unfriendly" device.
Review URL: http://codereview.chromium.org/6580058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The stats function was not written to be shared across threads, and
recent use by sync on a second thread is causing it to malfunction
(because it uses function level statics).
r=wtc
bug=74467
Review URL: http://codereview.chromium.org/6624023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
navigator.onLine and online/offline events. Only works on Windows at the moment, as IsCurrentlyOffline() is supported only by NetworkChangeNotifierWin.
Most of the changes are due to the need to support two different kinds of NetworkChangeNotifier observers. Both observers currently happen to trigger on the same event, but that could change, e.g., if we store the previous online state and only notify on a change. Thus the need for two different observer interfaces, and associated Add/Remove methods.
BUG=7469
TEST=Load https://bug336359.bugzilla.mozilla.org/attachment.cgi?id=220609, unplug network cable, reload, see that page changes to note offline status
Review URL: http://codereview.chromium.org/6526059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=carnitas
TEST=compiles
Review URL: http://codereview.chromium.org/6609008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of this, I had to move the chunked encoding part from UploadData::Element::SetChunk
to HttpStreamParser::DoSendBody as SPDY doesn't have this encoded format and UploadData
needs to serve both.
BUG=none
TEST=net_unittests (2 new tests added)
Committed and rolled back: http://src.chromium.org/viewvc/chrome?view=rev&revision=76892
Review URL: http://codereview.chromium.org/6292013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
len and fix typo.
(Comment only change. Cleanup for 76539)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6612026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 8431a6e7be70b1b50b0d5b851bbe728b7fef220f.
TBR=satish
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of this, I had to move the chunked encoding part from UploadData::Element::SetChunk
to HttpStreamParser::DoSendBody as SPDY doesn't have this encoded format and UploadData
needs to serve both.
BUG=none
TEST=net_unittests (2 new tests added)
Review URL: http://codereview.chromium.org/6292013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=there is no bug
TEST=not applicable
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ip_endpoint_unittest
Review URL: http://codereview.chromium.org/6592096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
functionality is available in release builds if explicitly
requested by using their Impl types. The default usage remains
that they do nothing in release mode.
Also, update unit tests to run in release mode, verifying that the release versions of NonThreadSafe and ThreadChecker do nothing in release builds.
BUG=none
TEST=base unit tests
Review URL: http://codereview.chromium.org/6599004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the throttling queue
BUG=54338
TEST=none
Review URL: http://codereview.chromium.org/6602073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to check if a name matches a cert without doing a full certificate verify.
Use the API provided as part of NSS. For other platforms, provide a default
implementation based on GetDNSNames.
BUG=none
TEST=X509CertificateTest.WebkitCertParsing
Review URL: http://codereview.chromium.org/6612013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many of our tests want to use Unicode literal strings with the
L"foobar" syntax. Allow us to test FilePaths against these
strings.
BUG=69467
Review URL: http://codereview.chromium.org/6606025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
does not appear to have a private key, do not include it in the list of client certificates to select when authenticating with an SSL server. If the certificate is stored on a smart card, this does not require the smart card to be inserted, only that the certificate metadata stored by Windows contains a reference to the private key.
R=wtc
BUG=66519
TEST=none
Review URL: http://codereview.chromium.org/6273017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: This patch might have resulted in some
flakiness in the sync bots on the chromium waterfall.
The range vector is calculated once when a histogram is
constructed, and should never change over the lifetime of the
histogram. When it does change, it means that memory is being
overwritten. We now crash (via CHECK) when there is any
detected corruption of the range vector.
This CL uses a more robust check-sum algorithm to detect corruption
of the vector. The previous algorithm just did a sum, and was
too easilly tricked by small (offsetting) changes in several
ranges. Hopefully, this CRC-32 implementation will not be
so easilly fooled.
I had to refactor the class to ensure that each histogram was completely
constructed before I registered it. The old code could sometimes
register a base class (tradtional Histogram, with exponential
bucket spread) and then run the derived constructor (such as
when creating a LinearHistogram, with a second construction
of the ranges and checksum). I now carefully avoid
generating the checksum until fully constructing the instance,
and then I run InitializeBuckets only once on
the instance before registering it.
bug=73939,74467
r=mbelshe
Review URL: http://codereview.chromium.org/6577013
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/6611001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: This patch might have resulted in some
flakiness in the sync bots on the chromium waterfall.
CL http://codereview.chromium.org/6577013/ had
a few changes suggested that were not incorporated.
This CL has those name changes etc.
r=rvargas
Review URL: http://codereview.chromium.org/6591052
BUG=74467
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/6591129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=erg
Review URL: http://codereview.chromium.org/6588136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6597039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
removed in r34047, as well as supporting code in testserver.py.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6591051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This turns on style checking for reals on the bots.
Review URL: http://codereview.chromium.org/6531017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Always validate a truncated entry. Furthermore, given
that a server can say not-modified (304), followed by
200 when actually asked for the final range, now we
validate truncated entries by asking for the next byte
that we need.
- If a server refuses to serve a byte range and instead
sends the whole resource, we just cache the response as
if nothing was stored before.
- If we receive a network error while reading from the
net, we don't discard the cached entry right away. Now
we wait until the transaction is closed, and attempt to
mark the entry as truncated.
BUG=48468
TEST=net_unittests
Review URL: http://codereview.chromium.org/6588105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
entries by path
If we have two cache entries :
< 'example.com', userA, realmA, paths=[ '/' ] > and
< 'example.com', userB, realmB, paths=[ '/foo/' ] >
Then a LookupByPath() for '/foo/bar/baz' should return the cache entry for userB rather than userA.
BUG=73294
TEST=net_unittests --gtest_filter=HttpAuthCacheTest.Basic
Review URL: http://codereview.chromium.org/6596076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76516 0039d316-1c4b-4281-b951-d872f2087c98
|