| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
http://codereview.chromium.org/593089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35869
TEST=gclient runhooks --force should work for arm configurations of linux.
Review URL: http://codereview.chromium.org/600144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=This is to reduce false positive "Unable to terminate process" log entries in unit tests.
BUG=none
Review URL: http://codereview.chromium.org/600108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetFileExtensionFromPath function.
BUG=None
TEST=compiles
Patch from Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/604049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The driving rationale for this change was to prevent choosing an AuthHandler when it
is not supported on the system due to a missing runtime component (such as not being
able to locate a gssapi shared library when seeing a Negotiate scheme).
It also has the advantage (currently unused) of determining some per-auth-scheme properties
only the first time that a challenge for that scheme is seen (such as maximum token length for
the SSPI implementation of NTLM).
Finally, it may make unit tests easier to generate since the factory can be easily mocked.
BUG=34795
TEST=New unit test for HttpAuthHandlerDispatchFactory.
Review URL: http://codereview.chromium.org/582007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SSLClientSocketMac reports certificate error before SSL handshake is completed,
so just returning OK for LOAD_IGNORE_CERT_* won't work (completed_handshake_ is false yet, so we can't Read()/Write() on the socket).
Add the cert in allowed_bad_certs, and reconnect again.
BUG=35108
TEST=none
Review URL: http://codereview.chromium.org/593013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to higher parts of the network stack.
BUG=23794
TEST=Covered by net_unittest, also see the bug.
Review URL: http://codereview.chromium.org/601027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
explicit path set. This CL also ensures that we set the expiry info properly.
This means using CanonPath and CanonExpiration from cookie_monster.cc. Instead
of exposing those methods, I just expose a CanonicalCookie constructor that
takes a ParsedCookie.
R=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/597031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mozilla.
This corresponds to their patch ec019978e8dc, from 2010-02-11 13:39 +0000.
Also update instructions for updating this file.
BUG=27523
TEST=none
Review URL: http://codereview.chromium.org/600077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, if the database has multiple cookies defined for the same (host, cookie name, cookie path), we will delete all but the most recently created cookie.
This step happens right after loading the cookie database.
I don't expect this to have any real impact on startup performance, since the cookie database is small, and compared to the cost of reading the DB from disk, should be cheap.
This CL also includes two other related changes:
(1) Added a histogram "Net.NumDuplicateCookiesInDb" that measures how common the need to remove duplicates is.
(2) If the in-memory store is ever found to contain duplicates after initializion, fail hard (crash).
The effect of this change will be users that had a bad database will get it fixed, and will no longer be sending duplicate cookies to servers.
-----------------------
Background:
-----------------------
Ok, so why does the corruption happen in the first place?
From what I can tell, the problem stems from how the interface between CookieMonster and the PersistentCookieStore is defined. Notably:
* It implements overwrites as "delete" + "insert" operations.
* It doesn't define the behavior when a "delete" or "insert" operation fails.
The steps that CookieMonster() runs through to overwrite a cookie is:
(a) Find the existing cookie, |old_cookie|, in the in-memory store.
(b) Delete |old_cookie| from the in-memory store.
(c) Ask the persistent cookie backing store to delete |old_cookie| (keyed by its creation time)
(d) Insert |new_cookie| into the in-memory store.
(e) Ask the persistent backing store to insert |new_cookie|.
This ordering assumes that no failures can happen during steps (c) and (e).
However in actuality, SQLitePersistentCookieStore swallows any errors it encounters writing to the DB, and does not attempt retries.
Here is one sequence of steps that could lead to your database getting hosed:
(1) Your cookie database becomes temporarily unwritable (maybe your home directory is network mounted and your kerberose ticket just expired).
(2) The browser gets a set-cookie to overwrite an existing cookie (perhaps a ping-back from gmail, which happen often).
Clearly steps (c) and (e) will now fail, since the database is offline. So the in-memory store will get changed, but the on-disk one won't.
(3) Now your cookie database becomes writable again (maybe you renewed the ticket).
(4) Another cookie update is received. This time, the update will cause us to insert a duplicate into the cookie database.
This happens because in step (c) the on-disk database is asked to delete the previous (at least according to the in-memory store) cookie. Well, the on-disk DB never wrote that value, so this has no effect, and the actual previous value remains. Next we insert the new value, kaboom.
A next step will be to re-work the PersistentCookieStore interface so SQLitePersistentCookieStore isn't as fragile to errors while overwriting.
BUG=17855
TEST=CookieMonsterTest.DontImportDuplicateCookies
Review URL: http://codereview.chromium.org/602029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27870
TEST=none
Review URL: http://codereview.chromium.org/604022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35288
TEST=see bug
Review URL: http://codereview.chromium.org/596054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cache grab it when needed.
BUG=26729
TEST=none.
Review URL: http://codereview.chromium.org/594041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/598074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
callbacks to notify the transaction about the completion
of AddTransactionToEntry.
BUG=26729
TEST=current tests.
Review URL: http://codereview.chromium.org/593058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/596013
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chrome frame failure appears to be unrelated.
Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly.
Review URL: http://codereview.chromium.org/600040
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/596048
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/604012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=26729
TEST=unittest
Review URL: http://codereview.chromium.org/603011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
even though this should be a strictly no-op change...
Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly.
Review URL: http://codereview.chromium.org/600040
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/596048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
checking that the PersistentCookieStore interface is exercised correctly.
Review URL: http://codereview.chromium.org/600040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This should prevent slowing down Mac startup.
BUG=34926
Review URL: http://codereview.chromium.org/593039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/578026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes include:
rename FIN_STREAM to RST_STREAM
update enums
Add associated-to field to SYN_STREAM
Update SYN_STREAM APIs
Fix up unit tests.
I think these are all the on-wire compatibility changes in the spec.
More semantic changes are necessary, of course.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/599018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=start chrome and run tcpdump -A. Should be contain any referer header.
Review URL: http://codereview.chromium.org/600008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from the cache transaction destructor.
BUG=31723
TEST=unittests
Review URL: http://codereview.chromium.org/594018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change involves two significant bits:
1- Add URLRequest::Delegate methods to report a blocked attempt to set a cookie
or get cookies, respectively.
2- Generalize the mechanisms we use to proxy notifications to the RenderViewHost
from the IO thread. See render_view_host_notification_task.h.
Finally, these are used together in ResourceDispatcherHost.
Note: Additional work is required to notify when JS attempts to set a cookie
fail.
R=brettw,eroman
BUG=34573
TEST=Configure the browser to block cookies, and then visit a site that tries to
set a cookie (e.g., cnn.com). You should see a cookie icon appear in the location
bar. If you click that it should report that cookies were blocked.
Review URL: http://codereview.chromium.org/600009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the SSLClientSocketNSSFactory function there.
Put the --use-nss-for-ssl command-line switch inside ifdefs
for the platforms that need it.
Call EnsureNSPRInit on the main thread so that PR_Cleanup
will be called on the main thread.
R=mark
BUG=28744
TEST=No build errors.
Review URL: http://codereview.chromium.org/573041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This header doesn't use anything from client_socket_handle.h.
R=vandebo
BUG=none
TEST=No compilation errors.
Review URL: http://codereview.chromium.org/579015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes one memory leak and one mismatched scoped_ptr/array usage.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/591003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when they fail.
TEST=net_unittests
BUG=27567
Review URL: http://codereview.chromium.org/582020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net_resources generated from a grd file.
This should make incremental rebuilds slightly more reliable.
Intentionally fixing this in one place only, in the hope of landing things
incrementally (and actually getting a fix in!).
BUG=19866
TEST=None
Review URL: http://codereview.chromium.org/587012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is so I can determine if r38052 caused the mac startup test regression.
This will disable the Mac implementation of NetworkChangeNotifier, which was implemented in January and is used by the ClientSocketPool to flush idle sockets on a network change.
r38052 added it to the HostResolver to flush the HostCache on a network change, which required instantiating NetworkChangeNotifierMac earlier in startup.
This change will prevent the initialization of the helper thread, which will turn off network change notifications on OS X. This is a relatively new feature, so it's fine to turn this off. I'll let this change sit overnight and check on the startup graphs tomorrow.
BUG=34926
Review URL: http://codereview.chromium.org/583015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It used to be the case that when a disconnected socket is released, it would pop the front of the queue, and since it was a disconnected socket, would kick off another ConnectJob and then append the request to the back to the queue.
While doing this, I cleaned up the TYPE_SOCKET_WAITING_IN_QUEUE since it doesn't make sense. You're always waiting in a queue, unless the request gets fulfilled immediately. I've added strings to the LoadLog to distinguish this situation and also identify when the socket has been reused.
Review URL: http://codereview.chromium.org/583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've added minimal probing to check if IPv6 is at all possible, and when it is not, then we disable IPv6 resolution.
I've also added histograms and A/B test support to evaluate the impact of
this change.
(I landed originally, but had tree problems, and this is a new CL to tryto reland).
Note that I've switched back to MACRO style enums as well, per http://dev.chromium.org/developers/coding-style
(search for "enum").
This version now does the conditional testing at a higher level (in io_thread.h), so that it should interfere less with other testing.
r=wtc,eroman
Review URL: http://codereview.chromium.org/585005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Use test and valgrind suppressions from the same locations as the other valgrind bots.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/561045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30747
TEST=none
Review URL: http://codereview.chromium.org/580009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
solution but rather an initial improvement on the current page. As a method of
retrieving the platform specific icons, I am investigating the possibility of
adding an open browser standard for the implementation of a icon:// URL scheme
that would be Web accessible. See http://goo.gl/gaZE. For this patch, we simply
use 3 different icons: file, folder and parent folder. These icons are embedded
in the template using data URIs.
Patch by Pierre-Antoine LaFayette, original review: http://codereview.chromium.org/543184
BUG=24421
TEST=none
Review URL: http://codereview.chromium.org/573052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is useless
I've added minimal probing to check if IPv6 is at all possible, and when
it is not, then we disable IPv6 resolution.
I've also added histograms and A/B test support to evaluate the impact of
this change.
r=wtc,eroman
Review URL: http://codereview.chromium.org/579010
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/582011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've added minimal probing to check if IPv6 is at all possible, and when
it is not, then we disable IPv6 resolution.
I've also added histograms and A/B test support to evaluate the impact of
this change.
r=wtc,eroman
Review URL: http://codereview.chromium.org/579010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I haven't yet renamed the classes.
BUG=30747
TEST=none
Review URL: http://codereview.chromium.org/582001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
95% of this is removing "const" from return types, but turning this
on found one bug! (A "for" loop that expected its iterator to go negative but
which was using an unsigned type.)
BUG=34160
Review URL: http://codereview.chromium.org/570012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/573021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/561082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
While this doesn't entirely remove the hack, it limits the scope of it to HostResolverImpl.
Hopefully in the future HostResolver will not be refcounted so this can go away altogether.
BUG=18373
Review URL: http://codereview.chromium.org/569035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* A NULL stream was added to pushed_streams_
* FlipStream had a NULL HttpResponseInfo pointer. In non-server-push paths, this pointer references a member of the associated FlipNetworkTransaction. In this case, I just leak memory - needs a better solution.
* io_state_ was set to NONE on a server push, which DCHECK'ed in the first state machine loop. Changed it to jump to READ_HEADERS state.
BUG=NONE
TEST=Manual
Review URL: http://codereview.chromium.org/551006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently this is implemented on Windows for the NTLM and Negotiate schemes.
This CL does not introduce the hooks to actually use Single Sign On in response to a 401/407 request - that will come in a later CL.
This behavior is disabled for now as well.
BUG=29862
TEST=Ran unittests, and Chrome against a server with authentication challenges.
Review URL: http://codereview.chromium.org/555174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TSAN had reported a race on the bool |should_block_|, between BlockableProxyResolver::GetProxyForURL() and BlockableProxyResolver::Unblock().
I avoided the problem by calling WaitUntilBlocked() before Unblock(), which is the same pardigm used by the other tests.
Really, the best fix is to remove that limitation from BlockableProxyResolver... left that as a future TODO.
TBR=willchan
Review URL: http://codereview.chromium.org/561083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It looks like there is a problem with the test setup (BlockableProxyResolver tests a bool outside of a lock). I will fix that next.
TBR=willchan
Review URL: http://codereview.chromium.org/578011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
request was stalled waiting to be scheduled to a thread.
TEST=SingleThreadedProxyResolverTest.UpdatesLoadLogWithThreadWait
Review URL: http://codereview.chromium.org/570019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
session cookies.
Introduces a new CookiePolicy result code OK_FOR_SESSION_ONLY.
R=eroman
BUG=34571
TEST=none
Review URL: http://codereview.chromium.org/577013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38179 0039d316-1c4b-4281-b951-d872f2087c98
|