summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* Stop NetworkChangeNotifierMac from calling a virtual function before the ↵willchan@chromium.org2010-09-016-47/+106
| | | | | | | | | | | | | constructor finishes. NetworkChangeNotifierMac was posting a task to a separate thread in its constructor. It's possible (although highly unlikely, but happens on buildbots) for the separate thread to start up and run the task (which invokes a virtual function) before the constructor completes (and, more importantly, the subtype's constructor initializes its vtable entries which are NULL / pure virtual in the base class). The solution is to simply use a Delegate instead. The Delegate should have been fully constructed (and thus, will not have the vtable initialization race) before being passed into NetworkChangeWatcherMac's constructor. This also solves the stylistic issue of avoiding multiple inheritance, since NetworkConfigWatcherMac was not strictly an interface. BUG=53138 Review URL: http://codereview.chromium.org/3344002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58230 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests for CanDelegate on URLSecurityManager.cbentzel@chromium.org2010-09-011-1/+32
| | | | | | | | BUG=50076 TEST=net_unittests --gtest_filter="*URLSecurityManager.CanDelegate*" Review URL: http://codereview.chromium.org/3311003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58217 0039d316-1c4b-4281-b951-d872f2087c98
* Fix invalid read in HostResolverImpl::OnIPAddressChanged.willchan@chromium.org2010-09-011-1/+2
| | | | | | | | | BUG=54090 TEST=HostResolverImplTest.OnlyAbortExistingRequestsOnIPAddressChange Review URL: http://codereview.chromium.org/3348001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58209 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move more ctors/dtors from headers to implementation.erg@google.com2010-09-018-21/+65
| | | | | | | | | | | | | | | | | - Adding/Moving dtors of objects that have CancelableRequestConsumers shaves three megs off browser.a. - Adding/Moving dtors of objects that have ScopedRunnableMethodFactories only shaved 100k off browser.a/renderer.a. - Adding/Moving dtors of objects that used some form of base::*Timer<> was negligible; there were only a few classes that had a Timer but had a ctor/dtor in the header after the previous cleanups. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3278006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58192 0039d316-1c4b-4281-b951-d872f2087c98
* net: add *.yodlee.com to False Start blacklistagl@chromium.org2010-09-013-3/+52
| | | | | | | | | | | (At the request of A10 networks.) BUG=53690 TEST=net_unittests http://codereview.chromium.org/3235009/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58191 0039d316-1c4b-4281-b951-d872f2087c98
* net: don't NOTREACHED on long search terms.agl@chromium.org2010-09-012-1/+13
| | | | | | | | | | | | | | We will pass long, single word search terms into the network stack to try and fetch them if they, even slightly, look like they could be a host name. DNSDomainForDot was triggering a NOTREACHED in this case because they weren't valid DNS names. BUG=53856 TEST=net_unittests http://codereview.chromium.org/3273006/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58189 0039d316-1c4b-4281-b951-d872f2087c98
* Relands r58007.willchan@chromium.org2010-09-013-24/+150
| | | | | | | | | | Fixes the problem with the flaky unittest that happened due to message loop posting race conditions. BUG=53386 TEST=HostResolverImplTest.AbortOnIPAddressChanged,HostResolverImplTest.OnlyAbortExistingRequestsOnIPAddressChange Review URL: http://codereview.chromium.org/3231013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58171 0039d316-1c4b-4281-b951-d872f2087c98
* Stop leaking requests on abort.willchan@chromium.org2010-09-011-0/+1
| | | | | | | | | Remove heapcheck/valgrind suppressions. BUG=53995,50665 Review URL: http://codereview.chromium.org/3284010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58170 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate spdy_session from using LOG() to NetLog. In the process, I'mmbelshe@chromium.org2010-09-015-131/+257
| | | | | | | | | | | | | | | trying to move to a more consistent model of logging between the SpdySession, SpdyStream, and HttpNetworkTransaction. Frame-level events belong on the session, so that we can get a clean view of what happened on the session. I'll be updating the spdy_stream next. BUG=53956 TEST=none Review URL: http://codereview.chromium.org/3212010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58145 0039d316-1c4b-4281-b951-d872f2087c98
* Change the API from passing refptr<>s through the interfaces.mbelshe@chromium.org2010-09-015-32/+26
| | | | | | | | | | | | | Instead use "const obj&" for objects where no ref should be taken by the callee, and use naked ptrs for objects which allow the callee to take references. BUG=none TEST=existing. Review URL: http://codereview.chromium.org/3292002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58128 0039d316-1c4b-4281-b951-d872f2087c98
* Allow NOTIFY_EXISTING_ONLY in ObserverListThreadSafe. Switch NCN to using it.willchan@chromium.org2010-08-311-1/+3
| | | | | | | | TEST=none Review URL: http://codereview.chromium.org/3235013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58089 0039d316-1c4b-4281-b951-d872f2087c98
* Add NSS cert trust setting, cert deleting, and CA cert import to CertDatabase.mattm@chromium.org2010-08-318-10/+720
| | | | | | | | | BUG=19991 TEST=net/base/cert_database_nss_unittest.cc Review URL: http://codereview.chromium.org/3106028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58077 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression whereby full-granularity network events were being captured ↵eroman@chromium.org2010-08-3111-20/+37
| | | | | | | | | | by PassiveLogCollector. BUG=53883 TEST=Load a webpage. Now open about:net-internals and verify that the log for that URL does NOT contain the HTTP request/response headers. Review URL: http://codereview.chromium.org/3274016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58070 0039d316-1c4b-4281-b951-d872f2087c98
* Add an optional parameter to CreatePlatformFile() to report the typedumi@chromium.org2010-08-317-10/+9
| | | | | | | | | | | | of error that occured while trying to open/create a file. TEST=none BUG=none Review URL: http://codereview.chromium.org/3223007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58045 0039d316-1c4b-4281-b951-d872f2087c98
* Abort ConnectJobs with ERR_ABORTED when network changes.willchan@chromium.org2010-08-313-3/+95
| | | | | | | | | BUG=50665 TEST=ClientSocketPoolBaseTest.AbortAllRequestsOnFlush Review URL: http://codereview.chromium.org/3255005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58042 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r58019 and r58007 due to flaky.willchan@chromium.org2010-08-313-126/+6
| | | | | | | | | Blargh, there are race conditions in UI->IO MessageLoop passing. Need to fix them. BUG=53965,53386 Review URL: http://codereview.chromium.org/3215012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58023 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: A giant cleanup to net/erg@google.com2010-08-3139-167/+421
| | | | | | | | | | | | This moves all sorts of code from h files to cc files and reduces header dependencies. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3212008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58020 0039d316-1c4b-4281-b951-d872f2087c98
* Mark HostResolverImplTest.AbortOnIPAddressChanged as FLAKY.willchan@chromium.org2010-08-311-1/+2
| | | | | | | | BUG=53965 Review URL: http://codereview.chromium.org/3261004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58019 0039d316-1c4b-4281-b951-d872f2087c98
* Abort host resolution requests with ERR_ABORTED on ip address change.willchan@chromium.org2010-08-313-6/+125
| | | | | | | | BUG=53386 Review URL: http://codereview.chromium.org/3277002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58007 0039d316-1c4b-4281-b951-d872f2087c98
* ClientSocketPoolBaseHelper can try to read an invalid iterator. Fix that.willchan@chromium.org2010-08-312-2/+35
| | | | | | | | | | | | | | If we hit the backup socket timer and there is no pending request, then the code still tries to create a backup socket using pending_requests.begin(). We change the code to cancel the backup socket timer when the pending_requests hit zero. We also check before reading pending_requests.begin(). BUG=53860 TEST=ClientsocketPoolBaseTest.CancelBackupSocketWhenThereAreNoRequests Review URL: http://codereview.chromium.org/3247007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57993 0039d316-1c4b-4281-b951-d872f2087c98
* Make heapcheck runner use the shadow stacks.glider@chromium.org2010-08-311-6/+0
| | | | | | | | | | | | Enable CertDatabaseNSSTest.ImportFromPKCS12 back, since the leaks are suppressible now. TBR=mattm BUG=51988 Review URL: http://codereview.chromium.org/3218011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57980 0039d316-1c4b-4281-b951-d872f2087c98
* Map SECURITY_STATUS from InitializeSecurityContext to net error codes.cbentzel@chromium.org2010-08-312-8/+54
| | | | | | | | | | | The SSPI implementation of Negotiate+NTLM used to have too many ways to generate an ERR_UNEXPECTED return code, which made it difficult to diagnose user reported issues. BUG=53850 TEST=net_unittests Review URL: http://codereview.chromium.org/3234007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57979 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the wstring FormatUrl() functions (and convert remaining users to the ↵viettrungluu@chromium.org2010-08-313-555/+385
| | | | | | | | | | | | | string16 verison). Still to do: Actually convert the code underlying FormatUrl(). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3263005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57968 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Address a TODO about renaming a function.eroman@chromium.org2010-08-314-15/+15
| | | | | | Review URL: http://codereview.chromium.org/3216008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57959 0039d316-1c4b-4281-b951-d872f2087c98
* Move the pretty-printing of proxy settings from the C++ code to javascript.eroman@chromium.org2010-08-313-289/+52
| | | | | | | | Also, the javascript version does some fancier output -- it now only displays the relevant fields, and numbers the fallback order. Review URL: http://codereview.chromium.org/3219004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57949 0039d316-1c4b-4281-b951-d872f2087c98
* Support handling blob URL and resolve blob references in upload data.jianli@chromium.org2010-08-311-0/+25
| | | | | | | | | BUG=none TEST=unittest Review URL: http://codereview.chromium.org/3282003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57938 0039d316-1c4b-4281-b951-d872f2087c98
* Add SSL test certificate data: dod_ca_13_cert.dermattm@chromium.org2010-08-311-0/+0
| | | | | | | | | | | | (For http://codereview.chromium.org/3106028/show) BUG=19991 TEST=none TBR=wtc Review URL: http://codereview.chromium.org/3214010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57937 0039d316-1c4b-4281-b951-d872f2087c98
* Add moneycenter.yodlee.com to the list of servers incompatiblewtc@chromium.org2010-08-301-1/+2
| | | | | | | | | | | | with SSL False Start. R=agl BUG=53690 TEST=https://moneycenter.yodlee.com should load in Chrome without a hang. Review URL: http://codereview.chromium.org/3274010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57912 0039d316-1c4b-4281-b951-d872f2087c98
* Add RandomNumberGenerator adapter to base/rand_util.hisherman@chromium.org2010-08-301-1/+1
| | | | | | | | | BUG=46679 TEST=none (yet...) Review URL: http://codereview.chromium.org/3053050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57904 0039d316-1c4b-4281-b951-d872f2087c98
* Don't write SPDY headers to the log file; they're redundant withmbelshe@chromium.org2010-08-301-34/+0
| | | | | | | | | | | about:net-internals. BUG=none TEST=none Review URL: http://codereview.chromium.org/3257004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57882 0039d316-1c4b-4281-b951-d872f2087c98
* Sockets page on net-internals now displays some information about the ↵mmenke@chromium.org2010-08-3010-0/+116
| | | | | | | | | | current socket pool state. Table padding slightly increased for legibility. TEST=manual BUG=39756 Review URL: http://codereview.chromium.org/3267002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57869 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ERR_SSL_WEAK_SERVER_KEY to ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEYwtc@chromium.org2010-08-302-3/+3
| | | | | | | | | | | so that it's clear what kind of key it is referring to. R=agl BUG=51694 TEST=none Review URL: http://codereview.chromium.org/3279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57868 0039d316-1c4b-4281-b951-d872f2087c98
* Add logging to the spdy session pool.mbelshe@chromium.org2010-08-304-4/+66
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3280003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57833 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch of uses of the wstring net::FormatUrl() to the new string16 one.viettrungluu@chromium.org2010-08-301-0/+5
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3287002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57829 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame HTTPs net tests which started failing with the change to ↵ananta@chromium.org2010-08-291-0/+4
| | | | | | | | | | | | | | | validate the certificate info in the HTTPs tests. ChromeFrame's host network stack implementation returns a fake certificate as we don't have access to the real certificate info from IE. Fix is to bypass this check for ChromeFrame. TBR=wtc Review URL: http://codereview.chromium.org/3229008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57814 0039d316-1c4b-4281-b951-d872f2087c98
* https: add support for DNS exclusion and switch to TXT records.agl@chromium.org2010-08-2811-42/+492
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (This code has no effect unless --enable-dnssec-certs is given.) The existing DNSSEC code will process embeded chains in certificates and validate CERT records there in. The format of the CERT record was just something made up as a proof of concept. This change switches that code to using TXT records which are at least used by some other code. Additionally, when --enable-dnssec-certs is given. TXT record lookups are triggered for each HTTPS connection. If DNSSEC secure, these lookups can validate a HTTPS certificate. Even without DNSSEC, they can by used for exclusion: if TLS fingerprints are given, but the certificate doesn't match any of them, then the certificate is rejected. The next step in this series will be to perform the TXT lookup for some percentage of dev channel users in order to measure the latency impact. For this experiment, all behavioural changes will be disabled. BUG=none TEST=net_unittests http://codereview.chromium.org/3148037/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57787 0039d316-1c4b-4281-b951-d872f2087c98
* Display the "effective" proxy settings in about:net-internals.eroman@chromium.org2010-08-286-38/+92
| | | | | | | | | | | | The "effective" settings is what you get after applying the various fallbacks between automatic and manual settings. This display makes it easier to notice whether "auto-detect" actually took effect, and if so what was the PAC URL it used. BUG=53549 TEST=On windows change your proxy settings to include both auto-detect, a custom pac script, and some manually configured proxy servers. Now run chrome and go to the proxy tab on about:net-internals. Check that the "original" settings is what you entered in the dialog box, however the "effective" settings will only be a subset of them. Review URL: http://codereview.chromium.org/3241002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57767 0039d316-1c4b-4281-b951-d872f2087c98
* Add regression tests for issue 53366. Check that thewtc@chromium.org2010-08-281-4/+21
| | | | | | | | | | | | | security_bits and connection_status members of a URLRequest's SSLInfo should have valid values when the SSL connection is set up successfully. R=agl BUG=53366 TEST=net_unittests --gtest_filter=HTTPSRequestTest.HTTPS*Test Review URL: http://codereview.chromium.org/3280002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57765 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an obsolete TODO comment. Support for the Netscape SSLwtc@chromium.org2010-08-271-4/+0
| | | | | | | | | | | | server name certificate extension was removed in NSS 3.12.7. R=rsleevi BUG=none TEST=Verify this with https://bugzilla.mozilla.org/show_bug.cgi?id=554425 Review URL: http://codereview.chromium.org/3223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57742 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the following SSLClientSocket methods to match the style guide:rch@chromium.org2010-08-277-17/+17
| | | | | | | | | | | | | | wasNpnNegotiated() -> was_npn_negotiated() setWasNpnNegotiated() -> set_was_npn_negotiated() wasSpdyNegotiated() -> was_spdy_negotiated() setWasSpdyNegotiated() -> set_was_spdy_negotiated() BUG=none TEST=none Review URL: http://codereview.chromium.org/3229004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57741 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 7)thestig@chromium.org2010-08-2710-15/+7
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3176026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
* Support sending BlobData to browser process. Also support sending UploadDatajianli@chromium.org2010-08-272-1/+20
| | | | | | | | | | | with the blob info to browser process. BUG=none TEST=none Review URL: http://codereview.chromium.org/3108042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57707 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: For an AppCache, now we only update thervargas@google.com2010-08-2711-33/+189
| | | | | | | | | | | | | | | | | | | | | | | | LRU list when an entry is created. This means that we don't update the list anymore when an entry is accessed, even if we are writing to the entry. The general idea is that now we should be able to open an AppCache and read from it without modifying the contents of the cache, so that if the browser crashes, we won't find "dirty" entries to discard. By minimizing writes to the LRU list, we reduce the chances that the list will get corrupt beyond the point where we cannot trust it anymore if the whole system crashes (and not just the browser). BUG=51870 TEST=net_unittests Review URL: http://codereview.chromium.org/3186032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57697 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for delegated kerberos tickets to Negotiate authentication.cbentzel@chromium.org2010-08-2714-57/+157
| | | | | | | | | | | This is controlled by the --auth-negotiate-delegate-whitelist command line. By default no servers are delegated to. BUG=50076 TEST=net_unittests, go to an IIS server specified in --auth-negotiate-delegate-whitelist and see if this works correctly. Review URL: http://codereview.chromium.org/3155046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57695 0039d316-1c4b-4281-b951-d872f2087c98
* Change, unify, and specify ordering of cookies from CookieMonster.rdsmith@chromium.org2010-08-273-2/+64
| | | | | | | | | | | | | | Affected interfaces: * GetCookiesWithOptions (used by HTTP requests) * GetAllCookiesForURL (used by extensions and Cookies UI) * GetAllCookies (used by Cookies UI). BUG=8850 (indirectly) TEST=Standard cookie monster tests, unit_tests::CookiesTreeModelTest.OriginOrdering, browser_tests::ExtensionApiTest.Cookies Review URL: http://codereview.chromium.org/3170034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57694 0039d316-1c4b-4281-b951-d872f2087c98
* Allow SSL_SecurityStatus, SSL_GetChannelInfo, andwtc@chromium.org2010-08-275-3/+178
| | | | | | | | | | | | | | SSL_HandshakeNegotiatedExtension to be called as soon as a false start handshake is done. R=agl BUG=53366 TEST=Visit any HTTPS sites, especially sites with certificate errors. The SSL InfoBubble should not say "your connection to www.example.com is not encrypted." Review URL: http://codereview.chromium.org/3233001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57691 0039d316-1c4b-4281-b951-d872f2087c98
* Remove exe perms from text files to fix checkprops failuredmazzoni@chromium.org2010-08-271-0/+0
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57679 0039d316-1c4b-4281-b951-d872f2087c98
* Update --gtest-filter files and suppressions for Dr. Memorytimurrrr@chromium.org2010-08-271-0/+12
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/3267001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57676 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new SSLClientSocket::wasSpdyNegotiated method,rch@chromium.org2010-08-273-14/+14
| | | | | | | | | | | | and modify HttpStreamRequest::DoInitConnectionComplete to call it. BUG=none TEST=none Review URL: http://codereview.chromium.org/3173053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57633 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Add a new uma histogram for the total internalrvargas@google.com2010-08-272-1/+4
| | | | | | | | | | | | buffers size. BUG=none TEST=none Review URL: http://codereview.chromium.org/3211003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57615 0039d316-1c4b-4281-b951-d872f2087c98