summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* HttpResponseHeaders::GetContentRange() to handle implied LWShclam@chromium.org2009-05-262-20/+78
| | | | | | | | | | | There was a bug in HttpResponseHeaders::GetContentRange() that it didn't respect implied LWS rule, i.e. there can be arbitrary number of spaces in the header value between tokens. TEST=HttpResponseHeaders.GetContentRange Review URL: http://codereview.chromium.org/113675 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16921 0039d316-1c4b-4281-b951-d872f2087c98
* Rename |policy_url| to |first_party_for_cookies|. This now matches the ↵abarth@chromium.org2009-05-235-22/+27
| | | | | | | | | | | | WebKit name for this piece of data. R=jackson BUG=None TEST=No behavior change Review URL: http://codereview.chromium.org/115743 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16843 0039d316-1c4b-4281-b951-d872f2087c98
* Extract socket mocks out of HttpNetworkTransactionTest.phajdan.jr@chromium.org2009-05-234-502/+607
| | | | | | | | | | This is the first step towards writing tests for FtpNetworkTransaction. http://crbug.com/12409 Review URL: http://codereview.chromium.org/115646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16837 0039d316-1c4b-4281-b951-d872f2087c98
* Change timeout settings in CacheTest tohuanr@chromium.org2009-05-231-2/+2
| | | | | | | | make it run faster. Review URL: http://codereview.chromium.org/115678 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16833 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a duplicate source file entry -- it appears in the sources of both ↵ericroman@google.com2009-05-221-1/+0
| | | | | | | | "net_unittests" and "net_test_support", but only really needs to be in "net_test_support" target, since "net_unittests" depends on "net_test_support". Review URL: http://codereview.chromium.org/115656 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16794 0039d316-1c4b-4281-b951-d872f2087c98
* Shows Unicode IDN instead of Punycode in the followings:brettw@google.com2009-05-223-0/+341
| | | | | | | | | | | | | | | | | | | - Bookmark Manager - Edit Bookmark dialog opened by Bookmark Manager - Edit Bookmark dialog opened by the star on the left of the address bar Introduces new function, net::FormatUrl(), which has the following parameters in addition to gfx::GetCleanStringFromUrl(). - bool omit_username_password - bool unescape and moves gfx::GetClienStringFromUrl() to net:: namespace, and removed the last two parameters. BUG=3991 Checked in for tkent Original review = http://codereview.chromium.org/115346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16761 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do of r16741 (http://codereview.chromium.org/113482).robertshield@google.com2009-05-223-0/+63
| | | | | | | | | | Moved the new automation message in automation_messages_internal.h to the END of the enum as per the large scary warning that I skillfully missed last time around. TBR=amit Review URL: http://codereview.chromium.org/115711 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16754 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r16741 which appeared to cause a perf regression (???) on the ↵robertshield@google.com2009-05-223-63/+0
| | | | | | | | | | builder. TBR=thomasvl Review URL: http://codereview.chromium.org/115708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16742 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the ability to alter Chrome's proxy settings via the automation ↵robertshield@google.com2009-05-223-0/+63
| | | | | | | | interface for automated testing. Review URL: http://codereview.chromium.org/113482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16741 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gconf for the linux proxy config service.sdoyon@chromium.org2009-05-229-177/+613
| | | | | | | | | | | | | | | | | | | | | | | | -Reenables fetching of settings from gconf. -Moves all gconf access to happen from the UI thread only, (where the default glib main loop runs). -Adds support for gconf notifications, avoiding having to poll the settings. -Fixes a small initialization glitch in the unittest. Plus minor code style tweaks. -Permanently removes gdk and glib threading initialization calls that were previously disabled. -Slight reorganization of ProxyService creation to pass down the IO thread MessageLoop. BUG=11111 TEST=none Review URL: http://codereview.chromium.org/113043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16739 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Temporarily landing my ClientSocketPool refactor. Will revert right ↵willchan@chromium.org2009-05-2211-774/+377
| | | | | | | | after." Review URL: http://codereview.chromium.org/113760 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16732 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily landing my ClientSocketPool refactor. Will revert right after.willchan@chromium.org2009-05-2211-377/+774
| | | | | | Review URL: http://codereview.chromium.org/113759 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16731 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Implement full duplex mode for TCPClientSocketLibevent.""willchan@chromium.org2009-05-225-157/+276
| | | | | | | | | Fix TCPClientSocketLibevent::DidCompleteConnect(). Should call Connect(write_callback_). TBR=wtc Review URL: http://codereview.chromium.org/115697 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16730 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo (one extra '!') in the previous checkin (r13601).wtc@chromium.org2009-05-221-1/+1
| | | | | | | R=eroman Review URL: http://codereview.chromium.org/113730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16696 0039d316-1c4b-4281-b951-d872f2087c98
* Add #if defined(OS_WIN) for the previous change, which onlywtc@chromium.org2009-05-221-1/+5
| | | | | | | | | | | | applies to Windows. I forgot that this file is used by all platforms. R=eroman http://crbug.com/5234 TEST=N/A Review URL: http://codereview.chromium.org/113729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16695 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Implement full duplex mode for TCPClientSocketLibevent."willchan@chromium.org2009-05-225-275/+156
| | | | | | | | Revert "Disable the flaky fullduplex tests." Review URL: http://codereview.chromium.org/113749 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16685 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the flaky fullduplex tests.willchan@chromium.org2009-05-211-2/+2
| | | | | | | | TBR=wtc Review URL: http://codereview.chromium.org/115671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16679 0039d316-1c4b-4281-b951-d872f2087c98
* Implement full duplex mode for TCPClientSocketLibevent.willchan@chromium.org2009-05-215-154/+273
| | | | | | | | | | | | | | | The main thing is not to share the same MessageLoopForIO::FileDescriptorWatcher object for both reads and writes. Fixed tcp_client_socket_unittest.cc's full duplex test. In doing so, I also had to fix up some other stuff. (1) Put everything in the net::(anonymous) namespace. (2) Keep calling Write() until ERR_IO_PENDING happens. (3) Make the server socket pause its reads so that the buffers (both client and server side) eventually fill up. (4) Discovered that after the first Read(), the server socket will close. Further Write() calls will lead to a TCP RST, which breaks the FullDuplex_WriteFirst test, since it wants to do a Write() at the end. Fix this by changing DidRead() not to automatically close the server socket. Added a CloseServerSocket() member function to make this explicit. Fixed up the Read() tests. Made them more exact too. BUG=http://www.crbug.com/11888 TEST=Go to gmail, compose a message, attach a large file (say 1MB or so). It shouldn't crash. Review URL: http://codereview.chromium.org/115504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16675 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the UI for HTTP/FTP auth challenges to include the server's port. So ↵ericroman@google.com2009-05-2110-65/+110
| | | | | | | | | | | instead of "www.foo.com" it will say "www.foo.com:80". We need to include the port number since otherwise it can be ambiguous what the actual target server is. This change also introduces utility function "GetHostAnd[Optional]Port()" to help with forming <host> [":" <port>] strings. BUG=12073 Review URL: http://codereview.chromium.org/112041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16672 0039d316-1c4b-4281-b951-d872f2087c98
* Map the NSS error code SEC_ERROR_CA_CERT_INVALID (-8156)wtc@chromium.org2009-05-211-1/+2
| | | | | | | | | | | | | to ERR_CERT_AUTHORITY_INVALID. R=ukai BUG=12359 TEST=Visit https://www.grounation.org/. The SSL error page should say "The site's security certificate is not trusted!" rather than "Invalid Server Certificate". Review URL: http://codereview.chromium.org/115597 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16566 0039d316-1c4b-4281-b951-d872f2087c98
* Remove another NOTIMPLEMENTEDkuchhal@chromium.org2009-05-201-1/+1
| | | | | | | | | BUG=12052 Review URL: http://codereview.chromium.org/113642 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16487 0039d316-1c4b-4281-b951-d872f2087c98
* Add JSON-specific escaping, which has different rules from JS ↵erikkay@google.com2009-05-201-6/+5
| | | | | | | | escaping.BUG=http://crbug.com/11431TEST=base_unittests.exe --gtest_filter=StringEscapeTest.Json* Review URL: http://codereview.chromium.org/113606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16485 0039d316-1c4b-4281-b951-d872f2087c98
* More progress on ForceHTTPS.abarth@chromium.org2009-05-206-5/+150
| | | | | | | | | | | Instead of turning on strict HTTPS error processing for every site, we now track which sites have opted in. Our implementation is still experimental and hidden behing the command line switch --force-https. R=darin TEST=No tests yet because this is just an experiment. Review URL: http://codereview.chromium.org/113503 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16464 0039d316-1c4b-4281-b951-d872f2087c98
* Linux download shelf icons first cut.estade@chromium.org2009-05-201-2/+2
| | | | | | | | | Nor do we have support for alternate file formats; nor do we have a default icon. BUG=http://crbug.com/8631 Review URL: http://codereview.chromium.org/113571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16444 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup code to keep flag showing "was cached" only in URLRequestHttpJobjar@chromium.org2009-05-196-20/+19
| | | | | | | r=wtc Review URL: http://codereview.chromium.org/113535 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16435 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize the ProxyService::Create() and ↵eroman@chromium.org2009-05-192-48/+62
| | | | | | | | | | | ProxyService::CreateWithoutV8Resolver() methods. Instead of using a NULL ProxyResolver dependency in cases where PAC is not supported, it uses a ProxyResolverNull (always fail) implementation. This is to avoid needing to check in other cases (when v8 is unsupported) if there is a non-null ProxyResolver. Review URL: http://codereview.chromium.org/115532 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16413 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an incorrect DCHECK.paul@chromium.org2009-05-191-4/+1
| | | | | | | | | | Neither the nss or Windows GetSSLInfo methods check this condition, which can be called in error situations. Review URL: http://codereview.chromium.org/113559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16397 0039d316-1c4b-4281-b951-d872f2087c98
* Include C system headers before C++ system headers.wtc@chromium.org2009-05-182-3/+6
| | | | | | | | | | | | | | | | Document that GetHostAndPort returns an IPv6 literal address with square brackets. Document that the host parameter to the ProxyServer constructor takes an IPv6 literal address with square brackets. R=eroman BUG=N/A TEST=N/A Review URL: http://codereview.chromium.org/113494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16287 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Revert "Add connected socket function to ClientSocketPool ↵willchan@chromium.org2009-05-1811-774/+377
| | | | | | | | | | | and ClientSocketHandle.""" Revert "Fix a memory leak in client_socket_pool_unittest.cc." Guess I still fail. kasperl pointed out that this managed to break layout tests and some reliability tests too. Review URL: http://codereview.chromium.org/113517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16269 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in client_socket_pool_unittest.cc.willchan@chromium.org2009-05-171-10/+14
| | | | | | | | | Need to run the MessageLoop one time to run a task to delete the canceled ConnectingSocket. Also reorder the test to help hide the minor race condition here. Review URL: http://codereview.chromium.org/115455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16266 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Add connected socket function to ClientSocketPool and ↵willchan@chromium.org2009-05-1711-377/+770
| | | | | | | | | | | | ClientSocketHandle."" This reverts commit c235c719f964cc8f7f9343177ae6d5af724be6c0. Fixes a use of deleted memory by making a copy instead of keeping a reference to the deleted memory. Review URL: http://codereview.chromium.org/113512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16263 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add connected socket function to ClientSocketPool and ↵willchan@chromium.org2009-05-1711-770/+377
| | | | | | | | | | ClientSocketHandle." Broke net_unittests on windows. Review URL: http://codereview.chromium.org/113510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16261 0039d316-1c4b-4281-b951-d872f2087c98
* Add connected socket function to ClientSocketPool and ClientSocketHandle.willchan@chromium.org2009-05-1711-377/+770
| | | | | | | | Provide a new api in ClientSocketPool and ClientSocketHandle for clients (notably HttpNetworkTransaction) to request connected sockets, rather than having to allocate and Connect() sockets themselves. Add a bunch of tests for it. Have not begun switching clients over to using this. Review URL: http://codereview.chromium.org/99143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16260 0039d316-1c4b-4281-b951-d872f2087c98
* Add a temporary hack to not resolve the mime type for .pl files to fix a ↵thestig@chromium.org2009-05-161-2/+7
| | | | | | | | | | | layout test. Remove a NOTIMPLEMENTED that was breaking layout tests. TBR=estade Review URL: http://codereview.chromium.org/113500 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16233 0039d316-1c4b-4281-b951-d872f2087c98
* Override .ico file's mime type on Linux. XDG's mime database has a bogus ↵thestig@chromium.org2009-05-161-0/+10
| | | | | | | | | "image/x-ico" entry whereas the rest of the world uses "image/x-icon". TBR=estade Review URL: http://codereview.chromium.org/115440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16231 0039d316-1c4b-4281-b951-d872f2087c98
* Add xdg mime support on Linux.thestig@chromium.org2009-05-161-11/+11
| | | | | | | BUG=10049 Review URL: http://codereview.chromium.org/113168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16227 0039d316-1c4b-4281-b951-d872f2087c98
* Use the new HostNoBrackets() method in more places.wtc@chromium.org2009-05-163-11/+12
| | | | | | | | | | | | | Note that IP addresses in certificate names are encoded in binary form (octet strings -- 4 octets for IPv4 and 16 octets for IPv6). R=eroman http://crbug.com/12005 TEST=covered by current tests Review URL: http://codereview.chromium.org/113438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16213 0039d316-1c4b-4281-b951-d872f2087c98
* AI_ADDRCONFIG is not necessary on Windows because itswtc@chromium.org2009-05-151-2/+23
| | | | | | | | | | | | | | behavior is ON by default. Using AI_ADDRCONFIG can actually be harmful, as it causes getaddrinfo to fail to resolve "localhost" when the computer is not connected to a network. R=eroman http://crbug.com/5234 TEST=See bug 5234 for instructions Review URL: http://codereview.chromium.org/115424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16212 0039d316-1c4b-4281-b951-d872f2087c98
* Add a comment to document that we don't know if a nonblockingwtc@chromium.org2009-05-151-0/+11
| | | | | | | | | | | | connect will ever return 0, and therefore we don't know if the event object will be signaled in that case. R=rvargas http://crbug.com/9258 TEST=N/A Review URL: http://codereview.chromium.org/113474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16171 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 16158.beng@google.com2009-05-154-17/+2
| | | | | | Review URL: http://codereview.chromium.org/113470 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16163 0039d316-1c4b-4281-b951-d872f2087c98
* Privacy option added for all cookies to become session cookies.idanan@chromium.org2009-05-154-2/+17
| | | | | | | BUG=10502 Review URL: http://codereview.chromium.org/87047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16158 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that HttpNetworkTransaction::GetResponseInfo() shouldukai@chromium.org2009-05-151-1/+5
| | | | | | | | | | | | never return NULL when we get a certificate error. R=wtc BUG=11646 TEST=access https://www.cdep.ro/ Review URL: http://codereview.chromium.org/113330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16144 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust histograms to only collect non-cache stats for SDCH.jar@chromium.org2009-05-157-47/+67
| | | | | | | | | | | | | | | | I also changed the name of all the SDCH histograms so that there would be no confusion about the data. I also added one new problem code, but that recordation doesn't have any semantic impact. I added it to help make it easier to diagnose dictionary specification errors in SDCH. bug=12012 R=wtc Review URL: http://codereview.chromium.org/115377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16138 0039d316-1c4b-4281-b951-d872f2087c98
* Fix reversed arguments to EXPECT_EQ() in mime_util_unittest.thestig@chromium.org2009-05-141-4/+4
| | | | | | Review URL: http://codereview.chromium.org/113426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16126 0039d316-1c4b-4281-b951-d872f2087c98
* Change the host() method of ProxyServer to strip thewtc@chromium.org2009-05-144-6/+51
| | | | | | | | | | | | | | | | | | | | | square brackets around an IPv6 literal address. Rename the method HostNoBrackets() to be consistent with GURL's new HostNoBrackets() method. When resolving an address, use the new HostNoBrackets() method instead of host(). Part of this changelist was contributed by Paul Marks of Google. Original review: http://codereview.chromium.org/115342 R=eroman http://crbug.com/12005 TEST=covered by new test cases in unit test Review URL: http://codereview.chromium.org/114029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16123 0039d316-1c4b-4281-b951-d872f2087c98
* Add a separate cookie store that's used for extensions.mpcomplete@google.com2009-05-143-12/+49
| | | | | | | Modify CookieMonster to support overriding the "cookieable schemes". Review URL: http://codereview.chromium.org/115204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16083 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the remaining WaitForSingleObject(INFINITE) call.wtc@chromium.org2009-05-141-47/+55
| | | | | | | | | | | | We now wait with a zero timeout. If the wait times out, we take the same code path as WSAEWOULDBLOCK/WSA_IO_PENDING. R=rvargas http://crbug.com/9258 TEST=Covered by existing unit tests Review URL: http://codereview.chromium.org/113371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16028 0039d316-1c4b-4281-b951-d872f2087c98
* If Schannel's InitializeSecurityContext calls returnwtc@chromium.org2009-05-141-2/+17
| | | | | | | | | | | | | | | | | | | certificate errors, do not map them to our (server) certificate errors because the errors are referring to the (missing) client certificate. If we incorrectly handle them as server certificate errors, we will crash because we can't get the server certificate from Schannel when the handshake fails. Fumitoshi Ukai of Google tracked down the bug and proposed an alternative fix. R=rvargas,ukai BUG=http://crbug.com/11646 TEST=Visit https://www.cdep.ro/. Chromium should not crash. Review URL: http://codereview.chromium.org/113375 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16026 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that IO thread is not called in last actions by SDCH shutdownjar@chromium.org2009-05-132-0/+10
| | | | | | | | | | | | | Unregister the sdch_dictionary_fetcher so that it destroys any pending URLFetcher instances when we are nearing shutdown time. Dictionaries are only *potentially* useful (and not needed) for future SDCH fetches, so abandoning any pending items is safe and harmless. b=9669 r=wtc Review URL: http://codereview.chromium.org/113235 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16015 0039d316-1c4b-4281-b951-d872f2087c98
* Split NetUtilTest.IDNToUnicode into IDNToUnicodeFast and IDNToUnicodeSlow. ↵thestig@chromium.org2009-05-132-277/+299
| | | | | | | | | Enable IDNToUnicodeFast test under Valgrind. BUG=9172 Review URL: http://codereview.chromium.org/113370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16010 0039d316-1c4b-4281-b951-d872f2087c98