| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.
BUG=87634
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8817019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
using the CDN pins.""
This relands r113203, which was reverted in r113229. Hopefully the ChromeOS
bots will be happy this time.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The primary commit was 113249, the dependents were 113261, 113263.
This is a speculative revert, r113249 is by far the likeliest culprit in the blamelist of build http://build.chromium.org/p/chromium.memory/builders/ASAN%20Tests%20%282%29/builds/2325 which is where we started seeing the ASAN failures in question, will un-revert if it does not fix the problem.
TBR=jhawkins@chromium.org
BUG=none
Review URL: http://codereview.chromium.org/8832006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were a few memory issues including access of unadressable memory.
DnsClient provides a generic DNS client that allows fetching resource records.
DnsClient is very lightweight and does not support aggregation, queuing or
prioritization of requests.
This is the first CL in a series to merge AsyncHostResolver into
HostResolverImpl.
Also introduces general-purpose BigEndianReader/Writer.
BUG=90881
TEST=./net_unittests
Review URL: http://codereview.chromium.org/8762001
TBR=szym@chromium.org
Review URL: http://codereview.chromium.org/8835011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=net_unittests under valgrind
Review URL: http://codereview.chromium.org/8838001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Save pipelining capabilities for the most used hosts between sessions.
BUG=None
TEST=unit_tests
Review URL: http://codereview.chromium.org/8770035
TBR=simonjam@chromium.org
Review URL: http://codereview.chromium.org/8833003
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8832003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Save pipelining capabilities for the most used hosts between sessions.
BUG=None
TEST=unit_tests
Review URL: http://codereview.chromium.org/8770035
TBR=simonjam@chromium.org
Review URL: http://codereview.chromium.org/8833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Needed to build on 10.5, which is in turn needed for coverity.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8828010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8801005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=unit_tests
Review URL: http://codereview.chromium.org/8770035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SPDY sessions when needed.
Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.
Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket.
Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is probably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).
BUG=62364,92244, 105839
TEST=none
Review URL: http://codereview.chromium.org/8340012
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8745007
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8803019
TBR=rtenneti@chromium.org
Review URL: http://codereview.chromium.org/8825014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when needed.
Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.
Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket.
Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is probably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).
BUG=62364,92244, 105839
TEST=none
Review URL: http://codereview.chromium.org/8340012
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8745007
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8803019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
or sent ping (like below):
t=1323200233634 [st=196851] SPDY_SESSION_PING
--> type = "sent"
--> unique_id = 3
t=1323200233638 [st=196855] SPDY_SESSION_PING
--> type = "received"
--> unique_id = 3
BUG=106499
R=willchan
TEST=spdy unit tests
Review URL: http://codereview.chromium.org/8824005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HttpStreamFactoryImpl::Job::OnStreamReadyCallback.
As a side-effect of OnPipelineFeedback() calling OnPipelineHasCapacity() on all
of the pipelines, some requests are late-bound to existing pipelines with
capacity. However, those requests may have been in the process of establishing
new pipelines. By stealing those requests, the new pipelines become empty and
are deleted. Later iterations of the loop in OnPipelineFeedback() weren't
careful about checking to see if the pipeline was deleted before calling
OnPipelineHasCapacity() on it.
BUG=106313
TEST=net_unittests under valgrind
Review URL: http://codereview.chromium.org/8820005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8801004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DnsClient provides a generic DNS client that allows fetching resource records.
DnsClient is very lightweight and does not support aggregation, queuing or
prioritization of requests.
This is the first CL in a series to merge AsyncHostResolver into
HostResolverImpl.
Also introduces general-purpose BigEndianReader/Writer.
BUG=90881
TEST=./net_unittests
Review URL: http://codereview.chromium.org/8762001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8799001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8792006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8798001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/8794003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the CDN pins."
This reverts commit r113203. It failed on the ChromeOS valgrind and heapcheck bots.
BUG=113203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=https://twitter.com loads
Review URL: http://codereview.chromium.org/8770048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=88782
TEST=changed certificate_types struct in local copy of nss selfserv,
reloaded, checked "echo .dump | sqlite3 'Origin Bound Certs'" to see if
new cert was generated.
Review URL: http://codereview.chromium.org/8821002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NSS implicitly before calling the NSS function
SSL_ClearSessionCache.
Remove the stale comment that
SSLClientSocketNSS::ClearSessionCache is only for tests.
R=mattm@chromium.org
BUG=105431
TEST=net_unittests --gtest_filter=SSLClientSocketNSSTest.ClearSessionCache
Review URL: http://codereview.chromium.org/8816002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8742001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based on whether there is a node on the sync side.
BUG=102714
TEST=none
Review URL: http://codereview.chromium.org/8786006
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8819008
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8818004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
there is a node on the sync side.
BUG=102714
TEST=none
Review URL: http://codereview.chromium.org/8786006
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8819008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=88782
TEST=none
Review URL: http://codereview.chromium.org/8771031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OriginBoundCertService::GetOriginBoundCert takes a vector of requested cert
types in order of preferrence and will return or generate one of an acceptable
type.
BUG=88782
TEST=net_unittests, unit_tests
Review URL: http://codereview.chromium.org/8662036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on the sync side.
BUG=102714
TEST=none
Review URL: http://codereview.chromium.org/8786006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move CapturingNetLog out of net project, as it's no longer
used except in tests.
Review URL: http://codereview.chromium.org/8567011
TBR=mmenke@chromium.org
Review URL: http://codereview.chromium.org/8822002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
used except in tests.
Review URL: http://codereview.chromium.org/8567011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
next_proto to net-internals log.
In net internal logs, we will log proto in the following
manner:
(P) t=1323112212350 [st=463]
HTTP_STREAM_REQUEST_PROTO
--> next_proto_status = "negotiated"
--> proto = "spdy/2"
--> server_protos = "spdy/2,http/1.1"
BUG=62064
TEST=network unit tests
R=willchan
The following was the original CL:
http://codereview.chromium.org/8676046/
Review URL: http://codereview.chromium.org/8787011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also extended the testserver's device_management.py handler to serve these
requests.
BUG=chromium-os:23063
TEST=unit_tests and browser_tests all pass
Review URL: http://codereview.chromium.org/8741014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The feature is behind a command line flag --enable-restore-session-state.
BUG=1870
TEST=CookieMonsterTest.PersistSessionCookies, SQLitePersistentCookieStoreTest.Test(Dont)?LoadOldSessionCookies, SQLitePersistentCookieStoreTest.PersistHasExpiresAndIsPersistent
Review URL: http://codereview.chromium.org/8533013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
optimize the call away.
Manual changes to spdy_protocol.h and spdy_framer.cc, rest of the CL generated by
running:
perl -pi -e "s/SpdyFrame::size\(\)/SpdyFrame::kHeaderSize/" $(git grep -l SpdyFrame::size)
This is the same as the google-internal CL 25917366 and 25938381
BUG=94125
TEST=none
TBR=willchan
Review URL: http://codereview.chromium.org/8790015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8784003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
spdy_stream_ was used when NULL. We now copy the peer address
and local address from spdy_stream_ when we connect.
BUG=106073
TEST=SpdyProxyClientSocket.GetPeerAddressReturnsCorrectValue
Review URL: http://codereview.chromium.org/8771012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8771030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The preference is controlled by the command line and enterprise policy.
R=mattm@chromium.org,mnissler@chromium.org
BUG=106077
TEST=Existing policy unit tests are updated.
Review URL: http://codereview.chromium.org/8772014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=88782
TEST=X509UtilNSSTest
Review URL: http://codereview.chromium.org/8537025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105579
Review URL: http://codereview.chromium.org/8749016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stringified form
On Windows, rather than converting the entire certificate
name to a string and attempting to parse out the components
and values, iterate through the relativeDistinguishedName
and AttributeTypeAndValue pairs to extract each name
component.
This is to ensure that:
1) When multiple AVAs are present in an RDN, ALL AVAs are
parsed.
2) When converting an AVA to a string, no extra escaping is
applied.
This also fixes domainComponent parsing on OS X, so that
unittests with a domainComponent can pass.
BUG=101009, 102839
TEST=net_unittests:X509CertificateTest has two new regression
tests. Additionally, sample a variety of SSL sites and ensure no
regressions, paying attention to internationalized domains.
Review URL: http://codereview.chromium.org/8608003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
etc), rather than parsing the entire certificate and converting all known fields to their CSSM equivalents, just parse the desired field.
Additionally, when parsing multiple fields, instead of parsing the certificate multiple times, parse it once and cache the internal parse results. While the cached handle cannot reliably be used across threads, it can reduce the amount of parsing for the common case, where constructing an X509Certificate on OS X requires parsing three fields.
BUG=101231
TEST=net_unittests passes on OS X 10.5, 10.6, and 10.7
Review URL: http://codereview.chromium.org/8470012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Build on Win Shared
Review URL: http://codereview.chromium.org/8770031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
IsVisible as it's no longer needed. This cl resulted in a ton of
changes, the majority are renames though.
BUG=102714
TEST=covered by tests
Review URL: http://codereview.chromium.org/8759017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to wait for an HTTP/1.1 keep-alive response before we try to pipeline. Notably, this fixes wordpress.com and techcrunch.com.
Remember which hosts clearly support, or don't support pipelining. If pipelining is supported, skip the slow start. If it's not, fall back to HttpBasicStreams.
A site is judged not to support pipelining if we see an old HTTP version or encounter a socket error. A site does support pipelining if it successfully handles 3 requests. There's obviously room for improvement here, but this is a
start.
Related changes:
- In the spirit of CHECK() failing. Use CHECK(false) instead of NOTREACHED().
- HttpPipelinedHost is now an interface with a corresponding Impl. This is to help unit test HttpPipelinedHostPool.
BUG=None
TEST=net_unittests
Review URL: http://codereview.chromium.org/8586015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary for gcc 4.4.3, see the comments on
http://codereview.chromium.org/8687014
BUG=94925
TEST=none
TBR=willchan
Review URL: http://codereview.chromium.org/8776012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=groby
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8743019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112534 0039d316-1c4b-4281-b951-d872f2087c98
|