| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/668197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type.
* Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF.
TBR=evanm
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No real code change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25032
TEST=none
Review URL: http://codereview.chromium.org/669122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31096
TEST=none
Review URL: http://codereview.chromium.org/669226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Submitted for inferno@chromium.org
BUG=35510
TEST=HostContentSettingsMapTest.HostTrimEndingDotCheck
Review URL: http://codereview.chromium.org/669284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The root cause was not firing the completion callback at the first point
the data could be read. This lead to a temporary deaadlock-like situation,
where the browser was waiting for the server to send a response
on the control connection, and the server was waiting for the browser
to start reading from the data connection.
This patch makes the completion callback fire as soon as data is ready.
It also removes a broken test. We should get a coverage for that scenario
from other tests.
TEST=Covered by net_unittests.
BUG=36116
Review URL: http://codereview.chromium.org/668162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/160
and integrates the update to IsStandard in that version. Adds several internal
schemes as "standard" and initializes them at startup. Fixes a few hardcoded
URL schemes I noticed.
Make typing "//foo" into the URL bar treat slashes in "strict" mode on Windows,
which means we'll only accept UNC if you use backslashes. This matches IE's
behavior.
BUG=http://crbug.com/33038
TEST=covered by unit tests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32553,30001
TEST=none
Review URL: http://codereview.chromium.org/661223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
put inside an if statement by mistake.
R=snej
BUG=30684
TEST=none
Review URL: http://codereview.chromium.org/669207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of SECFailure when we want to abort the handshake, because
SECWouldBlock causes NSS to suspend the client authentication,
whereas SECFailure causes NSS to continue the handshake with an
empty certificate (in TLS) or no_certificate alert (in SSL 3.0).
R=agl
BUG=16830
TEST=SSL client authentication on Linux should still work.
Review URL: http://codereview.chromium.org/669198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
domain. The default remains at 1.
Command line usage to set it to 13:
chrome.exe --use-spdy --max-spdy-sessions-per-domain=13
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/669169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I've gotten several sites (startcom and foaf.me) to work by aborting the connection on renegotiation, telling the caller to ask for a client cert, and then when a client cert is provided not enabling break-on-auth.
BUG=36207
TEST=none
Review URL: http://codereview.chromium.org/669110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32553,30001
TEST=none
Review URL: http://codereview.chromium.org/661223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
request does not generate a separate row in the history
database.
BUG=34350
Review URL: http://codereview.chromium.org/668051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In DoSSLConnectComplete, we still need to set using_spdy_
if we get a certificate error.
In HandleCertificateError, we need to ignore the error
after adding the certificate to the allowed_bad_certs list.
R=mbelshe
BUG=37367
TEST=Connect to a SPDY server with a bad certificate. Clicking
"Proceed anyway" in the SSL blocking page should not result in
a download.
Review URL: http://codereview.chromium.org/668111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update SpdyControlFrame to remove the stream_id.
Update associated tests.
BUG=none
TEST=spdy_protocol_test.cc
Review URL: http://codereview.chromium.org/668048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/668057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
module to the chrome module.
This is in preparation for making a javascript frontend to it, and merging in the functionality from about:network.
There is no behavior change here, just moving code around.
Review URL: http://codereview.chromium.org/668039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
outstanding.
BUG=none
TEST=SpdyNetworkTranscation.BufferedCancelled
Review URL: http://codereview.chromium.org/667003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31723
TEST=none
Review URL: http://codereview.chromium.org/660431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/667013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The original log message sounded like SSL renegotiation was attempted.
R=abarth
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/666011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the unused member completed_handshake_.
In OnHandshakeIOComplete, correct the comments to note
that we also notify the caller of success. We cannot
DCHECK renegotiating_ is true because DidCompleteRenegotiation
has reset it to false. Instead, DCHECK the equivalent
conditions in DidCompleteRenegotiation. Log the end of
TYPE_SSL_CONNECT only for initial handshakes.
In DoCompletedRenegotiation, result may not be OK.
R=mbelshe
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/666004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Net.HadConnectionType3
Each bucket is a boolean (0 or 1) indicating whether the user has had a successful connection of that type during the session. The bucket indexes are defined in "net/base/connection_type_histograms.h". 0 = Any connection (SSL or not); 1 = An SSL connection; 2 = An SSL connection with an MD5 certificate in the certificate chain (excluding root); 3 = An SSL connection with an MD2 certificate in the certificate chain (excluding root); 4 = An SSL connection with an MD4 certificate in the certificate chain (excluding root); 5 = An SSL connection with an MD5 CA certificate in the certificate chain (excluding root); 6 = An SSL connection with an MD2 CA certificate in the certificate chain (excluding root); 7 = A HTTP connection. 8 = A SPDY connection.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a copy of http://codereview.chromium.org/660445 written by
hbono@chromium.org
BUG=37289
TEST=make valgrind bots green.
TBR=jam,snej,hbono
Review URL: http://codereview.chromium.org/660451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instead.
Review URL: http://codereview.chromium.org/660430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37007
TEST=unit_tests --gtest_filter=DownloadManagerTest.*
Review URL: http://codereview.chromium.org/660297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=snej
Review URL: http://codereview.chromium.org/660428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For benchmarking and testing, we still want to be able to ignore the
certificate errors, so I added a flag to the use-spdy option to do so:
--ignore-certificate-errors
BUG=32020
TEST=none
Review URL: http://codereview.chromium.org/661375
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Adds TLS false start support. This allows us to start sending encrypted
data before we have validated the server's Finished message. (This
behaviour is already enabled on Android.)
I've verified that this works using netem to add a 200ms delay on the
loopback adaptor. I've also checked that an incorrect Finished message from
the server causes an error by hacking the Go TLS server.
Beware when looking at packet traces that the time taken in NSS's SQLite
calls can exceed the RTT of the connection and make it appear that this
code isn't functioning.
* Adds DEBUG and TRACE defines to libssl when building Chromium in Debug
mode. This means that setting SSLTRACE in the environment now works for
debug builds.
(Reland. First landed in r39905, reverted in r40024 because it uncovered a bug. Then landed in r40124 and reverted in r40126 because the faster SSL handshakes made a flake UI test worse. UI test fixed in r40285.)
http://codereview.chromium.org/518065
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=32406
TEST=unittests
Review URL: http://codereview.chromium.org/660041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none - not used and blocks refactoring for bug 30357
TEST=unit tests
Review URL: http://codereview.chromium.org/661318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36871
Review URL: http://codereview.chromium.org/660353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Keychain.
BUG=34607
TEST=KeygenHandlerTest.SmokeTest
Review URL: http://codereview.chromium.org/652137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unless TLS is disabled. This allows implementers of server
side secure renegotiation to use Linux Chrome as a test
client that sends empty renegotiation info extensions in
initial handshakes.
Rename README.google to README.chromium.
R=agl
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
while the read is still pending.
BUG=none
TEST=SpdyNetworkTransactionTest
Review URL: http://codereview.chromium.org/661292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no memory leak in valgrind test: net_unittests
Review URL: http://codereview.chromium.org/661266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=browser_tests ExtensionApiTest.FLAKY_WebSocket doesn't crash
Review URL: http://codereview.chromium.org/660259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Web Socket should send "HttpOnly" cookie when handshaking.
In WebKit/WebCore, WebSocketHandshake uses cookieRequestHeaderFieldValue() to
get cookies including HttpOnly cookie. However, Chrome doesn't trunk renderer
process, so we're not allowed to access HttpOnly cookie in WebCore.
Thus, we handle HttpOnly cookies in browser process.
Add SocketStreamJob as interface for protocol specific handling on
SocketStream.
WebSocketJob implements Web Socket specific handling. For now, it handles
cookies in Web Socket. It checks Web Socket handshake request message
from renderer process, and replaces Cookie: header to include HttpOnly cookies.
It also checks Web Socket handshake response message, sets cookies if any,
and strips Set-Cookie: header, so that renderer process couldn't see
Set-Cookie: header.
BUG=35660
TEST=net_unittests and layout_tests passes
Review URL: http://codereview.chromium.org/601077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check that we report that we wrote no more than we requested to write.
Remove some debugging.
BUG=27870
TEST=none
Review URL: http://codereview.chromium.org/660194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SSL secure renegotiation.
R=abarth
BUG=none
TEST=Run Chrome witl logging enabled. Visit https://www.google.com/.
An informational message like
[1812:8012:351987676:INFO:ssl_client_socket_nss.cc(651)]
The server www.google.com does not support SSL secure renegotiation.
should be logged. Then visit https://ssltls.de/. No such informational
message should be logged.
Review URL: http://codereview.chromium.org/660144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing unit tests
Review URL: http://codereview.chromium.org/661194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40182 0039d316-1c4b-4281-b951-d872f2087c98
|