| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
* Add additional dropbox domains
* Set includeSubdomains for dropbox pins
* Add a preloaded report-uri for dropbox pins
BUG=
Review URL: https://codereview.chromium.org/1291183002
Cr-Commit-Position: refs/heads/master@{#343403}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create a about handler component.
The following files ::
chrome/browser/net/about_protocol_handler.*
net/url_request/url_request_about_job.*
moved to new component: components/about_handler.
Also added GYP and GN file for same.
BUG=516695
Review URL: https://codereview.chromium.org/1284173003
Cr-Commit-Position: refs/heads/master@{#343366}
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files are not using any of the three functions from dns_util.h.
BUG=None
TEST=net_unittests
R=mmenke@chromium.org
Review URL: https://codereview.chromium.org/1286933003
Cr-Commit-Position: refs/heads/master@{#343342}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change URLFetcherCore to read the values for
GetReceivedResponseContentLength() and GetTotalReceivedBytes() after the
request has finished processing, rather than immediately after the
response started. Add tests to verify this.
BUG=
Review URL: https://codereview.chromium.org/1285403002
Cr-Commit-Position: refs/heads/master@{#343337}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
experiment that sets the FEC timeout to 0.25 RTT. This is a temporary
change. Will revert these changes after getting results for this
experiment.
Merge internal change: 100617579
R=rch@chromium.org
Review URL: https://codereview.chromium.org/1292243002
Cr-Commit-Position: refs/heads/master@{#343331}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a basic JNI wrapper for java.lang.System. Expose just the
getProperty() method, eliminating a deprecated __system_property_get
usage as well as a seperate System.getProperty wrapper.
The remaining uses of __system_property_get will be removed in
https://codereview.chromium.org/1236283002/.
BUG=392196, 392191
Review URL: https://codereview.chromium.org/1283543003
Cr-Commit-Position: refs/heads/master@{#343245}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in (patchset #1 id:1 of https://codereview.chromium.org/1281303002/ )
Reason for revert:
BUG=520301
Original issue's description:
> QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in
> QuicSentPacketManager::MaybeRetransmitTailLossProbe.
>
> BUG=517726
> R=rch@chromium.org
>
> Committed: https://crrev.com/22f7d9ae62bb4867579032e3cae46dbb5720a8ff
> Cr-Commit-Position: refs/heads/master@{#342694}
TBR=rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=517726
Review URL: https://codereview.chromium.org/1287363002
Cr-Commit-Position: refs/heads/master@{#343227}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only the source files are make using of the functions from this header,
and thus we don't need to include it from the header files.
Also remove a left-behind iosfwd include from create_listener.h.
BUG=None
R=rch@chromium.org
Review URL: https://codereview.chromium.org/1288813002
Cr-Commit-Position: refs/heads/master@{#343223}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Save alternative service expiration times as int64 in a string instead of
double in HttpServerPropertiesManager::SaveAlternativeServiceToServerPrefs(),
and load expiration time accordingly in
HttpServerPropertiesManager::ParseAlternativeServiceDict(). The reason is that
numeric_limits<int64>::max() can be serialized in JSON, whereas
numeric_limits<double>::max() cannot. That is, this change allows
base::Time::Max() expiration times. Note that JSON does not support int64, so
it has to be converted into a string.
This change might result in unexpected behavior on user installations where
alternative services were persisted to disk as double with earlier versions.
However, as https://crrev.com/1227063002 has not even made it to Beta yet,
this can be safely ignored.
BUG=516034
Review URL: https://codereview.chromium.org/1275663002
Cr-Commit-Position: refs/heads/master@{#343209}
|
|
|
|
|
|
|
|
|
| |
BUG=518717
TBR=agl@chromium.org
Review URL: https://codereview.chromium.org/1289923004
Cr-Commit-Position: refs/heads/master@{#343185}
|
|
|
|
|
|
|
|
|
|
|
| |
This is useful for clients that only wants to show CT
info if the certificate is not CT compliant.
BUG=None
Review URL: https://codereview.chromium.org/1287023003
Cr-Commit-Position: refs/heads/master@{#343170}
|
|
|
|
|
|
|
|
|
|
| |
These functions are re-used further in upcoming changelists.
BUG=410574
Review URL: https://codereview.chromium.org/1290553002
Cr-Commit-Position: refs/heads/master@{#343149}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
iOS has protected storage so encrypting cookies is not
necessary. It was done by mistake because I didn't
realize that iOS builds also defined OSX.
Also, fix an issue where failed OS encryption could
result in storing an unpredictable value. If it fails,
store nothing. Similarly, if decryption fails, ignore
the cookie.
BUG=517071
Review URL: https://codereview.chromium.org/1276493002
Cr-Commit-Position: refs/heads/master@{#343107}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use of the ternary operator in a void context is very concise, but not
necessarily readable.
Replace it with a boring, verbose if statement.
BUG=
TEST=net_unittests
Review URL: https://codereview.chromium.org/1283203003
Cr-Commit-Position: refs/heads/master@{#343083}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The name "BasicURLRequestContext" is misleading, as it is *more* than
just a URLRequestContext. Instead, it's a URLRequestContext with added
storage to contain owned-pointers to the context's components.
This rename better reflects that distinction.
BUG=none
Review URL: https://codereview.chromium.org/1273363006
Cr-Commit-Position: refs/heads/master@{#342984}
|
|
|
|
|
|
|
|
| |
TBR=zelidrag@chromium.org (chromeos)
Review URL: https://codereview.chromium.org/1284833004
Cr-Commit-Position: refs/heads/master@{#342983}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL processes report URIs in preloaded pins and removes special-case code
for reporting pin violations on Google properties
(FraudulentCertificateReporter and its implementation
ChromeFraudulentCertificateReporter), in favor of a preloaded report
URI.
BUG=445793
Review URL: https://codereview.chromium.org/1267383002
Cr-Commit-Position: refs/heads/master@{#342967}
|
|
|
|
|
|
|
|
|
|
|
| |
net/third_party/nss/ssl/sslmutex.c uses sem_init/sem_destroy that
are deprecated (not supported in fact) on iOS. Disable the warning.
BUG=459705
Review URL: https://codereview.chromium.org/1275403003
Cr-Commit-Position: refs/heads/master@{#342953}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make NetworkQuality private. Remove NetworkQuality from all
public APIs since we decided to have a separate Getter for
each metric.
Future CL will template the Observations/Estimates.
BUG=502415,519637
Committed: https://crrev.com/402963c809947a9a53983cadfcb91b63e3ac87e7
Cr-Commit-Position: refs/heads/master@{#342851}
Review URL: https://codereview.chromium.org/1277483004
Cr-Commit-Position: refs/heads/master@{#342913}
|
|
|
|
|
|
|
|
| |
This seems to not be used.
Review URL: https://codereview.chromium.org/1281483012
Cr-Commit-Position: refs/heads/master@{#342895}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1277483004/ )
Reason for revert:
Suspected in sizes failures
BUG=519637
Original issue's description:
> Cleanup NQE
>
> Make NetworkQuality private. Remove NetworkQuality from all
> public APIs since we decided to have a separate Getter for
> each metric.
>
> Future CL will template the Observations/Estimates.
>
> BUG=502415
>
> Committed: https://crrev.com/402963c809947a9a53983cadfcb91b63e3ac87e7
> Cr-Commit-Position: refs/heads/master@{#342851}
TBR=bengr@chromium.org,pauljensen@chromium.org,nyquist@chromium.org,tbansal@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=502415
Review URL: https://codereview.chromium.org/1277183004
Cr-Commit-Position: refs/heads/master@{#342874}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove StringToLowerASCII. This removes the template and makes a consistent call that can take a string piece.
http_response_headers.cc in HttpResponseHeaders::RemoveHeaderLine there seemed to be a bug where it did
std::string old_header_name_lowercase(name);
where it actually meant
std::string old_header_name_lowercase(old_header_name);
I fixed this.
There were a number of cases where url.host() or url.scheme() was passed to ToLowerASCII. These are already guaranteed lower-case, so I removed the call.
There were a number of cases in net that did return ToLowerASCII().c_str() when the return type is a std::string, which is unnecessary and wasteful. I removed the c_str() call.
NOPRESUBMIT=true
(for touching code with wstrings)
Review URL: https://codereview.chromium.org/1282363003
Cr-Commit-Position: refs/heads/master@{#342869}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a new SpdyStream::Delegate method to surface trailers to
Delegate's implementations. Before this CL, receiving trailers will trigger
a spdy protocol error. However, SpdyHttpStream does not implement
this delegate method as of this CL, so trailers are ignored.
BUG=481033
Review URL: https://codereview.chromium.org/1272283003
Cr-Commit-Position: refs/heads/master@{#342859}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make NetworkQuality private. Remove NetworkQuality from all
public APIs since we decided to have a separate Getter for
each metric.
Future CL will template the Observations/Estimates.
BUG=502415
Review URL: https://codereview.chromium.org/1277483004
Cr-Commit-Position: refs/heads/master@{#342851}
|
|
|
|
|
|
|
|
| |
BUG=472381
Review URL: https://codereview.chromium.org/1280973004
Cr-Commit-Position: refs/heads/master@{#342791}
|
|
|
|
|
|
|
|
| |
BUG=410574
Review URL: https://codereview.chromium.org/1125333005
Cr-Commit-Position: refs/heads/master@{#342750}
|
|
|
|
|
|
|
|
| |
BUG=518073,518079
Review URL: https://codereview.chromium.org/1278243002
Cr-Commit-Position: refs/heads/master@{#342736}
|
|
|
|
|
|
|
|
|
|
|
| |
QuicSentPacketManager::MaybeRetransmitTailLossProbe.
BUG=517726
R=rch@chromium.org
Review URL: https://codereview.chromium.org/1281303002
Cr-Commit-Position: refs/heads/master@{#342694}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates to the now-canonical upstream Github repository at
https://github.com/publicsuffix/list
This updates to the following revision:
3c153e3947dd6ee130c3f8706955281fa9923ed4 (2015-08-07)
R=pkasting@chromium.org
BUG=37436
Review URL: https://codereview.chromium.org/1283593002
Cr-Commit-Position: refs/heads/master@{#342691}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add QuicClient and QuicTestClient support for stateless rejects.
QuicClient:
If the client receives a stateless reject, it will now re-try the
entire request with a new connection, since presumably any data sent
on the previous connection has been abandoned.
The method for getting a new ConnectionId has also been modified to
take in the server's id, which is necessary for stateless-rejects.
Add separate accounting for num hellos sent, since the underlying
connection may change during a stateless reject.
EndToEndTest:
Modified the end_to_end_test to exercise the new code.
Added a new end_to_end_test to exercise the 0-RTT QuicTestClient
synchronous request methodology. Otherwise, it could easily drift
away from supporting stateless-rejects without anyone's knowledge.
QuicTestClient:
Refactored the synchronous request methodology to share code with the
synchronous "custom" request methodology.
Merge internal change: 99562314
R=rch@chromium.org
Review URL: https://codereview.chromium.org/1278293002
Cr-Commit-Position: refs/heads/master@{#342684}
|
|
|
|
|
|
|
|
|
|
|
| |
Fix some header guards and removed an unused file.
BUG=none
R=rch@chromium.org
Review URL: https://codereview.chromium.org/1280363002
Cr-Commit-Position: refs/heads/master@{#342681}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a README.md for Cronet. It also generates a html
file from the markdown file, and includes the html file as
the overview page in the javadoc.
BUG=428935
Review URL: https://codereview.chromium.org/1180733003
Cr-Commit-Position: refs/heads/master@{#342663}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notify NQE when the request finishes so NQE can keep track of which
requests are active. This would be used in throughput computation
in a later changelist. Also, change the existing notification to
notify NQE only when the headers are received (instead of on
every raw read).
BUG=502430
Review URL: https://codereview.chromium.org/1247723005
Cr-Commit-Position: refs/heads/master@{#342656}
|
|
|
|
|
|
|
|
|
|
|
| |
HTTP/0.9 over SSL, HTTP/0.9 on a socket previously used
to receive HTTP/1.x responses.
BUG=472762
Review URL: https://codereview.chromium.org/1281523007
Cr-Commit-Position: refs/heads/master@{#342631}
|
|
|
|
|
|
|
|
|
|
| |
This CL lands server change 99395244 by rjshade.
BUG=345769
Review URL: https://codereview.chromium.org/1265413003
Cr-Commit-Position: refs/heads/master@{#342625}
|
|
|
|
|
|
|
|
|
|
| |
Check that the list of files build with gn and gyp are the same.
BUG=BUG=459705
Review URL: https://codereview.chromium.org/1272193002
Cr-Commit-Position: refs/heads/master@{#342592}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change should be a no-op as it just regenerates the HSTS data in
light of [1]. This causes empty report URIs to be added to each pinset.
[1] https://github.com/agl/transport-security-state-generate/commit/4ab5faf44f8cc090525b3609dab698064b77154d.
BUG=445793
Review URL: https://codereview.chromium.org/1282003004
Cr-Commit-Position: refs/heads/master@{#342497}
|
|
|
|
|
|
|
|
| |
R=rtenneti@chromium.org
Review URL: https://codereview.chromium.org/1282573002
Cr-Commit-Position: refs/heads/master@{#342480}
|
|
|
|
|
|
|
|
|
|
| |
This also includes:
∙ A manual addition of “zachborboa.com”
∙ Removal of “keycom.co.uk” – see bug.
BUG=517848
Cr-Commit-Position: refs/heads/master@{#342456}
|
|
|
|
|
|
|
|
| |
BUG=508900
Review URL: https://codereview.chromium.org/1275413002
Cr-Commit-Position: refs/heads/master@{#342452}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds URLRequest unit tests for sending HPKP violation
reports. The tests check that HPKP reports are sent when a URLRequest
violates a previously set pin, and that reports are sent when a
URLRequest violates the pins in a PKP-Report-Only header on that
request.
This is based on top of crrev.com/1266723003
BUG=445793
Review URL: https://codereview.chromium.org/1270043004
Cr-Commit-Position: refs/heads/master@{#342450}
|
|
|
|
|
|
|
|
|
|
| |
Various clean-ups and style fixes for certificate reporting classes and tests.
BUG=
Review URL: https://codereview.chromium.org/1210053006
Cr-Commit-Position: refs/heads/master@{#342449}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net::FormatUrl and related are specifically concerned with display
policies of URLs, which is not something that //net needs to be aware
of, as that's a UX question.
This folds in net::FormatURL along with the existing //components/url_fixer
and //components/secure_display into a common component,
//components/url_formatter, that handles reformatting URLs for user-friendly
or data storage (url_formatter), for use in security prompts (elide_url),
or for reformatting URLs from user input (url_fixer)
(Disabling presubmit since this is intentionally not fixing a legacy API, just moving it for future cleanups)
BUG=486979
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1171333003
Cr-Commit-Position: refs/heads/master@{#342445}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no need/reason for it to be protected. This is a scope class, it
is not meant to be inherited, and thus this variable is not meant to be
externally accessible.
BUG=None
R=rch@chromium.org
Review URL: https://codereview.chromium.org/1279963002
Cr-Commit-Position: refs/heads/master@{#342444}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Soon SpdyHeaderBlock will become a LinkedHashMap which does not have
operator== defined, and it doesn't look likely that it will gain such an
implementation (if cl/98825772 does get submitted, I'll revert this CL).
No behavior change.
relnote: n/a (test only)
Merge internal change: 99406076
R=rch@chromium.org
Review URL: https://codereview.chromium.org/1281763002
Cr-Commit-Position: refs/heads/master@{#342397}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in https://codereview.chromium.org/1273813005/. The CL is unchanged,
except the DCHECKs that uncovered another bug have been removed. They'll
be added back once that bug is fixed.
Fix cancellation of a pair of URLRequestJob subclasses.
URLRequestSimpleJob and URLRequestChromeJob can call back into their
parent URLRequestJob class after Kill() has been invoked, which can
cause Bad Things.
Longer term, we should think about the interface between URLRequestJob
and its subclasses, to see if we can create a more robust interface.
BUG=508900
Committed: https://crrev.com/363ce98af274c07f43acac74b7ca7c23641c996e
Cr-Commit-Position: refs/heads/master@{#342211}
Review URL: https://codereview.chromium.org/1281943002
Cr-Commit-Position: refs/heads/master@{#342390}
|
|
|
|
|
|
|
|
|
|
|
| |
This allows an MITM to make the firs byte of a valid HTTP/1.x response
look like a valid HTTP/0.9 reponses, so best to be safe.
BUG=517106
Review URL: https://codereview.chromium.org/1276943003
Cr-Commit-Position: refs/heads/master@{#342365}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable FLAGS_quic_require_handshake_confirmation for ZeroRTT test.
relnote: Adding FLAGS_require_handshake_confirmation to emergency-disable
QUIC 0-rtt
Adding a reloadable flag to allow quickly disabling QUIC's 0-rtt
handshake as an interim measure (0-rtt DoS protection) to allow
StrikeServer turndown before full DoSServer integration. See b/20122788
Merge internal change: 99600488
https://codereview.chromium.org/1272153006/
relnote: Deprecate FLAGS_quic_send_fec_packet_only_on_fec_alarm.
Merge internal change: 99599597
https://codereview.chromium.org/1279433004/
relnote: Limit the number of burst tokens in QUIC's pacing sender to the
min of 10 and the current CWND in packets.
Protected by FLAGS_quic_limit_pacing_burst.
Should decrease retransmit rate for low CWND flows.
Merge internal change: 99597412
https://codereview.chromium.org/1276983003/
Preparation for changing SpdyHeaderBlock to be ordered. This just reduces
the number of files in upcoming CL by 2. No behavior change as these are
currently entries into a map, and the key:value pairs haven't changed.
However after changing to ordered SpdyHeaderBlock, the pseudo-header
order of authority,path,scheme,method is what ends up getting written,
and thus I'm changing the order here in advance.
relnote: n/a (test only)
Merge internal change: 99394725
https://codereview.chromium.org/1281463002/
relnote: Close QUIC connections due to too many open streams earlier in
processing. No significant behavior change. Flag-protected by enabled
FLAGS_exact_stream_id_delta.
Replace the "maximum delta in stream ID" test on a newly-created stream
with an exact test for the max number of open streams. Change the error
in this case from QUIC_INVALID_STREAM_ID to QUIC_TOO_MANY_OPEN_STREAMS.
FIXED=22477228
Merge internal change: 99369742
https://codereview.chromium.org/1277753002/
relnote: Minor format changes to keep the code similar to internal source.
Merge internal change: 99250353
https://codereview.chromium.org/1274003002/
relnote: Change the QuicStreamSequencer to call OnDataAvailable instead
of OnFinRead when the fin is consumed.
Make ReliableQuicStream::OnFinRead() non-virtual and remove overrides in
subclasses.
Merge internal change: 99214926
https://codereview.chromium.org/1261273003/
R=rch@chromium.org
Review URL: https://codereview.chromium.org/1277723003
Cr-Commit-Position: refs/heads/master@{#342349}
|
|
|
|
|
|
|
|
| |
BUG=514575
Review URL: https://codereview.chromium.org/1275853003
Cr-Commit-Position: refs/heads/master@{#342337}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows controlling:
* What RSA key sizes are accepted
* What digest algorithms are accepted
* What ellipitc curves are accepted
This policy is expressed through a separate interface. I expect this interface will morph into something more generic for certificate verifying.
BUG=410574
Review URL: https://codereview.chromium.org/1259313002
Cr-Commit-Position: refs/heads/master@{#342292}
|