| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
boolean flag.
This is just prep work for a large CL that rewrites the JSON parser. Splitting
out this interface change will make it easier to review the other CL.
BUG=121469
TEST=No functional change.
Review URL: https://chromiumcodereview.appspot.com/9960077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change causes NSS only to False Start with NPN capable servers. It also
removes the False Start blacklist and this has the effect of enabling 1/n-1
record splitting for those hosts that were previously on the blacklist.
However, those hosts have been getting 1/n-1 from Opera, Firefox and IE for a
few months now.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/10014010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lower layer pools to higher layer pool.
Revert 10006036 - Revert 130129 - Revert 129034 - Revert 127893 - Revert 127730 - Revert 127717 - Revert 118788 - Revert 113405 - Revert 113305 - Revert 113300 - Revert 112134 - Revert 112130 - Close idle connections / SPDY sessions when needed
Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.
Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket.
Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob
ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).
Added NET_EXPORT for layered_pool class defintion to fix windows shared compile.
BUG=62364, 92244, 109876, 110368, 119847
TEST=
Review URL: http://codereview.chromium.org/10026024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
be changed without affecting persisted values.
BUG=121967
TEST=HttpServerPropertiesManagerTest.*
Review URL: http://codereview.chromium.org/10006047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I plan to use this to assert to slowly flush out the leaks in tests
and then with the production code (testing with canary channel). I'll
start with the system request context and then move into the less popular
profile-owned request contexts, and then do the main one last.
BUG=90971
TEST=none
Review URL: http://codereview.chromium.org/10020021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The actual URLRequestContext used by the Chromium embedder here is the "proxy
script fetcher" URLRequestContext. It is owned by the browser process's
IOThread. Therefore, there's no need to refcount it within objects owned by
the ProxyService of that URLRequestContext.
BUG=58859
TEST=none
Review URL: http://codereview.chromium.org/10024019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=memory bots are happy bots
Review URL: https://chromiumcodereview.appspot.com/10014016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
calling OS API routines for certificate verification. This
allows tests that depend on SSL to cycle noticably faster,
particularly when under memory instrumentation.
R=wtc
BUG=none
TEST=existing unittests
Review URL: http://codereview.chromium.org/9956047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=121919
Review URL: http://codereview.chromium.org/10005041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=agl@chromium.org
BUG=108171
Review URL: http://codereview.chromium.org/10029001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will revert this change after canary push with this change.
BUG=121971
R=eroman
TEST=network unit tests browser unit tests.
Review URL: http://codereview.chromium.org/10025002
TBR=rtenneti@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10028003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some routers black-hole resolutions beyond 6 in
parallel, and this should avoid the problem until
we craft a more adaptive implementation.
r=eroman
bug=122529
Review URL: http://codereview.chromium.org/10025005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=120976
TEST=./net_unittests --gtest_filter=DnsTransactionTest.Sync*
Review URL: https://chromiumcodereview.appspot.com/9958082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will revert this change after canary push with this change.
BUG=121971
R=eroman
TEST=network unit tests browser unit tests.
Review URL: http://codereview.chromium.org/10025002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
about:net-internals.
R=eroman@chromium.org
BUG=none
Review URL: http://codereview.chromium.org/10012041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107056
TEST=browse with --enable-origin-bound-certs, go to site data, look at certs, try deleting them
Review URL: https://chromiumcodereview.appspot.com/9860025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
easier debugging.
R=simonjam@chromium.org
BUG=122347
Review URL: http://codereview.chromium.org/10009043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 130129 - Revert 129034 - Revert 127893 - Revert 127730 - Revert 127717 - Revert 118788 - Revert 113405 - Revert 113305 - Revert 113300 - Revert 112134 - Revert 112130 - Close idle connections / SPDY sessions when needed
Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.
Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket.
Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob
ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).
Added NET_EXPORT for layered_pool class defintion to fix windows shared compile.
BUG=62364, 92244, 109876, 110368, 119847
TEST=
Review URL: http://codereview.chromium.org/9861032
TBR=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10006036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add code in URLRequestContext to CHECK in its destructor to make sure there are no references. This is sort of pointless right now because URLRequest holds a scoped_refptr<URLRequestContext>. My plan is to probe on canary channel with killing that off, and debugging crash reports until I've fixed the last leaks.
BUG=58859
TEST=none
Review URL: http://codereview.chromium.org/10006009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code used to be part of Chrome OS bug 8285 but these days
Chrome OS relies on CrosNetworkChangeNotifierFactory rather
than NetworkChangeNotifierLinux.
BUG=chromium-os:8285
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10012006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
callback.
R=eroman@chromium.org
BUG=83561
TEST=tools/valgrind/chrome_tests.sh -t net --gtest_filter=HostResolverImplTest.DeleteWithinAbortedCallback
Review URL: http://codereview.chromium.org/10012030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://code.google.com/p/chromium/source/search?q=back_inserter+-%23include%5C+%5C%3Citerator%5C%3E&origq=back_inserter+-%23include%5C+%5C%3Citerator%5C%3E&btnG=Search+Trunk
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/9969147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=112155
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9965019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A SPDY proxy that is trusted explicitly should still not be able
to push HTTPS content.
BUG=113427
TEST=
Review URL: http://codereview.chromium.org/9968055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9959139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=121153
TEST=X509CertificateTest.ParseSubjectAltName
R=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9950065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The result of transactions with synchronous completions might be wrong until
bug 121717 is fixed.
BUG=120976
Review URL: https://chromiumcodereview.appspot.com/9950102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
them by default, and do that in Chrome
BUG=none
TEST=existing tests shouldn't break
Review URL: https://chromiumcodereview.appspot.com/9865018
TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9956142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and do that in Chrome
BUG=none
TEST=existing tests shouldn't break
Review URL: https://chromiumcodereview.appspot.com/9865018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9958122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Properly handle spdy3 to SPDY proxies.
BUG=120890
TEST=Run chrome with --enable-spdy3 and visit a spdy3 server
Review URL: https://chromiumcodereview.appspot.com/9958023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/9934004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of these suppressed tests no longer exist or were renamed. They
have not been failing since they were renamed, so it should be fine.
Additionally, in the case of the CertVerifier tests, these tests now
use a mock stub for testing caching behaviour, and thus no longer
block dependent on the system libraries.
R=wtc
BUG=117372, 67599
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/9965036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=114343
TEST=none
R=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9969064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
subclasses.
BUG=120890
Review URL: https://chromiumcodereview.appspot.com/9958028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
build into the right state.
TBR=pfeldman
Review URL: https://chromiumcodereview.appspot.com/9956101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thanks to all my reviewers, you are legion. I hope I didn't waste too
much of your time.
BUG=None
Review URL: http://codereview.chromium.org/9854039
Review URL: http://codereview.chromium.org/9854043
Review URL: http://codereview.chromium.org/9863058
Review URL: http://codereview.chromium.org/9863059
Review URL: http://codereview.chromium.org/9887005
Review URL: http://codereview.chromium.org/9890002
Review URL: http://codereview.chromium.org/9891002
Review URL: http://codereview.chromium.org/9895003
Review URL: http://codereview.chromium.org/9896002
Review URL: http://codereview.chromium.org/9896003
Review URL: http://codereview.chromium.org/9897002
Review URL: http://codereview.chromium.org/9897003
Review URL: http://codereview.chromium.org/9903004
Review URL: http://codereview.chromium.org/9904003
Review URL: http://codereview.chromium.org/9904002
Review URL: http://codereview.chromium.org/9904004
Review URL: http://codereview.chromium.org/9906002
Review URL: http://codereview.chromium.org/9906001
Review URL: http://codereview.chromium.org/9906003
Review URL: http://codereview.chromium.org/9909001
Review URL: http://codereview.chromium.org/9909002
Review URL: http://codereview.chromium.org/9909003
Review URL: http://codereview.chromium.org/9909004
Review URL: http://codereview.chromium.org/9910001
Review URL: http://codereview.chromium.org/9910002
Review URL: http://codereview.chromium.org/9910010
Review URL: http://codereview.chromium.org/9911001
Review URL: http://codereview.chromium.org/9912001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r117969.
BUG=121623
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change will make it possible for Chromium to accept a resource
that is pushed by a SPDY proxy, even if the SYN control frame advertises
a URL whose origin is different from its associated request. The advantage
of this change is, potentially, better performance. This change is disabled
by default and activated by a new switch.
BUG=113427
TEST=
Review URL: http://codereview.chromium.org/9475037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=114484
TEST=existing filesystem tests don't break
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128753
Review URL: https://chromiumcodereview.appspot.com/7811006
TBR=ericu@google.com
Review URL: https://chromiumcodereview.appspot.com/9950079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SplitString() should return an empty vector, not a vector of one empty string.
Brett and I discussed this for a while and felt this would be wise, whereas dropping all empty segments entirely (e.g. converting "a,,b" to a vector of two elements instead of three) was probably unwise.
This also simplifies the code some.
Fixing this also required changing the code in mime_util.cc to handle empty vectors to "are codecs valid" oracle functions (in which case we return false). I also fixed some style issues there. It also required avoiding passing the empty string in a test in extension_api_unittest.cc; Aaron assures me that this code is not expected to be defensive against such inputs, but at his suggestion I also added some CHECK()s to the API.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9958076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=114484
TEST=existing filesystem tests don't break
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128753
Review URL: https://chromiumcodereview.appspot.com/7811006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r123482.
BUG=121482
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use-after-free.
Revert 129034 - Revert 127893 - Revert 127730 - Revert 127717 - Revert 118788 - Revert 113405 - Revert 113305 - Revert 113300 - Revert 112134 - Revert 112130 - Close idle connections / SPDY sessions when needed
Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.
Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket.
Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob
ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).
Added NET_EXPORT for layered_pool class defintion to fix windows shared compile.
BUG=62364, 92244, 109876, 110368, 119847
TEST=
Review URL: http://codereview.chromium.org/9861032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=rsleevi@chromium.org
BUG=120938
TEST=none
Review URL: http://codereview.chromium.org/9958008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=120890
Review URL: http://codereview.chromium.org/9959033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: https://chromiumcodereview.appspot.com/9960002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pkasting@chromium.org, scherkus@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9950039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TCPServerSocket worked properly before, but then it was broken by r112863.
Review URL: https://chromiumcodereview.appspot.com/9837122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
return an empty vector, not a vector of one empty string.
Brett and I discussed this for a while and felt this would be wise, whereas dropping all empty segments entirely (e.g. converting "a,,b" to a vector of two elements instead of three) was probably unwise.
This also simplifies the code some.
Fixing this also required changing the code in mime_util.cc to handle empty vectors to "are codecs valid" oracle functions (in which case we return false). I also fixed some style issues there. It also required avoiding passing the empty string in a test in extension_api_unittest.cc; Aaron assures me that this code is not expected to be defensive against such inputs, but at his suggestion I also added some CHECK()s to the API.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9960004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129998 0039d316-1c4b-4281-b951-d872f2087c98
|