summaryrefslogtreecommitdiffstats
path: root/net
Commit message (Collapse)AuthorAgeFilesLines
* Add a fallback socket connect() for IPv6.willchan@chromium.org2011-05-123-27/+374
| | | | | | | | | | | | | | | | | | When a hostname has both IPv6 and IPv4 addresses, and the IPv6 address is listed first, we start a timer (300ms) (deliberately chosen to be different from the backup connect job). If the timer fires, that means the IPv6 connect() hasn't completed yet, and we start a second socket connect() where we give it the same AddressList, except we move all IPv6 addresses that are in front of the first IPv4 address to the end. That way, we will use the first IPv4 address. We will race these two connect()s and pass the first one to complete to ConnectJob::set_socket(). Adds 4 new TCP connection latency histograms to assess the new behavior: IPv6 raceable (includes both when it races and doesn't, which are distinguished by whether or not the samples exceed the race timeout of 300ms) IPv6 solo (no IPv4 addresses to race against) IPv4 no race (IPv4 is the first address, so we're not racing) IPv4 wins race (IPv4 raced and won, even though it started behind). BUG=81686 TEST=On Linux, drop ip6 packets via `sudo ip6tables -A OUTPUT -p tcp -j DROP`. Then test against a site with both IPv6 and IPv4 addresses (such as www.ripe.net). It should load without hitting 20s connect() timeouts on the IPv6 addresses. Review URL: http://codereview.chromium.org/6969028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85188 0039d316-1c4b-4281-b951-d872f2087c98
* Tolerate extra whitespace in header parametersasanka@chromium.org2011-05-122-1/+21
| | | | | | | | | BUG=69939 TEST=net_unittests --gtest_filter=NetUtilTest.GetSuggestedFilename Review URL: http://codereview.chromium.org/7005003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85164 0039d316-1c4b-4281-b951-d872f2087c98
* Fix net_perftestsjoth@chromium.org2011-05-121-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this, I am reliably getting the following crash. It looks like the timer may fire (in the nested MessageLoop run call inside TestCompletionCallback::WaitForResult) before the expected num_callbacks_ gets set. [ RUN ] DiskCacheTest.CacheBackendPerformance [18893:18893:0511/165403:1994535049146:FATAL:disk_cache_test_util.cc(174)] Check failed: false. Backtrace: base::debug::StackTrace::StackTrace() [0x4ed37e] logging::LogMessage::~LogMessage() [0x4fdd12] MessageLoopHelper::TimerExpired() [0x4d2589] DispatchToMethod<>() [0x4d2b42] base::BaseTimer<>::TimerTask::Run() [0x4d29d2] (anonymous namespace)::TaskClosureAdapter::Run() [0x4ffac9] base::internal::Invoker1<>::DoInvoke() [0x503624] base::Callback<>::Run() [0x504799] MessageLoop::RunTask() [0x50241c] MessageLoop::DeferOrRunPendingTask() [0x502553] MessageLoop::DoDelayedWork() [0x502f49] base::MessagePumpLibevent::Run() [0x4d9e8b] MessageLoop::RunInternal() [0x50222b] MessageLoop::RunHandler() [0x5020de] MessageLoop::Run() [0x501af9] TestCompletionCallback::WaitForResult() [0x4d1681] TestCompletionCallback::GetResult() [0x4d16e6] (anonymous namespace)::TimeWrite() [0x4136cc] DiskCacheTest_CacheBackendPerformance_Test::TestBody() [0x41407b] testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x588785] testing::internal::HandleExceptionsInMethodIfSupported<>() [0x585206] testing::Test::Run() [0x579066] testing::TestInfo::Run() [0x57988a] testing::TestCase::Run() [0x579f80] testing::internal::UnitTestImpl::RunAllTests() [0x57ed57] BUG=None TEST=net_perftests Review URL: http://codereview.chromium.org/7001028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85139 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of net::CookiePolicy, now that all code that uses it (except ↵jam@chromium.org2011-05-1214-192/+74
| | | | | | | | | WebSocketJob, which appears to be unused and which I updated in this cl) is switched over to use ContentBrowserClient. BUG=76793 Review URL: http://codereview.chromium.org/6973011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85136 0039d316-1c4b-4281-b951-d872f2087c98
* Code formatting.qsr@google.com2011-05-121-4/+5
| | | | | | | | | | | | | Reformat function call for consistency. Move typedef definition into the scope of the only function using it. BUG=none TEST=none Review URL: http://codereview.chromium.org/7003023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85116 0039d316-1c4b-4281-b951-d872f2087c98
* Miscelaneous cleanups to AddressList to make it harder to mis-use.eroman@chromium.org2011-05-1221-161/+227
| | | | | | | | | | | | | | - Removed all destructive non-const member functions -- these were dangerous since if you called them without first making a copy of the AddressList, it could mutate earlier copies. - Made AddressList::Data::head const, so new code added to AddressList cannot inadvertently introduce such dangerous mutations (won't compile). - Moved the non-trivial constructors and assign methods into factory methods (for added readability) - Removed the bool parameter from Copy (for added readability). Review URL: http://codereview.chromium.org/6880302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85090 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Include stringprintf.h where appropriate, part 3.jhawkins@chromium.org2011-05-124-10/+12
| | | | | | | | | | | BUG=82098 TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/7016011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85088 0039d316-1c4b-4281-b951-d872f2087c98
* Remove prefer_ipv4.wtc@chromium.org2011-05-123-19/+0
| | | | | | | | | | | | Do not make a ConnectBackupJob prefer IPv4. We will hide the long IPv6 connect timeout on broken IPv6 networks in a different way. R=willchan@chromium.org BUG=81686 TEST=none Review URL: http://codereview.chromium.org/6969025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85083 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r85014 because it doesn't work fully and we're doing something else.willchan@chromium.org2011-05-123-61/+8
| | | | | | | | | | | | | | | | | | ===== Restart socket pool backup job timer on ReleaseSocket. This is a temporary hack while we pursue longer term solutions that will require bigger changes. BUG=81686 TEST=none Review URL: http://codereview.chromium.org/7002016 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6973022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85080 0039d316-1c4b-4281-b951-d872f2087c98
* The flip server's --http-server and --spdy-server switches for don't functionleighton@cis.udel.edu2011-05-111-1/+5
| | | | | | | | | | | | | | as advertised. If the ssl cert and key fields are left empty to disable ssl, flip_in_mem_edsm_server will segfault. For these switches, the split function is expected to return a std::vector of size 4, but leaving the ssl cert and key fields empty results in a std::vector of size 2. BUG=NONE TEST=none Review URL: http://codereview.chromium.org/6949002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85023 0039d316-1c4b-4281-b951-d872f2087c98
* Restart socket pool backup job timer on ReleaseSocket.willchan@chromium.org2011-05-113-8/+61
| | | | | | | | | | | This is a temporary hack while we pursue longer term solutions that will require bigger changes. BUG=81686 TEST=none Review URL: http://codereview.chromium.org/7002016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85014 0039d316-1c4b-4281-b951-d872f2087c98
* Updating logging in src/net/disk_cache/. Using DCHECK_NE/EQ/GT/GE/LT/LE() ↵kushi.p@gmail.com2011-05-118-23/+23
| | | | | | | | | | | where possible BUG=58409 Review URL: http://codereview.chromium.org/6966001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84966 0039d316-1c4b-4281-b951-d872f2087c98
* Use const operator to enable compilation with stlport.jknotten@chromium.org2011-05-111-2/+2
| | | | | | | | | | | | This is required if you want to use the user configuration _STLP_USE_PTR_SPECIALIZATIONS=1 for template bloat reduction. BUG=None TEST=None Review URL: http://codereview.chromium.org/6995025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84956 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of 83710 which reverted 83641 - DNS Host resolver changesrtenneti@chromium.org2011-05-113-48/+388
| | | | | | | | | | | | | | | | | with retry logic. Fix for bug Chromium cannot recover from a state when its DNS requests have been dropped. Whenever we try to resolve the host, we post a delayed task to check if host resolution (OnLookupComplete) is completed or not. If it hasn't completed, then we start a new job to resolve for the same request. BUG=73327 TEST=dns host resolver tests R=eroman,jar Review URL: http://codereview.chromium.org/6976006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84908 0039d316-1c4b-4281-b951-d872f2087c98
* Add a final few pin hosts to the HSTS metadata.cevans@chromium.org2011-05-102-0/+29
| | | | | | | TEST=TransportSecurityStateTest.* Review URL: http://codereview.chromium.org/6996001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84885 0039d316-1c4b-4281-b951-d872f2087c98
* More progress towards removing content settings code from the content layer. ↵jam@chromium.org2011-05-108-191/+112
| | | | | | | | | We can't use CookiePolicy anymore since, being in the network layer, we can't give it render_process_id/render_view_id, which are needed to put up the content settings UI. Instead of the networking code calling CookiePolicy then calling the delegate (ResourceDispatcherHost) to inform it if something is blocked, we directly ask the delegate if something is allowed. ResourceDispatcherHost then calls the embedder, and passes along the IDs to identify the tab. In the next change, I'll use this mechansim in RenderMessageFilter and remove the CookiePolicy class. BUG=76793 Review URL: http://codereview.chromium.org/6995013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84881 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Make sure the list of unused entries is notrvargas@google.com2011-05-104-22/+56
| | | | | | | | | | | depleted if we are not reaching the time targets for any of the lists. BUG=79491 TEST=netunittests Review URL: http://codereview.chromium.org/6967006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84877 0039d316-1c4b-4281-b951-d872f2087c98
* Add one-time randomization support for FieldTrial, and the ability tojoi@chromium.org2011-05-107-26/+17
| | | | | | | | | | | | | | | | | | | | | | | disable field trials. I am going to have a need for both soon. Update some documentation about empty trial names, add TrialExists() method and update many call-sites to use this (it simplifies the previous logic which checked for existence and then for non-empty name, which can no longer happen). Refactor a bit in browser_main. While I'm in there and needing base/OWNERS approval, add an OWNERS file for base/metrics that adds jar@chromium.org as an owner for that directory. Initially committed as r84197. Rolled back due to DCHECK in official builds, r84373. Will re-submit with fix. BUG=81750 TEST=base_unittests Review URL: http://codereview.chromium.org/6883102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84801 0039d316-1c4b-4281-b951-d872f2087c98
* Reformating functions calls.qsr@google.com2011-05-101-1/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6966011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84760 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Include stringprintf.h where appropriate, part 1.jhawkins@chromium.org2011-05-106-2/+6
| | | | | | | | | | | BUG=82098 TEST=none R=thakis@chromium.org Review URL: http://codereview.chromium.org/6997006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84754 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Use callback_old.h where appropriate, part 2.jhawkins@chromium.org2011-05-102-2/+4
| | | | | | | | | | | BUG=none TEST=none R=thakis@chromium.org Review URL: http://codereview.chromium.org/6995007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84753 0039d316-1c4b-4281-b951-d872f2087c98
* Start backup socket timer for preconnects too.willchan@chromium.org2011-05-102-5/+57
| | | | | | | | | | | | This is important because entering URLs into the omnibox will trigger preconnects. BUG=81686 TEST=none Review URL: http://codereview.chromium.org/6985008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84746 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: call WatchFileDescriptor on the file thread to monitor KDE proxy ↵mdm@chromium.org2011-05-103-44/+81
| | | | | | | | | | settings. BUG=81405 Review URL: http://codereview.chromium.org/6954011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84743 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Use callback_old.h where appropriate, part 1.jhawkins@chromium.org2011-05-101-1/+1
| | | | | | | | | | | BUG=none TEST=none R=thakis@chromium.org Review URL: http://codereview.chromium.org/6985009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84725 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GeoTrust; leaving Equifax for now as discussed by chat.cevans@chromium.org2011-05-091-3/+0
| | | | | | | TBR=agl@chromium.org Review URL: http://codereview.chromium.org/6981009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84698 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that the built-in pins for *.google.com don't prevent non-built-incevans@chromium.org2011-05-092-14/+31
| | | | | | | | | subdomains from turning on mode="strict" HSTS. TEST=TransportSecurityStateTest.OverrideBuiltins Review URL: http://codereview.chromium.org/6965001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84659 0039d316-1c4b-4281-b951-d872f2087c98
* net: fix matching ".google.com" at the end of a string.agl@chromium.org2011-05-092-2/+4
| | | | | | | | | BUG=none TEST=none http://codereview.chromium.org/6975002/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84630 0039d316-1c4b-4281-b951-d872f2087c98
* net: break out SSLHostInfo verification time for Google.agl@chromium.org2011-05-091-1/+6
| | | | | | | | | | | | | The SSL host info verification time is the amount of time that a verification took, as opposed to SSLCertVerificationTime, which is the amount of time that we blocked on verification. BUG=none TEST=none http://codereview.chromium.org/6929044/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84613 0039d316-1c4b-4281-b951-d872f2087c98
* Documentation for ProxyResolverErrorObserverjochen@chromium.org2011-05-091-1/+7
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6932065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84611 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command-line flag for MAC cookies.abarth@chromium.org2011-05-082-1/+16
| | | | | | | | | Currently, this flag isn't wired up to anything yet. That will come in http://codereview.chromium.org/6901147/. Review URL: http://codereview.chromium.org/6953012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84591 0039d316-1c4b-4281-b951-d872f2087c98
* disk cache: Add NET_API for net.dllrvargas@google.com2011-05-071-7/+11
| | | | | | | | | BUG=76997 TEST=NONE TBR=wtc Review URL: http://codereview.chromium.org/6951014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84536 0039d316-1c4b-4281-b951-d872f2087c98
* disk cache: Add NET_API for net.dllrvargas@google.com2011-05-0715-46/+60
| | | | | | | | BUG=76997 TEST=NONE Review URL: http://codereview.chromium.org/6933045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84532 0039d316-1c4b-4281-b951-d872f2087c98
* Add requested documentation.abarth@chromium.org2011-05-061-0/+7
| | | | | | Review URL: http://codereview.chromium.org/6927074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84493 0039d316-1c4b-4281-b951-d872f2087c98
* net/url_request/url_request_test_util.h doesn't need to includewtc@chromium.org2011-05-062-1/+1
| | | | | | | | | | | | "net/test/test_server.h" because it doesn't use the TestServer type. R=eroman@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6929003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84487 0039d316-1c4b-4281-b951-d872f2087c98
* Accept new WebSocket handshake format (hybi-04 and later).yutak@chromium.org2011-05-064-57/+553
| | | | | | | | | | | | | | | To update WebSocket protocol implementation in WebKit, WebSocketRequestHandshakeHandler and WebSocketResponseHandler need to be able to understand both old handshake (hybi-03 and prior, including hixie-76) and new handshake (hybi-04 and later). BUG=64470 TEST=net_unittests --gtest_filter="WebSocketHandshake*HandlerTest.*" Review URL: http://codereview.chromium.org/6823075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84427 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented unit tests for ProxyService and fixed a bugbattre@chromium.org2011-05-063-2/+247
| | | | | | | | | BUG=81368 TEST=execute net_unittests --gtest_filter='ProxyServiceTest.*' Review URL: http://codereview.chromium.org/6932041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84422 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: split the directory listing parser test and re-enable it on TSan botsphajdan.jr@chromium.org2011-05-062-142/+185
| | | | | | | | | | | | | | The test was disabled on TSan bots becuase it was taking too much time. This change converts one huge test which parses ~30 directory listings to ~30 separate test cases. This change also moves ToLower/ToUpper from ui/base/l10n_util to base/i18n/case_conversion so that they can be used in net/ftp. BUG=79022 Review URL: http://codereview.chromium.org/6905027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84413 0039d316-1c4b-4281-b951-d872f2087c98
* GetPeerAddress could be called without socket, added checkdpolukhin@chromium.org2011-05-061-0/+6
| | | | | | | | | | | From crash it is clear that GetPeerAddress was called with NULL socket. Perhaps it should never happen, I don't know this code. So I fixed obvious root of the crash but real issue can be deeper. BUG=chromium-os:14877 TEST=compile Review URL: http://codereview.chromium.org/6933027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84406 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move ResponseCookies into the net namespace.tfarina@chromium.org2011-05-061-5/+5
| | | | | | | | | | | BUG=81612 TEST=None R=wtc@chromium.org,willchan@chromium.org Review URL: http://codereview.chromium.org/6932025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84375 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84197 - Add one-time randomization support for FieldTrial, and the ↵joi@chromium.org2011-05-067-17/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | ability to disable field trials. I am going to have a need for both soon. Cleaning up some comments about empty trial names, adding static method TrialExists() and simplifying many call sites by using this method. While I'm in there and needing base/OWNERS approval, add an OWNERS file for base/metrics that adds jar@chromium.org as an owner for that directory. BUG=none TEST=base_unittests TBR=jam@chromium.org R=jar@chromium.org,phajdan.jr@chromium.org,mark@chromium.org,wtc@chromium.org Reason for revert: See http://crbug.com/81750 BUG=81750 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/6931048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84373 0039d316-1c4b-4281-b951-d872f2087c98
* (harmless) Missed include from http://codereview.chromium.org/6930040/cevans@chromium.org2011-05-051-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84350 0039d316-1c4b-4281-b951-d872f2087c98
* Gchat data is mapped onto talkgadget.google.com so don't forget to HSTS it.cevans@chromium.org2011-05-052-0/+8
| | | | | | | (Note that talkgadget.google.com is pretty much a giant 302 to https already). Review URL: http://codereview.chromium.org/6928025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84348 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor to address URLRequestContext dependency added incevans@chromium.org2011-05-058-23/+33
| | | | | | | | | http://codereview.chromium.org/6873029/ BUG=81009 Review URL: http://codereview.chromium.org/6930040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84325 0039d316-1c4b-4281-b951-d872f2087c98
* Http Cache: make sure that if we cancel a request after all datarvargas@google.com2011-05-053-1/+55
| | | | | | | | | | has been read, we don't consider it a truncated resource. BUG=68298 TEST=net_unittests Review URL: http://codereview.chromium.org/6927004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84315 0039d316-1c4b-4281-b951-d872f2087c98
* Re-connect if Keep-Alive connection has been closed by the time we get ↵asanka@chromium.org2011-05-0513-121/+245
| | | | | | | | | | | around to reusing it. BUG=none TEST=net_unittests --gtest_filter=HttpNetworkTransactionTest.BasicAuthKeepAliveImpatientServer:*.BasicAuthKeepAliveNoBody:*.BasicAuthKeepAliveLargeBody && unit_tests --gtest_filter=*TransportClientSocketTest.IsConnected* Review URL: http://codereview.chromium.org/6902165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84257 0039d316-1c4b-4281-b951-d872f2087c98
* Prefer IPv4 in the ConnectBackupJob to work around broken IPv6 networkswtc@chromium.org2011-05-058-54/+210
| | | | | | | | | | | | where connects take a long time to fail. R=eroman@chromium.org,mbelshe@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6905080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84251 0039d316-1c4b-4281-b951-d872f2087c98
* net: add cloudsecurityalliance.org to HSTS preloaded list.agl@chromium.org2011-05-052-0/+8
| | | | | | | | | Requested by Kurt Seifried. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84248 0039d316-1c4b-4281-b951-d872f2087c98
* Using DCHECK_NE/EQ/LE/GE/GT/LT() where possible. Updating logging in ↵kushi.p@gmail.com2011-05-0511-22/+26
| | | | | | | | | | | | | src/net/base/ Contributor: kushi.p@gmail.com BUG=58409 Review URL: http://codereview.chromium.org/6905059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84228 0039d316-1c4b-4281-b951-d872f2087c98
* Fix logic for handling reports of malformed bodies. To end up countingjoi@chromium.org2011-05-053-9/+23
| | | | | | | | | | | | | | | | | | | | one error, we need to count two when the malformed body is reported, against the one success reported based on the response code from what must have been a successful HTTP request. Updated a unit test that previously should have caught this but was making incorrect assumptions. BUG=81587 TEST=net_unittests Initially Committed: r84196 Reverted: r84200 Re-landed after fixing compile error. Review URL: http://codereview.chromium.org/6932013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84202 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84196 - Fix logic for handling reports of malformed bodies. To end up ↵joi@chromium.org2011-05-053-22/+9
| | | | | | | | | | | | | | | | | | | | | counting one error, we need to count two when the malformed body is reported, against the one success reported based on the response code from what must have been a successful HTTP request. Updated a unit test that previously should have caught this but was making incorrect assumptions. BUG=81587 TEST=net_unittests Review URL: http://codereview.chromium.org/6932013 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/6932029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84200 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-14 02:29:16 +0000