| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we receive a report with cache read error, we are not 100% sure whether it
happened because the newest binary has a bug or because the old one wrote a file
incorrectly. To be absolutely sure that the bug needs attention we should reset
the cache for the new binaries.
We seem to correctly doom the entries with read error, even in CRC check failure
case (kudos to gavinp@, you rock), but the error would be displayed to the user
once anyway.
Flushing cache has undesirable effects like:
1. having to re-login to some websites
2. performance comparisons with the control group are no longer valid
There is one alternative: make a retry, but that would make the code more
complex by adding another state, would require longer review, would have to be
undone later at the moment when we are almost sure there are no old entries in
the wild. Mission impossible.
Given how much we want to be stable, we absolutely should reset the cache.
BUG=239223
Review URL: https://chromiumcodereview.appspot.com/16299004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It never gets called in the current implementation, and the concept of
DomainState is changing to better support HPKP and TACK.
BUG=171025
TBR=cbentzel,agl
Review URL: https://chromiumcodereview.appspot.com/16236007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Long URLs can trigger O(n^2) runtime behavior in PAC scripts, these histograms try to measure the severity of the problem.
BUG=240536
Review URL: https://chromiumcodereview.appspot.com/16236006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=245942
Review URL: https://chromiumcodereview.appspot.com/15881011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for SPDY/3.1 and SPDY/4a2.
Make SpdyTestUtil::*Key() methods public.
Add a utility function to inject the right headers for
a URL into a SpdyHeaderBlock.
BUG=226192
Review URL: https://chromiumcodereview.appspot.com/15731012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed when the SPDY2/SPDY3 versions were merged in r203518.
Also introduce a version of ConstructSpdyControlFrame
that takes a SpdyHeaderBlock.
BUG=226192
R=rch@chromium.org, ttuttle@chromium.org
Review URL: https://codereview.chromium.org/16291002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Linux fixes
BUG=110610
TBR=darin
Review URL: https://chromiumcodereview.appspot.com/15829004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add helper functions to abstract away the different header
keys between SPDY2 and SPDY3.
BUG=226192
R=rch@chromium.org
Review URL: https://codereview.chromium.org/16137006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=226192
R=rch@chromium.org
Review URL: https://codereview.chromium.org/16159010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After the write operation returns OK, the caller is free to reuse the IOBuffer.
It is invalid to do, as the SimpleCache did previously, return OK and keep a
reference and use the IOBuffer.
As it happens, the BufferResource handler does reuse IO buffers, and this was
causing cache read errors due to CRC mismatches from the IO buffer being reused.
R=pasko,felipeg
BUG=239223
Review URL: https://chromiumcodereview.appspot.com/15825012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/15858009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CertificateRequest message in TLS 1.2.
R=rsleevi@chromium.org
BUG=90392
TEST=none
Review URL: https://chromiumcodereview.appspot.com/16195008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
us understand how frequently we are able to make use of the 0RTT handshake.
Review URL: https://chromiumcodereview.appspot.com/15950009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This hasn't been needed for 6 months, since the switch from NetworkManager (via DBus) network monitoring to Netlink.
Review URL: https://chromiumcodereview.appspot.com/16223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These are either missed in the first pass, or added after the first pass.
TBR=thestig@chromium.org
BUG=236029
Review URL: https://codereview.chromium.org/16092013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The carefully constructed histograms for synchronous open and create
results on the SimpleCache backend omitted one case that occurs with
some frequency: success.
R=pasko
BUG=None
Review URL: https://chromiumcodereview.appspot.com/15854009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=thestig@chromium.org,grt@chromium.org,joi@chromium.org,eroman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15950011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make the FEC group optional by adding a flag to the private headers.
Merge internal change: 46979143
Merging changes from chromium CL - 15385004
Merge internal change: 46949614
Removing debug logging from RecordPacketReceived. Seems redundant to
log both when we actually receive and when we record it.
Merge internal change: 46934210
Logging crypto handshake as a DVLOG rather than DLOG as it hasn't
recently been needed to debug test failures.
Merge internal change: 46932247
Changing the quic test client to simply not return a stream if not connected.
This will hopefully turn server test check-failures into server test
failures.
Merge internal change: 46932163
QUIC: redo server nonces.
Previously, in order to cope with strike-register failures and client
clock-sync issues, the server could issue a server nonce to a client. This
meant that the server had to remember rejected handshakes so that the server
nonce could be matched up. With this change, QUIC servers no longer need to
keep track of rejected handshakes.
Instead of issuing and remembering nonces, a server will now encrypt them and
forget about them. When a server nonce is used to establish freshness for a
connection, it will be stored in a per-GFE strike-register. (This
strike-register is separate from the one used to process client nonces.)
Merge internal change: 46889484
Remove FEC_ENTROPY_FLAG from private flags. Now, FEC packet's entropy
flag contain the xor of entropies of the protected packets.
Merge internal change: 46889094
Limit the number of times we'll fast-retransmit a given packet using taildrop.
Merge internal change: 46754530
Added CommonCertSetsQUIC to anonymous namespace.
QUIC: cleanups round two.
* Make CommonCertSetsQUIC a Singleton to save on every Config having its own
copy.
* Rework server config expiry: previously it caused an error at client hello
send time. Now it will cause an error at REJ processing time but, if the
config expired after we cached it, we will act as if we didn't have a cached
server config.
* Invalidate the server config cache in the event of a client hello sending
failure. This will prevent a bad server config from being cached and poisoning
connection attempts for the lifetime of the cache.
* Fix a bug in the test code which failed to parse hex chunks in debugging
messages correctly. (Thanks to wtc for noticing.)
Merge internal change: 46742937
Merging changes from chromium - CL 15074007
Merge internal change: 46710932
Fix a bug in QuicSession's header compression behavior which could lead
to infinite loops.
Merge internal change: 46694681
Getting 5% our CPU usage back by not calculating SentBandwidth for the
tcp congestion control algorithm.
Added a TODO to improve that function since it's pretty abysmal: the
ToLargerUnits and Subtract overhead alone accounted for 4.5% of the cpu
in initial loadtest runs.
Merge internal change: 46608880
Adding support for truncated guids in QuicFramer.
Merge internal change: 46575819
using our latched write_blocked status to spare us useless system calls.
Merge internal change: 46573462
Fixing some crashing issues in the QUIC loadtest, where if a client ever
disconnects it never recovers, either crashing trying to create a stream
or crashing waiting for a response on a non-existant stream.
I'm not sure if we have the same problem for the http/https simple clients
but we definitely do for QUIC.
Merge internal change: 46562890
Merging changes from chromium - CL 14614006
Merge internal change: 46460427
Merging cleanup changes from chromium CL - 14651009
Merge internal change: 46457093
Fixing a test framework bug for quic: we were munging headers to do
https:// for insecure quic resulting in a 404 in the http-only service
map. Then disalbing the test since we don't advertise secure SPDY on
insecure QUIC.
Merge internal change: 46408400
Move QuicConfig from ssl_global_data to quic_dispatcher.cc. Initialize
using values from QuicConfigProto and use the max_time_before_crypto_handshake
to set the overall connection timeout before crypto handshake finishes.
Merge internal change: 46400649
QUIC: implement ChannelIDs.
We'll need this for HTTPS.
Merge internal change: 46396357
Deleted usage of scoped_ptr_openssl. Added TODO comments for porting
ChannelIDSigner and Verifier.
R=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15937012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a lower level stalled socket pool.
Issue was that SpdySession::CloseOneIdleConnection() would
return false, despite deleting the session. Then the caller
would try and follow a no-longer-valid iterator to the next
layered socket pool. Fix is to have the function return
true in that case.
This was broken in https://codereview.chromium.org/199880
BUG=244730
Review URL: https://chromiumcodereview.appspot.com/16229002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The EntrySet type was a base::hash_map that duplicated the hash_key
value in both the key and value types, wasting 8 bytes per node.
Changing the implementation to a base::hash_set has been experimented
with and introduces lots of non trivial code changes (some of them being
dependent on the exact C++ STL implementation).
This is a simpler optimization that simply puts the hash_key out of the
EntryMetadata structure, and updates all related code appropriately.
Note that this only changes the in-memory representation of the index,
the on-disk format is untouched.
BUG=
Review URL: https://chromiumcodereview.appspot.com/14746019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When socket bind failure happens on enabling remote web debugging,
retry using a socket name with PID suffix to ensure uniquiness.
This allows several channels of Chrome to have remote web debugging
enabled simultaneously. Also, this preserves backwards compatibility,
as in the case of the single Chrome instance on a device, remote
debugging socket name is unchanged.
It seems easier to add retry functionality to UnixDomainSocket,
as DevToolsHttpHandler creation is heavily asynchronous.
BUG=222338
Review URL: https://chromiumcodereview.appspot.com/16093005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Adam Langley.
R=agl@chromium.org
BUG=90392
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/14772023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Splitting from the original patch here, crrev.com/14942008
to only include 'webkit' specific changes
BUG=102853
Review URL: https://chromiumcodereview.appspot.com/14680012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
failed to connect and thus have NULL socket_lease.
BUG=244507
TEST=net_unittests --gtest_filter=DnsTransactionTest.ConnectFailureFollowedBySuccess
Review URL: https://chromiumcodereview.appspot.com/15881008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changes to the TransportSecurityState data structures and JSON format.
The "--hsts-hosts" feature is likely unused, is redundant with net-internals, and is dangerous since it fails silently. Also it exposes the internal JSON format to the user.
BUG=156152
R=rsleevi,palmer
Review URL: https://chromiumcodereview.appspot.com/15711007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change causes us to not process any headers unless they are correctly
terminated with a \r\n\r\n sequence.
BUG=244260
Review URL: https://chromiumcodereview.appspot.com/15688012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a re-land of issue 14299011, which broke GLSurfaceGLX, in turn breaking Chrome Linux/Aura.
This CL changes WeakPtr in the following ways:
* Changes thread-bindings semantics so that WeakPtrs only become bound when the first one is dereferenced, or the owning factory invalidates them.
* Removes WeakPtrFactory::DetachFromThread.
* Renames SupportsWeakPtr::DetachFromThread to DetachFromThreadHack.
Calling code changes to allow this:
* Unnecessary use of SupportsWeakPtr removed from SGIVideoSyncProviderThreadShim.
* Unnecessary DetachFromThread() calls removed from PluginInfoMessageFilter, DhcpProxyScript[Adapter]FetcherWin and (Chromoting's) PolicyWatcherLinux.
* DetachFromThread() calls rendered unnecessary by change in binding semantics removed from IOThread, SearchProviderInstallData, RuleRegistryWithCache and GLSurfaceGlx.
WebGraphicsContext3DInProcessCommandBufferImpl uses the re-named DetachFromThreadHack() - bug 234964 tracks work to remove that use.
TBR=darin,awong
BUG=232143, 234964, 243914
Review URL: https://chromiumcodereview.appspot.com/16007009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, remove STATE_SEND_BODY,
STATE_SEND_BODY_COMPLETE, SPDY_WAITING_FOR_RESPONSE and
instead add logic to detect when we receive an out-of-place
response.
Fix tests that were using the wrong SpdyStreamType and
weren't using a delegate.
Add various TODOs.
BUG=243643
R=rch@chromium.org
Review URL: https://codereview.chromium.org/15892015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Formats from Canon, Fuji, Minolta, Olympus, Panasonic, and Sigma.
BUG=165598
Review URL: https://chromiumcodereview.appspot.com/15875004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
parsing.
BUG=238041
Review URL: https://chromiumcodereview.appspot.com/15897003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Merge some member functions and rename others.
Clean up SpdyHttpStream logic a bit.
BUG=243643
Review URL: https://chromiumcodereview.appspot.com/15936003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a resubmit of https://codereview.chromium.org/15505003
TBR=avi
BUG=96594
Review URL: https://codereview.chromium.org/15740023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This gets rid of more places where Persistent handles are copied
(see bug).
BUG=236290
TBR=eroman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15796006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify SocketStream::Finish so that it works correctly if the delegate
calls DetachDelegate() and then deletes itself from within the OnError()
callback.
Test the delegate deleting itself in OnError().
SocketStream::Delegate is permitted to call
SocketStream::DetachDelegate() and then delete itself from within the
OnError method. Ensure this works correctly.
BUG=
TEST=net_unittests layout tests
Review URL: https://chromiumcodereview.appspot.com/15989003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use SpdyStreamType to enforce stream and stream delegate semantics
instead of trying to infer it from various parameters and return values.
Remove now-redundant return value of
SpdyStream::Delegate::OnSendRequestHeadersComplete().
Comment expected semantics of SpdyStream::Delegate member
functions and related SpdyStream member functions.
Enforce some restrictions on push streams. Namely, set send_status_
to NO_MORE_DATA_TO_SEND immediately for them, and make sure
its entry point is SpdyStream::OnResponseReceived().
Also clarify how push streams interact with the stream histograms.
BUG=243643
Review URL: https://chromiumcodereview.appspot.com/15701009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> GTTF: Convert most tests in content to use EmbeddedTestServer.
>
> This eliminates a whole class of problems with SpawnedTestServer
> failing to start.
>
> BUG=96594
> R=avi@chromium.org, satorux@chromium.org
>
> Review URL: https://codereview.chromium.org/15505003
TBR=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/15846017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current disk cache tracing is single threaded but the
new version of the cache is not (as in interesting stuff
happens on more than one thread)
BUG=241277
TEST=none
Review URL: https://chromiumcodereview.appspot.com/15197004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than computing the expiration
internally.
This makes it easier for the caller to handle the special max-age=0.
BUG=156152
R=rsleevi,palmer
Review URL: https://chromiumcodereview.appspot.com/15962009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace pending_send_flags_ and has_upload_data_ with send_status_, and
update/check its value as necessary.
Make SpdyStream::Send{Request,StreamData}() take a SpdySendStatus
parameter.
Remove OnSendBodyComplete()'s return value, since it's now redundant.
Rename SendRequest() and related functions to SendRequestHeaders().
Change references to "send headers" to "send request".
Fix some discovered erroneous data in tests.
BUG=243643
R=rch@chromium.org
Review URL: https://codereview.chromium.org/15983003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused local failures in linux_aura builds. Unsure why this isn't showing
up on the bots.
> Remove all but one use of WeakPtrFactory::DetachFromThread.
>
> This CL changes WeakPtr in the following ways:
> * Changes thread-bindings semantics so that WeakPtrs only become bound when the first one is dereferenced, or the owning factory invalidates them.
> * Removes WeakPtrFactory::DetachFromThread.
> * Renames SupportsWeakPtr::DetachFromThread to DetachFromThreadHack.
>
> Calling code changes to allow this:
> * Unnecessary DetachFromThread() calls removed from PluginInfoMessageFilter, DhcpProxyScript[Adapter]FetcherWin and (Chromoting's) PolicyWatcherLinux.
> * DetachFromThread() calls rendered unnecessary by change in binding semantics removed from IOThread, SearchProviderInstallData, RuleRegistryWithCache and GLSurfaceGlx.
>
> WebGraphicsContext3DInProcessCommandBufferImpl uses the re-named DetachFromThreadHack() - bug 234964 tracks work to remove that use.
>
> Review URL: https://chromiumcodereview.appspot.com/14299011
BUG=232143, 234964, 243914
TBR=wez@chromium.org
Review URL: https://codereview.chromium.org/15819004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a per-file OWNERS for net/base/mime_sniffer.*, set to abarth, to make it
clear that this file is meant to strictly follow
http://mimesniff.spec.whatwg.org/
BUG=none
R=eroman@chromium.org
Review URL: https://codereview.chromium.org/15821010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This simplifies the flow a bit.
BUG=243643
Review URL: https://chromiumcodereview.appspot.com/15982002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=147383
TEST=none
R=gavinp@chromium.org
Review URL: https://codereview.chromium.org/15594003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=243385
R=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/15755015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates a whole class of problems with SpawnedTestServer
failing to start.
BUG=96594
R=avi@chromium.org, satorux@chromium.org
Review URL: https://codereview.chromium.org/15505003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=226192
Review URL: https://chromiumcodereview.appspot.com/15784005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
problems associated with NAT rebinding.
Review URL: https://chromiumcodereview.appspot.com/15924004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes WeakPtr in the following ways:
* Changes thread-bindings semantics so that WeakPtrs only become bound when the first one is dereferenced, or the owning factory invalidates them.
* Removes WeakPtrFactory::DetachFromThread.
* Renames SupportsWeakPtr::DetachFromThread to DetachFromThreadHack.
Calling code changes to allow this:
* Unnecessary DetachFromThread() calls removed from PluginInfoMessageFilter, DhcpProxyScript[Adapter]FetcherWin and (Chromoting's) PolicyWatcherLinux.
* DetachFromThread() calls rendered unnecessary by change in binding semantics removed from IOThread, SearchProviderInstallData, RuleRegistryWithCache and GLSurfaceGlx.
WebGraphicsContext3DInProcessCommandBufferImpl uses the re-named DetachFromThreadHack() - bug 234964 tracks work to remove that use.
BUG=232143, 234964
Review URL: https://chromiumcodereview.appspot.com/14299011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
style of tcpdump's -X and -XX options.
R=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15951002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202034 0039d316-1c4b-4281-b951-d872f2087c98
|