summaryrefslogtreecommitdiffstats
path: root/ppapi/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Remove PPB_Ext_Socket_Dev.yzshen@chromium.org2014-04-301-2/+0
| | | | | | | | | BUG=366304,244653,312916,314899 TEST=None Review URL: https://codereview.chromium.org/252923005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267348 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Change uma presubmit to never block CQ.teravest@chromium.org2014-04-031-1/+1
| | | | | | | | | | | | | | | | | This changes the presubmit rule for adding pepper interface hashes to UMA to a notification instead of a warning. This is because the presubmit is a bit too broad, and was blocking some changes from being submitted through the CQ. Using a notification message should be fine, since the impact of missing a histogram is relatively low (we'll just see a number for a while), and the hash can always be added later. BUG=351389 R=xhwang@chromium.org Review URL: https://codereview.chromium.org/221973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261411 0039d316-1c4b-4281-b951-d872f2087c98
* Proxy the PDF API to the PDF plugin.koz@chromium.org2014-02-061-1/+1
| | | | | | | | This makes the Rotate Clockwise / Counterclockwise context menu items work. Review URL: https://codereview.chromium.org/142413006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249366 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Log in UMA when an interface is used.teravest@chromium.org2014-02-051-0/+34
| | | | | | | | | | | | | | | | We'd like to know what versions of our interfaces are used by end users. This change logs usage of PPB interfaces for out-of-process plugins the first time that get_interface<>() is called for a given interface and version. I tested this change by loading some plugin examples and checking the about:histograms page. BUG=111542 R=asvitkine@chromium.org, jschuh@chromium.org, yzshen@chromium.org Review URL: https://codereview.chromium.org/141523010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249007 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude ppb_pdf interface from autogen PRESUBMIT checks as it is hand written.koz@chromium.org2014-01-311-0/+3
| | | | | | Review URL: https://codereview.chromium.org/149033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248134 0039d316-1c4b-4281-b951-d872f2087c98
* Whitelist opengles2 headers for ppapi presubmitpiman@chromium.org2014-01-231-0/+6
| | | | | | | | | | | | The opengles2 interface headers are generated automatically by the command buffer generator script, instead of the ppapi idl script. So skip the .h <-> .idl matching for those. BUG=None Review URL: https://codereview.chromium.org/143903019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246482 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Fix PRESUBMIT when deleting files.teravest@chromium.org2013-10-081-2/+4
| | | | | | | | | | | | The PRESUBMIT script for ppapi/ currently tried to open and check files, even when they've been deleted. This makes it impossible to use the presubmit hooks when removing certain files. BUG=305289 Review URL: https://codereview.chromium.org/26518002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227600 0039d316-1c4b-4281-b951-d872f2087c98
* PPAPI: Make API changes w/o IDL changes Warnings if generators have changeddmichael@chromium.org2013-09-101-5/+18
| | | | | | | | | | | | | We frequently run in to the situation where we change the generators which causes some real (but usually minor) change in header files, even though the IDL is unchanged. We should just warn in that situation, so that developers can use the CQ for these kind of generator changes. BUG= Review URL: https://chromiumcodereview.appspot.com/23620032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222190 0039d316-1c4b-4281-b951-d872f2087c98
* Add PPAPI presubmit check, to ensure NaCl SDK is updated properly.binji@chromium.org2013-07-171-0/+36
| | | | | | | | | | | | When adding or removing a PPAPI interface, a file in the NaCl SDK must be updated as well. BUG=254174 R=dmichael@chromium.org, sbc@chromium.org Review URL: https://codereview.chromium.org/19067002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212107 0039d316-1c4b-4281-b951-d872f2087c98
* Apps v2 in Pepper: Add C/C++ definition for chrome.socket.yzshen@chromium.org2013-04-081-0/+2
| | | | | | | | | | BUG=226303 TEST=None Review URL: https://chromiumcodereview.appspot.com/13490003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192897 0039d316-1c4b-4281-b951-d872f2087c98
* Update PRESUBMIT scripts to use PresubmitPromptOrNotify helper.wez@chromium.org2013-04-021-1/+1
| | | | | | | | NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13093006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191863 0039d316-1c4b-4281-b951-d872f2087c98
* Notify rather than warning on PPAPI_RELEASE change.wez@chromium.org2013-02-221-1/+1
| | | | | | | | | Warning prevents the Commit Queue from landing the CL. Review URL: https://chromiumcodereview.appspot.com/12321060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183962 0039d316-1c4b-4281-b951-d872f2087c98
* Add presubmit exception for PPAPI_RELEASE changes to pp_macros.hwez@chromium.org2013-02-211-0/+16
| | | | | | | | | | The C header generator adds a PPAPI_RELEASE macro based on all the IDL files, so pp_macros.h may change while its IDL does not. Review URL: https://chromiumcodereview.appspot.com/12317032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183729 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NaCl SRPC proxy source files.bbudge@chromium.org2013-01-181-17/+0
| | | | | | | | | | | | | | This change removes the source files for the old NaCl SRPC proxy, which is no longer used. Also changes the presubmit rules to no longer check for srpc files. BUG=169152 TEST=compiles Review URL: https://chromiumcodereview.appspot.com/11956045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177732 0039d316-1c4b-4281-b951-d872f2087c98
* PPAPI: change PRESUBMIT.py to not complain about TODOs in .cc files.ncbray@chromium.org2012-12-121-1/+1
| | | | | | | | | | | This restriction doesn't make a lot of sense for .cc files, and there are in fact already TODOs in the .cc files and this can choke the CQ. BUG= none Review URL: https://codereview.chromium.org/11555028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172671 0039d316-1c4b-4281-b951-d872f2087c98
* Added test and fixed bugs with release dependencynoelallen@chromium.org2012-12-061-2/+2
| | | | | | | | | | | | | | | | | | | Fixed 'visited' bug where sibling were poluting the visit set, preventing dependency expantion. Fixed release list generation where a node's typeref releases were not constrained by the node's min/max. Added generator unit tests to PRESUBMIT when changes to generator are detected. Added test for release dependency when a child uses different releases than the parent. Fix release dependencies and tests. R=sehr@chromium.org BUG=157017 Review URL: https://chromiumcodereview.appspot.com/11419173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171499 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for generating thunk source from IDL.teravest@chromium.org2012-11-171-2/+13
| | | | | | | | | | | | | | | | | | | | | This introduces a few new IDL attributes: generate_thunk - Enables thunk generation for an IDL file. create_func - Overrides the guessed create function name. on_failure - Overrides the default return value on failure. report_errors - Allows error reporting to be disabled. By using these attributes, we can generate _thunk.cc files for many IDL files. I'll send CLs for moving the thunks separately, as I found it tiring to review them all in a big lump. I have PPB_Widget_Dev here as an example. BUG= Review URL: https://chromiumcodereview.appspot.com/11417010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168450 0039d316-1c4b-4281-b951-d872f2087c98
* Add presubmit check for unversioned PPB interface macros in C++ wrappers.wez@chromium.org2012-06-011-0/+34
| | | | | | | | | BUG=107398 TEST=Presubmit fails if a C++ wrapper implementation is modified and it uses unversioned PPB interface macro, succeeds otherwise. Review URL: https://chromiumcodereview.appspot.com/10443119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140065 0039d316-1c4b-4281-b951-d872f2087c98
* Make PPAPI presubmit more stringentnoelallen@chromium.org2012-03-141-13/+95
| | | | | | | | | | | | | | | | | The PPAPI docs team is having issues with missing documentation, this CL makes the PRESUBMIT more stringent, forcing errors when a stable interfaces contains a TODO, or is missing an IDL implementation. Additional cleanup: Added missing LF between global function definitions Removed extra space in list Added comments Converted all errors and warnings to point to the file where the error was found. Review URL: http://codereview.chromium.org/9691019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126601 0039d316-1c4b-4281-b951-d872f2087c98
* ppapi: Add presubmit check for .srpc file changesmcgrathr@chromium.org2012-01-101-7/+23
| | | | | | | | | | | | | | If someone changes a .srpc file, they must include the regenerated files from srpcgen in the same commit. BUG= none TEST= none R=noelallen@google.com,noelallen@chromium.org Review URL: http://codereview.chromium.org/9152017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117103 0039d316-1c4b-4281-b951-d872f2087c98
* Pnacl ppapi shim generator (from IDL), based on Noel's first cut.jvoung@google.com2011-11-301-10/+38
| | | | | | | | | | | | | | BUG= http://code.google.com/p/nativeclient/issues/detail?id=2413 TEST= python idl_gen_pnacl.py --test --wnone Also ** ./generator.py doesn't change ** ./generator.py --wnone --pnacl --pnaclshim=pnacl_shim.c generates a shim that compiles and works in the NaCl repo. Review URL: http://codereview.chromium.org/8568025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112244 0039d316-1c4b-4281-b951-d872f2087c98
* Allow defaults for generator which will check all available versions.noelallen@google.com2011-11-041-1/+1
| | | | | | | | | | | Change the default 'range' for the presubmit and generator to be start,end which represent the first and last Label found in the IDL. BUG= http://code.google.com/p/chromium/issues/detail?id=103037\ TRY= ./generate.py Review URL: http://codereview.chromium.org/8478005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108697 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing changenoelallen@google.com2011-09-271-1/+1
| | | | | | | | | | | | | This file was missing from: http://codereview.chromium.org/8045001/ This caused a missmatch in the presubmit by the next PPAPI developer. BUG= http://code.google.com/p/chromium/issues/detail?id=97708 TEST= manually run on originally failing machine. Review URL: http://codereview.chromium.org/8050001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102883 0039d316-1c4b-4281-b951-d872f2087c98
* Add presubmit check to verify PPAPI C headers match IDL files.noelallen@google.com2011-09-141-0/+72
Update outfile to print a better filename on diff. Update fix missing 'name' in idl_generator.py BUG= http://code.google.com/p/chromium/issues/detail?id=93534 TEST= gcl upload | presubmit (after modifying a .h or .idl file) R= brettw@chromium.org Review URL: http://codereview.chromium.org/7700001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101092 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 17:34:04 +0000