| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/13220002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For interface Foo with versions A and B, structs will be defined for Foo_A and Foo_B, and a typedef generated from Foo_B to Foo. Versioning of IDL structs remains unchanged.
(Follow-up to discussion on CL 8931019)
*** This change breaks compatibility with C code that makes use of unversioned-named interface structs. :( ***
We need to define a versioned-named struct for each interface's current version. We could:
1. Carry on defining the current struct unversioned and typedef a versioned name for it.
The versioned type for the interface would be a typedef for the latest version and a struct for later versions, causing calling C code that uses it to break when a new version is added.
2. Define structs for all versions, and a separate unversioned struct.
This would lose type equivalence between the versioned and unversioned copies of the latest interface specification, and lead to needless duplication, especially for one-version interfaces.
3. Do this CL. We break some C code once, by change the unversioned type from struct to typedef, but we avoid these headaches in future. C++ code shouldn't be affected.
*** Contents of this CL, including notes on to-dos:
This change requires updating thunk-getters to be defined using versioned names, so that the interface structs can be forward declared; the thunk-getters now have versioned names and return values.
Changing the thunk-getter naming requires updating unit-tests to call the versioned names. It also requires some interface headers not generated from IDL to be manually updated to the new scheme (PPB_CharSet_Dev, PPB_Crypto_Dev, PPB_DirectoryReader_Dev, PPB_LayerCompositor_Dev, PPB_Graphics3D, PPB_Flash_Menu, PPB_Instance_Private, PPP_Pdf, PPB_Flash_NetConnector, PPB_GLESChromiumTextureMapping_Dev and PPB_Graphics3D_Trusted).
The proxy GetInfo() calls are updated to use versioned interface macros and thunks. Similarly, most PPBs added in interface_list.cc are now added using versioned interface macros and thunk getters. Ditto PluginModule, and some of PluginInstance. Some implementations (e.g. PPB_CharSet_Dev) needed updating to use versioned thunk getters to fetch interfaces to use.
The VideoDecoder interface size checks are for 32-bit are updated not to expect structs.
It was necessary to replace forward declarations of interface structs with includes, and remove "struct" prefixes where unversioned names were used. In most cases the affected code should really be updated to cope with versions.
PPP_Pdf has become PPP_Pdf_1. Other versionless structs that should be updated for consistenct include PPB_UMA_Private, PPB_GPU_Blacklist_Private, PPB_Proxy_Private, PPP_PDF, PPB_OpenGLES2, PPB_Flash_File_FileRef and PPB_Flash_File_ModuleLocal. Also PPP_Class_Deprecated, PPP_CursorControl_Dev, PPP_Find_Dev, PPP_NetworkState_Dev, PPP_Scrollbar_Dev, PPP_Selection_Dev, PPP_VideoCapture_Dev, PPP_Graphics3D and PPP_Instance_Private.
The Graphics2D and GLES2 examples now use unversioned interface type names without "struct" prefix. It's not clear whether examples should use versioned names, to show best practice, or unversioned.
The typedef hack in PPP_Instance IDL is gone. Yay.
BUG=107398,108379
TEST=All Pepper and NaCl tests should continue to pass on Chromium bots. NaCl SDK examples build correctly.
Review URL: http://codereview.chromium.org/8989006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
same (on @param tags) as per polina.
Review URL: http://codereview.chromium.org/7701004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several IDL files contain references to M13 which are unused. This causes
the generator to use M13 instead of M14 as the version number for the
unchanged interface. This CL removes the unused references to M13 in
the IDL, and pushes the updated set of '*.h' removing the unused
#define of the unused version string.
BUG= http://code.google.com/p/chromium/issues/detail?id=94201
TEST= compile + try
R= brettw@chromium.org
Review URL: http://codereview.chromium.org/7748012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7669049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A minor change to the way we output the headers. This change moves the
defines which are used to name the interfaces and thier versions to the
top of the header, moving out of the @file block. This prevents them
from being 'spewed' in the documentation.
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/7669001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These headers were autogenerated from ppapi/api/*.idl
BUG= http://code.google.com/p/chromium/issues/detail?id=76271^M
TEST= run try
Review URL: http://codereview.chromium.org/7399016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Plus bonus change to a comment in pp_bool.h to try to get the bots to rebuild things properly
------
First pass at revving stable pepper interfaces to 1.0.
Missing PPB_Core (pending removal of MemAlloc/MemFree) and new input event interfaces, in case we want to change them in the next ~week.
BUG=84519
TEST=ppapi tests
TBR=dmichael
Review URL: http://codereview.chromium.org/7355014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Missing PPB_Core (pending removal of MemAlloc/MemFree) and new input event interfaces, in case we want to change them in the next ~week.
BUG=84519
TEST=ppapi tests
Review URL: http://codereview.chromium.org/7292033
TBR=dmichael@chromium.org
Review URL: http://codereview.chromium.org/7342032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Missing PPB_Core (pending removal of MemAlloc/MemFree) and new input event interfaces, in case we want to change them in the next ~week.
BUG=84519
TEST=ppapi tests
Review URL: http://codereview.chromium.org/7292033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These trivial changes make the PPAPI headers more consistent.
This allows the headers to more closely match the autogenerated
ones simplifying validation before we switch over to IDL.
TEST= tryserver
BUG= http://code.google.com/p/chromium/issues/detail?id=76271
Review URL: http://codereview.chromium.org/7333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7282015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
always be invoked asynchronously on success or error or skipped if the
operation can complete synchronously without blocking. Keep the default
behavior as-is until clients update their code. Bump revisions of all
interfaces that take callbacks as args. Update browser interface function
implementations and C++ layer to force callbacks if sync option is not set.
Change ppapi/tests to run tests involving callbacks with both flag options.
BUG=79376
TEST=ppapi_tests + bots
Review URL: http://codereview.chromium.org/6899055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ppb.h: changed to relative url
ppb_audio.h: changed to relative url
ppb_audio_config.h: changed to relative url
ppb_image_data.h: changed in/out to in,out (correct syntax)
ppb_url_loader.h: removed a bunch of </li> tags that were unneeded and causing warnings, also rename parm to param and in/out to in,out
ppp_instance.h: escaped some <embed> tags so they didn't confuse Doxygen.
Review URL: http://codereview.chromium.org/7248017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This explicitly does not change any of the version numbers, and just makes the
name of the define string match the current version number.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6893022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6532065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
size_t -> int32_t, char* -> void* for buffers, void* -> const void* where needed.
We already use int32_t when we serialize size_t (and unlike pointers, size_ts do get serialized a lot).
char* for representing unstructured blocks of memory is weird, see "man 2 read" and friends. I'm removing it because it complicates our type system in IDL for no reason.
const void* should be obvious.
BUG=76271
TEST=none
Review URL: http://codereview.chromium.org/6711047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
construct (enums, interfaces, and so on).
Review URL: http://codereview.chromium.org/6297018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
David Sehr helped me get the NaCl side working so I'll try to land this again.
Previous CL at http://codereview.chromium.org/5837001
BUG=69474
TEST=compiles
Review URL: http://codereview.chromium.org/6231003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows graphics 2d example to compile.
BUG=none
TEST=Compiling examples/2d/graphics_2d.c with NaCl works.
Review URL: http://codereview.chromium.org/5997003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://code.google.com/p/nativeclient/issues/detail?id=933
TEST=It compiles can run the nacl ppapi srpc test
Review URL: http://codereview.chromium.org/6041001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly done by bbudge.
BUG=none
TEST=ppapi_include_tests.py
Review URL: http://codereview.chromium.org/5837001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
and rename accordingly.
Rename URLResponseInfo.GetBody to GetBodyAsFileRef.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/4747001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65705 0039d316-1c4b-4281-b951-d872f2087c98
|