| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This patch refactors ppapi_shared.gypi and ppapi_proxy.gypi into proper includes, adds ppapi_shared_untrusted and ppapi_proxy_untrusted .gyp files, and integrates them into the nacl_irt build (ppapi/native_client/native_client.gyp). In order to build without link errors, it includes our plugin side initialization of PluginDispatcher, and a PpapiPluginMain definition. When the 'build_ppapi_ipc_proxy_untrusted' gyp flag is set to '1', this will build a working NaCl IRT using the Chrome IPC proxy.
BUG=116317
TEST=compiles, runs HelloWorld and GetURL SDK examples.
Review URL: https://chromiumcodereview.appspot.com/10565015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Move pnacl translation SRPC methods to non-static method, called from thread entry point, rather than using the entry point directly
2) Add a few comments
R= jvoung@chromium.org,robertm@chromium.org,sehr@google.com
BUG=none
TEST=nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10532154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch refactors ppapi_shared.gypi and ppapi_proxy.gypi into proper includes, adds ppapi_shared_untrusted and ppapi_proxy_untrusted .gyp files, and integrates them into the nacl_irt build (ppapi/native_client/native_client.gyp). In order to build without link errors, it includes our plugin side initialization of PluginDispatcher, and a PpapiPluginMain definition. When the 'build_ppapi_ipc_proxy_untrusted' gyp flag is set to '1', this will build a working NaCl IRT using the Chrome IPC proxy.
BUG=116317
TEST=compiles, runs HelloWorld and GetURL SDK examples.
Review URL: https://chromiumcodereview.appspot.com/10546140
TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10565012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This patch refactors ppapi_shared.gypi and ppapi_proxy.gypi into proper includes, adds ppapi_shared_untrusted and ppapi_proxy_untrusted .gyp files, and integrates them into the nacl_irt build (ppapi/native_client/native_client.gyp). In order to build without link errors, it includes our plugin side initialization of PluginDispatcher, and a PpapiPluginMain definition. When the 'build_ppapi_ipc_proxy_untrusted' gyp flag is set to '1', this will build a working NaCl IRT using the Chrome IPC proxy.
BUG=116317
TEST=compiles, runs HelloWorld and GetURL SDK examples.
Review URL: https://chromiumcodereview.appspot.com/10546140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R= ncbray@google.com,noelallen@google.com
BUG=none
TEST=mac nacl plugin scons build
Review URL: https://chromiumcodereview.appspot.com/10536181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix broken SDK build due to mismatch in warning level which permits
this conversions on the GYP build.
TBR=dschuff@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10532147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
SDK bots are broken becaus of scons failure due to different warning levels.
TBR=dschuff@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10543155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add mode to FileDownload for streaming the code directly to the user
* Derive a new class from PnaclTranslateThread to stream bitcode over SRPC
* Add alternate path through PnaclCoordinator for firing up the translation sooner, and plumbing the bitcode to the translation thread.
* Enable with environment variable for now.
R= sehr@google.com,jvoung@google.com,robertm@google.com
BUG=none
TEST=nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10539059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
-Wundef warns about "#if FOO" when FOO is undefined.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2787
TEST=nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10545062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: NaCl CL to update untrusted.gypi must go in first.
BUG=127699
TEST=this is a test
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140786
Review URL: https://chromiumcodereview.appspot.com/10409032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: NaCl CL to update untrusted.gypi must go in first.
BUG=127699
TEST=this is a test
Review URL: https://chromiumcodereview.appspot.com/10409032
TBR=bradchen@google.com
Review URL: https://chromiumcodereview.appspot.com/10543028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: NaCl CL to update untrusted.gypi must go in first.
BUG=127699
TEST=this is a test
Review URL: https://chromiumcodereview.appspot.com/10409032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Technically one is always supposed to do #include <sys/types.h> before
doing #include <sys/mman.h>. For the newlib <sys/mman.h> this
actually matters, as otherwise off_t will be undefined when it's used
in the mmap prototype. Newer libstdc++ no longer implicitly includes
<sys/types.h> in places that it used to, so this nit is newly noticed.
BUG= none
TEST= none
R=sehr@google.com
Review URL: https://chromiumcodereview.appspot.com/10540020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Newer compilers have new warnings: signedness of integer initializers matters.
Newer libstdc++ reduces implicit #include's so IWYU failures get noticed:
usleep is declared in <unistd.h>.
BUG= none
TEST= nacl_integration
R=sehr@google.com
Review URL: https://chromiumcodereview.appspot.com/10545012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=already removed
Review URL: https://chromiumcodereview.appspot.com/10483022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The starred changes below required additional Chrome-side changes:
* required the change to native_client.gyp.
** required a PNaCl toolchain update.
*** required a #include change.
This pulls in the following Native Client changes:
r8734: (robertm) Enable higher optimization level when building ld-gold-sb.
r8735: (robertm) Attempt to green the x86-32 torture test bot
r8736: (jvoung) Bump llvm rev for dangling debug info workaround.
r8737: (jvoung) Add a test for bitcode linking + dwarf local var info.
r8738: (jvoung) bump llvm rev for clashing compile unit ID for same source file change:
r8739: (mseaborn) Remove a duplicated implementation of NaClDescEffectorTrustedMem
r8740: (bradnelson) Don't attempt to archive coverage information on coverage trybots.
r8741: (robertm) Do not build the obsolete sandboxed binutils ld anymore.
r8742: (bradnelson) Stop uploading with caching turned off.
r8743: (mcgrathr) Remove some variables set but not used
r8744: (mseaborn) NaClDesc: Make the Unmap() and UnmapUnsafe() methods Windows-only
r8745: (kschimpf) Define a baseline and testing patterns for ARM load_store_word_byte table.
*r8746: (bradnelson) Reducing duplication.
r8748: (jvoung) Try removing ppapi_example_audio from pyauto tests.
r8749: (bradnelson) Fixing ARM inconsistency in untrusted.gypi introduced in r8746.
r8750: (jvoung) Revert "Define a baseline and testing patterns for ARM load_store_word_byte table."
r8751: (jvoung) Bump llvm rev for local var dwarf info + bitcode linking fix
r8752: (halyavin) Update deps which includes using NaCl osabi in GDB. Use NaCl osabi in debug
r8754: (eaeltsin) Debug stub: cleanup - get rid of Target::send_done_
r8755: (robertm) Misc cleanup in pnacls's nativeld driver
r8756: (robertm) Document randomness in calling convention test better
r8757: (robertm) Update PNaCl TC to rev 8741 to pull in changes to the linker.
r8759: (halyavin) Bump REVISIONS.
r8760: (dschuff) Set PNACL_BUILDBOT in buildbot/pnacl.sh to allow dumping of log files in build steps
r8761: (mseaborn) Re-enable run_trusted_mmap_test under ARM QEMU since it works fine there
r8762: (mcgrathr) Add testdata files for unaligned_data test
r8763: (kschimpf) Improve error reporting of arm validator.
r8764: (robertm) Merge pnacl tc builder script into pnacl bot scripts
r8765: (jvoung) Remove adhoc shared lib test so that "pnacl/test.sh test-all"
r8766: (dschuff) Prepend instead of append -lplatform when linking platform_qualify tests
r8767: (bradnelson) Making download_toolchains more noisy by default.
**r8768: (jvoung) Enable '-g' for pnacl and ARM. We've worked around and/or
r8769: (sehr) Get runnable-ld.so 0mod16 alignment change.
***r8770: (ncbray) Move sandbox memory preservation from sel_memory.h to sel_addrspace.h
r8771: (mcgrathr) SCons build tweaks to enable using a custom native ARM toolchain
r8772: (jvoung) Bump pnacl rev for debug info changes.
r8774: (mseaborn) Add code for address space teardown for use in tests
BUG=none
TEST=nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10509010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code in the NaCl repo no longer uses this function; it gets a
/dev/urandom FD via dependency injection instead.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2655
TEST=nacl_integration etc.
Review URL: https://chromiumcodereview.appspot.com/10448055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow an "#ifdef NACL_STANDALONE" to be removed from the NaCl side.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2655
TEST=nacl_integration on Unix
Review URL: https://chromiumcodereview.appspot.com/10442009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will enable me to remove this header from the NaCl side, since it is no
longer used there.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2550
TEST=build
Review URL: https://chromiumcodereview.appspot.com/10440006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=104035,104037
TBR=sehr@google.com
R=jhawkins@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10408051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
specialize extra_deps for newlib and glibc.
BUG=127699
TEST=browser_tests (build)
Review URL: https://chromiumcodereview.appspot.com/10409059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
alias as gpu::RefCountedThreadSafe.
Additionally, ensure all of the nacl::RefCountedThreadSafe-derived classes
do not have public destructors.
BUG=123295
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10386080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the nacl SDK build
R= binji@chromium.org
BUG=none (broken nacl SDK bots)
TEST=nacl SDK build
Review URL: https://chromiumcodereview.appspot.com/10392137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move compilation thread into its own class to make future multiple
implementations easier. Also split LocalTempFile into its own file to break
circular dependency.
R= sehr@google.com,jvoung@google.com,robertm@chromium.org
BUG=none
TEST=nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10377157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=116317
TEST=compiles
Review URL: https://chromiumcodereview.appspot.com/10343005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:127530
TEST=browser_tests:PPAPINaClTest.UDPSocketPrivate
Review URL: https://chromiumcodereview.appspot.com/10332086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in anticipation of removing nacl::RefCounted from native_client, as
it is only used by Chromium code.
BUG=123295
TEST=it compiles
Review URL: https://chromiumcodereview.appspot.com/10386100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We no longer need to need to build ppapi_proxy in nacl_env now that
I've removed the irt=0 build option from the NaCl side, and now that
I've fixed a test that was accidentally bypassing the IRT.
This change should make the NaCl build faster since it will compile
ppapi_proxy once rather than twice. It should also stop us bypassing
the IRT accidentally.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2648
TEST=nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10384094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this code, NaCl's "chrome_browser_tests using GYP" Buildbot
phase on Mac was inexplicably failing. However, that Buildbot phase
no longer exists, so we can presumably remove this.
BUG=114431
TEST=Chromium trybots
Review URL: https://chromiumcodereview.appspot.com/10392026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test was using an old-style library list so it was running
against a version of libppruntime supplied by the web app instead of
the version built into the IRT library supplied by the system.
This change should save a lot of build time in nacl_integration, which
should no longer compile libppruntime.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2648
TEST=nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10383096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've been doing some cleanup in this code recently and it would make
it easier if I could send reviews to others who aren't in OWNERS but
who know the NaCl Scons build well.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10378077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=simple usage test in nacl
Review URL: https://chromiumcodereview.appspot.com/10354004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to make TestFailures() pass fully, we have to add a NULL
callback check to Create().
BUG=none
TEST=browser_tests
Review URL: http://codereview.chromium.org/10221026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
note: the bug ref is for a different issue, but a CL in that
issue is the one that originally bumped the number of stress
test iterations.
BUG=http://code.google.com/p/chromium/issues/detail?id=120728
TEST=ppapi_ppb_image_data.cc
Review URL: http://codereview.chromium.org/10317025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
These headers make using gl extensions easier.
BUG=none
TEST=ppb_graphics3d,building of gles book examples
Review URL: https://chromiumcodereview.appspot.com/10290006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cleanup has been made possible by moving
sel_ldr_launcher_chrome.cc into the Chromium repo.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750
TEST=build
Review URL: https://chromiumcodereview.appspot.com/10267027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I moved sel_ldr_launcher_chrome.cc into the Chromium repo in r134552
but I forgot to update build.scons. This update is necessary for
removing sel_ldr_launcher_chrome.cc from the NaCl repo because it
ensures that the 'launch_nacl_process' variable (which module_ppapi.cc
assigns to) will be defined. (The alternative would be to
conditionalise the assignment of 'launch_nacl_process' in
module_ppapi.cc.)
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750
TEST=NaCl's Scons build
Review URL: http://codereview.chromium.org/10261016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow the launch_nacl_process() callback to be simplified by
removing unused arguments. But for now, I have left
sel_ldr_launcher_chrome.cc unchanged except to change its use of
namespaces.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750
TEST=nacl_integration etc.
Review URL: https://chromiumcodereview.appspot.com/10266003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The instrumentation in this CL served its purpose, and is now being removed.
BUG= http://code.google.com/p/chromium/issues/detail?id=122057
TEST= none
Review URL: http://codereview.chromium.org/10236013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10255009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium/issues/detail?id=124863
TEST=various CWS titles
Review URL: http://codereview.chromium.org/10213015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This declaration prevents us from defining SelLdrLauncher via a
typedef. Plus it should really be a class, not a struct.
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/10192003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=this is the test
Review URL: http://codereview.chromium.org/10226012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function is not defined or used anywhere any more.
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/10198008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The functions ByteStringAsUTF8() and ByteStringFromUTF8() are no longer used.
BUG=none
TEST=build
Review URL: https://chromiumcodereview.appspot.com/10206009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium/issues/detail?id=120837
TEST=variuos nacl audio samples
Review URL: http://codereview.chromium.org/10165016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
like a complete example (rather then autogenerate them).
This reverts part of r133327.
Bail out for PNaCl for now, until we turn on these tests.
BUG= none
TEST= trybots
Review URL: https://chromiumcodereview.appspot.com/10191008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
compatible, even though they are currently marked broken for PNaCl.
Bail out for partly_invalid, since:
- that depends on a nexe built from a nacl.scons file in NaCl repo and
- the nexe name doesn't follow the autogenerator's pattern
- and the nacl repo's pyauto expects the .nmf
Can untie those dependencies later...
This will allow use to run ./scons bitcode=1 platform=${arch}
again, without complaints about missing .nexe dependencies
required by the checked-in NMF files, even though we are
generating .pexes.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2609
TEST= trybots
Review URL: http://codereview.chromium.org/10166018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In a later change, I will make KillChildProcess() not work on Windows,
because the sandboxed renderer process will not get passed the process
handle for the NaCl loader proces, so the renderer cannot kill the
NaCl loader process directly.
So I'm removing KillChildProcess() for consistency between OSes and to
avoid confusion.
Also, I suspect KillChildProcess() does not work in other sandboxes
anyway:
* In the Linux SUID sandbox, the renderers run in a different PID
namespace, but the NaCl plugin is using a PID from the main PID
namespace, which is wrong.
* In the Linux seccomp sandbox (debug builds only), kill() is
disabled.
* I think kill() is disabled in the Mac sandbox too.
Furthermore, on Unix, if the NaCl loader process dies and its PID is
recycled, we could accidentally kill the wrong process. (Normally the
PID cannot be recycled until the zombie process is reaped with
waitpid(), but in Chromium the NaCl loader process is a child of the
browser, not the renderer. The NaCl process gets reaped automatically
and the NaCl plugin's call to waitpid() is useless.)
Calling KillChildProcess() is unnecessary because the NaCl loader
process is supposed to exit voluntarily when it receives EOF on its
connection to the renderer process.
Removing this call also removes the risk that we do kill(0, SIGKILL)
(if using a dummy PID of 0 later on), which would kill all processes
in the progress group and might bring down the browser.
This will let me remove KillChildProcess() from the NaCl side.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719
TEST=nacl_integration etc.
Review URL: https://chromiumcodereview.appspot.com/10122002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to remove the silly white-list of ported tests in
"native_client/buildbot/buildbot_pnacl.sh" when pnacl_generate_pexe=1,
and just say "chrome_browser_tests".
This was split out of:
http://codereview.chromium.org/9834030/
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2609
TEST= chrome_browser_tests
Review URL: https://chromiumcodereview.appspot.com/10115044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132886 0039d316-1c4b-4281-b951-d872f2087c98
|