| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10253017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cleanup has been made possible by moving
sel_ldr_launcher_chrome.cc into the Chromium repo.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750
TEST=build
Review URL: https://chromiumcodereview.appspot.com/10267027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10213005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I moved sel_ldr_launcher_chrome.cc into the Chromium repo in r134552
but I forgot to update build.scons. This update is necessary for
removing sel_ldr_launcher_chrome.cc from the NaCl repo because it
ensures that the 'launch_nacl_process' variable (which module_ppapi.cc
assigns to) will be defined. (The alternative would be to
conditionalise the assignment of 'launch_nacl_process' in
module_ppapi.cc.)
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750
TEST=NaCl's Scons build
Review URL: http://codereview.chromium.org/10261016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow the launch_nacl_process() callback to be simplified by
removing unused arguments. But for now, I have left
sel_ldr_launcher_chrome.cc unchanged except to change its use of
namespaces.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750
TEST=nacl_integration etc.
Review URL: https://chromiumcodereview.appspot.com/10266003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119511
TEST=none
TBR=brettw
Review URL: https://chromiumcodereview.appspot.com/10260015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the manual Flash interface registration and adds them via the
interfaces_ppb_private_flash.h header. I moved File_ModulalLocal and
File_FileRef to the Flash API virtual interface which allowed me to delete
the separate proxies and stuff associated with those interfaces.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10169040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
List files in 'test_common_source_files' instead of listing them in
both 'test_nacl_source_files' and 'test_trusted_source_files'.
This makes it more obvious which tests are not yet enabled for NaCl.
Note that test_memory.cc was listed twice in the NaCl section, and
tests/test_mouse_cursor.h was missing from the trusted section.
BUG=none
TEST=trybots
Review URL: https://chromiumcodereview.appspot.com/10257017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The FunctionGroupBase stuff was intended to used for our manual RTTI for
interfaces not associated with resources. However, we've been putting most
of those interfaces on the PPB_Instance_API which allows us to skip a
whole lot of routing, setup, and boilerplate code.
This patch moves the two remaining classes deriving from FunctionGroupBase
and moves them to special getters on the globals class. We'll keep these
classes around and since there are only two, it seems to warrant the special
case.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10168026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The instrumentation in this CL served its purpose, and is now being removed.
BUG= http://code.google.com/p/chromium/issues/detail?id=122057
TEST= none
Review URL: http://codereview.chromium.org/10236013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10255009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
deps. Most of these are already listed in DEPS files, and it seems that we want to prevent includes on them just like normal directories that are in our tree (otherwise content can depend on native_client, for ex)
Review URL: https://chromiumcodereview.appspot.com/10248005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This shares the implementation with the PDF interface. I put the implementation
in the Flash file since that file was already so much smaller, and this one
function didn't seem worth creating a new shared file for.
This also does some cleanup of the Chrome PPB interfaces. I separated out the
implementation of the NaCl interface into its own file, and moved everything
into a new renderer/pepper subdirectory.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10173029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to delete a bunch of separate files that just do routing.
TEST=none
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10170014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium/issues/detail?id=124863
TEST=various CWS titles
Review URL: http://codereview.chromium.org/10213015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This declaration prevents us from defining SelLdrLauncher via a
typedef. Plus it should really be a class, not a struct.
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/10192003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
change, just trying to fix the auto-generated documentation.
BUG=none
TEST=none
R=dmichael@chromium.org
Review URL: http://codereview.chromium.org/10236012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
sentence in audio_config.h.
Review URL: http://codereview.chromium.org/10069017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it will call the audio callback with an invalid buffer.
This also shifts all the state checks into the start of StartThread for safety/clarity. Note that this changes the behavior very slightly in that shared memory will be mapped even if a callback is not provided. However, AFAICT this will not be the common case and IMO simplifies the logic here. If you disagree, I'm happy to add the additional check.
BUG=118346
TEST=Audio tests
Review URL: http://codereview.chromium.org/10107021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=this is the test
Review URL: http://codereview.chromium.org/10226012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119511
TEST=none
TBR=brettw
Review URL: https://chromiumcodereview.appspot.com/10232014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:120470
TEST=browser_tests:*.UDPSocketPrivate
Review URL: http://codereview.chromium.org/10196012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Because PPB_Var_Deprecated_Proxy::OnMsgReleaseObject() can
defer a ReleaseVar() call past the time an instance is destroyed, and because
as part of instance destruction HostVarTracker::ForceReleaseNPObject() forcibly
zeroes a variable's ref_count and deletes it, the deferred ReleaseVar() call
will hit this path frequently and blow up the debugger.
Review URL: https://chromiumcodereview.appspot.com/10227009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to delete the separate proxy files for this.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10163012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WebSocket API defines that call to Close() on CLOSED state must do nothing
and cause no error. Currently Pepper API returns PP_ERROR_INPROGRESS. This
error code is confusing. We should return PP_OK here.
BUG=124866
TEST=browser_tests --gtest_filter='*WebSocket*'
Review URL: http://codereview.chromium.org/10169036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function is not defined or used anywhere any more.
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/10198008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The functions ByteStringAsUTF8() and ByteStringFromUTF8() are no longer used.
BUG=none
TEST=build
Review URL: https://chromiumcodereview.appspot.com/10206009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IDL defines close behavior as it ignores the reason argument if the type of
reason is PP_VARTYPE_UNDEFINED.
BUG=124609
TEST=browser_tests --gtest_filter='*WebSocket*'
Review URL: http://codereview.chromium.org/10167028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was a bit tricky since some of the functions had no instance context, so I added global functions on the PpapiGlobals interface for them. It would be nice to add a PP_Instance argument and fix this in the future.
I did a new style of doing the thunking. The "function APIs" haven't really worked out since it's almost always easier to add the functions directly on the instance one. Since this is a larger and more separable chunk, I just added a getter on the instance API for the flash API and thunk through that. I'd like to convert the remaining ~3 function APIs to either call directly on the instance or use this method, but that's not addressed by this patch.
I moved the flash command line switch to plugin_switches so this could be hooked up properly. It allowed me to delete the delegate API for this.
I combined the flash fullscreen functions into the new Flash API which removed a bit of code.
Review URL: https://chromiumcodereview.appspot.com/10091003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
ppapi_proxy_untrusted.gyp should now build with a single link error for main.
BUG=116317
TEST=builds with a single link error for main().
Review URL: https://chromiumcodereview.appspot.com/10167024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium/issues/detail?id=120837
TEST=variuos nacl audio samples
Review URL: http://codereview.chromium.org/10165016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
like a complete example (rather then autogenerate them).
This reverts part of r133327.
Bail out for PNaCl for now, until we turn on these tests.
BUG= none
TEST= trybots
Review URL: https://chromiumcodereview.appspot.com/10191008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DeepCopy creates a ListValue*, which swap (correctly) doesn't free.
CID=103840
R=brettw,raymes
BUG=
TEST=
Review URL: http://codereview.chromium.org/10168015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=viettrungluu@chromium.org
TEST=
BUG=
Review URL: http://codereview.chromium.org/10162022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
compatible, even though they are currently marked broken for PNaCl.
Bail out for partly_invalid, since:
- that depends on a nexe built from a nacl.scons file in NaCl repo and
- the nexe name doesn't follow the autogenerator's pattern
- and the nacl repo's pyauto expects the .nmf
Can untie those dependencies later...
This will allow use to run ./scons bitcode=1 platform=${arch}
again, without complaints about missing .nexe dependencies
required by the checked-in NMF files, even though we are
generating .pexes.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2609
TEST= trybots
Review URL: http://codereview.chromium.org/10166018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10170010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the message routing. The message is sent over the "broker" channel in this case which normally connects to the renderer. Switching this over to be the main plugin <-> browser channel is extra work since we'd need a way to plumb through the response. Since we already do this weird routing for the NPAPI plugin, doing the same thing is the simplest here.
I moved the code to the broker dispatcher which is the endpoint for the channel that's used.
This removes the timeout for sending the clear message. This made it challenging to debug since if you load the plugin in the debugger, the message never gets sent. This could legitimately happen if the computer is swapping and is super slow to load the plugin. It seems if you want to clear your data, we shouldn't "forget" to clear it in certain cases. So I just left this code out.
Review URL: https://chromiumcodereview.appspot.com/10155001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10130001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In a later change, I will make KillChildProcess() not work on Windows,
because the sandboxed renderer process will not get passed the process
handle for the NaCl loader proces, so the renderer cannot kill the
NaCl loader process directly.
So I'm removing KillChildProcess() for consistency between OSes and to
avoid confusion.
Also, I suspect KillChildProcess() does not work in other sandboxes
anyway:
* In the Linux SUID sandbox, the renderers run in a different PID
namespace, but the NaCl plugin is using a PID from the main PID
namespace, which is wrong.
* In the Linux seccomp sandbox (debug builds only), kill() is
disabled.
* I think kill() is disabled in the Mac sandbox too.
Furthermore, on Unix, if the NaCl loader process dies and its PID is
recycled, we could accidentally kill the wrong process. (Normally the
PID cannot be recycled until the zombie process is reaped with
waitpid(), but in Chromium the NaCl loader process is a child of the
browser, not the renderer. The NaCl process gets reaped automatically
and the NaCl plugin's call to waitpid() is useless.)
Calling KillChildProcess() is unnecessary because the NaCl loader
process is supposed to exit voluntarily when it receives EOF on its
connection to the renderer process.
Removing this call also removes the risk that we do kill(0, SIGKILL)
(if using a dummy PID of 0 later on), which would kill all processes
in the progress group and might bring down the browser.
This will let me remove KillChildProcess() from the NaCl side.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719
TEST=nacl_integration etc.
Review URL: https://chromiumcodereview.appspot.com/10122002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=viettrungluu@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10127006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10096001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to remove the silly white-list of ported tests in
"native_client/buildbot/buildbot_pnacl.sh" when pnacl_generate_pexe=1,
and just say "chrome_browser_tests".
This was split out of:
http://codereview.chromium.org/9834030/
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2609
TEST= chrome_browser_tests
Review URL: https://chromiumcodereview.appspot.com/10115044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The handle_pass library is no longer needed because it is replaced by
Chromium's BrokerDuplicateHandle() function.
Removing the Chromium-side uses will let me delete the library on the
NaCl side.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719
TEST=nacl_integration etc.
Review URL: https://chromiumcodereview.appspot.com/10083035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This CL moves non-NaCl interface proxies like Flash, and also
temporarily moves unported interfaces such as Graphics3D.
BUG=116317
TEST=builds without PPAPI link errors
Review URL: https://chromiumcodereview.appspot.com/10116003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=120837
TEST=See bug
Review URL: http://codereview.chromium.org/9921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=MSVS 2010 stops recompiling like mad
TBR=brettw,oshima,ivankr
Review URL: http://codereview.chromium.org/10108030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/10105036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pass BrokerDuplicateHandle() to the NaCl loader process in
nacl_listener.cc.
Pass BrokerDuplicateHandle() to the NaCl trusted plugin. We need to
add this to PPB_NaCl_Private in order to pass it through.
Remove the use of the "init_handle_passing" SRPC call. Otherwise the
NaCl process will attempt to do an imc_connect() to the renderer,
which involves sending a handle to it, which fails.
Add a wrapper for AddTargetPeer() to 'content' so that
nacl_process_host.cc can use it.
Change the renderer's handle-passing policy to allow sending handles
other than Sections. The NaCl trusted plugin sends other handle types
to the NaCl loader process.
This change will allow the sandbox to be tightened up, in the future,
so that the NaCl loader process and the renderer process do not have
handles to each other.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719
TEST=nacl_integration etc.
Review URL: https://chromiumcodereview.appspot.com/10039001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow optional remote callback, then perform synchronous completion
if receiving data is enough small for SRPC buffer. Otherwise invoke
another callback for asynchronous completion from main thread.
BUG=87310
TEST=browser_tests --gtest_filter=PPAPINaclTest.WebSocket_StressedSendReceive
Review URL: https://chromiumcodereview.appspot.com/9802027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
not found.
BUG=123184
TEST=
Review URL: http://codereview.chromium.org/10082013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132327 0039d316-1c4b-4281-b951-d872f2087c98
|