summaryrefslogtreecommitdiffstats
path: root/ppapi
Commit message (Collapse)AuthorAgeFilesLines
* Remove explicit keyword from multi-argument (w/o default values) constructorsdilmah@chromium.org2011-07-262-4/+4
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7477008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94115 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented CommandBuffer::GetState Graphics3D.apatrick@chromium.org2011-07-261-0/+5
| | | | | | | I'm not sure how it worked without it. Review URL: http://codereview.chromium.org/7493032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94001 0039d316-1c4b-4281-b951-d872f2087c98
* Update PPB_Flash_TCPSocket implementation to support force async callback.yzshen@chromium.org2011-07-252-16/+22
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7485014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93971 0039d316-1c4b-4281-b951-d872f2087c98
* Re-added decoder id to PPP_VideoDecoder_Dev methodsfischman@chromium.org2011-07-224-37/+64
| | | | | | | | | | | | This supports having multiple decoders per PP_Instance, which was removed as part of 92704. BUG=none TEST=gles2 works, trybots Review URL: http://codereview.chromium.org/7489012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93691 0039d316-1c4b-4281-b951-d872f2087c98
* PPAPI: Make forceasync callback option the default.polina@google.com2011-07-222-11/+4
| | | | | | | | BUG=79376 TEST=ppapi_tests + NaCl integration Review URL: http://codereview.chromium.org/7461023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93682 0039d316-1c4b-4281-b951-d872f2087c98
* Fix return value when unfiltered keyboard events are registered.dmichael@chromium.org2011-07-221-4/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7489011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93662 0039d316-1c4b-4281-b951-d872f2087c98
* Adding linter for IDLnoelallen@google.com2011-07-223-28/+132
| | | | | | | | | | | | | | | | | | Removing current warnings from parser and create a new file which will traverse AST after it is built looking for possible issues. Also includes minor comment cleanup for visitor class on which the linter is based. TEST= python idl_parser.py BUG= http://code.google.com/p/chromium/issues/detail?id=76271 R= sehr@google.com Review URL: http://codereview.chromium.org/7468012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93655 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the requirement that keyboard events be sent in filtered mode. Thisbrettw@chromium.org2011-07-222-17/+19
| | | | | | | | hurts some higher-performance game use cases, and probably won't help much to prevent abuse. Review URL: http://codereview.chromium.org/7481021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93641 0039d316-1c4b-4281-b951-d872f2087c98
* Fix input event resource proxying functions in the Chrome IPC proxy. Thebrettw@chromium.org2011-07-223-4/+46
| | | | | | | message-specific PPB interfaces were'nt hooked up. Review URL: http://codereview.chromium.org/7479008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93639 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify the requirements of the GetInterface function that the plugin mustbrettw@chromium.org2011-07-222-1/+21
| | | | | | | implement to include warnings about reentrancy and using other functions. Review URL: http://codereview.chromium.org/7486015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93638 0039d316-1c4b-4281-b951-d872f2087c98
* Reland http://codereview.chromium.org/7484003/:dmichael@chromium.org2011-07-222-54/+1
| | | | | | | | | | | | | | Remove backwards compatibility for PPP_Instance 0.5 and old input events. Note this can't land until the associated NaCl DEPS roll is landed: http://codereview.chromium.org/7478001/ BUG=none TEST=ppapi tests TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/7488003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93540 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 93523 - Remove backwards compatibility for PPP_Instance 0.5 and old ↵dmichael@chromium.org2011-07-222-1/+54
| | | | | | | | | | | | | | | | input events. I already rolled DEPS of the PPP_Instance and input events change in NaCl. I may need to land the associated DEPS of NaCl in Chrome before committing this one: http://codereview.chromium.org/7481008/ BUG=84519 TEST=trybots Review URL: http://codereview.chromium.org/7484003 TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/7484019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93529 0039d316-1c4b-4281-b951-d872f2087c98
* Remove backwards compatibility for PPP_Instance 0.5 and old input events.dmichael@chromium.org2011-07-222-54/+1
| | | | | | | | | | | I already rolled DEPS of the PPP_Instance and input events change in NaCl. I may need to land the associated DEPS of NaCl in Chrome before committing this one: http://codereview.chromium.org/7481008/ BUG=84519 TEST=trybots Review URL: http://codereview.chromium.org/7484003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93523 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 93066 - Execute all GL commands up to the put offset reported by a ↵apatrick@chromium.org2011-07-211-0/+5
| | | | | | | | | | | each flush.This means glFlush is a barrier that prevents reordering of GL commands issued on different command buffers. I used it to replace latches for synchronizing the rendering of WebGL canvas and Pepper 3D with the accelerated compositor. The primary advantage is it is more robust than latches and there is no possibility of deadlock. It should also be possible for WebGL and Pepper 3D to use it whereas exposing SetLatch and WaitLatch would be dangerous. The calls to SetLatch and WaitLatch are still in webkit but they are no-ops. SetLatch and WaitLatch are completely removed elsewhere.I changed CommandBuffer::FlushSync to Finish to reflect the new semantics. Going forward, I will add a synchronous CommandBuffer::WaitForToken and WaitForAvailableEntries, which should eliminate the need to call Finish unless glFinish is called by the client. The Pepper interface is unchanged because I don't want to break binary compatibility.I fixed a bug where the last read token in CmdBufferHelper was stale after receiving a ReportState IPC. That was causing a redundant synchronous flush in the client side SwapBuffers throttling. I removed Yield because it does not make sense with the new semantics. There is no round robin scheduling.Tested with WebGL on Windows and Mac and checked that 72672 did not regress. Review URL: http://codereview.chromium.org/7466022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93479 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in PPB_URLLoader_Impl, where didFail invokes a null callback.bbudge@chromium.org2011-07-212-0/+44
| | | | | | Review URL: http://codereview.chromium.org/7371013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93345 0039d316-1c4b-4281-b951-d872f2087c98
* Trivial fix for IDL to H deltanoelallen@google.com2011-07-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | ppp_instance has a block of injected code: typedef PPP_Instance PPP_Instance_1_0; This was not updated to _1_0 from _0_5 when the version number was bumped. Since #include blocks are injected as is, instead of generated, changes that are version dependent will create problems later. This CL fixes the IDL so that it generates the correct thing, however, a better fix would be to either always generate type typedef automatically, or to not rely on the typedef in this way. This particular issue is more confusing in that it is the only instance of this requirement. TEST= trybots BUG= none R= brettw@chromium.org Review URL: http://codereview.chromium.org/7472015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93291 0039d316-1c4b-4281-b951-d872f2087c98
* Convert input event to interface version 1.0. Rename some of the mouse andbrettw@chromium.org2011-07-2020-172/+416
| | | | | | | | | | | | | | | | | | wheel events to remove the redundant "Mouse" and "Wheel" in the getters. Rename PP_INPUTEVENT_TYPE_MOUSEWHEEL to .._WHEEL so that it doesn't look like a mouse event (it's its own type). Add documentation to the C++ wrapper from the C wrappers. Do some minor documentation updates. Update IDL for some of the recent changes we've made. Update the way points are passed for resource creation since IDL wanted to do it by pointer. TEST=it compiles. Review URL: http://codereview.chromium.org/7464003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93263 0039d316-1c4b-4281-b951-d872f2087c98
* Redid VideoDecodeAccelerator::Error codes and propagated to ppapi.fischman@chromium.org2011-07-204-29/+49
| | | | | | | | | BUG=none TEST=chrome builds, gles2 & ovdatest pass, trybots Review URL: http://codereview.chromium.org/7452010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93251 0039d316-1c4b-4281-b951-d872f2087c98
* Reland http://codereview.chromium.org/7452002/ againdmichael@chromium.org2011-07-2018-257/+108
| | | | | | | | | | | | | | Update chromoting input events. (Clang caught this. Thanks, Clang!) Note I'm leaving in temporary backwards-compatibility. BUG=None TEST=ppapi tests TBR=brettw,sergeyu Review URL: http://codereview.chromium.org/7466008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 93223 - Reland http://codereview.chromium.org/7452002/dmichael@chromium.org2011-07-2018-108/+257
| | | | | | | | | | | | | | | | | | Update chromoting input events. (Clang caught this. Thanks, Clang!) Note I'm leaving in temporary backwards-compatibility. brettw, just need a rubber-stamp. This is the same as the last CL. awong/garykac/sergeyu, looking for someone on chromoting team to glance at my changes and make sure I didn't do anything you don't like. This is a high priority for 14, so please look if you can. BUG=None TEST=ppapi tests Review URL: http://codereview.chromium.org/7466002 TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/7471006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93229 0039d316-1c4b-4281-b951-d872f2087c98
* Reland http://codereview.chromium.org/7452002/dmichael@chromium.org2011-07-2018-257/+108
| | | | | | | | | | | | | | | Update chromoting input events. (Clang caught this. Thanks, Clang!) Note I'm leaving in temporary backwards-compatibility. brettw, just need a rubber-stamp. This is the same as the last CL. awong/garykac/sergeyu, looking for someone on chromoting team to glance at my changes and make sure I didn't do anything you don't like. This is a high priority for 14, so please look if you can. BUG=None TEST=ppapi tests Review URL: http://codereview.chromium.org/7466002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93223 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 93202 - Remove HandleInputEvent from PPP_Instance and freeze to 1.0.dmichael@chromium.org2011-07-2018-108/+257
| | | | | | | | | | | | | | Note I'm leaving in temporary backwards-compatibility. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2035 TEST=ppapi tests Review URL: http://codereview.chromium.org/7452002 TBR=dmichael@chromium.org Review URL: http://codereview.chromium.org/7467002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93208 0039d316-1c4b-4281-b951-d872f2087c98
* Remove HandleInputEvent from PPP_Instance and freeze to 1.0.dmichael@chromium.org2011-07-2018-257/+108
| | | | | | | | | | | Note I'm leaving in temporary backwards-compatibility. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2035 TEST=ppapi tests Review URL: http://codereview.chromium.org/7452002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93202 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 93066 - Execute all GL commands up to the put offset reported by a ↵apatrick@chromium.org2011-07-201-5/+0
| | | | | | | | | | | each flush.This means glFlush is a barrier that prevents reordering of GL commands issued on different command buffers. I used it to replace latches for synchronizing the rendering of WebGL canvas and Pepper 3D with the accelerated compositor. The primary advantage is it is more robust than latches and there is no possibility of deadlock. It should also be possible for WebGL and Pepper 3D to use it whereas exposing SetLatch and WaitLatch would be dangerous.The calls to SetLatch and WaitLatch are still in webkit but they are no-ops. SetLatch and WaitLatch are completely removed elsewhere.I changed CommandBuffer::FlushSync to Finish to reflect the new semantics. Going forward, I will add a synchronous CommandBuffer::WaitForToken and WaitForAvailableEntries, which should eliminate the need to call Finish unless glFinish is called by the client. The Pepper interface is unchanged because I don't want to break binary compatibility.I fixed a bug where the last read token in CmdBufferHelper was stale after receiving a ReportState IPC. That was causing a redundant synchronous flush in the client side SwapBuffers throttling.I removed Yield because it does not make sense with the new semantics. There is no round robin scheduling.Tested with WebGL on Windows and Mac and checked that 72672 did not regress. Review URL: http://codereview.chromium.org/7253052 TBR=apatrick@chromium.org Review URL: http://codereview.chromium.org/7458010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93143 0039d316-1c4b-4281-b951-d872f2087c98
* Move check for Javascript URL to ↵bbudge@chromium.org2011-07-202-0/+27
| | | | | | | | PPB_URLRequestInfo_Impl::RequiresUniversalAccess to fix issue http://code.google.com/p/chromium/issues/detail?id=89738 and http://code.google.com/p/chromium-os/issues/detail?id=17401. This is a redo of this CL http://codereview.chromium.org/7006004/. Review URL: http://codereview.chromium.org/7448003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93142 0039d316-1c4b-4281-b951-d872f2087c98
* Missing changes for IDLnoelallen@google.com2011-07-194-8/+55
| | | | | | | | | | To minor changes to comments for the IDL. Updated pp_stdint.idl so that we could generate it instead of checking in pp_stdint.h. In addition it now provides a location for defining built in types. Eventually we can migrate type properties into this file. Review URL: http://codereview.chromium.org/7448005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93125 0039d316-1c4b-4281-b951-d872f2087c98
* Binding Graphics3D with Instance and OpenGLES2 interface.alokp@chromium.org2011-07-1910-893/+956
| | | | | | | BUG=86370,78087 Review URL: http://codereview.chromium.org/7409003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93086 0039d316-1c4b-4281-b951-d872f2087c98
* Allow creation of input events. Revert changes to testing interface forbrettw@chromium.org2011-07-1911-41/+280
| | | | | | | | | creating keyboard events. TEST=manual Review URL: http://codereview.chromium.org/7443005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93076 0039d316-1c4b-4281-b951-d872f2087c98
* Execute all GL commands up to the put offset reported by a each flush.This ↵apatrick@chromium.org2011-07-192-8/+5
| | | | | | | | means glFlush is a barrier that prevents reordering of GL commands issued on different command buffers. I used it to replace latches for synchronizing the rendering of WebGL canvas and Pepper 3D with the accelerated compositor. The primary advantage is it is more robust than latches and there is no possibility of deadlock. It should also be possible for WebGL and Pepper 3D to use it whereas exposing SetLatch and WaitLatch would be dangerous.The calls to SetLatch and WaitLatch are still in webkit but they are no-ops. SetLatch and WaitLatch are completely removed elsewhere.I changed CommandBuffer::FlushSync to Finish to reflect the new semantics. Going forward, I will add a synchronous CommandBuffer::WaitForToken and WaitForAvailableEntries, which should eliminate the need to call Finish unless glFinish is called by the client. The Pepper interface is unchanged because I don't want to break binary compatibility.I fixed a bug where the last read token in CmdBufferHelper was stale after receiving a ReportState IPC. That was causing a redundant synchronous flush in the client side SwapBuffers throttling.I removed Yield because it does not make sense with the new semantics. There is no round robin scheduling.Tested with WebGL on Windows and Mac and checked that 72672 did not regress. Review URL: http://codereview.chromium.org/7253052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93066 0039d316-1c4b-4281-b951-d872f2087c98
* Update the widget API to use the new InputEvent resource rather than the oldbrettw@chromium.org2011-07-199-21/+59
| | | | | | | | | | PP_InputEvent struct. TEST=manual BUG=none Review URL: http://codereview.chromium.org/7399035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93044 0039d316-1c4b-4281-b951-d872f2087c98
* Create a way to iterate over instances in a module in the C++ wrapper.brettw@chromium.org2011-07-191-1/+5
| | | | | | | | | | Remove out-of-date TODO comment in ppb_core. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/7395008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93043 0039d316-1c4b-4281-b951-d872f2087c98
* Removing file io, file ref, and file sytem from dev.sanga@chromium.org2011-07-198-148/+1
| | | | | | Review URL: http://codereview.chromium.org/7421002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93038 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented cpp interface for PPB_Graphics3D_Dev. Needed to port gpu demos.alokp@chromium.org2011-07-192-3/+69
| | | | | | | TBR=piman Review URL: http://codereview.chromium.org/6816028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93037 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing IDL Visistor classnoelallen@google.com2011-07-191-0/+81
| | | | | | | | | | | | This class provides a simple mechanism for recursively traversing the AST for both simple and version aware traversal. TBR= sehr@google.com BUG= http://code.google.com/p/chromium/issues/detail?id=87684 TEST= python idl_c_header.py Review URL: http://codereview.chromium.org/7448001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93036 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant size and type information from VideoDecode PPAPIvrk@google.com2011-07-1912-80/+36
| | | | | | | | | | | | | | | | | | | The visible size of the video frame is determined at Create stage. The type of buffer (from system memory or texture-backed via GLES) is decided by the plugin when it calls AssignGLESBuffers or AssignSysmemBuffers in response to ProvidePictureBuffers. The decoded size will be the same as the size requested in ProvidePictureBuffers. Thus these values specified anywhere else is redundant, and introduces a place to have inconsistency. BUG=NONE TEST=ovda unittest passes; gles2 runs w/o crashing Review URL: http://codereview.chromium.org/7021020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93031 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r92885, which was reverted in r92891.alokp@chromium.org2011-07-1918-1/+1234
| | | | | | | | BUG=86370,78087 TBR=piman Review URL: http://codereview.chromium.org/7431001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93028 0039d316-1c4b-4281-b951-d872f2087c98
* Remove common.h from the build. This only included the bool converters whichbrettw@chromium.org2011-07-195-44/+0
| | | | | | | | | have been replaced with the ones in pp_bool.h TEST=it compiles Review URL: http://codereview.chromium.org/7390039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92971 0039d316-1c4b-4281-b951-d872f2087c98
* Update the generatornoelallen@google.com2011-07-195-31/+67
| | | | | | | | | | | | | | | | | Fix output file to ignore modified datestamp and copyright year. Minor pychecker fixes (shadowed built-ins) Add 'Type' so we can define builtin types in pp_stdint.h Remove 'skip' of pp_stdint.idl so we now process it. Setup intelligent defaults for generator. BUG= http://code.google.com/p/chromium/issues/detail?id=84272 TEST= python idl_c_header.py & gcl try Generate the new headers, add them to a CL, and try TBR= sehr@google.com Review URL: http://codereview.chromium.org/7396035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92941 0039d316-1c4b-4281-b951-d872f2087c98
* More trivial cleanupi of ppapi/c headersnoelallen@google.com2011-07-1934-476/+376
| | | | | | | | | | These headers were autogenerated from ppapi/api/*.idl BUG= http://code.google.com/p/chromium/issues/detail?id=76271^M TEST= run try Review URL: http://codereview.chromium.org/7399016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92931 0039d316-1c4b-4281-b951-d872f2087c98
* Update the generatornoelallen@google.com2011-07-1912-345/+1069
| | | | | | | | | | | | | | | | | | | | Outstanding changes to the generator to: Support hashing Support versions Clean up 'C' header generation Update of 'C' header generation tests Fix line wrapping Pass error counts through to File objects BUG= http://code.google.com/p/chromium/issues/detail?id=84272 TEST= python idl_c_header.py & gcl try Generate the new headers, add them to a CL, and try TBR= sehr@google.com Review URL: http://codereview.chromium.org/7408002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92930 0039d316-1c4b-4281-b951-d872f2087c98
* More trivial cleanupi of ppapi/c/trusted headersnoelallen@google.com2011-07-187-85/+205
| | | | | | | | BUG= http://code.google.com/p/chromium/issues/detail?id=76271 TEST= run try Review URL: http://codereview.chromium.org/7396002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92914 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 92885 - Completed the implementation for PPB_Graphics3D interface.alokp@chromium.org2011-07-1818-1233/+1
| | | | | | | | | | | | | | | | | - Mostly copied from the implementations for PPB_Surface3D and PPB_Context3D. - Added the proxy implementation - Refactored common code between host and plugin side into a common class. I will send the changes to bind Graphics3D with Instance and OpenGLES2 interface in a separate patch. BUG=86370,78087 Review URL: http://codereview.chromium.org/6824006 TBR=alokp@chromium.org Review URL: http://codereview.chromium.org/7398033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92891 0039d316-1c4b-4281-b951-d872f2087c98
* Completed the implementation for PPB_Graphics3D interface.alokp@chromium.org2011-07-1818-1/+1233
| | | | | | | | | | | | | | - Mostly copied from the implementations for PPB_Surface3D and PPB_Context3D. - Added the proxy implementation - Refactored common code between host and plugin side into a common class. I will send the changes to bind Graphics3D with Instance and OpenGLES2 interface in a separate patch. BUG=86370,78087 Review URL: http://codereview.chromium.org/6824006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92885 0039d316-1c4b-4281-b951-d872f2087c98
* Removing support dev file interfaces.sanga@chromium.org2011-07-171-1/+1
| | | | | | | | BUG= none TEST= build chrome. Review URL: http://codereview.chromium.org/7395011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92821 0039d316-1c4b-4281-b951-d872f2087c98
* Update the IDLnoelallen@google.com2011-07-1642-782/+3798
| | | | | | | | | | | | | Final update of the IDL so that we can switch to using generated code for ppapi/c/ and ppapi/c/trusted. BUG= http://code.google.com/p/chromium/issues/detail?id=74634 TEST= tryserver TBR= dmichael@chromium.org Review URL: http://codereview.chromium.org/7390023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92805 0039d316-1c4b-4281-b951-d872f2087c98
* [Reverted due to check_deps failure]zea@chromium.org2011-07-152-13/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 92749 - Fix problem when 'ended' event was fired before stream really ended. That caused impression that rewind does not work. With that change small JS program var a = new Audio("file:///home/enal/temp/click2/click2.wav"); var num_played = 0; a.addEventListener('canplaythrough', function() { a.play(); }); a.addEventListener('ended', function() { num_played ++; if (num_played < 10) { a.currentTime = 0; a.play(); } }); works correctly, you hear 10 clicks one after another, and it takes ~1.5 seconds to play all 10 sounds (one click is 146ms). Current Chrome plays only beginnings of the first 9 clicks and then entire 10th click -- 'ended' event fires too early, so rewind stops audio playback for all clicks but last one. With that fix you can easily create pool of audio objects -- on 'ended' event just add audio object to the pool. Fix consists of 3 parts: 1) For low-latency code path pass entire "audio state" object to the renderer process. That allows renderer take into account number of pending bytes in the buffer. 2) When using low-latency code path renderer not only fills the buffer with data, but also writes length of data into first word of the buffer. That allows host process to pass correct byte counts to renderer. 3) Renderer now keeps track of the earliest time playback can end based on the number of rendered bytes, and will not call 'ended' callback till that time. BUG=http://code.google.com/p/chromium/issues/detail?id=78992 http://codereview.chromium.org/7328030 Review URL: http://codereview.chromium.org/7328030 TBR=enal@chromium.org Review URL: http://codereview.chromium.org/7395014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92753 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem when 'ended' event was fired before stream really ended.enal@chromium.org2011-07-152-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | That caused impression that rewind does not work. With that change small JS program var a = new Audio("file:///home/enal/temp/click2/click2.wav"); var num_played = 0; a.addEventListener('canplaythrough', function() { a.play(); }); a.addEventListener('ended', function() { num_played ++; if (num_played < 10) { a.currentTime = 0; a.play(); } }); works correctly, you hear 10 clicks one after another, and it takes ~1.5 seconds to play all 10 sounds (one click is 146ms). Current Chrome plays only beginnings of the first 9 clicks and then entire 10th click -- 'ended' event fires too early, so rewind stops audio playback for all clicks but last one. With that fix you can easily create pool of audio objects -- on 'ended' event just add audio object to the pool. Fix consists of 3 parts: 1) For low-latency code path pass entire "audio state" object to the renderer process. That allows renderer take into account number of pending bytes in the buffer. 2) When using low-latency code path renderer not only fills the buffer with data, but also writes length of data into first word of the buffer. That allows host process to pass correct byte counts to renderer. 3) Renderer now keeps track of the earliest time playback can end based on the number of rendered bytes, and will not call 'ended' callback till that time. BUG=http://code.google.com/p/chromium/issues/detail?id=78992 http://codereview.chromium.org/7328030 Review URL: http://codereview.chromium.org/7328030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92749 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid leaking file handles.yzshen@chromium.org2011-07-151-2/+6
| | | | | | | | | | | | | | AsyncOpenFileCallback: fix the issue that file handle is leaked if the file handle arrives after the requester has died. This change also fixes test_file_system. BUG=79820 TEST=FileIO/FileRef/FileSystem tests in ppapi_tests: Reload the test page, the test still passes. The output files can be deleted when any of these tests finishes running, no matter the test page is still open or not. Review URL: http://codereview.chromium.org/7327025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92727 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the file dev interfaces. The combination of some dev and some nonbrettw@chromium.org2011-07-1517-668/+74
| | | | | | | | | | | | | dev interfaces in various places makes it impossible to compile some code. This makes the dev versions typedefs which should avoid breaking most (though not all) users. It also converts the file chooser to using the non-dev version of file ref. TEST=it compiles Review URL: http://codereview.chromium.org/7387011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92725 0039d316-1c4b-4281-b951-d872f2087c98
* Enable fire-and-forget Destroy of HW video decoder, and misc other improvements.fischman@chromium.org2011-07-159-97/+55
| | | | | | | | | | | | | | | | | | | | | | | - Instead of requiring the client to wait for NotifyDestroyDone we do the asynchronous OMX teardown dance on the client's behalf. - Prettify/simplify error handling in OVDA for easier matching of errors to OMX_Core.h and to remove redundant information. - Enable previously-DISABLED_ early-teardown unittests! - Remove passing VideoDecoder_Dev object in PPP_VideoDecoder_Dev calls, because it was unnecssary, and because the ~VideoDecoder_Dev dtor is now not a no-op so we don't want to call it spuriously. - Remove accidentally re-added gpu_video_service_host.cc (originally removed in 92251, accidentally reintroduced by a bad rebase in 92383). BUG=none TEST=ovdatest passes (incl. early-teardown tests) and gles2 works (including reload and EOS handling, no crashes) Review URL: http://codereview.chromium.org/7361010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92704 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 11:57:44 +0000