| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enhanced gles2.cc sample plugin to have multipe decodes outstanding at a time,
and assert that we get back from the decode API exactly the bitstream buffers we
sent to it.
This CL is relative to http://codereview.chromium.org/7200033/ which must land first.
BUG=86235
TEST=gles2 sample plugin completes correctly even with concurrent Decode()s.
Review URL: http://codereview.chromium.org/7204038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Startup crash was being caused by deleting the Context3D object out from under a
running OmxVideoDecodeAccelerator, which would trigger a SEGV in the GPU
process, which would cause a Graphics3DContextLost callback to be fired on the
plugin, which is implemented as an assert(false). The delete that kicked all
this off was not actually necessary, so removed it.
During-playback crash was being caused by a lack of synchronization between the
GPU command buffer mechanism and the PPAPI impl IPC mechanism (triggered much
more commonly in DEBUG mode, which explains why these weren't seen so much
before).
While debugging this cleaned up and documented some of the bogusity I found that
I didn't want to clean all in one CL:
- Emit type of unhandled message in GpuChannel, and document TODO to fix poor
code structure that confused me.
- Emit EGL error code on CHECK-failures in EGL<->GLES translator.
- Simplify GpuVideoService a bit and remove redundant map lookups.
- Fix ppapi_tests.gypi: my r89636 was too ambitious and ran into the limits of
my understanding of .gyp. This version is less factored but has the benefit
of producing actually-working example plugins.
BUG=none
TEST=manually running gles2.{html,cc} works every time. No crashes.
Review URL: http://codereview.chromium.org/7200033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This another round of minor changes in the IDL to bring it up to date
with the checked in PPAPI 'C' headers. WRT testing, the CL needed
to drive the test is still in flight.
TEST= python idl_c_header.py --wcomment --srcroot=../api --dstroot=hdir ../api/*.idl
BUG= http://code.google.com/p/chromium/issues/detail?id=76271
Review URL: http://codereview.chromium.org/7204019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
idl_option - fix incorrect 'if not X' to 'if X is None' to distinguish between no value (boolean) to empty ('') default value.
idl_output - add function to retreive the filename
TEST= python idl_c_header.py --wcomment --srcroot=../api --dstroot=hdir ../api/*.idl
BUG= http://code.google.com/p/chromium/issues/detail?id=84272
Review URL: http://codereview.chromium.org/7200032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build all newly uncommented targets
Review URL: http://codereview.chromium.org/7204017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the video decoder API to make GetConfigs be a resource member
function so it can be routed with the rest of the resource functions.
This patch also removes the font_list_dev API which was never implemented and
has been replaced with a function on the Font interface.
TEST=manual
BUG=none
Review URL: http://codereview.chromium.org/7193018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, webkit/plugins/ppapi (and proxy) code does not need to use any precompiler defines, and instead refers to each version by its versioned name.
BUG=80696
TEST=Manually run PDF plugin.
Review URL: http://codereview.chromium.org/7197001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=PPAPI UI tests
BUG=none
Review URL: http://codereview.chromium.org/7192012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
cross-origin test doesn't properly check for an error, and the custom-referrer change broke cross-origin requests as a result. Also, there was confusion with some errors being reported as PP_ERROR_FAILED and others as PP_ERROR_NOACCESS. After conversations with WebKit folks, it seems unlikely that a consistent system of error codes can be added, so instead, have PPB_URLLoader_Impl::didFail report PP_ERROR_NOACCESS for unknown error domains (WebKit) and switch on net::kErrorDomain errors from our lower level WebURLLoader.
Review URL: http://codereview.chromium.org/7046091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
moved this to pp::SelectionDev.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/7185007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/7097004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sdch, skia, and testing.
BUG=28727
Review URL: http://codereview.chromium.org/7165009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This takes it in a slightl different direction. Rather than maintaining separate
APIs, proxies, and impls for each interface, I think smaller instance-related
interfaces can just be added on the Instance_API. There's no need for binary
compatibility here and it saves a whole lot of boilerplate. Although
PPB_Instance_API will get large, this isn't necessarily bad, and is probably
more clear than the alternative (it saves a whole lot of code).
This means that the interface IDs no longer have a 1:1 mapping to interface
names. But this was already going to be the case when we have multiple versions
of different interfaces. Currently the code in dispatcher to deal with this is
a bit weird, because of the way the mapping works. Long term, I'm going to
change these from interface IDs in the proxy to API IDs in the thunk layer.
This adds APIs and thunks for several other interfaces without implementing
them yet (this patch was getting too large): URL loading and surface 3D.
TEST=ppapi tests
BUG=none
Review URL: http://codereview.chromium.org/7058015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Write thunk for image data trusted.
BUG=none
TEST=ppapi ui tests
Review URL: http://codereview.chromium.org/7149026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
this adds discussion of the fast shutdown mode where the cleanup functions won't get called.
I also copied the instance documentation to the C++ class since apparently we want the C++ layer to be documented in isolation.
BUG=69909
TEST=none (no code change)
Review URL: http://codereview.chromium.org/7163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=85629
TEST=Printing from the PDF plugin works.
Review URL: http://codereview.chromium.org/7171010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7150005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a class that can be used to generate MHTML for the current
page of a tab.
It is not yet surfaced in the UI.
BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/7044095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requires refcounting Map() to make sure that Unmap() is called once per
underlying SharedMemory.
BUG=85629
TEST=trybots, ui_tests:*PPAPI.Buffer
Review URL: http://codereview.chromium.org/7146007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/7148003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Currently RecommendSampleFrameCount just clamps the value passed in, so passing in 0 returns the min frame count (64) instead of an actual value recommended by the system. As a note, if/when this behavior changes we'll also need to update the NaCl audio walkthrough doc which details the current behavior.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7046115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(and remove no-longer necessary valgrind suppression).
BUG=85825
TEST=trybots
Review URL: http://codereview.chromium.org/7003139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fills in implementation for AssignGLESBuffers where it was missing. Also
updates OmxVideoDecodeAccelerator to reflect the changes.
BUG=NONE
TEST=NONE
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88698
Review URL: http://codereview.chromium.org/6965010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
red test bot in NaCl (lucid-newlib-64-dbg); the problem was caused by garbage values (non-0) in pp:Var being usedto index into the proxy var cache.
BUG=none
TEST=ppapi tests
Review URL: http://codereview.chromium.org/6995138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80696
TEST=none
Review URL: http://codereview.chromium.org/7051009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fills in implementation for AssignGLESBuffers where it was missing. Also
updates OmxVideoDecodeAccelerator to reflect the changes.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6965010
TBR=vrk@google.com
Review URL: http://codereview.chromium.org/7044115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fills in implementation for AssignGLESBuffers where it was missing. Also
updates OmxVideoDecodeAccelerator to reflect the changes.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6965010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=85427,85441
TEST=./ninja/ui_tests --gtest_filter=*PPAPITest.Buffer
Review URL: http://codereview.chromium.org/7108051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7054060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We default to using the target name as the product name;
there's no need to state it twice.
Review URL: http://codereview.chromium.org/7135006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note this doesn't need to use IPC at all, so it's a little strange.
Made test for pp::Var/PPB_Var that does only strings (copied from test_var_deprecated.cc). Fixed string var tracking so test can pass out-of-process (aside from invalid UTF8 checking, which is still not implemented o-o-p).
BUG=85236
TEST=test_var.cc, run tests manually out-of-process.
Review URL: http://codereview.chromium.org/6995083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang recently added a warning that warns when invoking 'delete' on a polymorphic non-final class without a virtual destructor. This finds real bugs – see the bug referenced below for a few examples.
However, one common pattern where it fires is this case:
class SomeInterface {
public:
virtual void interfaceMethod() {} // or = 0;
protected:
~SomeInterface() {}
}
class WorkerClass : public SomeInterface {
public:
// many non-virtual functions, but also:
virtual void interfaceMethod() override { /* do actual work */ }
};
void f() {
scoped_ptr<WorkerClass> c(new WorkerClass); // simplified example
}
(See the 2nd half of http://www.gotw.ca/publications/mill18.htm for an explanation of this pattern.)
It is arguably correct to fire the warning here, since someone might make a subclass of WorkerClass and replace |new WorkerClass| with |new WorkerClassSubclass|. This would be broken since WorkerClass doesn't have a virtual destructor.
The solution that the clang folks recommend is to mark WorkerClass as |final| (a c++0x keyword that clang supports as an extension in normal c++ mode – like override). But chrome's base/OWNERS deemed that as too complicated and we decided to make virtual the destructors of leaf classes that implement these interfaces and that are deleted dynamically. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
(For the gtk files, this is necessary because the CHROMEGTK_CALLBACK_ macros add virtual functions.)
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/7087028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7066058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
constructs a TestCase but never calls the destructor. In the case of TestScrollbar, this causes a surf-away ASSERT because the per-instance objects remain in the global map. A simple fix is to define a virtual destructor for TestingInstance, and in the base implementation, call the destructor for the current TestCase, if any.
BUG=85141
TEST=PPAPITests
Review URL: http://codereview.chromium.org/7064048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6993025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added chidlist which provides in-order access to node children.
Extra warning information on idl_parse.
Added 'srcdir' to parser for prepending path
Added header generator
Fixed minor errors in idl_c_proto
BUG= http://codereview.chromium.org/7085014/
TEST= python idl_c_header.py --srcdir="../api" *.idl
Review URL: http://codereview.chromium.org/7056069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interface functions that take PP_CompletionCallbacks, but don't
return codes from pp_errors.h
87905 - Review URL: http://codereview.chromium.org/6975053
87919 - Review URL: http://codereview.chromium.org/7058061
BUG=85010
TEST=none
Review URL: http://codereview.chromium.org/6975053
Review URL: http://codereview.chromium.org/7058061
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/7112040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
functions that take PP_CompletionCallbacks, but don't
return codes from pp_errors.h
BUG=none
TEST=compile + manually run ppapi_tests::VideoDecoder
Review URL: http://codereview.chromium.org/6975053
TBR=polina@google.com
Review URL: http://codereview.chromium.org/7058061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
return codes from pp_errors.h
BUG=none
TEST=compile + manually run ppapi_tests::VideoDecoder
Review URL: http://codereview.chromium.org/6975053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7085030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running out-of-process.
BUG=none
TEST=Use the Broker in an out-of-process plugin. The Connect callback should be received correctly.
Review URL: http://codereview.chromium.org/7066040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, it would read beyond the end of the PP_GRAPHICS3DATTRIB_NONE-terminated list. This change also ensures that attrib values do not trigger termination.
BUG=none
TEST=Pass a non-NULL attrib_list to the pp::Surface3D_Dev constructor and run the plugin out-of-process.
Review URL: http://codereview.chromium.org/7066041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated idl_log to provide Log/LogTag (which add the log type tag)
Remove stale switches to idl_lexer.py
Add Regex based Replace function to Node to replace $KEY$ with a property on that node
Added quick resolution of typeinfo by adding typeinfo member to IDLNode
Added idl_c_proto.py which defines a set of function which take an IDL Node then
generate the 'C' style equivelent.
BUG= http://code.google.com/p/chromium/issues/detail?id=84272
TEST= python idl_c_proto.py
Review URL: http://codereview.chromium.org/7085014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=82606
TEST=it compiles, tests pass
Review URL: http://codereview.chromium.org/7054042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the ones starting with "F".
Since this adds a lot more interfaces, I added the macro stuff we used for the
old system to generate the various template specializations. This involded a
lot of renaming since the As* needs to match the name (I was previously leaving
off the "PPB_" part). I did other misc cleanup to the infrastructure.
Review URL: http://codereview.chromium.org/7082036
Reland 87415
Review URL: http://codereview.chromium.org/7105013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to and including
the ones starting with "F".
Since this adds a lot more interfaces, I added the macro stuff we used for the
old system to generate the various template specializations. This involded a
lot of renaming since the As* needs to match the name (I was previously leaving
off the "PPB_" part). I did other misc cleanup to the infrastructure.
Review URL: http://codereview.chromium.org/7082036
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/7006022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the ones starting with "F".
Since this adds a lot more interfaces, I added the macro stuff we used for the
old system to generate the various template specializations. This involded a
lot of renaming since the As* needs to match the name (I was previously leaving
off the "PPB_" part). I did other misc cleanup to the infrastructure.
Review URL: http://codereview.chromium.org/7082036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- make sure the result won't be affected by other tests or previous runs of the same test;
- don't assert if the directory to read is empty.
TEST=The test itself.
BUG=63239
Review URL: http://codereview.chromium.org/7094008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7062028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dictionary had a value for colorformat. Added dictionary key for values which are now defined in separate enumeration.
BUG=
TEST=make -j16 chrome (affected functionality not used currently)
Review URL: http://codereview.chromium.org/6965013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87333 0039d316-1c4b-4281-b951-d872f2087c98
|