| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL suspends script callbacks and resource loads while running nested message loop using PPB_Flash_MessageLoop.
BUG=569496
Review URL: https://codereview.chromium.org/1559113002
Cr-Commit-Position: refs/heads/master@{#374529}
(cherry picked from commit dd77c2a41c72589d929db0592565125ca629fb2c)
Review URL: https://codereview.chromium.org/1691513004 .
Cr-Commit-Position: refs/branch-heads/2623@{#365}
Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
block list.
FileSelectHelper subjects suggested filenames to the safe browsing
white/black lists prior to showing the file picker. However, if the list
of accepted file types passed in to the file picker is not empty, and
the suggested filename doesn't match the accepted file types, the file
picker may append an accpeted file extension to the suggested filename.
In order to prevent this from being abused, this CL causes
FileSelectHelper to also verify that the list of accepted file types is
also safe.
R=sky,nparker,bbudge,holte
BUG=575849
Review URL: https://codereview.chromium.org/1613483003
Cr-Commit-Position: refs/heads/master@{#371997}
(cherry picked from commit 78ff0a5433b1c9f6fd2e3cddfc7e9cb28d809853)
Review URL: https://codereview.chromium.org/1685623002 .
Cr-Commit-Position: refs/branch-heads/2623@{#332}
Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=514815, 581951
Review URL: https://codereview.chromium.org/1641323002
Cr-Commit-Position: refs/heads/master@{#372232}
(cherry picked from commit 549080a113a0756a35d760d56ff52873e1739c92)
Review URL: https://codereview.chromium.org/1650643002 .
Cr-Commit-Position: refs/branch-heads/2623@{#198}
Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert to using DISALLOW_COPY_AND_ASSIGN from base/macros.h instead
of NACL_DISALLOW_COPY_AND_ASSIGN.
BUG=302078
TEST=build
Review URL: https://codereview.chromium.org/1581933003
Cr-Commit-Position: refs/heads/master@{#369843}
|
|
|
|
|
|
|
|
| |
BUG=514815
Review URL: https://codereview.chromium.org/1583023006
Cr-Commit-Position: refs/heads/master@{#369793}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the shared and static version of libppapi_cpp have a different
GN target and are depended on a different way. This change unifies both
versions and makes the dependency explicit.
BUG=462791
Review URL: https://codereview.chromium.org/1590613003
Cr-Commit-Position: refs/heads/master@{#369790}
|
|
|
|
|
|
|
|
|
|
|
| |
Some tests check the libraries and symbols linked into the nexe and to
make these pass, we need to replicate the GYP behavior.
BUG=462791
Review URL: https://codereview.chromium.org/1583043002
Cr-Commit-Position: refs/heads/master@{#369604}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes the sync point inserted directly from the command
buffer after swap buffers and just uses GL to insert a fence sync
after each swap buffer instead.
BUG=514815
Review URL: https://codereview.chromium.org/1586883002
Cr-Commit-Position: refs/heads/master@{#369575}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There isn't much that uses bit_cast. bit_cast requires memcpy which
requires <string.h>
On Mac, <string.h> includes AvailabilityInternal.h which is half a
megabyte and defines dozens of macros. Providing <string.h> in
base/macros.h also tempts IWYU violations. Try to avoid it.
Add base/bit_cast.h and include it from the 17 files that need it. Then
remove the <string.h> #include from base/macros.h and IWYU.
BUG=395001
Review URL: https://codereview.chromium.org/399313006
Cr-Commit-Position: refs/heads/master@{#369348}
|
|
|
|
|
|
|
|
|
|
|
| |
These includes are no longer needed and they cause a compilation errors
with nacl_x86_glibc toolchain because of the unsupported C++11 features.
BUG=576820
Review URL: https://codereview.chromium.org/1583883002
Cr-Commit-Position: refs/heads/master@{#369226}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to be sure Ppapi applications can properly pass around sync
tokens, they need to ensure sync tokens have been received by the
Gpu process before passing the sync token. This is done through a
synchronous Nop IPC which gets passed to the Ppapi Host which then
passes a synchronous Nop IPC to the Gpu Process.
BUG=574269, 514815
Review URL: https://codereview.chromium.org/1579013002
Cr-Commit-Position: refs/heads/master@{#368917}
|
|
|
|
|
|
|
|
|
|
|
|
| |
NaCl tests and helpers are build as standalone executables and
hence need to be marked as data_deps to be copied over to shards.
BUG=462791
CQ_EXTRA_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel
Review URL: https://codereview.chromium.org/1563093003
Cr-Commit-Position: refs/heads/master@{#368833}
|
|
|
|
|
|
|
|
|
| |
BUG=555769
R=bbudge
Review URL: https://codereview.chromium.org/1440423003
Cr-Commit-Position: refs/heads/master@{#368617}
|
|
|
|
|
|
|
|
|
|
|
| |
As of https://crrev.com/368312, the IRT no longer uses SRPC.
BUG=302078
TEST=build
Review URL: https://codereview.chromium.org/1570173002
Cr-Commit-Position: refs/heads/master@{#368427}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the last remaining use of SRPC. (I'll remove the remaining
SRPC plumbing in follow-up changes.)
Change pnacl_translate_thread.cc to send its request using Chrome IPC
instead of SRPC. Similarly, change irt_pnacl_translator_compile.cc to
receive its request this way.
* Generalise GetHandleForSubprocess() to work for this other process.
* Use std::string instead of std::vector<char> to avoid needing to
make an extra copy when creating
PpapiMsg_PnaclTranslatorCompileChunk.
BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
Review URL: https://codereview.chromium.org/1564903002
Cr-Commit-Position: refs/heads/master@{#368312}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The argument is meaningless, since the function also takes a source_id and
dest_id, each of which is already bound to a target. This is a refactor and has
no intended behavior change.
BUG=533617
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1551143002
Cr-Commit-Position: refs/heads/master@{#367878}
|
|
|
|
|
|
|
|
| |
BUG=514815
Review URL: https://codereview.chromium.org/1559893003
Cr-Commit-Position: refs/heads/master@{#367457}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#2 id:20001 of https://codereview.chromium.org/1547463004/ )
Reason for revert:
broke windows GN build:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/9754/steps/generate_build_files/logs/stdio
E:\b\build\slave\Win_x64_GN\build\src\buildtools\win\gn gen //out/Release_x64 "--args=is_debug=false is_component_build=false use_goma=true goma_dir=\"E:\b\build\goma\" symbol_level=1" --check
-> returned 1
ERROR Input to target not generated by a dependency.
The file:
//out/Release_x64/nacl_irt_x86_64.nexe
is listed as an input or source for the target:
//chrome/installer/mini_installer:archive(//build/toolchain/win:x64)
but this file was not generated by any dependencies of the target. The target
that generates the file is:
//ppapi/native_client:nacl_irt_debuglink(//build/toolchain/nacl:irt_x64)
Original issue's description:
> GN: Properly mark all NaCl test depencies as data_deps
>
> NaCl tests and helpers are build as standalone executables and
> hence need to be marked as data_deps to be copied over to shards.
>
> BUG=462791
>
> Committed: https://crrev.com/21255d8b9b0ace0629fd941ee128cf9adf356b31
> Cr-Commit-Position: refs/heads/master@{#367367}
TBR=brettw@chromium.org,bradnelson@chromium.org,phosek@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462791
Review URL: https://codereview.chromium.org/1555223002
Cr-Commit-Position: refs/heads/master@{#367396}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Detected using `gn check`, which complains that the target doesn't depend
on :gles2_implementation. It seems reasonable to have //content/renderer
depend only on the interface header.
* Add PPB_Graphics3D_Shared::gles2_interface, which returns a pointer to
the interface (since one would need gles2_implementation.h to know that
it is derived from GLES2Implementation), for use in PPB_Graphics3D_Impl.
* video_decoder_shim.cc no longer has GL_UNPACK_ROW_LENGTH defined without
the implementation header. This should be written to GLES2, so it should
use GL_UNPACK_ROW_LENGTH_EXT from gl2ext.h.
* Include ordering is fixed in video_decoder_shim.cc, and base/logging.h
is made unconditional (since it is needed for DCHECK, which is used
outside preprocessor guards).
Review URL: https://codereview.chromium.org/1543943003
Cr-Commit-Position: refs/heads/master@{#367394}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the second-to-last remaining use of SRPC.
* Change pnacl_translate_thread.cc to send its request using Chrome
IPC instead of SRPC. Similarly, change
irt_pnacl_translator_link.cc to receive its request this way.
* Add plumbing so that pnacl_translate_thread.cc can acquire a Chrome
IPC channel object. Change LaunchSelLdr() (in ppb_nacl_private.h)
to return this channel, and plumb it through service_runtime.h too.
* Extend nacl_message_scanner.cc to handle a couple of things our new
IPC message needs:
* File handles inside of std::vector<>s.
* File handles inside of sync messages. (Previously, only sync
replies were handled.)
* Change a BUILD.gn to account for #includes of
content/public/common/sandbox_init.h and
ppapi/proxy/{serialized_handle.h,ppapi_messages.h}.
BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
Review URL: https://codereview.chromium.org/1512733003
Cr-Commit-Position: refs/heads/master@{#367369}
|
|
|
|
|
|
|
|
|
|
|
| |
NaCl tests and helpers are build as standalone executables and
hence need to be marked as data_deps to be copied over to shards.
BUG=462791
Review URL: https://codereview.chromium.org/1547463004
Cr-Commit-Position: refs/heads/master@{#367367}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This lands patch set 16 of https://codereview.chromium.org/1551753002/
(reviewed there), except for the changes to build/common.gypi and
build/config/compiler/BUILD.gn. The changes to these two files are likely
to break some bot I don't know about, and I don't want to keep reverting
and relanding all these files. So this lands the parts that are hopefully
harmless separately.
BUG=573250
TBR=thestig
Review URL: https://codereview.chromium.org/1557733002
Cr-Commit-Position: refs/heads/master@{#367252}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1552833002
Cr-Commit-Position: refs/heads/master@{#367209}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1545343002
Cr-Commit-Position: refs/heads/master@{#367015}
|
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=mark@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1548993002
Cr-Commit-Position: refs/heads/master@{#366860}
|
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=bbudge@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1548813002
Cr-Commit-Position: refs/heads/master@{#366718}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
event
This fixes a idiosyncrasy in blink input pipeline where when transforming
Core -> Web Input Events, WebInputEvent::timeStampSeconds field would get and
epoch timestamp value instead of a monotonic timestamp.
This occurs for any input event that gets passed to plugins including Pepper
plugins.
The patch does the following:
- Use platform timestamp to populate WebInputEvent::timeStampSeconds
- Teach Pepper to expect monotonic time in theat field and remove all
unnecessary machinery in Pepper to convert event time.
BUG=538199
Review URL: https://codereview.chromium.org/1496193003
Cr-Commit-Position: refs/heads/master@{#366659}
|
|
|
|
|
|
|
|
|
| |
BUG=302078
TEST=none
Review URL: https://codereview.chromium.org/1540953002
Cr-Commit-Position: refs/heads/master@{#366543}
|
|
|
|
|
|
|
|
| |
BUG=557422
Review URL: https://codereview.chromium.org/1535913002
Cr-Commit-Position: refs/heads/master@{#366132}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Introduce AudioOutputBufferParameters in media/audio/audio_parameters.h. This contains number of skipped frames.
* Change the shared memory to hold AudioOutputBufferParameters before the audio data.
* Forward skipped frames by OS on Mac over IPC. Not yet used by any client.
This relands https://codereview.chromium.org/1487983002/ which was reverted due to crackling flash (pepper) audio.
Original CL is in patch set 1.
Will be done in follow-up CLs:
* Forward skipped frames by OS on Windows.
* Forward skipped frames to the WebRTC AEC.
BUG=560371
TBR=dalecurtis@chromium.org,ckehoe@chromium.org (no changes from original CL)
Review URL: https://codereview.chromium.org/1538563002
Cr-Commit-Position: refs/heads/master@{#366078}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tests for the case of building nacl64.exe were not quite right.
The clauses guarded by these tests had some trivial copying errors.
BUG= 512869
R=bbudge@chromium.org
Review URL: https://codereview.chromium.org/1535503002
Cr-Commit-Position: refs/heads/master@{#365860}
|
|
|
|
|
|
|
|
|
|
|
|
| |
PPAPI extensions tests use the same structure as NaCl browser tests and
as such can use the same template which was refactored and moved to
a .gni file which is now used by both types of tests.
BUG=462791, 512900
Review URL: https://codereview.chromium.org/1521843002
Cr-Commit-Position: refs/heads/master@{#365369}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The NaCl toolchains include various libraries, used to build NaCl
executables, whose sources live in //native_client/src/untrusted.
For a long time the intent has been to just use the library binaries
supplied in the NaCl toolchains rather than building these locally
as part of the Chromium components built with NaCl toolchains. But
the GYP files, and the GN files written from their model, have
explicit dependencies on //native_client/src/untrusted/* components
that cause them to be rebuilt locally. This rebuilding is
unnecessary and slows Chromium builds down a little. Furthermore,
the GN rules for NaCl toolchains are not fully compatible with
building all of these low-level internal components of the NaCl
toolchains' runtime and in some circumstances have errors building
them. To avoid all this, replace various deps entries on those
library targets with libs entries that refer to the libraries
already available in a NaCl toolchain. The various nacl_*_private
libraries are not included in the toolchains and so still need to be
built locally as they are now.
The corresponding GYP rules do still have the dependencies that cause
the toolchain libraries to be rebuilt, so with this change GN and GYP
are now doing things differently. I'm not touching the GYP rules for
this because they work fine as they are and I'm avoiding perturbing the
fragile GYP situation while we make GN more perfect.
BUG= 565493
R=bradnelson@chromium.org, ncbray@chromium.org, plundblad@chromium.org
Review URL: https://codereview.chromium.org/1514223003
Cr-Commit-Position: refs/heads/master@{#365167}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Statically-linked binaries do not need -rpath=$ORIGIN
set, and setting it can be a source of strange security
issues (see bug for more details).
Manually add this to some test binaries that require shared libraries to be loaded from the build directory.
R=phajdan.jr@chromium.org, thestig@chromium.org
BUG=556843
Renald of https://codereview.chromium.org/1525733002/
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1525773002
Cr-Commit-Position: refs/heads/master@{#365125}
|
|
|
|
|
|
|
|
| |
BUG=461222
Review URL: https://codereview.chromium.org/1343273005
Cr-Commit-Position: refs/heads/master@{#365010}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My intent here is just to make the code easier to follow.
plugin_main.cc and irt_ppapi.cc are both quite small, and there's no
need for the code to be split between the two.
* Inline PpapiPluginMain() into irt_ppapi_start().
* irt_shim_ppapi.c: Remove a duplicated function declaration. We can
use the one from irt_ppapi.h instead.
BUG=none
TEST=build
Review URL: https://codereview.chromium.org/1512233002
Cr-Commit-Position: refs/heads/master@{#364514}
|
|
|
|
|
|
|
|
| |
BUG=138542, 488550
Review URL: https://codereview.chromium.org/1499423004
Cr-Commit-Position: refs/heads/master@{#364429}
|
|
|
|
|
|
|
|
| |
BUG=138542, 488550
Review URL: https://codereview.chromium.org/1502503004
Cr-Commit-Position: refs/heads/master@{#364133}
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 5097a2103f86741a7d0e6567e57759be939182b0.
R=dalecurtis@chromium.org, dcheng@chromium.org, piman@chromium.org, sky@chromium.org
BUG=514815, 566291
Review URL: https://codereview.chromium.org/1499813003
Cr-Commit-Position: refs/heads/master@{#363922}
|
|
|
|
|
|
|
|
| |
BUG=138542,488550
Review URL: https://codereview.chromium.org/1498003003
Cr-Commit-Position: refs/heads/master@{#363854}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
identification. (patchset #8 id:140001 of https://codereview.chromium.org/1489573003/ )
Reason for revert:
This is causing a large number of layout tests in virtual/threaded/animations to crash.
They're hitting the following assertion:
FATAL:scheduler.cc(203)] Check failed: state_machine_.pending_swaps() > 0 (0 vs. 0){"compositor_timing_history":
e.g. see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28dbg%29/builds/25835
Confirmed with a local bisect.
Original issue's description:
> Added an extra sync token field for extra command buffer identification.
>
> This CL adds an extra field within sync tokens without changing the size
> of the sync token. Currently this extra field is only used for the
> GPU channel implementation, storing the stream of the identified command
> buffer.
>
> BUG=514815
>
> Committed: https://crrev.com/f21e7e6e2b260d56fa54373dd662c81c9d955331
> Cr-Commit-Position: refs/heads/master@{#363231}
TBR=dcheng@chromium.org,dalecurtis@chromium.org,piman@chromium.org,sky@chromium.org,dyen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=514815
Review URL: https://codereview.chromium.org/1495893005
Cr-Commit-Position: refs/heads/master@{#363290}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This refactors the pnacl_support_extension rule a bit to be
cleaner, and so that it actually works as intended for the
32-bit Windows case.
BUG= 512869
R=bradnelson@chromium.org, mseaborn@chromium.org
Review URL: https://codereview.chromium.org/1491213007
Cr-Commit-Position: refs/heads/master@{#363241}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds an extra field within sync tokens without changing the size
of the sync token. Currently this extra field is only used for the
GPU channel implementation, storing the stream of the identified command
buffer.
BUG=514815
Review URL: https://codereview.chromium.org/1489573003
Cr-Commit-Position: refs/heads/master@{#363231}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The plugin is automatically registered in layout tests using the
MIME type application/x-blink-test-plugin. Several layout tests
have also been migrated to use the new plugin.
Implementing the plugin also revealed a bug in PPAPI and the
layout test runner:
- Retrieving the key code via PPAPI always returned KeyA on Mac.
- The layout test runner explicitly set DYLD_FRAMEWORK_PATH,
making it hard to load the plugin from the right location.
BUG=474535
Review URL: https://codereview.chromium.org/1480303002
Cr-Commit-Position: refs/heads/master@{#362872}
|
|
|
|
|
|
|
|
|
|
|
| |
This lets the compositor specify whether the backbuffer will need to be blended with the contents behind it, and if not it can use a method that uses less power.
BUG=561185
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1474873003
Cr-Commit-Position: refs/heads/master@{#362817}
|
|
|
|
|
|
|
|
| |
BUG=504082
Review URL: https://codereview.chromium.org/1478633002
Cr-Commit-Position: refs/heads/master@{#362703}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The values of GL_RENDERBUFFER_SAMPLES_EXT, GL_MAX_SAMPLES_EXT
and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT as per khronos
updated header third_party/khronos/GLES2/gl2ext.h should be
0x8CAB, 0x8D57 and 0x8D56 respectively.
The values of 0x9133, 0x9134 and 0x9135 instead point to
GL_RENDERBUFFER_SAMPLES_IMG, GL_MAX_SAMPLES_IMG and
GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_IMG.
BUG=None
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1476233003
Cr-Commit-Position: refs/heads/master@{#362674}
|
|
|
|
|
|
|
|
|
|
|
| |
This gets everything that wasn't covered by a previous CL in flight.
BUG=556678
TBR=zea@chromium.org
Review URL: https://codereview.chromium.org/1471043004
Cr-Commit-Position: refs/heads/master@{#362283}
|
|
|
|
|
|
|
|
|
| |
BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1469863003
Cr-Commit-Position: refs/heads/master@{#362203}
|
|
|
|
|
|
|
|
|
|
| |
Support for building NaCl browser tests under GN.
BUG=462791
Review URL: https://codereview.chromium.org/1434823002
Cr-Commit-Position: refs/heads/master@{#362075}
|