| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
System dialog shows only properties of selected printers, no system dialog with printers.
Removed global Ctrl+Shift+P shortcut on windows.
BUG=374321
Review URL: https://codereview.chromium.org/480303002
Cr-Commit-Position: refs/heads/master@{#292032}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
locale.
BUG=374321
Committed: https://chromium.googlesource.com/chromium/src/+/ee8f4e4029c09ba77e7dbb8fddd85186642b3de8
R=jschuh@chromium.org, noamsml@chromium.org, thestig@chromium.org, yzshen@chromium.org
Review URL: https://codereview.chromium.org/478183005
Cr-Commit-Position: refs/heads/master@{#291871}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* add vendor id and custom display name to media selection
* propagate selected media size in PrintSettings Related
Сhanges in JS:
* Use media custom diaply name received from the native layer
* Make sure media size selection is propagated to the native layer
BUG=239879
NOTRY=true
Review URL: https://codereview.chromium.org/325313003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reset margins to default when media size changes.
BUG=139170
NOTRY=true
Review URL: https://codereview.chromium.org/285613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OSX already uses description as display name for printers, so pass printer model instead.
BUG=256223
NOTRY=true
Review URL: https://codereview.chromium.org/214443007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Take the CDD from the print preview javascript and put it in the
PrivetLocalPrintOperation.
BUG=354605
Review URL: https://codereview.chromium.org/208583007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=318373
Review URL: https://codereview.chromium.org/78173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a first iteration of printing to a Privet local printer. It only
supports PDFs. PWG rasterization will be added separately.
BUG=311390
Review URL: https://codereview.chromium.org/59843010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Proper set/get methods in PrintSettings.
Objective of this re-factoring is to simplify processing of
"print_to_pdf || is_cloud_dialog || print_to_cloud" case.
Now all platforms for this case do almost the same by in different way: calculate and set printing area.
In the next CL I'll move that code into common PrintingContext::UpdatePrintSettings and will ask platform specific implementation for desired page size only.
BUG=305731
Review URL: https://codereview.chromium.org/47823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
page calculation.
TBR=gene
Review URL: https://chromiumcodereview.appspot.com/12220093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Browser test for selection.
BUG=83098
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12087005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=113594
Review URL: https://chromiumcodereview.appspot.com/11818062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Old implementation with gfx::RenderText had issues with fallback fonts. Sandbox does not allow to read required information from registry.
Also WebKit inplementation is smaller and more readable.
BUG=152893, 108599, 133548
TEST=manual: make sure that main content with or without headers is in the same place (default margin is exception). Make sure that any custom margins and paper layout produce reasonable result. If margins are to small, header and footer should be hidden.
Review URL: https://chromiumcodereview.appspot.com/11359020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=144051
Review URL: https://chromiumcodereview.appspot.com/10870003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Print preview currently keeps settings "sticky" within a single browser session
so that if the user chooses a printer or settings it will be remembered
the next time preview is launched.
This CL extends that behavior to make the settings stick across multiple
sessions.
BUG=111957
TEST=Enable flag. Verify that all print preview settings that are sticky within a session are sticky across sessions.
Review URL: https://chromiumcodereview.appspot.com/10780004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85132
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10083060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104080
TEST= Please refer to bug report.
Review URL: http://codereview.chromium.org/9699040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
native preview app.
BUG=101724
TEST=Preview a webpage. Click "Open PDF In Preview" option Observe that the pdf is displayed in native preview app. Complete the printing workflow by clicking "Print" or
"Cancel" button at the bottom of the preview app.
Review URL: http://codereview.chromium.org/8425008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
some general clean ups.
BUG=67091, 92045, 92218
TEST=Print a PDF with print scaling disabled and see that it takes up the entire page.
Review URL: http://codereview.chromium.org/8312003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original (broken) CL: http://codereview.chromium.org/8227034
Already approved by dpapad@
TBR=dpapad@chromium.org
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/8261005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
printer ppd/schema info.
Show/Hide the color options based on printer ppd/schema information. Some printers does not provide sufficient information in the printer schema/ppd regarding the color settings and they use custom advance settings to print in black & white/greyscale. In those cases, users need to print using native dialog in order to set these advance color settings.
BUG=93811, 93490, 87344, 96658, 98768
TEST= Please refer to bug description.
Review URL: http://codereview.chromium.org/8138020
Review URL: http://codereview.chromium.org/8226024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
printer ppd/schema information.
Show/Hide the color options based on printer ppd/schema information. Some printers does not provide sufficient information in the printer schema/ppd regarding the color settings and they use custom advance settings to print in black & white/greyscale. In those cases, users need to print using native dialog in order to set these advance color settings.
BUG=93811, 93490, 87344, 96658, 98768
TEST= Please refer to bug description.
Review URL: http://codereview.chromium.org/8138020
TBR=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/8245012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
information.
Show/Hide the color options based on printer ppd/schema information. Some printers does not provide sufficient information in the printer schema/ppd regarding the color settings and they use custom advance settings to print in black & white/greyscale. In those cases, users need to print using native dialog in order to set these advance color settings.
BUG=93811, 93490, 87344, 96658, 98768
TEST= Please refer to bug description.
Review URL: http://codereview.chromium.org/8138020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92000
TEST=NONE
Review URL: http://codereview.chromium.org/8173016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed "Local" and "Cloud" labels from dropdown
The "More printers" label is now more clear and shares behavior with the cloud print printer option in Chrome.
The system print dialog link is replaced with a similar link referencing cloud print in chrome os.
Choosing cloud print from the printers dropdown now requires the user to hit print before opening the cloud print dialog.
Fixed broken tests.
BUG=88098, 97175, http://code.google.com/p/chromium-os/issues/detail?id=16082, http://code.google.com/p/chromium-os/issues/detail?id=20121, http://code.google.com/p/chromium-os/issues/detail?id=20119
TEST=Enable print preview in about:flags. Printing should work with cloud print printers in much the same way as local printers in Chrome
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103010
Review URL: http://codereview.chromium.org/7976017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
print_preview_cloud.js.
Removed "Local" and "Cloud" labels from dropdown
The "More printers" label is now more clear and shares behavior with the cloud print printer option in Chrome.
The system print dialog link is replaced with a similar link referencing cloud print in chrome os.
Choosing cloud print from the printers dropdown now requires the user to hit print before opening the cloud print dialog.
Fixed broken tests.
BUG=88098, 97175, http://code.google.com/p/chromium-os/issues/detail?id=16082, http://code.google.com/p/chromium-os/issues/detail?id=20121, http://code.google.com/p/chromium-os/issues/detail?id=20119
TEST=Enable print preview in about:flags. Printing should work with cloud print printers in much the same way as local printers in Chrome
Review URL: http://codereview.chromium.org/7976017
TBR=abodenha@google.com
Review URL: http://codereview.chromium.org/8055036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed "Local" and "Cloud" labels from dropdown
The "More printers" label is now more clear and shares behavior with the cloud print printer option in Chrome.
The system print dialog link is replaced with a similar link referencing cloud print in chrome os.
Choosing cloud print from the printers dropdown now requires the user to hit print before opening the cloud print dialog.
Fixed broken tests.
BUG=88098, 97175, http://code.google.com/p/chromium-os/issues/detail?id=16082, http://code.google.com/p/chromium-os/issues/detail?id=20121, http://code.google.com/p/chromium-os/issues/detail?id=20119
TEST=Enable print preview in about:flags. Printing should work with cloud print printers in much the same way as local printers in Chrome
Review URL: http://codereview.chromium.org/7976017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.
Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
BUG=84383
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7647010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The UI for margin options are hidden by default.
BUG=69337
TEST=
There is currently minimal UI for testing this. The custom margins option does nothing. You can however click the no margins option to see the page print without margins.
Review URL: http://codereview.chromium.org/7552033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sync messages. The sync messages now go to the IO thread to avoid the potential deadlock on Windows.
BUG=91057, and probably a few more.
TEST=included.
Review URL: http://codereview.chromium.org/7621087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67514
TEST=In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Review URL: http://codereview.chromium.org/7544006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97219
Review URL: http://codereview.chromium.org/7348010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skia
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Review URL: http://codereview.chromium.org/7348010
TBR=aayushkumar@chromium.org
Review URL: http://codereview.chromium.org/7670045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Review URL: http://codereview.chromium.org/7348010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that pending preview requests are being canceled when a new request is issued, the event listeners of the printing controls should not check for |hasPendingPreviewRequest| before issuing new requests, instead they should immediately request a new preview so that the previous one is canceled.
Also all functions that are associated with a specific print request should get the requestID as a parameter, in order to ignore obsolete responses.
I found out that when the print preview tab is reloaded, responses from requests before the reload are reaching the ui code. If reloading the preview tab repeatedly all these request have id=0 and are not being ignored as they should. Therefore I changed the id of the initial request to have a random variable.
BUG=91556, 91769
TEST=See bug description
Review URL: http://codereview.chromium.org/7550022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
require a rerendering of draft pages.
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.
1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview|
Review URL: http://codereview.chromium.org/7544018
Original Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=96406
Revert Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96414
BUG=84383
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7628019
TBR=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/7639023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of draft pages.
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.
1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview|
Review URL: http://codereview.chromium.org/7544018
Original Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=96406
Revert Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96414
BUG=84383
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7628019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of draft pages.
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.
1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview|
BUG=84383
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7544018
TBR=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/7618014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.
1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview|
BUG=84383
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7544018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous review comments:
http://codereview.chromium.org/7395016/
http://codereview.chromium.org/7210042/
BUG=88762
TEST=NONE
Review URL: http://codereview.chromium.org/7495003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88807, 89106
TEST=NONE
Review URL: http://codereview.chromium.org/7313035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To enable in Windows/Mac/Linux pass "--enable-cloud-print --enable-print-preview" on the command line.
To enable in ChromeOS open about:flags and enable print preview.
This first pass extends the print preview UI to retrieve a printer list from cloud print and to allow printing to a cloud print printer.
Limitations/known issues:
Sign in opens a new tab and requires the print preview page to be refreshed after sign in.
Only pulls the first 10 GCP printers.
Job settings are very limited. Only sets color and only for a limited set of printers.
BUG=80004
TEST=
When running with default flags the only visible change should be that "Manage Printers" is now "Manage Local Printers"
With flags set as above there should be new entries in the printer selection dropdown allowing the use of cloud printers. It should be possible to sign in to cloud print, open the management page, and be able to print documents to cloud printers.
Review URL: http://codereview.chromium.org/7038028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7275030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=85767
TEST=none
Review URL: http://codereview.chromium.org/7149020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=79900
TEST=Install a default printer with a dot in the name and preview a webpage.
Review URL: http://codereview.chromium.org/6915012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the user selected pages.
BUG=none
TEST=Only a 3 page PDF, select page 3, print.
Review URL: http://codereview.chromium.org/6895015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Set duplex binding settings in print preview tab and observe the printed data.
Review URL: http://codereview.chromium.org/6879054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79525
TEST=Open a multi-page document in print preview, select specific pages, the
preview should automatically update.
Review URL: http://codereview.chromium.org/6882019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6792061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Enable print preview on mac. Print preview a webpage. Change the number of copies and collate setting values. Print the preview data.
Review URL: http://codereview.chromium.org/6780001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80499 0039d316-1c4b-4281-b951-d872f2087c98
|