| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
System dialog shows only properties of selected printers, no system dialog with printers.
Removed global Ctrl+Shift+P shortcut on windows.
BUG=374321
Review URL: https://codereview.chromium.org/480303002
Cr-Commit-Position: refs/heads/master@{#292032}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
locale.
BUG=374321
Committed: https://chromium.googlesource.com/chromium/src/+/ee8f4e4029c09ba77e7dbb8fddd85186642b3de8
R=jschuh@chromium.org, noamsml@chromium.org, thestig@chromium.org, yzshen@chromium.org
Review URL: https://codereview.chromium.org/478183005
Cr-Commit-Position: refs/heads/master@{#291871}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
application locale. (patchset #13 of https://codereview.chromium.org/478183005/)
Reason for revert:
PrintJobTest.SimplePrint leaking on Linux ASAN bots since this was checked in:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29?numbuilds=100
This CL looks like the likeliest culprit.
Original issue's description:
> Added PrintingContext::Delegate to get parent view handle and application locale.
>
> BUG=374321
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ee8f4e4029c09ba77e7dbb8fddd85186642b3de8
TBR=noamsml@chromium.org,inferno@chromium.org,yzshen@chromium.org,thestig@chromium.org,jschuh@chromium.org,vitalybuka@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=374321
Review URL: https://codereview.chromium.org/504763002
Cr-Commit-Position: refs/heads/master@{#291654}
|
|
|
|
|
|
|
|
|
|
| |
locale.
BUG=374321
Review URL: https://codereview.chromium.org/478183005
Cr-Commit-Position: refs/heads/master@{#291584}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/209973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per discussion with ananta, opening a system modal dialog from a
background thread is a bad idea, so reverting this (from long ago).
Windows doesn't preserve the order correctly when the window is not on
the main UI thread, and in the bug here, it interacts very badly with
the IME toolbar window, causing the modal print dialog to go behind the
browser window in Z order making chrome appear to be hung.
The original goal was to fix tasks not being dispatched while the dialog
was open. We can instead use the ScopedNestedTaskAllower as we've done
for other system modal dialogs which I'll do in a separate CL.
BUG=342697,180997
> Use BaseShellDialog for print dialog on Windows
>
> This puts the print dialog on a background thread which is necessary so other
> top level windows can keep painting as Aura does the compositor swaps on the
> UI thread.
>
> R=sky@chromium.org,vitalybuka@chromium.org
>
>
> Review URL: https://codereview.chromium.org/27441003
TBR=scottmg@chromium.org,sky@chromium.org,vitalybuka@chromium.org,ananta@chromium.org
Review URL: https://codereview.chromium.org/164013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PrintingContext.
Hard-code CloudPrint printable area until we start to receive this data from server.
BUG=305731
NOTRY=true
Review URL: https://codereview.chromium.org/46623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Proper set/get methods in PrintSettings.
Objective of this re-factoring is to simplify processing of
"print_to_pdf || is_cloud_dialog || print_to_cloud" case.
Now all platforms for this case do almost the same by in different way: calculate and set printing area.
In the next CL I'll move that code into common PrintingContext::UpdatePrintSettings and will ask platform specific implementation for desired page size only.
BUG=305731
Review URL: https://codereview.chromium.org/47823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This puts the print dialog on a background thread which is necessary so other
top level windows can keep painting as Aura does the compositor swaps on the
UI thread.
R=sky@chromium.org,vitalybuka@chromium.org
BUG=180997
Review URL: https://codereview.chromium.org/27441003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/24989002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11530005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/8549031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=rvargas,thestig
Review URL: http://codereview.chromium.org/7799003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97219
Review URL: http://codereview.chromium.org/7348010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skia
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Review URL: http://codereview.chromium.org/7348010
TBR=aayushkumar@chromium.org
Review URL: http://codereview.chromium.org/7670045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Review URL: http://codereview.chromium.org/7348010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
with a minor change to that code since libcros also uses base/values.h.
BUG=88666
TEST=none
Review URL: http://codereview.chromium.org/7259019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6675013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=76123
TEST=Enable print preview on mac. Press ctrl+p to print a page. On print preview tab, select a printer and press print button.
Review URL: http://codereview.chromium.org/6698013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
printing without displaying a native dialog.
(2) Made code changes to accept a print page range from the user and to print only those specified pages.
BUG=none
TEST=Enable print preview on mac, provide a valid page range and make sure print button in print preview works.
Review URL: http://codereview.chromium.org/6533006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
PrintingContext.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6510007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71063
TEST=compiled
Review URL: http://codereview.chromium.org/6312156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rather than rely on GTK.
BUG=None.
TEST=Web pages printed from Chrome OS should use locale-specific default paper size (specifically, for US, it should use 8.5 x 11).
Review URL: http://codereview.chromium.org/5636001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
platforms.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3610013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61714 0039d316-1c4b-4281-b951-d872f2087c98
|