| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Removed win_pdf_metafile_for_printing gyp option.
Removed WIN_PDF_METAFILE_FOR_PRINTING define.
BUG=170859
TBR=yzshen
Review URL: https://codereview.chromium.org/516823002
Cr-Commit-Position: refs/heads/master@{#292501}
|
|
|
|
|
|
|
|
|
|
|
| |
System dialog shows only properties of selected printers, no system dialog with printers.
Removed global Ctrl+Shift+P shortcut on windows.
BUG=374321
Review URL: https://codereview.chromium.org/480303002
Cr-Commit-Position: refs/heads/master@{#292032}
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the rest of the non-rtc and non-vpx linker errors for the chrome target.
BUG=
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/505853003
Cr-Commit-Position: refs/heads/master@{#291952}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
locale.
BUG=374321
Committed: https://chromium.googlesource.com/chromium/src/+/ee8f4e4029c09ba77e7dbb8fddd85186642b3de8
R=jschuh@chromium.org, noamsml@chromium.org, thestig@chromium.org, yzshen@chromium.org
Review URL: https://codereview.chromium.org/478183005
Cr-Commit-Position: refs/heads/master@{#291871}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
application locale. (patchset #13 of https://codereview.chromium.org/478183005/)
Reason for revert:
PrintJobTest.SimplePrint leaking on Linux ASAN bots since this was checked in:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29?numbuilds=100
This CL looks like the likeliest culprit.
Original issue's description:
> Added PrintingContext::Delegate to get parent view handle and application locale.
>
> BUG=374321
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ee8f4e4029c09ba77e7dbb8fddd85186642b3de8
TBR=noamsml@chromium.org,inferno@chromium.org,yzshen@chromium.org,thestig@chromium.org,jschuh@chromium.org,vitalybuka@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=374321
Review URL: https://codereview.chromium.org/504763002
Cr-Commit-Position: refs/heads/master@{#291654}
|
|
|
|
|
|
|
|
|
|
| |
locale.
BUG=374321
Review URL: https://codereview.chromium.org/478183005
Cr-Commit-Position: refs/heads/master@{#291584}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chrome target doesn't link yet so is currently a source set.
This adds some installer util targets and some related targets, as well as fixes up some TODOs referencing completed targets.
Fixes and enables the snapshot unit test.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/489223002
Cr-Commit-Position: refs/heads/master@{#290927}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=noamsml
Review URL: https://codereview.chromium.org/493453005
Cr-Commit-Position: refs/heads/master@{#290782}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=noamsml
BUG=374321
Review URL: https://codereview.chromium.org/484373002
Cr-Commit-Position: refs/heads/master@{#290759}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/465693002
Cr-Commit-Position: refs/heads/master@{#290688}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: https://codereview.chromium.org/447403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many win32 APIs take non-const string pointers. I checked that MSDN documents
them as _In_ and says that they are inputs, and then added const_cast<>s at
the calling sites. (In one test, I introduced a helper struct so that there
can be fewer casts.)
This wasn't just busywork, I found one function that we were handing string
literals where the documentation explicitly said that that's not valid
(filed http://crbug.com/396705).
I didn't change the DECLARE_REGISTRY_APPID_RESOURCEID() call in cloud_print;
it sounds like that'll fix itself when we update to the 2014 sdk:
http://connect.microsoft.com/VisualStudio/feedback/details/806376/atl-hindrances-to-adopting-new-strictstrings-conformance-option-in-vs2013
BUG=396705,82385
R=rnk@chromium.org, rsleevi@chromium.org, sergeyu@chromium.org, vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/413763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the //ui/base/ime target to the GN build, which is used
everywhere except for ios. In the gyp build this isn't a real target,
it's a set of properties that are included into the ui_base target which
is the best you can do in GYP since you can't link a static library into
a component without dropping some symbols. In GN, we can define this as
a source_set with its own dependencies and settings.
This also fixes up some miscellaneous mac issues.
R=brettw@chromium.org,ben@chromium.org
Review URL: https://codereview.chromium.org/389083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In GN it is redundat to include the parent directory name, as in
ui/gfx:gfx_test_support. Instead we can write it as ui/gfx:test_support
which is shorter and nicer to read.
Targets found with the following command line:
$ for f in $(g ls-files | grep BUILD); do grep _test_support $f; echo
$f; done
BUG=None
TEST=None
R=brettw@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/409493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and send them to the layout test framework for an image diff. This is for print preview end to end testing.
BUG=388517
Review URL: https://codereview.chromium.org/383623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixes two issues in OSExchangeDataProviderWin:
- It used a disjoint set of clipboard formats when handling
GetUrl(..., true /* filename conversion */) vs GetFilenames(...), so the
actual returned results would vary depending on which one was called.
- It incorrectly used ::DragFinish() instead of ::ReleaseStgMedium().
::DragFinish() is only meant to be used in conjunction with WM_DROPFILES.
BUG=346135
Review URL: https://codereview.chromium.org/380553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the intermediate grit files:
ui/ui_resources -> ui/resources
ui/ui_strings -> ui/strings
in the GYP build to put it in line with the GN one (and also what one would expect).
R=ajwong@chromium.org
BUG=
Review URL: https://codereview.chromium.org/381113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When this lands, we can remove SkBitmap::Config entirely from Skia
TBR=kmadhusu@chromium.org
mac_chromium_rel failure is unrelated to this CL (and passes locally)
NOTRY=True
Review URL: https://codereview.chromium.org/382623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add chrome/browser/ui to the GN build.
>
> This moves the intermediate grit files:
> ui/ui_resources -> ui/resources
> ui/ui_strings -> ui/strings
> in the GYP build to put it in line with the GN one (and also what one would expect).
>
> R=ajwong@chromium.org
>
> Review URL: https://codereview.chromium.org/381463002
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/387573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the intermediate grit files:
ui/ui_resources -> ui/resources
ui/ui_strings -> ui/strings
in the GYP build to put it in line with the GN one (and also what one would expect).
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/381463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This provides PrintTo(..) functions for the geometric types in ui/gfx/
so that failing gtest assertions pretty-print the values instead of
dumping the bytes of the objects. This way gtest assertions on these
types can be written in the form:
EXPECT_EQ(a, b);
instead of
EXPECT_EQ(a.ToString(), b.ToString());
which is currently used (inconsistently) to provide more readable
failure messages.
This is a bit tricky since gtest uses streams and somewhat complicated
template expansion magic to pretty print values and we don't want to
link the stream-based code into production code paths. This declares the
PrintTo() functions in the headers defining each of the geometry types,
using the <iosfwd> header to keep stream bloat to a minimum, and defines
the formatters in gfx_test_support. This way every test that
instantiates these printers has to declare a dependency on
gfx_test_support or it fails to link, but a test does not have to
#include any particular header to see the correct printer declaration
and thus expand the template correctly.
If we were to declare the PrintTo() functions in a test only header such
a gfx_util.h then the pretty printers would work reliably only if
*every* target in a translation unit that instantiated the comparison
saw this declaration. If some unit tests in a target #included the
header and some did not then it would be intederminate whether the
template instantiation linked in to the test binary was the pretty
printed one or the hex dump one (and in practice this appears to be
inconsistent across clang and gcc for whatever reason).
Review URL: https://codereview.chromium.org/368903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also suppress a -Wwritable-strings warning while here.
BUG=82385
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/374443003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=82385
R=kmadhusu@chromium.org
Review URL: https://codereview.chromium.org/356803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=239879
Review URL: https://codereview.chromium.org/345493003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=239879
TBR=noamsml
Review URL: https://codereview.chromium.org/345453005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This time, add an annotation to ignore the leak in system libraries.
BUG=176888,375126
Review URL: https://codereview.chromium.org/321223004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Set windows paper is as ventor_id.
Use windows paper id in Cloud Print Connector.
BUG=239879,382338
Review URL: https://codereview.chromium.org/333993003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Print Preview).
BUG=239879
Review URL: https://codereview.chromium.org/334763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Renamed print_settings_initializer.* into print_settings_conversion.*
* Dump on FILE thread.
* Added PrintSettingsToJobSettingsDebug to dump PrintSettings.
* Added PrintedDocument::CreateDebugDumpPath for consistent dump file naming.
* Dump PDFs received from renderer process.
* Moved GetCustomMarginsFromJobSettings into print_settings_conversion.cc.
* Moved Parsing PageRanges into print_settings_conversion.*
BUG=379961
Review URL: https://codereview.chromium.org/329683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Shrink value passed over IPC only in if defined (OS_WIN && !WIN_PDF_METAFILE_FOR_PRINTING)
This build config should be gone in near future.
PrintedPage::shrink_factor_ is used only for OS_WIN.
BUG=379961
NOTRY=true
Review URL: https://codereview.chromium.org/335473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* add vendor id and custom display name to media selection
* propagate selected media size in PrintSettings Related
Сhanges in JS:
* Use media custom diaply name received from the native layer
* Make sure media size selection is propagated to the native layer
BUG=239879
NOTRY=true
Review URL: https://codereview.chromium.org/325313003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specific case. Enable supported paper szes… (https://codereview.chromium.org/321703002/)
Reason for revert:
Didn't fix.
Original issue's description:
> Revert of Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes… (https://codereview.chromium.org/324523002/)
>
> Reason for revert:
> Breaks Linux ASAN http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2865
>
> Original issue's description:
> > Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes reporting for all platforms.
> >
> > BUG=239879
> > NOTRY=true
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275646
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275716
>
> TBR=vitalybuka@chromium.org,jschuh@chromium.org,alekseys@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=239879
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275739
TBR=vitalybuka@chromium.org,jschuh@chromium.org,alekseys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=239879
Review URL: https://codereview.chromium.org/318293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
case. Enable supported paper szes… (https://codereview.chromium.org/324523002/)
Reason for revert:
Breaks Linux ASAN http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2865
Original issue's description:
> Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes reporting for all platforms.
>
> BUG=239879
> NOTRY=true
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275646
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275716
TBR=vitalybuka@chromium.org,jschuh@chromium.org,alekseys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=239879
Review URL: https://codereview.chromium.org/321703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable supported paper szes reporting for all platforms.
BUG=239879
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275646
Review URL: https://codereview.chromium.org/324523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculative revert.
Something breaks "Linux ASan LSan Tests", TaskManagerNewPrintPreview.
> Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes reporting for all platforms.
>
> BUG=239879
>
> Review URL: https://codereview.chromium.org/324523002
TBR=alekseys@chromium.org
Review URL: https://codereview.chromium.org/319373004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Enable supported paper szes reporting for all platforms.
BUG=239879
Review URL: https://codereview.chromium.org/324523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and PDF printer. This is a necessary step for adding paper size capability to local printers.
BUG=239879
Review URL: https://codereview.chromium.org/313723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=369973
Review URL: https://codereview.chromium.org/301353009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/311603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It's a no-op in Windows-only code.
Review URL: https://codereview.chromium.org/299363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=239879
Review URL: https://codereview.chromium.org/294923005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fixes GetHomeDir() for multi-profiles case on Chrome OS.
* Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
* Added content switch --homedir to pass that information to ppapi plugins since they
run in a separate process and previous base::DIR_HOME override does not apply there.
This fix doesn't require checking for --multi-profiles switch
since user_id hash is known even without it.
Note:
download_prefs.cc still uses GetHomeDir() in its DownloadPathIsDangerous() check.
// Consider downloads 'dangerous' if they go to the home directory on Linux and
// to the desktop on any platform.
In this context correct behavior is to use "real" base::GetHomeDir() and not "virtual one" base::DIR_HOME.
Since latter is remapped to some test dir in tests, in some subfolders in Chrome OS etc.
BUG=331530
TBR=vitalybuka@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270872
Review URL: https://codereview.chromium.org/200473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently:
- Based on #if, switches renderer rendering to PDF for preview
- Add PdfToEmfConvert based on PWGRasterConverter
- Various plumbing.
Preview works the same as other PDF based platforms. For getting
to EMF, the when PRINTING_WIN_USES_PDF_AS_METAFILE is on, the
renderer generates a PDF instead of EMF directly (this contains
all the pages in the desired range). This is returned to
PrintViewManagerBase, where it's passed to PdfToEmfConverter which
uses the sandboxed utility process and pdf.dll to convert via
RenderPDFPageToDC. The utility process renderers one emf page at
at time (into numbered files) to avoid having a very large emf file.
As this uses pdf.dll this is currently off-by-default controlled by
the gyp variable win_pdf_metafile_for_printing.
R=vitalybuka@chromium.org
BUG=170859
Review URL: https://codereview.chromium.org/255543006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=369973
TEST=ctrl + p does not crash.
Review URL: https://codereview.chromium.org/270553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The underlying rule is now "long" by default.
Mechanical change:
git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d
Relands crrev.com/270750 (reverted by 270849)
BUG=317523
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/288223005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move all callers of GetHomeDir() to PathService::Get(base::DIR_HOME).
>
> * Fixes GetHomeDir() for multi-profiles case on Chrome OS.
> * Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
> * Added content switch --homedir to pass that information to ppapi plugins since they run in a separate process and previous base::DIR_HOME override does not apply there.
>
> This fix doesn't require checking for --multi-profiles switch
> since user_id hash is known even without it.
>
> BUG=331530
> TBR=vitalybuka@chromium.org
>
> Review URL: https://codereview.chromium.org/200473002
This test has caused two tests to start failing on the chromeos valgrind bots:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%286%29/builds/25884
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%285%29/builds/26990
TBR=nkostylev@chromium.org
Review URL: https://codereview.chromium.org/284333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fixes GetHomeDir() for multi-profiles case on Chrome OS.
* Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
* Added content switch --homedir to pass that information to ppapi plugins since they run in a separate process and previous base::DIR_HOME override does not apply there.
This fix doesn't require checking for --multi-profiles switch
since user_id hash is known even without it.
BUG=331530
TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/200473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suspected to cause Android Tests bot failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/13592
> Android: cleans up jni_generator_ptr_type.
>
> The underlying rule is now "long" by default.
> Mechanical change:
> git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d
>
> BUG=317523
> TBR=darin@chromium.org
>
> Review URL: https://codereview.chromium.org/288963002
TBR=bulach@chromium.org
Review URL: https://codereview.chromium.org/292433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The underlying rule is now "long" by default.
Mechanical change:
git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d
BUG=317523
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/288963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reset margins to default when media size changes.
BUG=139170
NOTRY=true
Review URL: https://codereview.chromium.org/285613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270515 0039d316-1c4b-4281-b951-d872f2087c98
|