summaryrefslogtreecommitdiffstats
path: root/printing
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: Fix some misc nits in printing code.thestig2015-07-161-4/+6
| | | | | | Review URL: https://codereview.chromium.org/1232783007 Cr-Commit-Position: refs/heads/master@{#339101}
* win: Remove a few instances of the "goto error" pattern.thakis2015-07-141-54/+40
| | | | | | | | | | | | | | | | | | This makes the code simpler, and also fixes a bunch of warnings that look like: goto done; ^ ..\..\remoting\host\win\rdp_client_window.cc(331,14) : note(clang): jump bypasses variable initialization const LONG kDesiredFlags = WTS_PERF_ENABLE_ENHANCED_GRAPHICS | ^ No intended behavior change. BUG=505296 Review URL: https://codereview.chromium.org/1226243004 Cr-Commit-Position: refs/heads/master@{#338720}
* Replace base::str[n]casecmp with helper functions.brettw2015-07-101-32/+34
| | | | | | | | | | | | | | | | | | | | Adds CompareCaseInsensitiveASCII and EqualsCaseInsensitiveASCII helper functions and removes base::strcasecmp and base::strncasecmp. This avoids the dangerous locale-sensitive behavior. ClientIsAdvertisingSdchEncoding in sdch_browsertest had the condition inverted, but because it returned true any time the given line wasn't found, the test didn't notice. cups_helper changed most significantly. I redid the loop to use StringPieces which saves a lot of copies. On line 82 cups_helper used to do a prefix match which I'm pretty sure it wanted a regular compare. I changed this. render_text_harfbuzz set "<" operator was also doing a prefix comparison only, when it looks like it really just wanted to compare the strings. file_path passed string pieces into strcasecmp which could then read off the end if they're not null terminated. This patch fixes the bug and calls the native strcasecmp which is probably the best we can do for Posix file names. Removed additional version of the same function in net. Adds a backwards-compat hack for crashpad which improperly uses base from a DEPS-ed in repo. Review URL: https://codereview.chromium.org/1224553010 Cr-Commit-Position: refs/heads/master@{#338324}
* Fixed all overloaded virtual methods on Windows.mgiuca2015-07-084-46/+11
| | | | | | | | | | | | | | | | | | | | | | | This fixes the 'overloaded-virtual' Clang warning on Windows (currently disabled; will be enabled in a follow-up CL). - PpapiThread::PreCacheFont: Renamed to PreCacheFontForFlash to avoid conflict with PreCacheFont method in base class ChildThreadImpl. (This method is only called by another method called PreCacheFontForFlash so the new name is appropriate.) - PrintingContextSytemDialogWin::InitializeSettings: Renamed to InitializeSettingsWithRanges to avoid conflict with InitializeSettings in base class PrintingContextWin. (These two methods are called on different code paths and the former is not meant to override the latter, so they should have different names.) - Removed PrintingContextWin::ShowPrintDialog. This method was totally unused and its name was conflicting with a method in a subclass. BUG=505301 Review URL: https://codereview.chromium.org/1216013005 Cr-Commit-Position: refs/heads/master@{#337735}
* Include user email into document title before spoolingvitalybuka2015-07-073-14/+81
| | | | | | | | | | | | Could be used to monitor print jobs on OS side. Windows spooler "owner" cannot be changed so we should modify title. Max title length increased from 50 to 80 better readability. BUG=504826 Review URL: https://codereview.chromium.org/1212883003 Cr-Commit-Position: refs/heads/master@{#337647}
* Fix some clang warnings with -Wmissing-braces in printing.dcheng2015-07-011-2/+2
| | | | | | | | | | | | | | | | Clang warns if there are missing braces around a subobject initializer. The most common idiom that triggers this is: STRUCT s = {0}; if the first field of STRUCT is itself a struct. This can be more simply written as: STRUCT s = {}; which also prevents the warning from firing. BUG=505297 Review URL: https://codereview.chromium.org/1221643016 Cr-Commit-Position: refs/heads/master@{#337086}
* Convert printing_unittests to run exclusively on Swarmingmaruel2015-06-302-0/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0 configs already ran on Swarming 28 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert printing_unittests R=dpranke@chromium.org,vitalybuka@chromium.org BUG=98637 NOTRY=true Review URL: https://codereview.chromium.org/1217243003 Cr-Commit-Position: refs/heads/master@{#336859}
* Move Tuple to base namespace.brettw2015-05-291-4/+4
| | | | | | | | | | | | | | Namespace change only, no functionality change. The only non-search-and-replace change is in generate_gmock_mutant.py which changes some line wrapping logic for the generated gmock_mutant header. NOPRESUBMIT=true (No presubmit due to long lines in the generated gmock_mutant.h header). R=sky Review URL: https://codereview.chromium.org/1159553007 Cr-Commit-Position: refs/heads/master@{#332058}
* Honor 'sysroot' setting when running cups-configsbc2015-05-222-7/+17
| | | | | | | | This mimic the existing behavior of build/linux/pkg-config-wrapper. Review URL: https://codereview.chromium.org/1156773004 Cr-Commit-Position: refs/heads/master@{#331207}
* Convert JsonWriter::Write to taking a const ref for the in-paramestade2015-05-161-1/+1
| | | | | | | | | | | | Clearer API; flushes out a lot of unnecessary heap allocations. depends on https://codereview.chromium.org/1129083003/ BUG=none Review URL: https://codereview.chromium.org/1131113004 Cr-Commit-Position: refs/heads/master@{#330255}
* Replacing VerifierTraits with DummyVerifierTraits for non-kernel handles.shrikant2015-05-051-2/+2
| | | | | | | | | | | Current implicit assumption for VerifierTraits when it is using ActiveVerifier seems to be that these are all one category of handles, espcially kernel handles as it is hooking up CloseHandle API. HDC/Printer Handle/Device Info handle all different from kernel handles. BUG=475872 R=cpu@chromium.org,grt@chromium.org,wfh@chromium.org,vitalybuka@chromium.org,keybuk@chromium.org, armansito@chromium.org, rpaquay@chromium.org Review URL: https://codereview.chromium.org/1121233003 Cr-Commit-Position: refs/heads/master@{#328402}
* Allow page range selection in system dialog called from previewvitalybuka2015-05-0512-15/+30
| | | | | | | | | | | Two location for this option could case small confusion. Still some users may prefer to select pages in system dialog. BUG=461843 Review URL: https://codereview.chromium.org/1124433006 Cr-Commit-Position: refs/heads/master@{#328260}
* [Mac/Cleanup] Trim down Foundation.h and ApplicationServices.h includestapted2015-05-042-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Foundation.h is about 100k lines of preprocessed source. ApplicationServices is one of the many things it includes, and it is also large (80k lines) and appears in ui/gfx/geometry headers that are used in many places that don't care specifically about mac. This CL avoids including Foundation.h or ApplicationServices.h from commonly-used header files. The particular focus is on header files typically included from other header files (versus headers most commonly included only from .cc or .mm files). The geometry headers get a forward-declare and fewer inline functions. rect.h on Mac was already de-inlined, so this makes size and point consistent with that. It also makes Mac more consistent with the approach on Windows for native geometry types. The main Foundation.h contributor was scoped_nsobject.h. It switches from <Foundation/Foundation.h> (100k lines) to <Foundation/NSObject.h> (1.5k lines). Note that even NSObject.h is not strictly needed: <objc/objc.h> for the declaration of "nil" is sufficient, but forces users of scoped_nsobject to make their own decision of the header to include. This results in a 36m20s [+/- 1s] CPU time improvement to compile times on Mac (or a measured 1m33s [+/- 2s] real/wall time improvement on a recent macpro). Error range gives the interval wherein lies the true mean with a 90% confidence (6 measurements each). There's a also a reduction in name collisions. E.g. kSmallIconSize which is a global symbol in both Chrome and CoreServices, and is what actually set me down this path in the first place. BUG=None TBR=sdefresne@chromium.org,stuartmorgan@chromium.org,thestig@chromium.org Review URL: https://codereview.chromium.org/1092033006 Cr-Commit-Position: refs/heads/master@{#328102}
* vs2015: avoid int->float warning in printing/emf_win.ccscottmg2015-04-301-3/+8
| | | | | | | | | | | | d:\src\cr2\src\printing\emf_win.cc(548): warning C4838: conversion from 'int' to 'FLOAT' requires a narrowing conversion d:\src\cr2\src\printing\emf_win.cc(569): warning C4838: conversion from 'int' to 'FLOAT' requires a narrowing conversion R=alekseys@chromium.org BUG=440500 Review URL: https://codereview.chromium.org/1113113002 Cr-Commit-Position: refs/heads/master@{#327781}
* win: Fix remaining plugin warnings in ash, device, printing, sandbox.thakis2015-04-302-6/+15
| | | | | | | | | | | https://www.chromium.org/developers/coding-style/chromium-style-checker-errors BUG=467287 TBR=cpu Review URL: https://codereview.chromium.org/1115293002 Cr-Commit-Position: refs/heads/master@{#327773}
* Update {virtual,override} to follow C++11 style in printing.nick2015-04-277-46/+46
| | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Review URL: https://codereview.chromium.org/1101023002 Cr-Commit-Position: refs/heads/master@{#327173}
* Fix crash from ipc_fuzzervitalybuka2015-04-111-0/+1
| | | | | | | | | | | | | | | | Can't reproduce original crash so I just fix all crashes I see. Use WeakPtr in AskUserForSettings callback. Move chrome::ShowMessageBox in separate task and protection against nested message boxes. Add missing return into AskUserForSettings. BUG=472146 Review URL: https://codereview.chromium.org/1083433003 Cr-Commit-Position: refs/heads/master@{#324746}
* Use SkPictureRecorder::endRecordingAsPicture() instead of endRecording()thestig2015-04-081-1/+1
| | | | | | | | endRecording() is deprecated. Review URL: https://codereview.chromium.org/1066273002 Cr-Commit-Position: refs/heads/master@{#324260}
* printing: Use MD5DigestToBase16() to get a human-readable hexadecimal string.tfarina2015-04-081-1/+1
| | | | | | | | | | | | | | | It seems better to use a specific MD5 API for this kind of thing. The result should be the same with the difference that the alpha chars used in MD5DigestToBase16() are lowercase. BUG=None TEST=components_browsertests --gtest_filter=PrintWebViewHelperTest.PrintLayoutTest R=vitalybuka@chromium.org Review URL: https://codereview.chromium.org/1068593002 Cr-Commit-Position: refs/heads/master@{#324186}
* SkPDF Metafile: fix recording canvas scalinghalcanary2015-04-031-10/+16
| | | | | | | | | | | Scale the recording canvas's page size, not it's canvas matrix. This allows getTotalMatrix() to return the identity matrix. BUG=469656 Review URL: https://codereview.chromium.org/1060603003 Cr-Commit-Position: refs/heads/master@{#323820}
* Address NewApi lint warnings in src/printing.newt2015-03-063-1/+10
| | | | | | | | | | | These are all false positives. We just need to mark several classes with @TargetApi(KitKat) since printing is only used on KitKat+. BUG=411461 Review URL: https://codereview.chromium.org/980473002 Cr-Commit-Position: refs/heads/master@{#319467}
* Add missing printExtension to print settings for print previewtbarzic2015-03-031-3/+8
| | | | | | | | BUG=461888 Review URL: https://codereview.chromium.org/957123002 Cr-Commit-Position: refs/heads/master@{#318852}
* Apply gn format with 'sources' sorting to src/scottmg2015-02-281-2/+2
| | | | | | | | | | | | Application of https://codereview.chromium.org/962003002/. TBR=keybuk@chromium.org R=brettw@chromium.org BUG=456014 Review URL: https://codereview.chromium.org/960413003 Cr-Commit-Position: refs/heads/master@{#318574}
* Remove unused codevitalybuka2015-02-234-19/+1
| | | | | | Review URL: https://codereview.chromium.org/932543003 Cr-Commit-Position: refs/heads/master@{#317629}
* Block nested system print dialogs on Windows.vitalybuka2015-02-232-1/+9
| | | | | | | | | | | | Browser needs to allow nested tasks to update backgroud tabs. If rendered requests new system dialog, asan build crashes in COMDLG32.dll NOTRY=true BUG=451753 Review URL: https://codereview.chromium.org/934393003 Cr-Commit-Position: refs/heads/master@{#317611}
* Add more size_t -> int warning fixes for the win x64 GN build.dpranke2015-02-201-0/+2
| | | | | | | | | R=brettw@chromium.org BUG=354261 Review URL: https://codereview.chromium.org/941863002 Cr-Commit-Position: refs/heads/master@{#317439}
* win/aura: Remove some more non-aura code for Windows.Sadrul Habib Chowdhury2015-02-131-9/+0
| | | | | | | | | | | | This removes all the uses of USE_AURA ifdefs from the _win.cc files (and some additional removal of dead code). BUG=none R=mkwst@chromium.org, sky@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/909183002 Cr-Commit-Position: refs/heads/master@{#316231}
* Add support for starting an extension print job to print previewtbarzic2015-02-122-0/+5
| | | | | | | | | | | This only implements web UI part; print_preview_handler returns an error for all issued jobs. BUG=408772 Review URL: https://codereview.chromium.org/909143004 Cr-Commit-Position: refs/heads/master@{#315925}
* Removed unused code in skia/ext/vector_*.vitalybuka2015-02-063-9/+8
| | | | | | | | Code is not used after we Chrome stopped generation of EMF inside render. Review URL: https://codereview.chromium.org/900683004 Cr-Commit-Position: refs/heads/master@{#315076}
* Update {virtual,override,final} to follow C++11 style in printing.dcheng2015-02-062-19/+18
| | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Review URL: https://codereview.chromium.org/900793008 Cr-Commit-Position: refs/heads/master@{#314957}
* Update {virtual,override,final} to follow C++11 style in printing, round 2.dcheng2015-01-232-28/+25
| | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Review URL: https://codereview.chromium.org/868883003 Cr-Commit-Position: refs/heads/master@{#312724}
* Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt.halcanary2015-01-221-85/+127
| | | | | | | | | | | | | | | | | | | | | | | | This relands http://crrev.com/694213002 In the PdfMetafileSkia class, Instead of storing a SkPDFDocument, store a vector of pages as SkPictures. This allows access to individual at any time. When FinishDocument() is called, use the SkDocument API to print all pages to PDF. In PrintWebViewHelper::RenderPageContent, skip clipping content to content area, since Windows printing prints content just outside of the content area, as noted in http://crbug.com/434079 . BUG=278148 Committed: https://crrev.com/18387e7ebb0eae6e4944e841d63ea058adab6e11 Cr-Commit-Position: refs/heads/master@{#310032} Review URL: https://codereview.chromium.org/821703005 Cr-Commit-Position: refs/heads/master@{#312672}
* Fix crash on NULL pointer when the browser is compiled with use_cups=0Paweł Hajdan, Jr2015-01-222-3/+41
| | | | | | | | | | | | | | Please see https://bugs.gentoo.org/show_bug.cgi?id=530682 for context. The idea is to make cups dependency optional at compile time. Even without cups one can print to file (pdf) or use cloud print. BUG=none R=thestig@chromium.org Review URL: https://codereview.chromium.org/862023002 Cr-Commit-Position: refs/heads/master@{#312594}
* Move the test template to //testing/test.gni (part 2)qsr2015-01-211-0/+1
| | | | | | | | | | | | This CL move the test target from build/config/BUILDCONFIG.gn to testing/test.gni It also update the test template to automatically build an apk on Android. R=cjhopman@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/824263004 Cr-Commit-Position: refs/heads/master@{#312396}
* Double buffer size to avoid crashes with drives which request buffer smallervitalybuka2015-01-081-0/+10
| | | | | | | | | | than dmSize + dmDriverExtra. BUG=421402 Review URL: https://codereview.chromium.org/821163006 Cr-Commit-Position: refs/heads/master@{#310620}
* Revert of Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt. ↵halcanary2015-01-081-130/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #6 id:140001 of https://codereview.chromium.org/821703005/) Reason for revert: A bisect proved that this change caused https://code.google.com/p/chromium/issues/detail?id=446729 Original issue's description: > Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt. > > This relands http://crrev.com/694213002 > > In the PdfMetafileSkia class, Instead of storing a > SkPDFDocument, store a vector of pages as > SkPictures. This allows access to individual at any > time. When FinishDocument() is called, use the > SkDocument API to print all pages to PDF. > > In PrintWebViewHelper::RenderPageContent, skip clipping > content to content area, since Windows printing prints > content just outside of the content area, as noted in > http://crbug.com/434079 . > > BUG=278148 > > Committed: https://crrev.com/18387e7ebb0eae6e4944e841d63ea058adab6e11 > Cr-Commit-Position: refs/heads/master@{#310032} TBR=vitalybuka@chromium.org,reed@google.com,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG=278148 BUG=446729 Review URL: https://codereview.chromium.org/788053006 Cr-Commit-Position: refs/heads/master@{#310517}
* Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt.halcanary2015-01-061-85/+130
| | | | | | | | | | | | | | | | | | | | | This relands http://crrev.com/694213002 In the PdfMetafileSkia class, Instead of storing a SkPDFDocument, store a vector of pages as SkPictures. This allows access to individual at any time. When FinishDocument() is called, use the SkDocument API to print all pages to PDF. In PrintWebViewHelper::RenderPageContent, skip clipping content to content area, since Windows printing prints content just outside of the content area, as noted in http://crbug.com/434079 . BUG=278148 Review URL: https://codereview.chromium.org/821703005 Cr-Commit-Position: refs/heads/master@{#310032}
* Cleanup: Update the path to gfx size headers.tfarina2015-01-036-6/+6
| | | | | | | | | | | | | The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so we are updating the include paths to fix this. BUG=395370 TEST=compiles TBR=sky@chromium.org,danakj@chromium.org Review URL: https://codereview.chromium.org/832953002 Cr-Commit-Position: refs/heads/master@{#309873}
* Cleanup: Update the path to gfx rect headers.tfarina2014-12-3110-10/+10
| | | | | | | | | | | | | The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so we are updating the include paths to fix this. BUG=395370 TEST=compiles TBR=sky@chromium.org,danakj@chromium.org Review URL: https://codereview.chromium.org/823133004 Cr-Commit-Position: refs/heads/master@{#309814}
* Cleanup: Update the path to insets and point headers.tfarina2014-12-232-2/+2
| | | | | | | | | | | | | The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so we are updating the include paths to fix this. BUG=395370 TEST=unit_tests, content_unittests, extensions_unittests ... TBR=sky@chromium.org,danakj@chromium.org Review URL: https://codereview.chromium.org/823703003 Cr-Commit-Position: refs/heads/master@{#309523}
* Standardize usage of virtual/override/final specifiers in printing code.dcheng2014-12-221-18/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 Review URL: https://codereview.chromium.org/795043004 Cr-Commit-Position: refs/heads/master@{#309487}
* Update legacy Tuple-using code.Avi Drissman2014-12-221-4/+4
| | | | | | | | | | | BUG=440675 TEST=no change R=mdempsky@chromium.org, thakis@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/821453003 Cr-Commit-Position: refs/heads/master@{#309441}
* Implement window.print() on Androiddgn2014-12-1518-10/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Essentially wires up the window.print() and the basic printing path to Android framwork's PrintManager. The changes affect the basic printing path using PrintingMessageFilter::OnScriptedPrint. When calling window.print() on Android, it would now be called twice. The first time is directly after the JS call, OnScriptedPrint is called with a parameter telling it that it's being called from JS. It will then end up calling PrintJobWorker::GetSettings, forwarding that information. PrintJobWorker then takes care of calling PrintingController through JNI, joining the same code path used when printing from chrome's menu in android: Android framework's PrintManager is invoked, and it manages the preview, using the tab to generate the output as the user changes his/her preferences. Why so many changes for just that: the window.print() call is blocked until the end of the process by message pumping. It has to be disabled when printing is finished. It is currently done by setting a callback in the current PrintingContext, that will be called when printing is done. PrintingController stores the reference to it, but here we have two queries at the same time, and only the latest PrintingContext would be stored. I added a field to store separately the one coming from the initial call, so that it can be used when printing is done to stop the message pumping. TL;DR: When window.print() is called, the basic printing path is used to forward the query to PrintManager. The PrintManager then uses almost the same path to actually print the document (as previously implemented to power the 'Print...' entry in the menu). The changes are mostly to ensure that JS returns when printing is completed and not before (or never). BUG=437338 Review URL: https://codereview.chromium.org/740983002 Cr-Commit-Position: refs/heads/master@{#308416}
* Add missed files in Windows GN build for printing.vchigrin2014-12-151-0/+2
| | | | | | Review URL: https://codereview.chromium.org/803493003 Cr-Commit-Position: refs/heads/master@{#308413}
* Drop unused base/tuple.h inclusiontzik2014-12-091-5/+0
| | | | | | | | | | TEST=compile BUG=None TBR=jam@chromium.org Review URL: https://codereview.chromium.org/790623002 Cr-Commit-Position: refs/heads/master@{#307457}
* Support NumCopies print presetn.bansal2014-12-092-0/+4
| | | | | | | | | | | | Chrome side javascript changes to support NumCopies print preset option. Copies in print preview dialog should be set to value set for NumCopies in pdf source document. BUG=169120 Review URL: https://codereview.chromium.org/407733002 Cr-Commit-Position: refs/heads/master@{#307454}
* Switch back to PrintDlgEx instead of DocumentProperties.vitalybuka2014-12-081-2/+12
| | | | | | | | | | | For unclear reasons DocumentProperties with DM_IN_PROMPT sometimes does not return. This is happening mostly on 32bit Windows inside of base::MessageLoop::ScopedNestableTaskAllower. BUG=436810 Review URL: https://codereview.chromium.org/766823004 Cr-Commit-Position: refs/heads/master@{#307294}
* gn format // (the rest, except mojo)scottmg2014-12-031-8/+5
| | | | | | | | | | | | | | Excluded mojo because I think that needs to happen on the other side. At gn --version = 306668 for which roll is in CQ. R=brettw@chromium.org TBR=scherkus@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/774353003 Cr-Commit-Position: refs/heads/master@{#306708}
* Added alekseys@chromium.org to printing OWNERS.vitalybuka2014-11-211-0/+1
| | | | | | Review URL: https://codereview.chromium.org/660453004 Cr-Commit-Position: refs/heads/master@{#305302}
* Revert of Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt. ↵vitalybuka2014-11-181-150/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #4 id:370001 of https://codereview.chromium.org/694213002/) Reason for revert: Breaks printing. BUG=434079 Original issue's description: > Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt. > > In the PdfMetafileSkia class, Instead of storing a > SkPDFDocument, store a vector of pages as > SkPictures. This allows access to individual at any > time. When FinishDocument() is called, use the > SkDocument API to print all pages to PDF. > > BUG=278148 > > Committed: https://crrev.com/816b7105b078f7300f825cd81f379e312efdb821 > Cr-Commit-Position: refs/heads/master@{#304379} TBR=robertphillips@google.com,reed@google.com,halcanary@google.com BUG=278148 Review URL: https://codereview.chromium.org/731143004 Cr-Commit-Position: refs/heads/master@{#304536}
generated by cgit v1.1 at 2025-02-20 04:17:18 +0000