| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
R=viettrungluu@chromium.org
TBR=viettrungluu
Review URL: https://codereview.chromium.org/184563006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is to add a new build option 'use_allocator' which will
replace 'linux_use_tcmalloc' in the future. It doesn't change the
behavior immediately. The migration plan is as follows:
1) (this change)
... Add 'use_allocator' and set its default to "see_use_tcmalloc".
... Change allocator conditions to check use_allocator firstly.
... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc".
... NO IMPACT without specifying use_allocator explicitly.
2) Change Blink to accept use_allocator. http://crrev.com/177053003/
3) Change gyp to accept use_allocator. http://crrev.com/178643004/
4) PSA the transition period to chromium-dev@.
5) (after the PSA-ed transition period)
... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default.
... Remove all linux_use_tcmalloc.
... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified.
At the point of this change (1), linux_use_tcmalloc is still used by default
because 'use_allocator%': "see_use_tcmalloc".
As written in http://crbug.com/345554, linux_use_tcmalloc would
be confusing to have more options about allocators. We plan to:
A) enable gperftools' heap-profiler with non-tcmalloc allocator,
B) add a new memory allocator instead of tcmalloc.
BUG=345554, 339604, 341349
R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/177353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces Window::GetDispatcher with Window::GetHost().
Had to clear ScreenPositionClient property prior to window teardown as tests on desktop delete it prior to destroying the window hierarchy. Unhooking the property appears to have no ill-effect.
R=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/184903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=viettrungluu@chromium.org, viettrungluu
Review URL: https://codereview.chromium.org/183853011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
driver behavior.
BUG=347282
Review URL: https://codereview.chromium.org/182273003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252221
Review URL: https://codereview.chromium.org/168003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/174433003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We should crash only if returned result is bigger that buffer we provided.
BUG=345605
NOTRY=true
Review URL: https://codereview.chromium.org/175603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Use DocumentProperties to get default DEVMODE instead of PRINTER_INFO_*.
> Fixed ScopedPrinterHandle::OpenPrinter interface.
>
> Review URL: https://codereview.chromium.org/168003002
TBR=vitalybuka@chromium.org
BUG=345746
Review URL: https://codereview.chromium.org/175173005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/308843
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/174803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixed ScopedPrinterHandle::OpenPrinter interface.
Review URL: https://codereview.chromium.org/168003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=344982
NOTRY=true
Review URL: https://codereview.chromium.org/172813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
DM_YRESOLUTION check was invalid.
TBR=noamsml
Review URL: https://codereview.chromium.org/170013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=344291
TBR=noamsml
Review URL: https://codereview.chromium.org/169373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Wrap DocumentProperties into printing::CreateDevMode().
BUG=166587
Review URL: https://codereview.chromium.org/165993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
TBR=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/160573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tasks need to be processed for painting to occur in other browser
windows while the modal dialog is up in Aura.
R=vitalybuka@chromium.org
BUG=342697,180997,343848
Review URL: https://codereview.chromium.org/164303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r251066 reverted the backgrounding of the print dialog.
Before the revert
http://src.chromium.org/viewvc/chrome/trunk/src/printing/printing_context_win_unittest.cc?r1=232466&r2=232611
assumed they were going to be async, so added RunLoop. Now that the
dialog is synchronous again, remove that code which is causing the
MessageLoop to complain.
TBR=vitalybuka@chromium.org
R=asvitkine@chromium.org
BUG=180997,342697
Review URL: https://codereview.chromium.org/164483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per discussion with ananta, opening a system modal dialog from a
background thread is a bad idea, so reverting this (from long ago).
Windows doesn't preserve the order correctly when the window is not on
the main UI thread, and in the bug here, it interacts very badly with
the IME toolbar window, causing the modal print dialog to go behind the
browser window in Z order making chrome appear to be hung.
The original goal was to fix tasks not being dispatched while the dialog
was open. We can instead use the ScopedNestedTaskAllower as we've done
for other system modal dialogs which I'll do in a separate CL.
BUG=342697,180997
> Use BaseShellDialog for print dialog on Windows
>
> This puts the print dialog on a background thread which is necessary so other
> top level windows can keep painting as Aura does the compositor swaps on the
> UI thread.
>
> R=sky@chromium.org,vitalybuka@chromium.org
>
>
> Review URL: https://codereview.chromium.org/27441003
TBR=scottmg@chromium.org,sky@chromium.org,vitalybuka@chromium.org,ananta@chromium.org
Review URL: https://codereview.chromium.org/164013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
messages from a bad renderer.
BUG=341777
Review URL: https://codereview.chromium.org/157323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=noamsml
Review URL: https://codereview.chromium.org/155663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Dpi capabilities.
BUG=317027
NOTRY=true
Review URL: https://codereview.chromium.org/153373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.
BUG=246708
R=vandebo@chromium.org
Review URL: https://codereview.chromium.org/145353018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/141703005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move into base/numerics subdirectory.
* Rename files for clarity.
* Add owners.
* Rename checked_numeric_cast to checked_cast.
* Fixup callsites and include paths.
BUG=332611
R=brettw@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/141113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A todo is the parent/dialog relationship. Right now print_dialog_gtk2
creates the dialog with NULL parent, so the dialog can move under the
browser window.
We need to do something similar to select_file_dialog_impl_gtk2.cc
BUG=317882
R=erg@chromium.org, thestig@chromium.org, vitalybuka@chromium.org
TEST=manually
Review URL: https://codereview.chromium.org/135163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
sandbox/, skia/, sql/, sync/, tools/, webkit/, win8/ to use the base:: namespace.
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/121123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
printing/, remoting/, rlz/, sync/, ui/ to use the base:: namespace.
BUG=88666
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/116433007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=dpapad@chromium.org
BUG=329295
Review URL: https://codereview.chromium.org/101643006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
http://crbug.com/327489
Review URL: https://codereview.chromium.org/109433013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than each dependent target of a target that generates jni headers having
to specify the appropriate include_dir manually, jni_generator.gypi can do it
via direct_dependent_settings.
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/111493006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=320711
TBR=isherman@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/110963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
First part of a two sided change. kNotEmbeddable_Font is going away in favor of an explicit flag to represent it. This change preserves existing functionality/operation and just changes the constant being used.
BUG=NONE
Review URL: https://codereview.chromium.org/105433003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/85693005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/102873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/99923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is
generally undefined on Mac, but as of r223369, it is incorrect in Chrome on
Mac.
To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not
used with close, and that IGNORE_EINTR is only used with close. Unnecessary
#includes of eintr_wrapper.h are also removed.
base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc
contain non-mechanical changes. Variable naming within the latter is updated
per r178174. Missing #includes for <errno.h> in
content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were
manually added. Mechanical changes were generated by running:
sed -E -i '' \
-e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \
-e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \
-e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \
$(git grep -El 'HANDLE_EINTR.*close')
sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \
$(grep -EL '(HANDLE|IGNORE)_EINTR' \
$(git grep -El '#include.*eintr_wrapper\.h"'))
BUG=269623
R=agl@chromium.org, jln@chromium.org
TBR=OWNERS
Review URL: https://codereview.chromium.org/100253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This also swaps the order of the parameters to GetShmemTempDir so the out
parameter is last, and enhances some documentation.
Review URL: https://codereview.chromium.org/93263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In general, the OS API contract doesn't guarantee that output variables are
not modified on failure, so a Reeceive pattern is fundamentally insecure.
BUG=318531
TEST=current tests
tbr'ing owners for the consumers.
TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237459
Review URL: https://codereview.chromium.org/71013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Causing compile failure in chrome_util.cc on "Google Chrome Win" http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/21803
TBR=cpu@chromium.org,jvoung@chromium.org,thakis@chromium.org,sergeyu@chromium.org,grt@chromium.org,gene@chromium.org,youngki@chromium.org,rvargas@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/90963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In general, the OS API contract doesn't guarantee that output variables are
not modified on failure, so a Reeceive pattern is fundamentally insecure.
BUG=318531
TEST=current tests
tbr'ing owners for the consumers.
TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org
Review URL: https://codereview.chromium.org/71013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=avayvod@chromium.org
Review URL: https://codereview.chromium.org/85623005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=317523
Review URL: https://codereview.chromium.org/83283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
PrintingControllerImpl uses new KitKat APIs, so it causes problems with
ICS bots.
BUG=321751
Review URL: https://codereview.chromium.org/83263003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=318373
Review URL: https://codereview.chromium.org/78173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/77453004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move printing logic from Tab to TabBase (i.e. to upstream), and
also in the relevant files tab_android.*, TabPrinter.java.
* Remove obsolete Android printing feature detection code.
* Move PrintingControllerFactory logic into PrintingControllerImpl.
* Create a new PrintingControllerFactory, so the clients have a
ligher weight creation process (5-6 lines to 1).
* Instead of depending on Context to create a PrintManager, depend
on an interface, namely PrintManagerDelegate.
* Remove setErrorText (move the logic inside factory).
* Remove the hardcoded default file name (use Printable#getTitle)
instead.
BUG=315229
Review URL: https://codereview.chromium.org/63483007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=318373
TBR=gene
Review URL: https://codereview.chromium.org/78143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added RenderPDFPageToBitmap signature.
Call ChromeContentUtilityClient::PreSandboxStartup for Zygote. It does not real additional work. Zygote already loads pdf and initialize MediaLibrary for renderer inside content/, pdf is just to hard to access from Utility. ServiceDiscoveryMessageHandler::PreSandboxStartup does nothing for POSIX.
BUG=318373
Review URL: https://codereview.chromium.org/70083006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Printing context need to know that it's Privet local printing to generate preview.
BUG=318373
Review URL: https://codereview.chromium.org/77023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236211 0039d316-1c4b-4281-b951-d872f2087c98
|