| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
native preview app.
BUG=101724
TEST=Preview a webpage. Click "Open PDF In Preview" option Observe that the pdf is displayed in native preview app. Complete the printing workflow by clicking "Print" or
"Cancel" button at the bottom of the preview app.
Review URL: http://codereview.chromium.org/8425008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8468031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)
BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/8491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of http://codereview.chromium.org/8351048/ with minor changes
to fix the compilation errors on the shared builders.
BUG=102446
TEST=See bug description.
Review URL: http://codereview.chromium.org/8528053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes "Custom" margins sticky across different preview sessions but also within the same preview session.
Here is a summary of all changes.
- Within same preview session: So far selecting "Custom" was
picking up from whatever the previous selected option was.
Now, "Custom" remembers the specified margins. To test this
select "Custom", do some dragging, then change to another
option and back to "Custom".
- Across preview sessions: Select "Custom", do some dragging,
then print. Open print preview again, the last used custom
margins are remembered.
- There was a bunch of messages sent from JS to get various
info/settings (initiator tab title, measurement system and
number format, last used margin settings, default printer).
I created a single message "getInitialSettings" to get all
at once (they are needed before the 1st preview is is
requested).
BUG=102446
TEST=See bug description.
Review URL: http://codereview.chromium.org/8351048
TBR=dpapad@chromium.org
Review URL: http://codereview.chromium.org/8564040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes "Custom" margins sticky across different preview sessions but also within the same preview session.
Here is a summary of all changes.
- Within same preview session: So far selecting "Custom" was
picking up from whatever the previous selected option was.
Now, "Custom" remembers the specified margins. To test this
select "Custom", do some dragging, then change to another
option and back to "Custom".
- Across preview sessions: Select "Custom", do some dragging,
then print. Open print preview again, the last used custom
margins are remembered.
- There was a bunch of messages sent from JS to get various
info/settings (initiator tab title, measurement system and
number format, last used margin settings, default printer).
I created a single message "getInitialSettings" to get all
at once (they are needed before the 1st preview is is
requested).
BUG=102446
TEST=See bug description.
Review URL: http://codereview.chromium.org/8351048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8538001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8560001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
margins values.
BUG=103465
TEST=Please refer to bug report.
Review URL: http://codereview.chromium.org/8505024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103183
TEST=none
Review URL: http://codereview.chromium.org/8496004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Splits printing_context_cairo into gtk and no system dialog versions. No system dialog versions are used in Chrome OS and Aura.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=13915
TEST=Build Chrome with Aura. Hit ctrl-p from any web page. Print preview page should come up and should be able to print via Cloud Print.
Review URL: http://codereview.chromium.org/8372030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101600,94925
TEST=none
TBR=vandebo,viettrungluu
Review URL: http://codereview.chromium.org/8487001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
orientation.
BUG=101419
TEST=Please refer to bug description.
Review URL: http://codereview.chromium.org/8351063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes sticky default, minimum and no margins selections. Selecting custom margins is not remembered for now (will be addressed in a follow up CL).
BUG=102446
TEST=See bug description.
Review URL: http://codereview.chromium.org/8428005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PMPageFormat.
BUG=none
TEST=Preview a webpage. Make sure the preview page size is same as default page size in print&fax preference pane.
Review URL: http://codereview.chromium.org/8426002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most consumers on all platforms (including windows!) were converting the font family/GetFontName() result to UTF8. (Windows was still having to convert for the SkTypeface calls.) On Linux, we're performing a UTF16ToUTF8 on each string print (and this is showing up in pprof output.)
BUG=100803
TEST=none
Review URL: http://codereview.chromium.org/8392017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/8342059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8334007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8345001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
size.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/8328001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
some general clean ups.
BUG=67091, 92045, 92218
TEST=Print a PDF with print scaling disabled and see that it takes up the entire page.
Review URL: http://codereview.chromium.org/8312003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems that this is where it is supposed to live and it was erroneously added to PrintWebViewHelper.
BUG=67091, 92045, 91880, 92000, 92218, 95905
TEST=NONE
Review URL: http://codereview.chromium.org/8201027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Add a printer which supports grayscale and cmyk color models. Preview a
color webpage. Observe that the color options is displayed to the user.
Review URL: http://codereview.chromium.org/8280002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
fine.
BUG=none
TEST=none
R=thestig@chromium.org
Review URL: http://codereview.chromium.org/8290001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original (broken) CL: http://codereview.chromium.org/8227034
Already approved by dpapad@
TBR=dpapad@chromium.org
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/8261005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
printer ppd/schema info.
Show/Hide the color options based on printer ppd/schema information. Some printers does not provide sufficient information in the printer schema/ppd regarding the color settings and they use custom advance settings to print in black & white/greyscale. In those cases, users need to print using native dialog in order to set these advance color settings.
BUG=93811, 93490, 87344, 96658, 98768
TEST= Please refer to bug description.
Review URL: http://codereview.chromium.org/8138020
Review URL: http://codereview.chromium.org/8226024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
printer ppd/schema information.
Show/Hide the color options based on printer ppd/schema information. Some printers does not provide sufficient information in the printer schema/ppd regarding the color settings and they use custom advance settings to print in black & white/greyscale. In those cases, users need to print using native dialog in order to set these advance color settings.
BUG=93811, 93490, 87344, 96658, 98768
TEST= Please refer to bug description.
Review URL: http://codereview.chromium.org/8138020
TBR=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/8245012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
information.
Show/Hide the color options based on printer ppd/schema information. Some printers does not provide sufficient information in the printer schema/ppd regarding the color settings and they use custom advance settings to print in black & white/greyscale. In those cases, users need to print using native dialog in order to set these advance color settings.
BUG=93811, 93490, 87344, 96658, 98768
TEST= Please refer to bug description.
Review URL: http://codereview.chromium.org/8138020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is not enough to build without stubs for WmIpc, Bubble and ScreenLocker.
TBR=sky@chromium.org
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/8233029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=96063
TEST=NONE
Review URL: http://codereview.chromium.org/8200010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8205015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99261
TEST=none
Review URL: http://codereview.chromium.org/8207004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=99362
TEST=None
Review URL: http://codereview.chromium.org/8190012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92000
TEST=NONE
Review URL: http://codereview.chromium.org/8173016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Use ScopedSelectObject for changed files
BUG=99139
TEST=no user visible change
Review URL: http://codereview.chromium.org/8139022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8174005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8174015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
channel.
Review URL: http://codereview.chromium.org/8146004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
remove Gtk too).
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/8165004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and printing::PrintedDocument::url(). They were only used by the old headers/footers code.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8113029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add handling for the cloud print dialog to update settings code on Mac and Windows.
BUG=98929
TEST=
Review URL: http://codereview.chromium.org/8122006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97431
TEST=Please refer to bug report.
Review URL: http://codereview.chromium.org/8072007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When there's no printer in system, invalid empty settings will be provided for Print to PDF. This patch fixes it.
BUG=95975
TEST=none
Review URL: http://codereview.chromium.org/8044008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed "Local" and "Cloud" labels from dropdown
The "More printers" label is now more clear and shares behavior with the cloud print printer option in Chrome.
The system print dialog link is replaced with a similar link referencing cloud print in chrome os.
Choosing cloud print from the printers dropdown now requires the user to hit print before opening the cloud print dialog.
Fixed broken tests.
BUG=88098, 97175, http://code.google.com/p/chromium-os/issues/detail?id=16082, http://code.google.com/p/chromium-os/issues/detail?id=20121, http://code.google.com/p/chromium-os/issues/detail?id=20119
TEST=Enable print preview in about:flags. Printing should work with cloud print printers in much the same way as local printers in Chrome
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103010
Review URL: http://codereview.chromium.org/7976017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
So we don't need to override operator<< for Rect class.
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8066006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=96063
TEST=NONE
Review URL: http://codereview.chromium.org/8054031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
last page of the PDF
BUG=93145
TEST=Please refer to bug report.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103021
Original review URL: codereview.chromium.org/7719014
Please refer to trybot results in the last patch of original review url.
Review URL: http://codereview.chromium.org/8059034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
print_preview_cloud.js.
Removed "Local" and "Cloud" labels from dropdown
The "More printers" label is now more clear and shares behavior with the cloud print printer option in Chrome.
The system print dialog link is replaced with a similar link referencing cloud print in chrome os.
Choosing cloud print from the printers dropdown now requires the user to hit print before opening the cloud print dialog.
Fixed broken tests.
BUG=88098, 97175, http://code.google.com/p/chromium-os/issues/detail?id=16082, http://code.google.com/p/chromium-os/issues/detail?id=20121, http://code.google.com/p/chromium-os/issues/detail?id=20119
TEST=Enable print preview in about:flags. Printing should work with cloud print printers in much the same way as local printers in Chrome
Review URL: http://codereview.chromium.org/7976017
TBR=abodenha@google.com
Review URL: http://codereview.chromium.org/8055036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
only previews the last page of the PDF
BUG=93145
TEST=Please refer to bug report.
Review URL: http://codereview.chromium.org/7719014
TBR=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/8052020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
last page of the PDF
BUG=93145
TEST=Please refer to bug report.
Review URL: http://codereview.chromium.org/7719014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103021 0039d316-1c4b-4281-b951-d872f2087c98
|