summaryrefslogtreecommitdiffstats
path: root/remoting/host
Commit message (Collapse)AuthorAgeFilesLines
* Move ChromiumPortAllocatorFactory to remoting/protocolsergeyu2015-11-103-106/+2
| | | | | | | | BUG=547158 Review URL: https://codereview.chromium.org/1419783013 Cr-Commit-Position: refs/heads/master@{#358751}
* Use the Local Machine Cert store in the token validator.weitaosu2015-11-072-9/+38
| | | | | | | | BUG=359798 Review URL: https://codereview.chromium.org/1410093003 Cr-Commit-Position: refs/heads/master@{#358499}
* port remoting_me2me_host_archive to GNdpranke2015-11-042-1/+204
| | | | | | | | | | | | | | | | | | This CL ports the remoting_me2me_host_archive target to GN and several of its dependent targets. This is only a partial port of the target, as the 'remoting_infoplist_strings' target hasn't been ported yet, but I'm not actually sure if that's needed on Linux. This CL also fixes the path to the remoting-webapp zip file. Both of these targets were needed in order to flip the official Linux x64 build over to GN. BUG=512899, 530733 Review URL: https://codereview.chromium.org/1426113002 Cr-Commit-Position: refs/heads/master@{#357697}
* Fix build_deb.sh script to work for any output directory.sergeyu2015-11-032-8/+12
| | | | | | | | | | | Previously build_deb.sh was assuming that the build is in out/Release, which is not always correct, particularly with GN. BUG=512899 Review URL: https://codereview.chromium.org/1412653005 Cr-Commit-Position: refs/heads/master@{#357658}
* Fix chromoting host to report error when closing connection.sergeyu2015-11-0327-68/+76
| | | | | | | | | | | | | | | Previously host would often close session without reporting the reason to the client. Added two new error codes and updated the host to report session termination reason when appropriate. BUG=548261 Committed: https://crrev.com/09750216bef8bc9f2953e4eee9f66801bf034fa4 Cr-Commit-Position: refs/heads/master@{#357215} Review URL: https://codereview.chromium.org/1430503002 Cr-Commit-Position: refs/heads/master@{#357652}
* Move curtain_mode and signal_handler to remoting_hostsergeyu2015-11-031-6/+7
| | | | | | | | | | | | | | There is no reason curtain_mode and signal_handler need to be in remoting_me2me_host_static instead of remoting_host. Also currently try bots don't compile Me2Me host and so they don't detect some potential breakages, e.g. as in https://codereview.chromium.org/1430503002/ . Also added USE_REMOTING_MACOSX_INTERNAL which was missing in the GN build Review URL: https://codereview.chromium.org/1417853005 Cr-Commit-Position: refs/heads/master@{#357600}
* Set encode-time when done encoding a frame.anandc2015-10-311-0/+3
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1417293004 Cr-Commit-Position: refs/heads/master@{#357252}
* Revert of Fix chromoting host to report error when closing connection. ↵rjkroege2015-10-3126-62/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #4 id:60001 of https://codereview.chromium.org/1430503002/ ) Reason for revert: This change would appear to have broken the Mac build: AILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/remoting/host/remoting_me2me_host_static.curtain_mode_mac.o.d -DBINARY_CORE=1 -DBINARY_DESKTOP=2 -DBINARY_HOST_ME2ME=3 -DBINARY_NATIVE_MESSAGING_HOST=4 -DBINARY_REMOTE_ASSISTANCE_HOST=5 -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=247874-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DVERSION=48.0.2551.0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_MAC -DWEBRTC_POSIX -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DOSX -DXML_STATIC -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../.. -Igen -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -Igen/policy -Igen/protoc_out -I../../third_party/webrtc_overrides -I../../third_party -I../../third_party/protobuf -I../../third_party/protobuf/src -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party/expat/files/lib -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O2 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-bitfield-width -Wexit-time-destructors -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/Mac/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics -fno-strict-aliasing -c ../../remoting/host/curtain_mode_mac.cc -o obj/remoting/host/remoting_me2me_host_static.curtain_mode_mac.o ../../remoting/host/curtain_mode_mac.cc:212:48: error: too few arguments to function call, single argument 'error' was not specified client_session_control_->DisconnectSession(); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ../../remoting/host/client_session_control.h:29:3: note: 'DisconnectSession' declared here virtual void DisconnectSession(protocol::ErrorCode error) = 0; ^ 1 error generated. ninja: build stopped: subcommand failed. http://build.chromium.org/p/chromium/builders/Mac/builds/8747 Original issue's description: > Fix chromoting host to report error when closing connection. > > Previously host would often close session without reporting the reason > to the client. Added two new error codes and updated the host to report > session termination reason when appropriate. > > BUG=548261 > > Committed: https://crrev.com/09750216bef8bc9f2953e4eee9f66801bf034fa4 > Cr-Commit-Position: refs/heads/master@{#357215} TBR=kelvinp@chromium.org,tsepez@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=548261 Review URL: https://codereview.chromium.org/1424403002 Cr-Commit-Position: refs/heads/master@{#357238}
* Fix chromoting host to report error when closing connection.sergeyu2015-10-3026-54/+62
| | | | | | | | | | | | Previously host would often close session without reporting the reason to the client. Added two new error codes and updated the host to report session termination reason when appropriate. BUG=548261 Review URL: https://codereview.chromium.org/1430503002 Cr-Commit-Position: refs/heads/master@{#357215}
* Add TransportSession interface to prepare for WebRTC-based transport.sergeyu2015-10-281-2/+2
| | | | | | | | | | | | | | | | | | | | Previosly JingleSession was responsible to establishing connection with the peer and managing list of channels. Now the new IceTransportSession class (that implements TransportSession interface) is responsible for managing list of channels and so it will be possible to add support for WebRTC-based transport by adding another TransportSession implementation. There are no functional changes in this CL. BUG=547158 Committed: https://crrev.com/7a5351f4c6e407e456978f6599d475616a69fc0b Cr-Commit-Position: refs/heads/master@{#356588} Review URL: https://codereview.chromium.org/1420273002 Cr-Commit-Position: refs/heads/master@{#356638}
* Revert of Add TransportSession interface to prepare for WebRTC-based ↵georgesak2015-10-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | transport. (patchset #4 id:60001 of https://codereview.chromium.org/1420273002/ ) Reason for revert: Broke android build. Original issue's description: > Add TransportSession interface to prepare for WebRTC-based transport. > > Previosly JingleSession was responsible to establishing connection > with the peer and managing list of channels. Now the new > IceTransportSession class (that implements TransportSession interface) > is responsible for managing list of channels and so it will be possible > to add support for WebRTC-based transport by adding another > TransportSession implementation. > > There are no functional changes in this CL. > > BUG=547158 > > Committed: https://crrev.com/7a5351f4c6e407e456978f6599d475616a69fc0b > Cr-Commit-Position: refs/heads/master@{#356588} TBR=jamiewalch@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=547158 Review URL: https://codereview.chromium.org/1413813006 Cr-Commit-Position: refs/heads/master@{#356595}
* Add TransportSession interface to prepare for WebRTC-based transport.sergeyu2015-10-281-2/+2
| | | | | | | | | | | | | | | | | Previosly JingleSession was responsible to establishing connection with the peer and managing list of channels. Now the new IceTransportSession class (that implements TransportSession interface) is responsible for managing list of channels and so it will be possible to add support for WebRTC-based transport by adding another TransportSession implementation. There are no functional changes in this CL. BUG=547158 Review URL: https://codereview.chromium.org/1420273002 Cr-Commit-Position: refs/heads/master@{#356588}
* Changing the case of hostOS to hostOs to conform to the coding guidelines.nicholss2015-10-261-1/+1
| | | | | | | | | | This CL is tied to https://critique.corp.google.com/#review/106160051 BUG=547094 Review URL: https://codereview.chromium.org/1426443002 Cr-Commit-Position: refs/heads/master@{#356054}
* Remove RemoteAccessHostDebugOverridePolicies.jamiewalch2015-10-232-59/+0
| | | | | | | | | | This policy is no longer used, and did not apply to Release builds anyway. BUG=545008 Review URL: https://codereview.chromium.org/1406123003 Cr-Commit-Position: refs/heads/master@{#355836}
* Fix Client doesn't handle the case when the connection is rejected by the host.kelvinp2015-10-211-0/+1
| | | | | | | | | | | | | The host doesn't return an error tag when incoming connections are rejected due to curtaining policies. This CL makes the client resilient to that scenario. BUG=543334 Review URL: https://codereview.chromium.org/1393893005 Cr-Commit-Position: refs/heads/master@{#355361}
* remoting: Make conversions from gfx::Point to PointF explicit.danakj2015-10-201-1/+1
| | | | | | | | | | | | | This implicit conversion operator will be going away. The ui::EventLocationFromNative() call returns a Point, so we need to explicitly cast it to a PointF, not just store it in one. R=wez@chromium.org BUG=342848 Review URL: https://codereview.chromium.org/1417563003 Cr-Commit-Position: refs/heads/master@{#355179}
* Make ValueDeserializer::Deserialize return scoped_ptrolli.raula2015-10-162-6/+6
| | | | | | | | | | | | Make ValueDeserializer::Deserialize return scoped_ptr as almost all consumers already use scoped_ptr and it is also better way to do it. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1394993004 Cr-Commit-Position: refs/heads/master@{#354458}
* Use standard DOM code definitions instead of custom.jamiewalch2015-10-122-21/+22
| | | | | | | | This turns out to be a bit more churn than I'd hoped because ui/events/keycodes/dom/dom_code.h declares a strongly-typed enum, which can't be compared to unsigned int without a cast. Overall, I like the safety of typed enums, so I added the casts rather than declaring our own untyped equivalent, but LMK if you would prefer that. Review URL: https://codereview.chromium.org/1403583003 Cr-Commit-Position: refs/heads/master@{#353626}
* Don't use base::MessageLoop::{Quit,QuitClosure} in remoting/ki.stfu2015-10-127-15/+15
| | | | | | | | | | | | | This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 TEST= R=joedow@chromium.org Review URL: https://codereview.chromium.org/1394803004 Cr-Commit-Position: refs/heads/master@{#353583}
* mac: Make remoting_host build with the 10.11 SDK.thakis2015-10-121-6/+6
| | | | | | | | | | | | CGEventFlags used to be a `typedef uint64_t CGEventFlags`, now it's a `enum CGEventFlags : uint64_t`. Add some type casting to keep the compiler happy. BUG=517914 Review URL: https://codereview.chromium.org/1401143002 Cr-Commit-Position: refs/heads/master@{#353564}
* Enforce WARN_UNUSED_RESULT attribute on Windowsdcheng2015-10-101-1/+2
| | | | | | | | | | BUG=none R=cpu,danakj,dpranke,hans,kelvinp,rickyz,sky,sorin,thestig,tuttle,yukawa TBR=vitalybuka Review URL: https://codereview.chromium.org/1390223002 Cr-Commit-Position: refs/heads/master@{#353450}
* Chrome Remote Host: support py3 syntaxvapier2015-10-061-25/+27
| | | | | | | | | | | | | | | | | | | | | | Tweak the code to work both with python2 and python3. Few categories of changes: - use the print function everywhere - use 0o0 for octals - update the exception syntax style - change from dict.has_key to the "in" operator - fix invalid read/write modes - handle encoding when writing to stdin BUG=537436 TEST=started & logged in & stopped daemon w/py2.7 in UTF8 locale TEST=started & logged in & stopped daemon w/py2.7 in C locale TEST=started & logged in & stopped daemon w/py3.4 in UTF8 locale TEST=started & logged in & stopped daemon w/py3.4 in C locale Review URL: https://codereview.chromium.org/1390823002 Cr-Commit-Position: refs/heads/master@{#352658}
* remoting: Remove a comment that references TOOLKIT_GTK.tfarina2015-10-061-1/+0
| | | | | | | | | | | TOOLKIT_GTK is not defined anymore by build/build_config.h. BUG=None R=jamiewalch@chromium.org Review URL: https://codereview.chromium.org/1374313006 Cr-Commit-Position: refs/heads/master@{#352476}
* Renaming CRD host OS details key to be constant with usage.nicholss2015-10-012-9/+11
| | | | | | | | | | | | | | | I added new keys to the xmpp packet heartbeat heartbeat.os-name which at the time was suppose to replace heartbeat.log.os-name but it is not constant with naming for the protos and variables and is easily confused with heartbeat.log.os-name. Renaming the key to heartbeat.host-os-name for constancy. R=sergeyu@chromium.org BUG=534902 Review URL: https://codereview.chromium.org/1375223004 Cr-Commit-Position: refs/heads/master@{#351835}
* Chrome Remote Desktop host will call get linux distro in main, caching result.nicholss2015-10-012-1/+9
| | | | | | | | | | | | | CRD host needs access to the linux distro in the heartbeat thread, but there are IO restrictions on the heartbeat thread. To get around this we will call GetLinuxDistro which caches the result and will allow the heartbeat thread to make the call without costing a IO delay. R=sergeyu@chromium.org Review URL: https://codereview.chromium.org/1379953002 Cr-Commit-Position: refs/heads/master@{#351678}
* Add UMA histograms for more detailed latency tracking on the CRD host.sergeyu2015-09-304-51/+168
| | | | | | | | | | | | | | | | | | | | Previously only two delays in CRD hosts were tracked: capture time and encode time. This CL adds 4 other values that are now measured on the host, sent to the client and logged to UMA: - capture_pending_time: time between input event being received and when the next frame starts capturing. - capture_overhead_time: extra latency for the capturer caused by IPC and threading. - encode_pending_time: delay between capturer and encoder. - send_pending_time: time encoded packets wait in the send queue. VideoFramePump is responsible for measuring all latency values sent to the client except for capture_time_ms which is still measured by the capturer. Review URL: https://codereview.chromium.org/1365663003 Cr-Commit-Position: refs/heads/master@{#351504}
* Chrome Remote Desktop will collect and report the host OS name and version.nicholss2015-09-296-31/+114
| | | | | | | | | | | | | The Chrome Remote Desktop daemon application will collect the host OS and versionHost OS name and version will then be collected by the Chrome Remote backend for analysis on error reports to help improve the stability of the product. Version was missing on linux systems. R=kelvinp@chromium.org, sergeyu@chromium.org BUG=534902 Review URL: https://codereview.chromium.org/1365983002 Cr-Commit-Position: refs/heads/master@{#351366}
* Extend base::win::ObjectWatcher to watch an event multiple times.jam2015-09-291-1/+1
| | | | | | | | | | This is split off from https://codereview.chromium.org/1350023003/. During performance testing, it was found that it was 5x faster to watch an auto-reset event once instead of a manual-reset event every time it fired. BUG=478251 Review URL: https://codereview.chromium.org/1366093006 Cr-Commit-Position: refs/heads/master@{#351240}
* Make SharedMemoryHandle a class on windows.erikchen2015-09-252-3/+8
| | | | | | | | | | | | | | | | This CL is intended to be a refactor and should not introduce any behavior changes. Previously, SharedMemoryhandle was typedefed to HANDLE. Making it a class allows us to add metainformation about the process in which the HANDLE is valid. This will be used in the future by Chrome's IPC system to automatically duplicate HANDLEs into their destination process. BUG=493414, 535028 Review URL: https://codereview.chromium.org/1320783002 Cr-Commit-Position: refs/heads/master@{#350932}
* Cleanup: IWYU for base/gtest_prod_util.h.thestig2015-09-252-4/+4
| | | | | | | | | | CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=pneubeck@chromium.org Review URL: https://codereview.chromium.org/1366123002 Cr-Commit-Position: refs/heads/master@{#350770}
* Wake up display when input event is injecteddcaiafa2015-09-251-0/+44
| | | | | | | | | | | | | | | | | | When a remoting session starts, the host creates a power assertion that prevents the display from automatically going to sleep. It doesn't prevent, however, the user from forcing the display go to sleep (by using a hot corner, for example). If this happens, the host's display sleeps until the user terminates the session and reconnects. This fix creates (and releases) a power assertion on every input event injected (with a 1 second throttle). The power assertion, at creation time, wakes the display up. BUG=472818 Review URL: https://codereview.chromium.org/1366013002 Cr-Commit-Position: refs/heads/master@{#350730}
* base: Template methods on Timer classes instead of the classes themselves.danakj2015-09-2420-29/+29
| | | | | | | | | | | | | | | | | | | The base class for OneShotTimer and DelayedTimer is templated but only the Start method needs to be (which has a TODO to make it go away entirely too). The DelayedTimer class is also templated but only its constructor needs to be, and the type can be inferred at the callsite, so less typing all around. R=thakis@chromium.org TBR=sky,brettw BUG=148832 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1355063004 Cr-Commit-Position: refs/heads/master@{#350496}
* ipc: Remove unnecessary attachment broker plumbing.erikchen2015-09-249-43/+23
| | | | | | | | | | | | The original design was to pass around an instance of an attachment broker. The new design uses a single global, and no longer needs any plumbing. This CL removes the last vestiges of the plumbing. BUG=493414 Review URL: https://codereview.chromium.org/1354973006 Cr-Commit-Position: refs/heads/master@{#350471}
* Improve diagnostic messages for CreateDirectory and running start-host as root.nicholss2015-09-222-5/+20
| | | | | | | | | | | | | | | | | | A user ran into a situation where their ~/.config directory had incorrect permissions and chromoting was unable to startup but there was no error message to hint towards the problem. There will now be an error message if CreateDirectory fails, found in the debug log. To prevent the issue it is now not possible to run start-host as root. The script will just throw an error, this should prevent the Chromoting config dir from starting out with the wrong permissions. R=sergeyu@chromium.org BUG=534918 Review URL: https://codereview.chromium.org/1359003002 Cr-Commit-Position: refs/heads/master@{#350240}
* Fixing an error when service chrome-remote-desktop commands in user mode.nicholss2015-09-221-5/+1
| | | | | | | | | | | | | | When running service chrome-remote-desktop, the script will now always sudo as the user running the service command. This loads the environment variables that service lacks. To replicate the orginal error, run `service chrome-remoting-desktop stop` as a user and note the error python throws when attempting to read in HOME from the env. R=sergeyu@chromium.org Review URL: https://codereview.chromium.org/1358763005 Cr-Commit-Position: refs/heads/master@{#350214}
* Cleanup: Pass std::string as const reference from remoting/ki.stfu2015-09-211-2/+2
| | | | | | | | | | | | Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=joedow@chromium.org,kelvinp@chromium.org Review URL: https://codereview.chromium.org/1357843002 Cr-Commit-Position: refs/heads/master@{#349952}
* Add source column to chrome://policy showing the origins of policies.fhorschig2015-09-211-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are the possible sources for a policy: Cloud - Policy values received from the cloud. Platform - Local configured policies. Enterprise Default - Defaults for policies in enterprise environments on Chrome OS. Can be overridden. Enterprise Override - Policies enforced in enterprise environments on Chrome OS. Can NOT be overridden. The source of a policy is determined when it's first set. For cloud policies, this would be the decoding of the protocol buffers. Platform policies are usually set by loading platform-specific local configurations like entries in the Windows registry. Enterprise defaults are automatically set if the device is active in an enterprise environment. Enterprise override policies are set within the code to enforce specific behaviors (like ash tray visibility). They cannot be overridden. BUG=506123 TBR=jam@chromium.org Committed: https://crrev.com/92e7960f06c2ac2ec0113bb88df3d322f0eb97fe Cr-Commit-Position: refs/heads/master@{#349654} Committed: https://crrev.com/2c4ce2a1988fdde3456e49112eba6c7855ca4528 Cr-Commit-Position: refs/heads/master@{#349749} Review URL: https://codereview.chromium.org/1304843004 Cr-Commit-Position: refs/heads/master@{#349927}
* Revert of Add source column to chrome://policy showing the origins of ↵dgrogan2015-09-181-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | policies. (patchset #18 id:620001 of https://codereview.chromium.org/1304843004/ ) Reason for revert: Fix google chrome compile. http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/4220/steps/compile/logs/stdio ../../chrome/browser/ui/startup/startup_browser_creator_browsertest.cc:1235:23:error: too few arguments to function call, expected 6, have 5 NULL); ^ ../../components/policy/core/common/policy_map.h:66:3: note: 'Set' declared here void Set(const std::string& policy, ^ Original issue's description: > Add source column to chrome://policy showing the origins of policies. > > These are the possible sources for a policy: > Cloud - Policy values received from the cloud. > Platform - Local configured policies. > Enterprise Default - Defaults for policies in enterprise environments > on Chrome OS. Can be overridden. > Enterprise Override - Policies enforced in enterprise environments on > Chrome OS. Can NOT be overridden. > > The source of a policy is determined when it's first set. For cloud > policies, this would be the decoding of the protocol buffers. > Platform policies are usually set by loading platform-specific local > configurations like entries in the Windows registry. > Enterprise defaults are automatically set if the device is active in > an enterprise environment. > Enterprise override policies are set within the code to enforce > specific behaviors (like ash tray visibility). They cannot be > overridden. > > BUG=506123 > TBR=jam@chromium.org > > Committed: https://crrev.com/92e7960f06c2ac2ec0113bb88df3d322f0eb97fe > Cr-Commit-Position: refs/heads/master@{#349654} > > Committed: https://crrev.com/2c4ce2a1988fdde3456e49112eba6c7855ca4528 > Cr-Commit-Position: refs/heads/master@{#349749} TBR=tnagel@chromium.org,bartfab@chromium.org,dbeam@chromium.org,jam@chromium.org,fhorschig@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506123 Review URL: https://codereview.chromium.org/1350913006 Cr-Commit-Position: refs/heads/master@{#349774}
* Add source column to chrome://policy showing the origins of policies.fhorschig2015-09-181-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are the possible sources for a policy: Cloud - Policy values received from the cloud. Platform - Local configured policies. Enterprise Default - Defaults for policies in enterprise environments on Chrome OS. Can be overridden. Enterprise Override - Policies enforced in enterprise environments on Chrome OS. Can NOT be overridden. The source of a policy is determined when it's first set. For cloud policies, this would be the decoding of the protocol buffers. Platform policies are usually set by loading platform-specific local configurations like entries in the Windows registry. Enterprise defaults are automatically set if the device is active in an enterprise environment. Enterprise override policies are set within the code to enforce specific behaviors (like ash tray visibility). They cannot be overridden. BUG=506123 TBR=jam@chromium.org Committed: https://crrev.com/92e7960f06c2ac2ec0113bb88df3d322f0eb97fe Cr-Commit-Position: refs/heads/master@{#349654} Review URL: https://codereview.chromium.org/1304843004 Cr-Commit-Position: refs/heads/master@{#349749}
* Allow local admins access to the pipe created by the unprivileged native ↵weitaosu2015-09-181-3/+6
| | | | | | | | | | messaging host process. If not, the privileged NM host process won't be able to connect to the named pipe created by the unprivileged NM host process. BUG=477471 Review URL: https://codereview.chromium.org/1351453005 Cr-Commit-Position: refs/heads/master@{#349703}
* Revert of Add source column to chrome://policy showing the origins of ↵jochen2015-09-181-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | policies. (patchset #15 id:540001 of https://codereview.chromium.org/1304843004/ ) Reason for revert: breaks compilation on iOS Device (ninja) Original issue's description: > Add source column to chrome://policy showing the origins of policies. > > These are the possible sources for a policy: > Cloud - Policy values received from the cloud. > Platform - Local configured policies. > Enterprise Default - Defaults for policies in enterprise environments > on Chrome OS. Can be overridden. > Enterprise Override - Policies enforced in enterprise environments on > Chrome OS. Can NOT be overridden. > > The source of a policy is determined when it's first set. For cloud > policies, this would be the decoding of the protocol buffers. > Platform policies are usually set by loading platform-specific local > configurations like entries in the Windows registry. > Enterprise defaults are automatically set if the device is active in > an enterprise environment. > Enterprise override policies are set within the code to enforce > specific behaviors (like ash tray visibility). They cannot be > overridden. > > BUG=506123 > TBR=jam@chromium.org > > Committed: https://crrev.com/92e7960f06c2ac2ec0113bb88df3d322f0eb97fe > Cr-Commit-Position: refs/heads/master@{#349654} TBR=tnagel@chromium.org,bartfab@chromium.org,dbeam@chromium.org,fhorschig@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506123 Review URL: https://codereview.chromium.org/1348903007 Cr-Commit-Position: refs/heads/master@{#349655}
* Add source column to chrome://policy showing the origins of policies.fhorschig2015-09-181-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | These are the possible sources for a policy: Cloud - Policy values received from the cloud. Platform - Local configured policies. Enterprise Default - Defaults for policies in enterprise environments on Chrome OS. Can be overridden. Enterprise Override - Policies enforced in enterprise environments on Chrome OS. Can NOT be overridden. The source of a policy is determined when it's first set. For cloud policies, this would be the decoding of the protocol buffers. Platform policies are usually set by loading platform-specific local configurations like entries in the Windows registry. Enterprise defaults are automatically set if the device is active in an enterprise environment. Enterprise override policies are set within the code to enforce specific behaviors (like ash tray visibility). They cannot be overridden. BUG=506123 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1304843004 Cr-Commit-Position: refs/heads/master@{#349654}
* Rename/Move ChromotingStats->protocol::PerformanceTrackersergeyu2015-09-171-2/+1
| | | | | | | | | | The class will be used directly from protocol dispatchers, so it needs to be accessible on the protocol layer. Also renamed it so the name reflects what the class is responsible for. Review URL: https://codereview.chromium.org/1351723004 Cr-Commit-Position: refs/heads/master@{#349295}
* Fix compilation of Me2Me host with GNsergeyu2015-09-171-0/+1
| | | | | | | | | | | | Me2MeNativeMessagingHost depends directly on LogMessageHandler in remoting/host/native_messaging, but wasn't depending on it directly, so remoting_all was failing to compile. TBR=jamiewalch@chromium.org Review URL: https://codereview.chromium.org/1349013002 Cr-Commit-Position: refs/heads/master@{#349294}
* Shift URLRequestContextStorage over to taking scoped_ptrs.rdsmith2015-09-161-3/+4
| | | | | | | | | | Also includes converting several sources of scoped_ptrs for URLRequestContextStorage, including the ProxyService static generators and the ShellURLRequestContextGetter protected methods to be used by subclasses. BUG=521705 Review URL: https://codereview.chromium.org/1290243007 Cr-Commit-Position: refs/heads/master@{#349194}
* Add three missing includes.grunell2015-09-161-0/+1
| | | | | | | | | | | | | Also fixed ambiguous call for a dcheck. Found these problem when working on removing WebRTC's dependency on Chromium and this should make the WebRTC Chromium FYI bots green. BUG=468375,532001 TBR=tommi@chromium.org,sergeyu@chromium.org Review URL: https://codereview.chromium.org/1349743002 Cr-Commit-Position: refs/heads/master@{#349124}
* Add ScopedAllowIO in GnubbyAuthHandlerPosix::CreateAuthorizationSocket().sergeyu2015-09-161-2/+10
| | | | | | | | | | | | | | GnubbyAuthHandlerPosix listens to a unix socket on the IO the remoting host. It needs to be able to unlink() previously created socket. Deletion of a unix socket is a blocking operation because it may require disk IO, but moving GnubbyAuthHandlerPosix on a different thread would be overkill. BUG=509807 Review URL: https://codereview.chromium.org/1324763007 Cr-Commit-Position: refs/heads/master@{#349038}
* Fix running gyp with configuration_policy=0the_jk2015-09-151-1/+4
| | | | | | | | | | | | Running gyp in chromium with configuration_policy set to 0 fails as multiple targets that are behind condition of configuration_policy==1 are referenced without corresponding conditionals BUG=530579 Review URL: https://codereview.chromium.org/1334253002 Cr-Commit-Position: refs/heads/master@{#348903}
* Move Singleton and related structs to namespace baseolli.raula2015-09-102-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Public APIs from base should live inside base:: so moved Singleton class and structs to base{} and fixed consumers. also fixed: ** Presubmit ERRORS ** Found Singleton<T> in the following header files. Please move them to an appropriate source file so that the template gets instantiated in a single compilation unit. chrome/browser/plugins/plugin_finder.h \ chromecast/media/base/media_message_loop.h \ content/browser/media/android/media_drm_credential_manager.h Presubmit warnings: src/chrome/browser/extensions/warning_badge_service_factory.h:5: #ifndef header guard has wrong style, please use: CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_ [build/header_guard] [5] src/chrome/browser/extensions/warning_badge_service_factory.h:39: #endif line should be "#endif // CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_" [build/header_guard] [5] TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1308823002 Cr-Commit-Position: refs/heads/master@{#348136}
* Gate gtk on chromeos.petermayo2015-09-042-4/+4
| | | | | | | | | | | | | We shouldn't use GTK in even the chromeos testing environment. It breaks to even reference it in the chroot building env, since the packages are not available. BUG=527996 TEST=set gn args, gn gen Review URL: https://codereview.chromium.org/1319843004 Cr-Commit-Position: refs/heads/master@{#347519}
generated by cgit v1.1 at 2025-02-19 12:26:54 +0000