| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
- Lossless encode/color requests may be ignored by codecs.
- VideoEncoderVpx supports lossless color when using VP9.
- The --enable-i444 flag now controls the default color mode for VP9.
BUG=260879,134202
Review URL: https://codereview.chromium.org/304653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyp failure on Win:
Exception: Missing input files:
C:\b\build\slave\Win\build\src\remoting\host\extension.h
C:\b\build\slave\Win\build\src\remoting\host\extension_session.h
> Host extensions
>
> This CL introduces HostExtension, an interface for classes that
> extend the host with non-core functionality.
>
> Extensions are added to the ChromotingHost. They are used to compile
> the list of capabilities reported to the client, which can be used by
> the client to determine the availability of the extension.
>
> When a client connects, a HostExtension has the opportunity to create
> an HostExtensionSession to hold client/extension state, and to handle
> extension messages from that client.
>
> BUG=
>
> Review URL: https://codereview.chromium.org/301453003
TBR=dcaiafa@chromium.org
Review URL: https://codereview.chromium.org/308743006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces HostExtension, an interface for classes that
extend the host with non-core functionality.
Extensions are added to the ChromotingHost. They are used to compile
the list of capabilities reported to the client, which can be used by
the client to determine the availability of the extension.
When a client connects, a HostExtension has the opportunity to create
an HostExtensionSession to hold client/extension state, and to handle
extension messages from that client.
BUG=
Review URL: https://codereview.chromium.org/301453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VideoScheduler was broken by crrev.com/272790. Problem was that after an
empty frame pending_frames_ was never decremented. Now all frames are
passed to EncodeFrame() and then it posts FrameCaptureCompleted task
on the capture thread. All frames must be passed to the encoder thread
to ensure that we don't try capturing frame n+2 while frame n is still
being encoded, which is necessary because capturers don't allow to have
more than 2 in-flight frames.
BUG=378125
Review URL: https://codereview.chromium.org/306633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fixes GetHomeDir() for multi-profiles case on Chrome OS.
* Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
* Added content switch --homedir to pass that information to ppapi plugins since they
run in a separate process and previous base::DIR_HOME override does not apply there.
This fix doesn't require checking for --multi-profiles switch
since user_id hash is known even without it.
Note:
download_prefs.cc still uses GetHomeDir() in its DownloadPathIsDangerous() check.
// Consider downloads 'dangerous' if they go to the home directory on Linux and
// to the desktop on any platform.
In this context correct behavior is to use "real" base::GetHomeDir() and not "virtual one" base::DIR_HOME.
Since latter is remapped to some test dir in tests, in some subfolders in Chrome OS etc.
BUG=331530
TBR=vitalybuka@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270872
Review URL: https://codereview.chromium.org/200473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the host was not sending empty keep alive messages when
video stream is paused or when it's blocked on the encoder, this
triggers reconnect too often.
Refactored keep-alive logic in VideoScheduler so now it always
sends keep-alive messages when there is no other activity on the
stream.
BUG=376528,375568
Review URL: https://codereview.chromium.org/292373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/290173011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also adds unittests for ServerLogEntry client code, with common code
pulled out to a separate file.
This doesn't affect LogToServer classes - they will be refactored in a
separate CL. Also fix some IWYU issues uncovered by the refactor.
TEST=unittests
Review URL: https://codereview.chromium.org/282063005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it possible to add candidate configurations at either the
back (least-preferred) or front (most-preferred) of each channel's
candidate list.
This CL also disables VP9, by default, in candidate session
configurations, replaces DisableVideoCodec with
EnableVideoCodec, and makes the Enable/Disable<foo>Codec
helpers members of CandidateSessionConfig..
Review URL: https://codereview.chromium.org/292093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Connect() has ended up acquiring all of the ConnectionToHost's
configuration settings as parameters, making calling code harder to read
especially as more new parameters are added.
Review URL: https://codereview.chromium.org/279273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is useful for testing. VP9 is already enabled at the client.
BUG=260879
Review URL: https://codereview.chromium.org/286213006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this the host will crash as soon as the BasicNetworkManager
is started, i.e. when a client connection is first received, due to
talk_base::Thread::current() being NULL.
BUG=375564
Review URL: https://codereview.chromium.org/289863008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Most code uses PLOG with the same effect.
TBR=bradchen
NOTRY=true
Review URL: https://codereview.chromium.org/281223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Some fixes to GetUserInfo flow to avoid superfluous GetUserInfo calls.
BUG=
Review URL: https://codereview.chromium.org/294813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move all callers of GetHomeDir() to PathService::Get(base::DIR_HOME).
>
> * Fixes GetHomeDir() for multi-profiles case on Chrome OS.
> * Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
> * Added content switch --homedir to pass that information to ppapi plugins since they run in a separate process and previous base::DIR_HOME override does not apply there.
>
> This fix doesn't require checking for --multi-profiles switch
> since user_id hash is known even without it.
>
> BUG=331530
> TBR=vitalybuka@chromium.org
>
> Review URL: https://codereview.chromium.org/200473002
This test has caused two tests to start failing on the chromeos valgrind bots:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%286%29/builds/25884
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%285%29/builds/26990
TBR=nkostylev@chromium.org
Review URL: https://codereview.chromium.org/284333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fixes GetHomeDir() for multi-profiles case on Chrome OS.
* Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
* Added content switch --homedir to pass that information to ppapi plugins since they run in a separate process and previous base::DIR_HOME override does not apply there.
This fix doesn't require checking for --multi-profiles switch
since user_id hash is known even without it.
BUG=331530
TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/200473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This will be selectable by clients that want to avoid I420 artefacts.
BUG=260879,134202
Review URL: https://codereview.chromium.org/261753013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order of precedence, set size according to:
* Command line parameters if present
* Environment variable if present
* 1600x1200,3840x1600 if RANDR is present, otherwise just 1600x1200.
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/278753002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=371432
R=rmsousa@chromium.org
Review URL: https://codereview.chromium.org/274933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code was failing in Ubuntu Trusty because psutil is at version
1.2.1, but the previous code was incorrectly detecting it as a "new"
2.0+ API. Fixed the check to be more explicit.
Also, this bypasses the issue of psutil.Error not being defined in
older versions by explicitly trapping the individual exception types
instead of psutil.Error. Note that psutil.error was always a private
API and should never have been used in the first place.
TEST=Works in Ubuntu Precise and Trusty
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/272543006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=322664
Review URL: https://codereview.chromium.org/254863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
url_util -> url
url_parse -> url
url_canon -> url
BUG=364747
TBR=atwilson,battre
Review URL: https://codereview.chromium.org/262593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland due to accidental incorrect revert.
> Revert 267234 "New policies: enable/disable relay; port range"
>
> > New policies: enable/disable relay; port range
> >
> > Add new Chromoting policies:
> >
> > "RemoteAccessHostAllowRelayedConnection"
> > bool, default true
> > It can be set to false to disable the use of relay servers if NAT
> > traversal is enabled.
> >
> > "RemoteAccessHostUdpPortRange"
> > string, default ""
> > Can be used to specify a range in the form "<min-port>-<max-port>" to
> > restrict the range of UDP ports available to the host for connections.
> > E.g. "12400-12409"
> >
> > BUG=355168
> >
> > Review URL: https://codereview.chromium.org/209323002
>
> TBR=dcaiafa@chromium.org
> BUG=368724
>
> Review URL: https://codereview.chromium.org/268483003
TBR=noamsml@google.com
Review URL: https://codereview.chromium.org/261633005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> New policies: enable/disable relay; port range
>
> Add new Chromoting policies:
>
> "RemoteAccessHostAllowRelayedConnection"
> bool, default true
> It can be set to false to disable the use of relay servers if NAT
> traversal is enabled.
>
> "RemoteAccessHostUdpPortRange"
> string, default ""
> Can be used to specify a range in the form "<min-port>-<max-port>" to
> restrict the range of UDP ports available to the host for connections.
> E.g. "12400-12409"
>
> BUG=355168
>
> Review URL: https://codereview.chromium.org/209323002
TBR=dcaiafa@chromium.org
BUG=368724
Review URL: https://codereview.chromium.org/268483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new Chromoting policies:
"RemoteAccessHostAllowRelayedConnection"
bool, default true
It can be set to false to disable the use of relay servers if NAT
traversal is enabled.
"RemoteAccessHostUdpPortRange"
string, default ""
Can be used to specify a range in the form "<min-port>-<max-port>" to
restrict the range of UDP ports available to the host for connections.
E.g. "12400-12409"
BUG=355168
Review URL: https://codereview.chromium.org/209323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds /etc/chrome-remote-desktop-session to the list of files that
the script looks for when deciding what session to start.
BUG=366759
NOTRY=true
Review URL: https://codereview.chromium.org/254393003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=359334
Review URL: https://codereview.chromium.org/243943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=jamiewalch@chromium.org
NOTRY=true
BUG=364315
Review URL: https://codereview.chromium.org/240693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gtk_signal_registrar.h is unused. gtk_signal.h is unused but for remoting/host.
Change those to use ui/base/glib_signal.h, fixing some incorrect pointer types
in the process. ("click" is emitted at GtkButton and "response" is emitted at
GtkDialog.)
BUG=297026
Review URL: https://codereview.chromium.org/239603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a large number of other files that were depending on this
include.
BUG=none
TBR=gene@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/235333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This sets us up for:
1. installation of the host component using the Omaha native messaging API when it's ready
2. removal of the NPAPI plugin.
BUG=134215
Review URL: https://codereview.chromium.org/232223003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The newer python psutil-2.x release has reworked the API in backwards
incompatible ways. Add some glue to handle both series.
BUG=None
TEST=ran script w/psutil-2.1.x and it worked again
Review URL: https://codereview.chromium.org/235883005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some cases the host may get invalid mouse-move events, so it
thinks that local user is moving the mouse, and as result it
starts dropping all input events. Now LocalInputMonitorMac ignores
mouse-move event when mouse position isn't changing.
BUG=360912
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/233083005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Both base and protocol directories had util.cc files, which confuses
the linker when compiling them into a single static .a lib.
BUG=276739
Review URL: https://codereview.chromium.org/231943005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To prevent a malicious client from guessing the PIN by spamming the host with bogus logins, the chromoting host can throttle incoming requests after too many unsuccessful login attempts. In the current implementation, every time when there is an incoming request, we start incrementing the bad login counter, regardless of whether the host has actually starts authenticating.
Fix:
This change adds an extra flag on the authenticator to indicate whether authentication has started.
The JingleSession checks the flag and progagates the message back all the way up to the host through the callback Session::OnSessionAuthenticationBegin
BUG=350208
Review URL: https://codereview.chromium.org/205583011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileStream will drop support of synchronous methods.
Use base::File instead.
BUG=351823
TEST=remoting_unittests
Review URL: https://codereview.chromium.org/225553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/210093006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260879
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255208
Review URL: https://codereview.chromium.org/28183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=357593
NOTRY=true
Review URL: https://codereview.chromium.org/216693005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=270356,265945
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/214193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in this CL include:
1. Initialize breakpad in it2me native messaging host
2. Create bundles for it2me and me2me native messaging hosts and move them out of the me2me host bundle (and update the manifests accordingly).
3. Dump symbols of the it2me and me2me native messaging hosts
4. Sign the me2me and it2me native messaging hosts
4. Rename the me2me host bundle and the prefPane bundle to get rid of the internal chromium/chromoting names and to conform to Mac convention
5. Refactor GYP, build-installer-archive.py, and do_signing.sh, etc to use name constants from branding_chrome and branding_chromium instead of hard coded names. This ensures that all the name constants are defined in a central location and reduces duplicate name definitions.
Here are the names of the host bundles:
me2me host:
old name: org.chromium.chromoting.me2me_host
new name: ChromeRemoteDesktop.Host
Pref pane:
old name: org.chromium.chromoting.prefPane
new name: ChromeRemoteDesktop.prefPane
it2me nm host:
name: NativeMessagingHost
Full Path: /Library/Google/ChromeRemoteDesktop/NativeMessagingHost.app
me2me nm host:
name: RemoteAssistanceHost
Full path: /Library/Google/ChromeRemoteDesktop/RemoteAssistanceHost.app
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259287
Review URL: https://codereview.chromium.org/186763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new message will be used for non-keyboard input methods
and software keyboards.
BUG=270356
R=lambroslambrou@chromium.org, nasko@chromium.org
Review URL: https://codereview.chromium.org/197613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks Google Chrome build:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/49089/steps/compile/logs/stdio
> Add breakpad support for me2me and it2me native messaging host on Mac.
>
> Changes in this CL include:
> 1. Initialize breakpad in it2me native messaging host
> 2. Create bundles for it2me and me2me native messaging hosts and move them out of the me2me host bundle (and update the manifests accordingly).
> 3. Dump symbols of the it2me and me2me native messaging hosts
> 4. Sign the me2me and it2me native messaging hosts
> 4. Rename the me2me host bundle and the prefPane bundle to get rid of the internal chromium/chromoting names and to conform to Mac convention
> 5. Refactor GYP, build-installer-archive.py, and do_signing.sh, etc to use name constants from branding_chrome and branding_chromium instead of hard coded names. This ensures that all the name constants are defined in a central location and reduces duplicate name definitions.
>
> Here are the names of the host bundles:
>
> me2me host:
> old name: org.chromium.chromoting.me2me_host
> new name: ChromeRemoteDesktop.Host
>
> Pref pane:
> old name: org.chromium.chromoting.prefPane
> new name: ChromeRemoteDesktop.prefPane
>
> it2me nm host:
> name: NativeMessagingHost
> Full Path: /Library/Google/ChromeRemoteDesktop/NativeMessagingHost.app
>
> me2me nm host:
> name: RemoteAssistanceHost
> Full path: /Library/Google/ChromeRemoteDesktop/RemoteAssistanceHost.app
>
> BUG=
>
> Review URL: https://codereview.chromium.org/186763004
TBR=weitaosu@chromium.org
Review URL: https://codereview.chromium.org/209043004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in this CL include:
1. Initialize breakpad in it2me native messaging host
2. Create bundles for it2me and me2me native messaging hosts and move them out of the me2me host bundle (and update the manifests accordingly).
3. Dump symbols of the it2me and me2me native messaging hosts
4. Sign the me2me and it2me native messaging hosts
4. Rename the me2me host bundle and the prefPane bundle to get rid of the internal chromium/chromoting names and to conform to Mac convention
5. Refactor GYP, build-installer-archive.py, and do_signing.sh, etc to use name constants from branding_chrome and branding_chromium instead of hard coded names. This ensures that all the name constants are defined in a central location and reduces duplicate name definitions.
Here are the names of the host bundles:
me2me host:
old name: org.chromium.chromoting.me2me_host
new name: ChromeRemoteDesktop.Host
Pref pane:
old name: org.chromium.chromoting.prefPane
new name: ChromeRemoteDesktop.prefPane
it2me nm host:
name: NativeMessagingHost
Full Path: /Library/Google/ChromeRemoteDesktop/NativeMessagingHost.app
me2me nm host:
name: RemoteAssistanceHost
Full path: /Library/Google/ChromeRemoteDesktop/RemoteAssistanceHost.app
BUG=
Review URL: https://codereview.chromium.org/186763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
responses as necessary.
Requires gnubbyd 0.8.37 or later.
BUG=134250
Review URL: https://codereview.chromium.org/205493005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
remoting_host_executable
NOTRY=true
Review URL: https://codereview.chromium.org/203683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Given that hosts don't always resize the desktop particularly cleanly, we should avoid unnecessary resizes, even if they should theoretically be no-ops. Specifically, if the client has not requested resizing, we should not attempt to restore the size on disconnect.
BUG=226232
Review URL: https://codereview.chromium.org/148113008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix all forward-declares and header files referencing CommandLine.
This keeps a "using base::CommandLine" in the command line header file so that the rest of the source files can be changes in a follow-up.
TBR=sky
Review URL: https://codereview.chromium.org/196413016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes WideToASCII and changes all callers to use UTF16ToASCII instead.
Moves UTF16ToASCII from base/strings/string_util.h to base/strings/utf_string_conversions.h and into the base namespace.
Convert a few related string_util functions to take a StringPiece16 instead of a string16. Remove IsStringASCII(std::wstring) which was unused.
Updates callers' includes and namespace usage accordingly.
TBR=sky
Review URL: https://codereview.chromium.org/176843022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used for a given render process id. This special cookie store will then
be used for renderer messages pertaining to cookies, url fetches in net,
and websockets. If the special cookie store is NULL, a default cookie store
will be used.
Re-submit of https://codereview.chromium.org/188693003
See https://codereview.chromium.org/188693003 for reviewers/lgtm's.
Review URL: https://codereview.chromium.org/197043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256657 0039d316-1c4b-4281-b951-d872f2087c98
|