summaryrefslogtreecommitdiffstats
path: root/remoting/jingle_glue
Commit message (Collapse)AuthorAgeFilesLines
* Return correct value from XmppSignalStrategy::HandleStanza()sergeyu@chromium.org2011-08-035-7/+12
| | | | | | | | | BUG=91531 TEST=Connection always works. Review URL: http://codereview.chromium.org/7564024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95316 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanups and bugfixes for JingleInfoRequest.sergeyu@chromium.org2011-07-263-35/+15
| | | | | | | | | BUG=None TEST=JinlgeInfoRequest can fetch jingle info on both host and client Review URL: http://codereview.chromium.org/7495041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94149 0039d316-1c4b-4281-b951-d872f2087c98
* Added an OriginBoundCertStore field to the SSLClientSocketNSS class andrkn@chromium.org2011-07-211-2/+3
| | | | | | | | | | | | did the plumbing to pass this field through the layers. In addition, this CL groups several fields together into a single struct |SSLClientSocket::Context|. BUG=None TEST=None Review URL: http://codereview.chromium.org/7315009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93416 0039d316-1c4b-4281-b951-d872f2087c98
* Purge references to JingleClient.wez@chromium.org2011-07-201-2/+0
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7459002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93254 0039d316-1c4b-4281-b951-d872f2087c98
* some cleanup for base/stl_utildilmah@chromium.org2011-07-191-1/+1
| | | | | | | | | | | | | removed unused/irrelevant functions removed irrelevant comments Moved stl_util-inl.h => stl_util.h BUG=None TEST=None Review URL: http://codereview.chromium.org/7342047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanups in JingleSession and JingleSessionManager.sergeyu@chromium.org2011-07-072-3/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7312013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91751 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Valgrind errors in remoting_unittests.sergeyu@chromium.org2011-07-072-41/+48
| | | | | | | | | | | | | - FakeSession was used after it is destroyed. - JingleThreadMessageLoop::Quit() was calling Thread::Stop() before all tasks are finished. - JingleSessionManager::AcceptConnection() would destroy JingleSession when called by that JingleSession. BUG=None TEST=Valgrind is happy. Review URL: http://codereview.chromium.org/7227017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91652 0039d316-1c4b-4281-b951-d872f2087c98
* Make JingleThreadMessageLoop usable without JingleThread.sergeyu@chromium.org2011-07-012-39/+49
| | | | | | | | | BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/7302002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91388 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in remoting_unittests.sergeyu@chromium.org2011-06-302-17/+30
| | | | | | | | | BUG=None TEST=valgrind is happy. Review URL: http://codereview.chromium.org/7283033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91077 0039d316-1c4b-4281-b951-d872f2087c98
* Remove JingleClient.sergeyu@chromium.org2011-06-297-480/+16
| | | | | | | | | | | Everything that JingleClient was doing has been rolled into JingleSessionManager BUG=None TEST=Remoting still works. Review URL: http://codereview.chromium.org/7277050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91035 0039d316-1c4b-4281-b951-d872f2087c98
* Add FakeSignalStrategy.sergeyu@chromium.org2011-06-292-0/+144
| | | | | | | | | | | The new class will be used in tests instead of SessionManagerPair. BUG=None TEST=None Review URL: http://codereview.chromium.org/7276017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90889 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90867 - Add FakeSignalStrategy.sergeyu@chromium.org2011-06-282-144/+0
| | | | | | | | | | | | | | The new class will be used in tests instead of SessionManagerPair. BUG=None TEST=None Review URL: http://codereview.chromium.org/7276017 TBR=sergeyu@chromium.org Review URL: http://codereview.chromium.org/7276057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90872 0039d316-1c4b-4281-b951-d872f2087c98
* Add FakeSignalStrategy.sergeyu@chromium.org2011-06-282-0/+144
| | | | | | | | | | | The new class will be used in tests instead of SessionManagerPair. BUG=None TEST=None Review URL: http://codereview.chromium.org/7276017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90867 0039d316-1c4b-4281-b951-d872f2087c98
* Add IDs to outgoing Iq stanzas.sergeyu@chromium.org2011-06-289-15/+40
| | | | | | | | | BUG=None TEST=Messages sent from client to host have valid IDs. Review URL: http://codereview.chromium.org/7276021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90864 0039d316-1c4b-4281-b951-d872f2087c98
* Remove StartSession/EndSession from SignalStrategy interface.sergeyu@chromium.org2011-06-288-58/+29
| | | | | | | | | BUG=None TEST=remoting still works. Review URL: http://codereview.chromium.org/7277017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90836 0039d316-1c4b-4281-b951-d872f2087c98
* Warmth of a connection (cwnd) is estimated by the amount of data written to ↵gagansingh@google.com2011-06-272-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | the socket. Choosing the warmest connection would mean faster resource load times. idle time is the time a socket has remained idle (no http requests being served on it). Probability of server resetting a connection increases with idle time duration. Using a cost function that takes into account bytes transferred and idle time to pick best connection to schedule http requests on. CODEREVIEW done in http://codereview.chromium.org/6990036/ Contributed by gagansingh@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90373 Reverted: http://codereview.chromium.org/7255002 :( Have fixed 2 things since: 1. Removed LOG(ERROR) from http_basic_stream.cc that was causing layout tests to fail. 2. Initialized class variables in http_basic_stream.cc that was causing uninitialized memory bugs in valgrind: http://code.google.com/p/chromium/issues/detail?id=87423 Review URL: http://codereview.chromium.org/7251004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90601 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup client shutdown sequence.sergeyu@chromium.org2011-06-243-38/+36
| | | | | | | | | BUG=None TEST=Client doesn't crash when reloading the tab. Review URL: http://codereview.chromium.org/7241016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90443 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup usage of JingleThread in the protocol code.sergeyu@chromium.org2011-06-243-15/+11
| | | | | | | | | | | | JingleThread was used in some places where it is not necessary. Replace it with MessageLoop. BUG=None TEST=None Review URL: http://codereview.chromium.org/7237013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90419 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90373 - Warmth of a connection (cwnd) is estimated by the amount of ↵dimich@chromium.org2011-06-242-12/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | data written to the socket. Choosing the warmest connection would mean faster resource load times. Caused layout tests http/tests/loading/redirect-methods.html and http/tests/security/xss-DENIED-iframe-src-alias.html fail on deps WebKit bots, and caused http://code.google.com/p/chromium/issues/detail?id=87423 Deps bots failures: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=http%2Ftests%2Floading%2Fredirect-methods.html%2Chttp%2Ftests%2Fsecurity%2Fxss-DENIED-iframe-src-alias.html idle time is the time a socket has remained idle (no http requests being served on it). Probability of server resetting a connection increases with idle time duration. Using a cost function that takes into account bytes transferred and idle time to pick best connection to schedule http requests on. CODEREVIEW done in http://codereview.chromium.org/6990036/ Contributed by gagansingh@google.com Review URL: http://codereview.chromium.org/7189055 TBR=gagansingh@google.com Review URL: http://codereview.chromium.org/7255002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90389 0039d316-1c4b-4281-b951-d872f2087c98
* Warmth of a connection (cwnd) is estimated by the amount of data written to ↵gagansingh@google.com2011-06-242-0/+12
| | | | | | | | | | | | | | | | | | | the socket. Choosing the warmest connection would mean faster resource load times. idle time is the time a socket has remained idle (no http requests being served on it). Probability of server resetting a connection increases with idle time duration. Using a cost function that takes into account bytes transferred and idle time to pick best connection to schedule http requests on. CODEREVIEW done in http://codereview.chromium.org/6990036/ Contributed by gagansingh@google.com Review URL: http://codereview.chromium.org/7189055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90373 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in XmppSignalStrategy.sergeyu@chromium.org2011-06-232-2/+4
| | | | | | | | | BUG=None TEST=Remoting host doesn't crash Review URL: http://codereview.chromium.org/7236020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90295 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring around SignalStrategy interface.sergeyu@chromium.org2011-06-2310-112/+159
| | | | | | | | | | | | - Added AddListener/RemoveListener in the SignalStrategy interface. - Remove dependancy on JavascriptIqRequest from JingleSignalingConnector. BUG=None TEST=Chromoting client still works Review URL: http://codereview.chromium.org/7239005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90219 0039d316-1c4b-4281-b951-d872f2087c98
* Split iq_request.[h|cc] into multiple files.sergeyu@chromium.org2011-06-2215-510/+652
| | | | | | | | | BUG=None TEST=compiles Review URL: http://codereview.chromium.org/7211033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90073 0039d316-1c4b-4281-b951-d872f2087c98
* Move SignalStrategy and its implementations to separate files.sergeyu@chromium.org2011-06-218-242/+326
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7219014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89929 0039d316-1c4b-4281-b951-d872f2087c98
* Remove gmail cert from SSLSocketAdapter.sergeyu@chromium.org2011-06-201-38/+0
| | | | | | | | | BUG=None TEST=connection still works. Review URL: http://codereview.chromium.org/7201018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89699 0039d316-1c4b-4281-b951-d872f2087c98
* roll clang 131935:132017thakis@chromium.org2011-06-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | clang recently added a warning that warns when invoking 'delete' on a polymorphic non-final class without a virtual destructor. This finds real bugs – see the bug referenced below for a few examples. However, one common pattern where it fires is this case: class SomeInterface { public: virtual void interfaceMethod() {} // or = 0; protected: ~SomeInterface() {} } class WorkerClass : public SomeInterface { public: // many non-virtual functions, but also: virtual void interfaceMethod() override { /* do actual work */ } }; void f() { scoped_ptr<WorkerClass> c(new WorkerClass); // simplified example } (See the 2nd half of http://www.gotw.ca/publications/mill18.htm for an explanation of this pattern.) It is arguably correct to fire the warning here, since someone might make a subclass of WorkerClass and replace |new WorkerClass| with |new WorkerClassSubclass|. This would be broken since WorkerClass doesn't have a virtual destructor. The solution that the clang folks recommend is to mark WorkerClass as |final| (a c++0x keyword that clang supports as an extension in normal c++ mode – like override). But chrome's base/OWNERS deemed that as too complicated and we decided to make virtual the destructors of leaf classes that implement these interfaces and that are deleted dynamically. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs). (For the gtk files, this is necessary because the CHROMEGTK_CALLBACK_ macros add virtual functions.) BUG=84424 TEST=none Review URL: http://codereview.chromium.org/7087028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88270 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue with Connect signal on TCP P2P sockets. Enable TCP sockets for ↵sergeyu@chromium.org2011-05-271-4/+0
| | | | | | | | | | | remoting. BUG=80245 TEST=Remoting connection still works and doesn't crash. Review URL: http://codereview.chromium.org/7068030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87101 0039d316-1c4b-4281-b951-d872f2087c98
* Wire in OAuth2 support into non-sandboxed connections in libjingle.ajwong@chromium.org2011-05-251-1/+6
| | | | | | | | | BUG=none TEST=can connect w/o ClientLogin token. Review URL: http://codereview.chromium.org/7008003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86685 0039d316-1c4b-4281-b951-d872f2087c98
* remoting: Fix response validation error found by PVS Studio.thakis@chromium.org2011-05-251-1/+1
| | | | | | | | | | BUG=83899 TEST=none Review URL: http://codereview.chromium.org/7031055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86653 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual destructors should have virtual keyword.hans@chromium.org2011-05-252-3/+3
| | | | | | | | | | | | | | | | | Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Review URL: http://codereview.chromium.org/7064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
* Miscelaneous cleanups to AddressList to make it harder to mis-use.eroman@chromium.org2011-05-121-2/+2
| | | | | | | | | | | | | | - Removed all destructive non-const member functions -- these were dangerous since if you called them without first making a copy of the AddressList, it could mutate earlier copies. - Made AddressList::Data::head const, so new code added to AddressList cannot inadvertently introduce such dangerous mutations (won't compile). - Moved the non-trivial constructors and assign methods into factory methods (for added readability) - Removed the bool parameter from Copy (for added readability). Review URL: http://codereview.chromium.org/6880302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85090 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Include stringprintf.h where appropriate, part 3.jhawkins@chromium.org2011-05-121-2/+2
| | | | | | | | | | | BUG=82098 TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/7016011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85088 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TCP temporarily to workaround crbug.com/80245.sergeyu@chromium.org2011-05-111-0/+4
| | | | | | | | | BUG=80245 TEST=None Review URL: http://codereview.chromium.org/7005015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85045 0039d316-1c4b-4281-b951-d872f2087c98
* Roll new libjingle. Use the new incoming_only flag in chromoting host.sergeyu@chromium.org2011-05-103-22/+3
| | | | | | | | | BUG=81597 TEST=Unittests. Review URL: http://codereview.chromium.org/6949010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84749 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented RegisterSupportHostRequest.sergeyu@chromium.org2011-05-103-4/+71
| | | | | | | | | BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/6893143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84731 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84722 - Implemented RegisterSupportHostRequest.sergeyu@chromium.org2011-05-102-53/+4
| | | | | | | | | | | | BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/6893143 TBR=sergeyu@chromium.org Review URL: http://codereview.chromium.org/6997005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84729 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Use callback_old.h where appropriate, part 1.jhawkins@chromium.org2011-05-101-1/+1
| | | | | | | | | | | BUG=none TEST=none R=thakis@chromium.org Review URL: http://codereview.chromium.org/6985009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84725 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented RegisterSupportHostRequest.sergeyu@chromium.org2011-05-102-4/+53
| | | | | | | | | BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/6893143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84722 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ClientSocket to StreamSocket.sergeyu@chromium.org2011-05-051-4/+4
| | | | | | | | | BUG=80895 TEST=Compiles Review URL: http://codereview.chromium.org/6930014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84167 0039d316-1c4b-4281-b951-d872f2087c98
* Add HostObserverInterface and decouple HeartbeatSender and ChromotingHost.sergeyu@chromium.org2011-05-032-3/+0
| | | | | | | | | BUG=None TEST=Everything still works. Review URL: http://codereview.chromium.org/6911024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83951 0039d316-1c4b-4281-b951-d872f2087c98
* Added GetLocalAddress() in net::ClientSocket.sergeyu@chromium.org2011-04-192-0/+11
| | | | | | | | | BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/6840033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82190 0039d316-1c4b-4281-b951-d872f2087c98
* Correction for r80070: call DoStartSession(), enable TCP.sergeyu@chromium.org2011-04-011-3/+5
| | | | | | | | | TEST=remoting connection works BUG=None Review URL: http://codereview.chromium.org/6706024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80197 0039d316-1c4b-4281-b951-d872f2087c98
* Chromoting: Disable NAT traversingsergeyu@chromium.org2011-03-312-7/+21
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6785002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80070 0039d316-1c4b-4281-b951-d872f2087c98
* Moved socket adapters from remoting/jingle_glue to jingle/glue.sergeyu@chromium.org2011-03-3111-951/+4
| | | | | | | | | BUG=None TEST=compiles, unittests Review URL: http://codereview.chromium.org/6776003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79929 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-2810-20/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* [Jingle] Refactored some notifier-related structs/classesakalin@chromium.org2011-03-221-1/+1
| | | | | | | | | | | | Moved ServerInformation into its own header and added ServerList typedef. Added notifier_options_util.{h,cc}. BUG=None Review URL: http://codereview.chromium.org/6708076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79026 0039d316-1c4b-4281-b951-d872f2087c98
* fix commentsdilmah@chromium.org2011-03-221-1/+1
| | | | | | | | | | BUG=None TEST=None TBR=rvargas@chromium.org Review URL: http://codereview.chromium.org/6715024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78977 0039d316-1c4b-4281-b951-d872f2087c98
* Hardcode gmail cert for chromoting.sergeyu@chromium.org2011-03-191-0/+40
| | | | | | | | | | | NSS doesn't load root certs in the renderer process, so cert verification fails for XMPP connection. Hardcode gmail.com certificate, to workaround this issue. TEST=remoting client can connect. BUG=None Review URL: http://codereview.chromium.org/6688043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78791 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for other authentication mechanisms in jingle. This will allow ↵sanjeevr@chromium.org2011-03-091-2/+5
| | | | | | | | | | | us to use OAuth2 tokens when OAuth2 support is ready in Talk. BUG=None TEST=Test cloud print and sync for regressions. Review URL: http://codereview.chromium.org/6649006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77434 0039d316-1c4b-4281-b951-d872f2087c98
* Replace libjingle's HttpPortAllocatorSession with Pepper's http clienthclam@google.com2011-03-085-6/+53
| | | | | | | | | | | | | | | | | HttpPortAllocatorSession uses libjingle's http client to establish relay connection. This will not work in the sanboxed case since it access OS level of network directly. This patch replaces the http client with URL loader in pepper. This goes through the standard URL fetching system for chrome to get around the sandbox problem. BUG=51198 TEST=Force libjingle to use relay and try it with this code. Review URL: http://codereview.chromium.org/6623048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77218 0039d316-1c4b-4281-b951-d872f2087c98