summaryrefslogtreecommitdiffstats
path: root/remoting/protocol/secure_channel_factory.h
Commit message (Collapse)AuthorAgeFilesLines
* Standardize usage of virtual/override/final in remoting/dcheng2014-10-211-4/+4
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=jamiewalch@chromium.org Review URL: https://codereview.chromium.org/667123002 Cr-Commit-Position: refs/heads/master@{#300472}
* replace OVERRIDE and FINAL with override and final in remoting/mostynb2014-10-081-2/+2
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/628753002 Cr-Commit-Position: refs/heads/master@{#298734}
* Move PseudoTCP and channel auth out of LibjingleTransportFactory.sergeyu2014-09-121-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | Previously TransportFactory interface was responsible for creation and initialization of several protocol layers, including PseudoTCP and authentication (TLS). Simplified it so now it only creates raw datagram transport channel. PseudoTcpChannelFactory is now responsible for setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care of channel authentication. Also added DatagramChannelFactory for Datagram channels. This change will make it possible to replace PseudoTcpChannelFactory with an object that creates SCTP-based channels. Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working properly when deleted from the callback. (base::Callback objects shouldn't be deleted while being called because when deleted they also destroy reference parameters values they are holding). BUG=402993 Review URL: https://codereview.chromium.org/551173004 Cr-Commit-Position: refs/heads/master@{#294653}
* Revert of Move PseudoTCP and channel auth out of LibjingleTransportFactory. ↵nasko2014-09-111-60/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #5 id:100001 of https://codereview.chromium.org/551173004/) Reason for revert: Failed to compile on android builder. http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/46485 In file included from ../../remoting/protocol/pseudotcp_channel_factory.h:11:0, from ../../remoting/protocol/pseudotcp_channel_factory.cc:5: ../../remoting/protocol/stream_channel_factory.h:34:41:error: 'string' in namespace 'std' does not name a type virtual void CreateChannel(const std::string& name, ^ ../../remoting/protocol/stream_channel_factory.h:40:49:error: 'string' in namespace 'std' does not name a type virtual void CancelChannelCreation(const std::string& name) = 0; ... Original issue's description: > Move PseudoTCP and channel auth out of LibjingleTransportFactory. > > Previously TransportFactory interface was responsible for creation > and initialization of several protocol layers, including PseudoTCP and > authentication (TLS). Simplified it so now it only creates raw datagram > transport channel. PseudoTcpChannelFactory is now responsible for > setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care > of channel authentication. Also added DatagramChannelFactory for > Datagram channels. > > This change will make it possible to replace PseudoTcpChannelFactory > with an object that creates SCTP-based channels. > > Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working > properly when deleted from the callback. (base::Callback objects > shouldn't be deleted while being called because when deleted they > also destroy reference parameters values they are holding). > > BUG=402993 > > Committed: https://crrev.com/28d886c967e016a5d5812be43cd5916f577c2e10 > Cr-Commit-Position: refs/heads/master@{#294474} TBR=wez@chromium.org,sergeyu@chromium.org NOTREECHECKS=true NOTRY=true BUG=402993 Review URL: https://codereview.chromium.org/570463002 Cr-Commit-Position: refs/heads/master@{#294488}
* Move PseudoTCP and channel auth out of LibjingleTransportFactory.sergeyu2014-09-111-0/+60
Previously TransportFactory interface was responsible for creation and initialization of several protocol layers, including PseudoTCP and authentication (TLS). Simplified it so now it only creates raw datagram transport channel. PseudoTcpChannelFactory is now responsible for setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care of channel authentication. Also added DatagramChannelFactory for Datagram channels. This change will make it possible to replace PseudoTcpChannelFactory with an object that creates SCTP-based channels. Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working properly when deleted from the callback. (base::Callback objects shouldn't be deleted while being called because when deleted they also destroy reference parameters values they are holding). BUG=402993 Review URL: https://codereview.chromium.org/551173004 Cr-Commit-Position: refs/heads/master@{#294474}
generated by cgit v1.1 at 2025-02-19 04:55:01 +0000