| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not desired to have audio to be enabled by default in It2Me
case. Specifically because in most cases helper and helpee will have separate
audio channel (e.g. Hangout or Skype) that's connected before the session
is started. Don't enable it until we have UI to toggle audio support.
This change also includes some minor code cleanups.
Review URL: https://chromiumcodereview.appspot.com/10928159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the current implementation MessageReader may read a message while processing
done callback for the previous message. The message handler may not expect that
which may lead to crashes. E.g. ChannelMultiplex was written such that
OnPacketReceived() is not reentrant.
BUG=148512
Review URL: https://chromiumcodereview.appspot.com/10919259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recorders to ClientSession.
This CL changes the way screen/audio recorders and event executors are managed. New DesktopEnvironmentFactory class is now used by ChromotingHost's owner to specify the kind of desktop environment (or virtual terminal) to be used by the host. Screen/audio recorders and event executors now owned by the ClientSession instance, so there is a separate set of recorders and stubs exists for each authenticated client session. Clients sessions can now be torn dowsn in parallel with the host shuttting down.
This is the 4th attempt to land this change. This version includes:
- |ClientSession| objects are torn down asynchronously now.
- |ClientSession| objects are ref-counted to facilitate the asynchronous shutdown. They still have to be used and destroyed on the network thread.
- |ChromotingHost| now waits until all connections are torn down before deleting the session manager.
- The unit tests were fixed to run message loops until all asynchronous object have been destroyed.
- |ClientSessionTest.ClampMouseEvents| makes sure that the expectations are destroyed when leaving TEST_F scope so that ASAN is not getting confused.
BUG=134694
TEST=remoting_unittests
Review URL: https://chromiumcodereview.appspot.com/10916263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen/audio recorders to ClientSession.
This CL changes the way screen/audio recorders and event executors are managed. New DesktopEnvironmentFactory class is now used by ChromotingHost's owner to specify the kind of desktop environment (or virtual terminal) to be used by the host. Screen/audio recorders and event executors now owned by the ClientSession instance, so there is a separate set of recorders and stubs exists for each authenticated client session. Clients sessions can now be torn dowsn in parallel with the host shuttting down.
This is the 3rd attempt to land this change. This version includes:
- |ClientSession| objects are torn down asynchronously now.
- |ClientSession| objects are ref-counted to facilitate the asynchronous shutdown. They still have to be used and destroyed on the network thread.
- |ChromotingHost| now waits until all connections are torn down before deleting the session manager.
- The unit tests were fixed to run message loops until all asynchronous object have been destroyed.
BUG=134694
TEST=remoting_unittests
Review URL: https://chromiumcodereview.appspot.com/10915206
TBR=alexeypa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10911248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recorders to ClientSession.
This CL changes the way screen/audio recorders and event executors are managed. New DesktopEnvironmentFactory class is now used by ChromotingHost's owner to specify the kind of desktop environment (or virtual terminal) to be used by the host. Screen/audio recorders and event executors now owned by the ClientSession instance, so there is a separate set of recorders and stubs exists for each authenticated client session. Clients sessions can now be torn dowsn in parallel with the host shuttting down.
This is the 3rd attempt to land this change. This version includes:
- |ClientSession| objects are torn down asynchronously now.
- |ClientSession| objects are ref-counted to facilitate the asynchronous shutdown. They still have to be used and destroyed on the network thread.
- |ChromotingHost| now waits until all connections are torn down before deleting the session manager.
- The unit tests were fixed to run message loops until all asynchronous object have been destroyed.
BUG=134694
TEST=remoting_unittests
Review URL: https://chromiumcodereview.appspot.com/10915206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=145057
Review URL: https://chromiumcodereview.appspot.com/10894050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen/audio recorders to ClientSession.
This CL changes the way screen/audio recorders and event executors are managed. New DesktopEnvironmentFactory class is now used by ChromotingHost's owner to specify the kind of desktop environment (or virtual terminal) to be used by the host. Screen/audio recorders and event executors now owned by the ClientSession instance, so there is a separate set of recorders and stubs exists for each authenticated client session. Clients sessions can now be torn dowsn in parallel with the host shuttting down.
This is the 2nd attempt to land this change. This version includes:
- |ClientSession| objects are torn down asynchronously now.
- |ChromotingHost| now waits until all connections are torn down before deleting the session manager.
BUG=134694
TEST=remoting_unittests
Review URL: https://chromiumcodereview.appspot.com/10911152
TBR=alexeypa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10909143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recorders to ClientSession.
This CL changes the way screen/audio recorders and event executors are managed. New DesktopEnvironmentFactory class is now used by ChromotingHost's owner to specify the kind of desktop environment (or virtual terminal) to be used by the host. Screen/audio recorders and event executors now owned by the ClientSession instance, so there is a separate set of recorders and stubs exists for each authenticated client session. Clients sessions can now be torn dowsn in parallel with the host shuttting down.
This is the 2nd attempt to land this change. This version includes:
- |ClientSession| objects are torn down asynchronously now.
- |ChromotingHost| now waits until all connections are torn down before deleting the session manager.
BUG=134694
TEST=remoting_unittests
Review URL: https://chromiumcodereview.appspot.com/10911152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen/audio recorders to ClientSession.
This CL changes the way screen/audio recorders and event executors are managed. New DesktopEnvironmentFactory class is now used by ChromotingHost's owner to specify the kind of desktop environment (or virtual terminal) to be used by the host. Screen/audio recorders and event executors now owned by the ClientSession instance, so there is a separate set of recorders and stubs exists for each authenticated client session. Clients sessions can now be torn dowsn in parallel with the host shuttting down.
BUG=134694
TEST=remoting_unittests
Review URL: https://chromiumcodereview.appspot.com/10920019
TBR=alexeypa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10916161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recorders to ClientSession.
This CL changes the way screen/audio recorders and event executors are managed. New DesktopEnvironmentFactory class is now used by ChromotingHost's owner to specify the kind of desktop environment (or virtual terminal) to be used by the host. Screen/audio recorders and event executors now owned by the ClientSession instance, so there is a separate set of recorders and stubs exists for each authenticated client session. Clients sessions can now be torn dowsn in parallel with the host shuttting down.
BUG=134694
TEST=remoting_unittests
Review URL: https://chromiumcodereview.appspot.com/10920019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
M22 host build has been pushed. It should be compatible with MUX-enabled
clients, so it's safe to enable multiplexing now.
BUG=137135
Review URL: https://chromiumcodereview.appspot.com/10909066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This CHECK() started failing after crrev.com/154272, but we no longer need it,
so it should be safe to remove it.
Review URL: https://chromiumcodereview.appspot.com/10917055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Previously RectangleUpdateDecoder maintaned list of pending packets. That's not really necessary.
Simplified it by queue tasks on the decode thread. Also some minor cleanups for the VideoStub
interface - removed GetPendingVideoPackets() that wasn't used anywhere.
Review URL: https://chromiumcodereview.appspot.com/10879085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously MessageReader class was ref-counted, which means in some cases
it could outlive the socket. Specifically the problem is when received messages
are processed asynchronously and the callback for one of the messages is called
after the socket is destroyed.
BUG=139257
Review URL: https://chromiumcodereview.appspot.com/10870021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
M22 builds expect audio channel configuration, but cannot parse it
when there are not version or codec attributes. Add them back temprorarily.
BUG=144053
Review URL: https://chromiumcodereview.appspot.com/10880016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10832418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Multiplexing has to be disabled because it's not compatible with M21 builds.
Will have to wait for M22 before enabling it back again.
BUG=137135
Review URL: https://chromiumcodereview.appspot.com/10867026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10877014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=123046
Review URL: https://chromiumcodereview.appspot.com/10824412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the session description parser always expected version and codec
attributes for each channel config. These attributes do not make sense
for NONE transport (i.e. when channel is disabled). Now the parser
accepts configs without these attributes and doesn't add them when formatting
outgoing messages.
BUG=144053
Review URL: https://chromiumcodereview.appspot.com/10834446
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=137135
Review URL: https://chromiumcodereview.appspot.com/10825359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10831246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the need for ClientSession to implement InputStub.
BUG=118511
Review URL: https://chromiumcodereview.appspot.com/10829409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also:
* Adds unit tests for InputFilter and CLipboardFilter.
* Updates ClientSession to enabled/disable filters for authentication.
BUG=118511
Review URL: https://chromiumcodereview.appspot.com/10860033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the need for ClientSession to implement ClipboardStub
and proxy clipboard events itself.
BUG=118511
Review URL: https://chromiumcodereview.appspot.com/10831223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now the Session interface has two methods that return channel factories - one for regular channels and one for multiplexed channels.
Also refactored AudioReader and AudioWriter to inherit from
ChannelDispatcherBase.
BUG=137135
Review URL: https://chromiumcodereview.appspot.com/10823323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Group member variables more appropriately.
- Create the input pipeline as member objects rather than separate objects, to remove the need for pointer checks in various places.
TEST=Existing unit-tests. Client plugin continues to work in manual tests.
Review URL: https://chromiumcodereview.appspot.com/10831221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also moved NameToValue() and ValueToName() from jingle_messages.cc to name_value_map.h . These functions simplify string<->enum mapping.
BUG=137135
Review URL: https://chromiumcodereview.appspot.com/10829324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously JingleThreadWrapper required a MessageLoop. In NaCl
we don't have MessageLoop for the main plugin thread, but have a task runner.
This CL allows to use JingleThreadWrapper on the main NaCl thread.
BUG=134216
TBR=tommi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10823224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=118511
Review URL: https://chromiumcodereview.appspot.com/10823244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.
The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.
BUG=139346
Review URL: https://chromiumcodereview.appspot.com/10855076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ChannelMultiplexer allows multiple logical channels to share a
single underlying transport channel.
BUG=137135
Review URL: https://chromiumcodereview.appspot.com/10830046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
After the last chrome remote desktop webapp update (version 1.6.1180.51) V1 authenticators should never be used, so it's
safe to remove them now.
BUG=110483
Review URL: https://chromiumcodereview.appspot.com/10830184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
One issue that is being fixed is that previously that class didn't
properly handle the case when write is called from a callback or
the object is destroyed from a callback.
Review URL: https://chromiumcodereview.appspot.com/10836030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137140
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148418
Review URL: https://chromiumcodereview.appspot.com/10808094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We may need to add new transport types in the future. Current config
parsing code fails to parse configs with transport types it doesn't
understand which will make it hard to add new transport type without
breaking backward compatibility.
BUG=137135
Review URL: https://chromiumcodereview.appspot.com/10831022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The default LibjingleTransportFactory is used for tests only. We didn't
disable TCP ports even though we do disable them in host and client.
Review URL: https://chromiumcodereview.appspot.com/10824049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=137140
Review URL: https://chromiumcodereview.appspot.com/10808094
TBR=sergeyu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=137140
Review URL: https://chromiumcodereview.appspot.com/10808094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10825017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10795075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138607
Review URL: https://chromiumcodereview.appspot.com/10817026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10815023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now screen is desaturated when we get notification that
video channel is not working.
BUG=131411
Review URL: https://chromiumcodereview.appspot.com/10692179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromotingView wasn't really doing what it was initially meant to do,
now FrameProducer and FrameConsumer interfaces are used to process video
stream. Renamed and simplified that interface. Also moved implementation
from PepperView to ChromotingInstance.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147595
Review URL: https://chromiumcodereview.appspot.com/10703144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromotingView wasn't really doing what it was initially meant to do,
now FrameProducer and FrameConsumer interfaces are used to process video
stream. Renamed and simplified that interface. Also moved implementation
from PepperView to ChromotingInstance.
Review URL: https://chromiumcodereview.appspot.com/10703144
TBR=sergeyu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10800048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ChromotingView wasn't really doing what it was initially meant to do,
now FrameProducer and FrameConsumer interfaces are used to process video
stream. Renamed and simplified that interface. Also moved implementation
from PepperView to ChromotingInstance.
Review URL: https://chromiumcodereview.appspot.com/10703144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
even if the session is not "secure". This required refactoring StreamSocket
to add WasNpnNegotiated() and GetSSLInfo() methods.
This allows for a change to SpdySession::GetSSLInfo to accurately return the correct SSLInfo in the case of SPDY Proxy sessions.
BUG=134690
TEST=\*DoNotUseSpdySessionIfCertDoesNotMatch\*
Review URL: https://chromiumcodereview.appspot.com/10690122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10695073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=136935
Review URL: https://chromiumcodereview.appspot.com/10703159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146719 0039d316-1c4b-4281-b951-d872f2087c98
|