| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This adds a "use_gtk3" gyp/gn flag, along with a separate gtk2/gtk3
targets in system.gyp and //build/config/linux/gtk[23] in gn.
BUG=132847
Review URL: https://codereview.chromium.org/1293073006
Cr-Commit-Position: refs/heads/master@{#346742}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, the decision to use GCD or the legacy registry is
made entirely at compile time by setting the value of
|remoting_use_gcd| in gyp.
This change is in preparation for a future change that will allow a
host to determine at runtime, based on a GCD query, whether or not it
is registered with GCD (as opposed to the legacy registry). At that
point, the compile-time switch will determine whether or not the host
attempts to connect to GCD before using the legacy registry as a
fallback.
BUG=503804
Review URL: https://codereview.chromium.org/1215173002
Cr-Commit-Position: refs/heads/master@{#339206}
|
|
|
|
|
|
|
|
|
|
|
| |
Previously AuraDesktopCanpturer wasn't handling empty CopyOutputResult,
which would cause chrome to crash whenever capture request fails.
BUG=504879
Review URL: https://codereview.chromium.org/1227873003
Cr-Commit-Position: refs/heads/master@{#338166}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a cross-platform change that adds credits.txt as a pre-requisite
for remoting_me2me_host. It also adds that file to the Mac bundle, which
means it is automatically installed on that platform, and adds rules to
install the file to /usr/share/doc/chrome-remote-desktop on Linux. The
Windows installer will be updated in a later CL.
It also updates the naming for the web-app credits to make the difference
clearer.
BUG=499478
Review URL: https://codereview.chromium.org/1187543004
Cr-Commit-Position: refs/heads/master@{#336023}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Google Update integration is not supported on Chromium builds.
Also entirely remove the dependency on google_update from
remoting/host/setup and win8/metro_driver, neither of which
used it.
BUG=none
Review URL: https://codereview.chromium.org/1136473005
Cr-Commit-Position: refs/heads/master@{#331659}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The names dom3 and dom4 reflect obsolete documentation and no longer
denote anything useful.
R=wez
TBR=jam
Review URL: https://codereview.chromium.org/1136503003
Cr-Commit-Position: refs/heads/master@{#329176}
|
|
|
|
|
|
|
|
| |
BUG=472269
Review URL: https://codereview.chromium.org/1055263005
Cr-Commit-Position: refs/heads/master@{#325356}
|
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org, garykac@chromium.org
BUG=461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1039083004
Cr-Commit-Position: refs/heads/master@{#323314}
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/961323004
TBR=dpranke
Review URL: https://codereview.chromium.org/969173002
Cr-Commit-Position: refs/heads/master@{#319080}
|
|
|
|
|
|
|
|
| |
BUG=463132
Review URL: https://codereview.chromium.org/969133002
Cr-Commit-Position: refs/heads/master@{#318819}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/961323004/)
Reason for revert:
broke windows GN builds as seen in
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/5206/steps/compile/logs/stdio
Original issue's description:
> Add remoting and PPAPI tests to GN build
>
> Reland of https://codereview.chromium.org/965633002/
>
> TBR=dpranke
>
> Committed: https://crrev.com/66c53eef76f7dff97b1bc76d51740c3a9c07844f
> Cr-Commit-Position: refs/heads/master@{#318756}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/968243004
Cr-Commit-Position: refs/heads/master@{#318772}
|
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/965633002/
TBR=dpranke
Review URL: https://codereview.chromium.org/961323004
Cr-Commit-Position: refs/heads/master@{#318756}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/965633002/)
Reason for revert:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20GN&number=4498
ERROR at //remoting/host/BUILD.gn:56:7: Item not found
"linux/x_server_clipboard.cc",
^----------------------------
You were trying to remove "linux/x_server_clipboard.cc"
Original issue's description:
> Add remoting and PPAPI tests to GN build
>
> BUG=
>
> Committed: https://crrev.com/d0437210926b14b1b7e06b2b56174fc92ade9c37
> Cr-Commit-Position: refs/heads/master@{#318539}
TBR=kelvinp@chromium.org,dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/970443002
Cr-Commit-Position: refs/heads/master@{#318545}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/965633002
Cr-Commit-Position: refs/heads/master@{#318539}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The host was depending on content just to access content::BrowserThread.
It's cleaner to just pass the references to the threads explicitly.
BUG=458581
Committed: https://crrev.com/d5197934178ef0da1b630792cfbda8ddb6b34388
Cr-Commit-Position: refs/heads/master@{#316648}
Review URL: https://codereview.chromium.org/929493002
Cr-Commit-Position: refs/heads/master@{#316746}
|
|
|
|
|
|
|
|
|
|
|
|
| |
For tools/sort_sources.py to be useful, existing GYP and GN files
should be sorted.
BUG=456014
TEST=everything should build as before
Review URL: https://codereview.chromium.org/934703002
Cr-Commit-Position: refs/heads/master@{#316733}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:160001 of https://codereview.chromium.org/929493002/)
Reason for revert:
Compile failure on Linux ChromiumOS Ozone Builder:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/11867
Original issue's description:
> Remove dependency on content from remoting_host.
>
> The host was depending on content just to access content::BrowserThread.
> It's cleaner to just pass the references to the threads explicitly.
>
> BUG=458581
>
> Committed: https://crrev.com/d5197934178ef0da1b630792cfbda8ddb6b34388
> Cr-Commit-Position: refs/heads/master@{#316648}
TBR=kelvinp@chromium.org,sergeyu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=458581
Review URL: https://codereview.chromium.org/923773003
Cr-Commit-Position: refs/heads/master@{#316661}
|
|
|
|
|
|
|
|
|
|
|
| |
The host was depending on content just to access content::BrowserThread.
It's cleaner to just pass the references to the threads explicitly.
BUG=458581
Review URL: https://codereview.chromium.org/929493002
Cr-Commit-Position: refs/heads/master@{#316648}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a re-land of crrev.com/896743004/, which was reverted in crrev.com/905223002/
Previous build problem was due to some linux variables being defined by a script which in turn had some dependencies on dpkg-architecture (which is not present for all linux builds).
Fix is to move the var definitions in with the targets.
BUG=
Review URL: https://codereview.chromium.org/906463005
Cr-Commit-Position: refs/heads/master@{#315670}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #8 id:140001 of https://codereview.chromium.org/896743004/)
Reason for revert:
It cause ChromiumOS.Chromium and PFQ bots to fail. The reason might because chroot didn't have "dpkg-architecture" command. The correct solution might be add "dpkg-architecture" command to chroot. But this CL currently break PFQ and a bunch of bots. So revert it for immediate fix.
See crbug.com/456491
Original issue's description:
> [Chromoting] Remove wildcard ('*') from remoting_all target.
>
> Support for the wildcard is going away in GN, so this helps prepare for the transition away from GYP.
>
> This cl adds dummy targets so that that logic for when the proper targets should be build can be kept in the platform-specific files.
>
> Some of the conditions in the host gyp files needed to be restructured so that the dummy targets would be defined only when necessary. The updated conditions caused a lot of lines to be re-indented, but the target definitions are the same (except for the new dummy targets).
>
> BUG=
>
> Committed: https://crrev.com/9fb75ed89c0ae4ced679576f9cf030cc8c30e928
> Cr-Commit-Position: refs/heads/master@{#315150}
TBR=kelvinp@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/905223002
Cr-Commit-Position: refs/heads/master@{#315261}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support for the wildcard is going away in GN, so this helps prepare for the transition away from GYP.
This cl adds dummy targets so that that logic for when the proper targets should be build can be kept in the platform-specific files.
Some of the conditions in the host gyp files needed to be restructured so that the dummy targets would be defined only when necessary. The updated conditions caused a lot of lines to be re-indented, but the target definitions are the same (except for the new dummy targets).
BUG=
Review URL: https://codereview.chromium.org/896743004
Cr-Commit-Position: refs/heads/master@{#315150}
|
|
|
|
|
|
|
|
|
|
| |
The InstallHost functionality is no longer used now that our Npapi plugin is gone. I am removing it in preparation for the removal of ElevatedDaemonController.
BUG=453172
Review URL: https://codereview.chromium.org/873353004
Cr-Commit-Position: refs/heads/master@{#313857}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changelist removes PolicyWatcherLinux/Win/Mac from
src/remoting/host/policy_hack (which had most of the code copied from
various classes that are now refactored into src/components/policy) and
replaces these classes with PolicyServiceWatcher that wraps a
PolicyService from src/components/policy. PolicyServiceWatcher is based
on a mostly unchanged PolicyWatcherChromeOS, which has been made
applicable to other OS-es, by enabling wrapping an *owned* PolicyService
(and by adding code that creates the owned PolicyService).
This changelist focuses on making minimal changes that:
1) preserve current behavior of PolicyWatcher
2) replace PolicyWatcherLinux/Win/Mac with PolicyServiceWatcher
The focused/minimal nature of the changelist means that some undesirable
or questionable aspects of PolicyWatcher remain untouched. For example:
A) src/remoting/host/policy_hack uses same policy dir path on Chrome
and Chromium (unlike src/chrome/browser/policy)
B) PolicyWatcher still contains quite a bit of business logic
(i.e. for filling out default values or using special fallback
values in case of incorrect value types)
C) PolicyWatcher's users consume policies via base::DictionaryValue
rather than policy::PolicyMap
D) Users of PolicyWatcher have to be aware of threading gotchas (i.e.
It2MeHost::OnPolicyUpdate has to account for the fact that on
ChromeOS, PolicyWatcher's callbacks are called on browser's UI thread
rather than on Chromoting's network_task_runner)
The changelist fails to preserve the following behavior of PolicyWatcher:
*) Policy parsing errors are not surfaced anymore to users of PolicyWatcher
Not retaining this behavior is probably okay because:
i) If the security lock down response to parsing errors is desirable, then we
should detect and surface this from component/policy, so that all Chrome
policies benefit (i.e. security-sensitive AlwaysAuthorizePlugins,
AudioCaptureAllowed or URLBlacklist)
ii) Code reuse from the current changelist allows detecting currently
undetected policy authoring problems in Chromoting scenarios (i.e.
by making it possible to validate policy value types via policy::Schema).
iii) Current policy-errors behavior is far from bullet-proof:
- Misspelled policy names are inherently undetectable
- Invalid types of policy values are ignored on Windows and Mac
(as mentioned above in (ii) and tracked by crbug.com/427513)
- Up until recently (until changelist here:
https://chromium.googlesource.com/chromium/src.git/+/142f8e1d3e4b75c901f33cb771cd848019630c1e)
malformed json files prevented chromoting host from starting but did
*not* stop an already running host (only prevented the already running
host from ever refreshing policies from other, still parseable files).
iv) Reuniting remoting/host/policy_hack with components/policy is automatically
bringing in other features (i.e. detecting policy updates on Mac).
The changelist has been tested by manually dumping and verifying policy
contents via the newly added unit test on Linux, Windows and Mac.
BUG=368321
Review URL: https://codereview.chromium.org/830193002
Cr-Commit-Position: refs/heads/master@{#311994}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change, Chromoting-specific code under
src/remoting/host/policy_hack was introducing its own constants for
names of Chromoting policies, rather than reusing the constants already
generated into policy_constants.h from
src/components/policy/resources/policy_templates.json. This change
fixes this (as asked for by crbug.com/368321).
Removing names of policy keys from policy_watcher.cc is good because:
- It enourages keeping policy_templates.json in-sync with remoting code
(i.e. RemoteAccessHostTokenUrl was introduced to policy_watcher.cc but
not to policy_templates.json; after this changes this should be less
likely).
- Code removal is good.
Updating and keeping in-sync policy_templates.json is good because:
- This is where rest of Chromium infrastructure looks for policy
descriptions, examples, supported-since, etc.
- Up-to-date policy_templates.json is a pre-requisite for removing
src/remoting/host/policy_hack and instead reusing PolicyService and/or
ConfigurationPolicyProvider(s) for Win/Linux/Mac.
While working on the change, I've noticed that 5 out of 15 Chromoting
policies are not covered in policy_templates.json (i.e.
src/components/policy and src/remoting/host/policy_hack got out of
sync). This change fixes this as well. Notes:
- Making src/components/policy and src/remoting/host/policy_hack in-sync
again is good for the short-term.
- In the long-term we might want to somehow separate Chromoting-specific
policies out of policy_templates.json (separate
chromoting_policy_templates.json? separate supported_on?). This
should be done in a separate changelist because
1) the separation concerns should not block current changelist and
more importantly crrev.com/830193002 which gets rid of most code
under policy_hack and
2) the separation is quite involved in itself (i.e. need to account
for it2me/chromeos differences and make sure that tools for
enterprise admins continue to support chromoting policies).
BUG=368321
R=asvitkine@chromium.org, bartfab@chromium.org, mnissler@chromium.org, sergeyu@chromium.org
Review URL: https://codereview.chromium.org/820133002
Patch from Lukasz Anforowicz <lukasza@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#311968}
|
|
|
|
|
|
|
|
| |
BUG=302704
Review URL: https://codereview.chromium.org/798173002
Cr-Commit-Position: refs/heads/master@{#308246}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements InputInjectorChromeOS with the SystemInputInjector API.
It also introduce a new class, DisplayRotationFilter, on the input pipeline to handle
display rotation settings on Ozone.
BUG=426716
Review URL: https://codereview.chromium.org/756643006
Cr-Commit-Position: refs/heads/master@{#307558}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces a class that monitors the changes in cursor shape
on Chrome OS. This CL also updates X11-based ChromeOS system
to use this cursor monitor.
BUG=431457,437955
Review URL: https://codereview.chromium.org/779443002
Cr-Commit-Position: refs/heads/master@{#307200}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cause:
Ash depends on blink. On ChromeOS, we need ash to identify the root
window for screen capturing.
Fix:
We should only depend on ash on ChromeOS.
BUG=436306
Review URL: https://codereview.chromium.org/757393003
Cr-Commit-Position: refs/heads/master@{#305913}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes It2Me host compile on platforms that uses Ozone.
It replaces the X11-based LocalInputMonitor, MouseCursorMonitor and InputInjector
with placeholder implementations for Chrome OS.
An actual implementation is provided for the LocalInputMonitor with code ported from
https://codereview.chromium.org/652293003/.
BUG=431876
Committed: https://crrev.com/18ffa032d49f63f8ae00e68ea7a870e61527bea5
Cr-Commit-Position: refs/heads/master@{#303971}
Review URL: https://codereview.chromium.org/700333007
Cr-Commit-Position: refs/heads/master@{#304091}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 18ffa032d49f63f8ae00e68ea7a870e61527bea5.
It broke ChromiumOS GN.
R=kelvinp@chromium.org
Review URL: https://codereview.chromium.org/718313002
Cr-Commit-Position: refs/heads/master@{#303972}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes It2Me host compile on platforms that uses Ozone.
It replaces the X11-based LocalInputMonitor, MouseCursorMonitor and InputInjector
with placeholder implementations for Chrome OS.
An actual implementation is provided for the LocalInputMonitor with code ported from
https://codereview.chromium.org/652293003/.
BUG=431876
Review URL: https://codereview.chromium.org/700333007
Cr-Commit-Position: refs/heads/master@{#303971}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GN builds are enabled by default on buildbots for Chrome OS with Ozone.
Since remote assistance is part of the Chrome binary on Chrome OS, it needs
to be migrated to GN.
This CL migrates the target remoting_it2me_host_static and its dependencies to GN
on Chrome OS. Specifically this CL:
1. Pulls out the sources from remoting_host.gypi into remoting_host_srcs.gypi,
which is shared by both GYP and GN.
2. Creates a BUILD.gn file for remoting/host and remoting/host/it2me
3. Makes //chrome/browser/extensions depends on //remoting/host/it2me:common
4. Modifies remoting_versions.gni to handle branding.
BUG=432358
Review URL: https://codereview.chromium.org/719603002
Cr-Commit-Position: refs/heads/master@{#303897}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 1d3fbc02ea36d1054ed570bdf2fdb2d46e88e9ba.
Reason for revert:
Build failure on
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/877/steps/steps/logs/stdio
TBR=kelvinp
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/703143004
Cr-Commit-Position: refs/heads/master@{#303579}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes It2Me host compile on platforms that uses Ozone.
It replaces the X11-based LocalInputMonitor, MouseCursorMonitor and InputInjector
with placeholder implementations for Chrome OS.
An actual implementation is provided for the LocalInputMonitor with code ported from
https://codereview.chromium.org/652293003/.
BUG=431876
Review URL: https://codereview.chromium.org/700333007
Cr-Commit-Position: refs/heads/master@{#303578}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Chrome OS, the clipboard is managed by aura instead of the underlying
native platform (e.g. x11, ozone, etc).
This CL introduces a class that
1) Monitors the aura clipboard on the host for changes and notifies the client clipboard.
2) Provides an interface to inject clipboard event into aura.
The public API of this class can be called in any thread as internally it
always posts the call to the |ui_task_runner|. On ChromeOS, that should
be the UI thread of the browser process.
BUG=424717
Committed: https://crrev.com/7a468734170979bca9e48590267d2d123f0c0f84
Cr-Commit-Position: refs/heads/master@{#303168}
Review URL: https://codereview.chromium.org/704683002
Cr-Commit-Position: refs/heads/master@{#303323}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #5 id:100001 of https://codereview.chromium.org/704683002/)
Reason for revert:
Broke the asan bots: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/4106
Original issue's description:
> Remote assistance on Chrome OS Part VII - Clipboard Injection
>
> On Chrome OS, the clipboard is managed by aura instead of the underlying
> native platform (e.g. x11, ozone, etc).
>
> This CL introduces a class that
> 1) Monitors the aura clipboard on the host for changes and notifies the client clipboard.
> 2) Provides an interface to inject clipboard event into aura.
>
> The public API of this class can be called in any thread as internally it
> always posts the call to the |ui_task_runner|. On ChromeOS, that should
> be the UI thread of the browser process.
>
> BUG=424717
>
> Committed: https://crrev.com/7a468734170979bca9e48590267d2d123f0c0f84
> Cr-Commit-Position: refs/heads/master@{#303168}
TBR=dcaiafa@chromium.org,jamiewalch@chromium.org,wez@chromium.org,kelvinp@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424717
Review URL: https://codereview.chromium.org/707913004
Cr-Commit-Position: refs/heads/master@{#303190}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Chrome OS, the clipboard is managed by aura instead of the underlying
native platform (e.g. x11, ozone, etc).
This CL introduces a class that
1) Monitors the aura clipboard on the host for changes and notifies the client clipboard.
2) Provides an interface to inject clipboard event into aura.
The public API of this class can be called in any thread as internally it
always posts the call to the |ui_task_runner|. On ChromeOS, that should
be the UI thread of the browser process.
BUG=424717
Review URL: https://codereview.chromium.org/704683002
Cr-Commit-Position: refs/heads/master@{#303168}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements the ContinueWindow on ChromeOS, which will
be shown to the user for confirmation after 10 minutes into a Remote
Assistance session.
To implement the ContinueWindow, this CL introduces a new class
MessageBox, which is a re-usable component built on top of the
widget framework.
BUG=424908
Committed: https://crrev.com/6410d7ad4937a4a86e9ad28b9ecf99f961305b2d
Cr-Commit-Position: refs/heads/master@{#302657}
Review URL: https://codereview.chromium.org/690183002
Cr-Commit-Position: refs/heads/master@{#302706}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #5 id:120001 of https://codereview.chromium.org/690183002/)
Reason for revert:
Build failure on
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Builder%20%28dbg%29&number=54095
Original issue's description:
> Remote assistance on Chrome OS Part V - It2MeHost Continue Window
>
> This CL implements the ContinueWindow on ChromeOS, which will
> be shown to the user for confirmation after 10 minutes into a Remote
> Assistance session.
>
> To implement the ContinueWindow, this CL introduces a new class
> MessageBox, which is a re-usable component built on top of the
> widget framework.
>
> BUG=424908
>
> Committed: https://crrev.com/6410d7ad4937a4a86e9ad28b9ecf99f961305b2d
> Cr-Commit-Position: refs/heads/master@{#302657}
TBR=wez@chromium.org,dcaiafa@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424908
Review URL: https://codereview.chromium.org/689093004
Cr-Commit-Position: refs/heads/master@{#302660}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements the ContinueWindow on ChromeOS, which will
be shown to the user for confirmation after 10 minutes into a Remote
Assistance session.
To implement the ContinueWindow, this CL introduces a new class
MessageBox, which is a re-usable component built on top of the
widget framework.
BUG=424908
Review URL: https://codereview.chromium.org/690183002
Cr-Commit-Position: refs/heads/master@{#302657}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL links the it2me host to the Chrome binary on ChromeOS
behind a flag.
The following changes are made to the it2me host so that it can be run in the browser process.
1. Initializes SSL server sockets and specific CPU media features on ChromeOS startup.
2. Fixes a crash in it2me shutdown by making It2meHost owns the ChromotingHostContext.
3. Replace the blocking shutdown wait on PolicyWatcher with a callback.
Implements policy_watcher on ChromeOS using policy services.
4. Re-use existing threads, url request context getters and policy service on ChromeOS.
5. Fixed a incorrect DCHECK regarding the color format of the frames captured on ChromeOS.
BUG=334087
Committed: https://crrev.com/54dde6f02d121ff745e66b57205583087ff720ec
Cr-Commit-Position: refs/heads/master@{#302034}
Review URL: https://codereview.chromium.org/639233002
Cr-Commit-Position: refs/heads/master@{#302162}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:700001 of https://codereview.chromium.org/639233002/)
Reason for revert:
Reverting due to build failure on Linux Ozone builder.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/6011
Original issue's description:
> Remote assistance on Chrome OS Part IV - It2MeHost
>
> This CL links the it2me host to the Chrome binary on ChromeOS
> behind a flag.
> The following changes are made to the it2me host so that it can be run in the browser process.
> 1. Initializes SSL server sockets and specific CPU media features on ChromeOS startup.
> 2. Fixes a crash in it2me shutdown by making It2meHost owns the ChromotingHostContext.
> 3. Replace the blocking shutdown wait on PolicyWatcher with a callback.
> Implements policy_watcher on ChromeOS using policy services.
> 4. Re-use existing threads, url request context getters and policy service on ChromeOS.
> 5. Fixed a incorrect DCHECK regarding the color format of the frames captured on ChromeOS.
>
> BUG=334087
>
> Committed: https://crrev.com/54dde6f02d121ff745e66b57205583087ff720ec
> Cr-Commit-Position: refs/heads/master@{#302034}
TBR=jochen@chromium.org,dpolukhin@chromium.org,jamiewalch@chromium.org,kalman@chromium.org,rmsousa@chromium.org,rockot@chromium.org,wez@chromium.org,agl@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=334087
Review URL: https://codereview.chromium.org/686373002
Cr-Commit-Position: refs/heads/master@{#302036}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL links the it2me host to the Chrome binary on ChromeOS
behind a flag.
The following changes are made to the it2me host so that it can be run in the browser process.
1. Initializes SSL server sockets and specific CPU media features on ChromeOS startup.
2. Fixes a crash in it2me shutdown by making It2meHost owns the ChromotingHostContext.
3. Replace the blocking shutdown wait on PolicyWatcher with a callback.
Implements policy_watcher on ChromeOS using policy services.
4. Re-use existing threads, url request context getters and policy service on ChromeOS.
5. Fixed a incorrect DCHECK regarding the color format of the frames captured on ChromeOS.
BUG=334087
Review URL: https://codereview.chromium.org/639233002
Cr-Commit-Position: refs/heads/master@{#302034}
|
|
|
|
|
|
|
|
|
| |
BUG=426561
TEST=None
Review URL: https://codereview.chromium.org/675943002
Cr-Commit-Position: refs/heads/master@{#301832}
|
|
|
|
|
|
|
|
| |
BUG=361137
Review URL: https://codereview.chromium.org/666073007
Cr-Commit-Position: refs/heads/master@{#301004}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL extracts the NativeMessageHost interface from the NativeMessageProcessHost
A NativeMessageHost hosts a native component, which can be
running in the same process as chrome or in a separate
process.
Committed: https://crrev.com/ba722a2a8ddf967dcadb483ea32d5ad31fc4bdf6
Cr-Commit-Position: refs/heads/master@{#298366}
Review URL: https://codereview.chromium.org/591463003
Cr-Commit-Position: refs/heads/master@{#298579}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit ba722a2a8ddf967dcadb483ea32d5ad31fc4bdf6.
It seems that ExtensionApiTest.NativeMessagingBasic and ExtensionApiTest.UserLevelNativeMessaging started to fail.
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/4549
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/4549/steps/browser_tests/logs/NativeMessagingBasic
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/4549/steps/browser_tests/logs/UserLevelNativeMessaging
TBR=kelvinp@chromium.org
Review URL: https://codereview.chromium.org/637463002
Cr-Commit-Position: refs/heads/master@{#298404}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL extracts the NativeMessageHost interface from the NativeMessageProcessHost
A NativeMessageHost hosts a native component, which can be
running in the same process as chrome or in a separate
process.
Review URL: https://codereview.chromium.org/591463003
Cr-Commit-Position: refs/heads/master@{#298366}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL lays the ground work for implementing in process native messaging.
It extracts a common interface |NativeMessagingChannel| outs of
native_messaging_channel.h and renames the existing implementation
to pipe_messaging_channel.
This CL is best reviewed by diffing against patch set 1.
Review URL: https://codereview.chromium.org/558403002
Cr-Commit-Position: refs/heads/master@{#295851}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements a WebRTC Desktop Capturer that captures from
the Aura Shell root window.
The capturer is used by the It2MeHost on Chrome OS.
|DesktopCaptureDeviceAura| cannot be re-used in our scenario
because is timer-driven as opposed to caller driven, which is
required by WebRTC.
The current implementation uses the layer API
desktop_window_->layer()->RequestCopyOfOutput(request.Pass())
to request the layer and its subtree to be rendered to a
|SkiaBitmap|. It then copies the pixels to a WebRTC |DesktopFrame|.
BUG=411530
Committed: https://crrev.com/278b065b519617b1e9231bd53e6502706d20787c
Cr-Commit-Position: refs/heads/master@{#295187}
Review URL: https://codereview.chromium.org/543243003
Cr-Commit-Position: refs/heads/master@{#295214}
|