| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also adds unittests for ServerLogEntry client code, with common code
pulled out to a separate file.
This doesn't affect LogToServer classes - they will be refactored in a
separate CL. Also fix some IWYU issues uncovered by the refactor.
TEST=unittests
Review URL: https://codereview.chromium.org/282063005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If this change breaks some bots, please try restarting the
bot before reverting it. http://crrev.com/264460 may not be
effective yet until restarting.
See the bug and http://crrev.com/255129 for the details.
BUG=345554
Review URL: https://codereview.chromium.org/258433005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/210093006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=357715
TEST=none
Review URL: https://codereview.chromium.org/217133007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in this CL include:
1. Initialize breakpad in it2me native messaging host
2. Create bundles for it2me and me2me native messaging hosts and move them out of the me2me host bundle (and update the manifests accordingly).
3. Dump symbols of the it2me and me2me native messaging hosts
4. Sign the me2me and it2me native messaging hosts
4. Rename the me2me host bundle and the prefPane bundle to get rid of the internal chromium/chromoting names and to conform to Mac convention
5. Refactor GYP, build-installer-archive.py, and do_signing.sh, etc to use name constants from branding_chrome and branding_chromium instead of hard coded names. This ensures that all the name constants are defined in a central location and reduces duplicate name definitions.
Here are the names of the host bundles:
me2me host:
old name: org.chromium.chromoting.me2me_host
new name: ChromeRemoteDesktop.Host
Pref pane:
old name: org.chromium.chromoting.prefPane
new name: ChromeRemoteDesktop.prefPane
it2me nm host:
name: NativeMessagingHost
Full Path: /Library/Google/ChromeRemoteDesktop/NativeMessagingHost.app
me2me nm host:
name: RemoteAssistanceHost
Full path: /Library/Google/ChromeRemoteDesktop/RemoteAssistanceHost.app
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259287
Review URL: https://codereview.chromium.org/186763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks Google Chrome build:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/49089/steps/compile/logs/stdio
> Add breakpad support for me2me and it2me native messaging host on Mac.
>
> Changes in this CL include:
> 1. Initialize breakpad in it2me native messaging host
> 2. Create bundles for it2me and me2me native messaging hosts and move them out of the me2me host bundle (and update the manifests accordingly).
> 3. Dump symbols of the it2me and me2me native messaging hosts
> 4. Sign the me2me and it2me native messaging hosts
> 4. Rename the me2me host bundle and the prefPane bundle to get rid of the internal chromium/chromoting names and to conform to Mac convention
> 5. Refactor GYP, build-installer-archive.py, and do_signing.sh, etc to use name constants from branding_chrome and branding_chromium instead of hard coded names. This ensures that all the name constants are defined in a central location and reduces duplicate name definitions.
>
> Here are the names of the host bundles:
>
> me2me host:
> old name: org.chromium.chromoting.me2me_host
> new name: ChromeRemoteDesktop.Host
>
> Pref pane:
> old name: org.chromium.chromoting.prefPane
> new name: ChromeRemoteDesktop.prefPane
>
> it2me nm host:
> name: NativeMessagingHost
> Full Path: /Library/Google/ChromeRemoteDesktop/NativeMessagingHost.app
>
> me2me nm host:
> name: RemoteAssistanceHost
> Full path: /Library/Google/ChromeRemoteDesktop/RemoteAssistanceHost.app
>
> BUG=
>
> Review URL: https://codereview.chromium.org/186763004
TBR=weitaosu@chromium.org
Review URL: https://codereview.chromium.org/209043004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in this CL include:
1. Initialize breakpad in it2me native messaging host
2. Create bundles for it2me and me2me native messaging hosts and move them out of the me2me host bundle (and update the manifests accordingly).
3. Dump symbols of the it2me and me2me native messaging hosts
4. Sign the me2me and it2me native messaging hosts
4. Rename the me2me host bundle and the prefPane bundle to get rid of the internal chromium/chromoting names and to conform to Mac convention
5. Refactor GYP, build-installer-archive.py, and do_signing.sh, etc to use name constants from branding_chrome and branding_chromium instead of hard coded names. This ensures that all the name constants are defined in a central location and reduces duplicate name definitions.
Here are the names of the host bundles:
me2me host:
old name: org.chromium.chromoting.me2me_host
new name: ChromeRemoteDesktop.Host
Pref pane:
old name: org.chromium.chromoting.prefPane
new name: ChromeRemoteDesktop.prefPane
it2me nm host:
name: NativeMessagingHost
Full Path: /Library/Google/ChromeRemoteDesktop/NativeMessagingHost.app
me2me nm host:
name: RemoteAssistanceHost
Full path: /Library/Google/ChromeRemoteDesktop/RemoteAssistanceHost.app
BUG=
Review URL: https://codereview.chromium.org/186763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
responses as necessary.
Requires gnubbyd 0.8.37 or later.
BUG=134250
Review URL: https://codereview.chromium.org/205493005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These inputs are not necessary because RULE_INPUT_PATH is always
an input of a rule. And the .gyp spec doesn't guarantee that the
RULE_INPUT_* variables exist for the inputs list.
BUG=
R=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/197233010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is to add a new build option 'use_allocator' which will
replace 'linux_use_tcmalloc' in the future. It doesn't change the
behavior immediately. The migration plan is as follows:
1) (this change)
... Add 'use_allocator' and set its default to "see_use_tcmalloc".
... Change allocator conditions to check use_allocator firstly.
... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc".
... NO IMPACT without specifying use_allocator explicitly.
2) Change Blink to accept use_allocator. http://crrev.com/177053003/
3) Change gyp to accept use_allocator. http://crrev.com/178643004/
4) PSA the transition period to chromium-dev@.
5) (after the PSA-ed transition period)
... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default.
... Remove all linux_use_tcmalloc.
... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified.
At the point of this change (1), linux_use_tcmalloc is still used by default
because 'use_allocator%': "see_use_tcmalloc".
As written in http://crbug.com/345554, linux_use_tcmalloc would
be confusing to have more options about allocators. We plan to:
A) enable gperftools' heap-profiler with non-tcmalloc allocator,
B) add a new memory allocator instead of tcmalloc.
BUG=345554, 339604, 341349
R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/177353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will reduce the size of remote_assistance_host.exe and thus the host download.
The size of the debug binary went down from 22MB to 440KB.
BUG=309844
Review URL: https://codereview.chromium.org/178473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Most of the common logic and response handling code are moved into a base class, and the implementation contains just the logic to prepare the validation request (which is where the actual keypair-based authentication happens). This makes it easier to implement different, non-keypair-based host authentication mechanisms.
BUG=
Review URL: https://codereview.chromium.org/165293004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This significantly reduces the size of remoting_native_messaging_host.exe and thus the download size of the Windows host package. The size of the debug binary was reduced to 440k from 17M.
BUG=325567
Review URL: https://codereview.chromium.org/166203003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/166263003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The remoting host changes, including the associated policy definitions,
required to proxy gnubby traffic through a Chrome Remote Desktop
session.
BUG=134250
Review URL: https://codereview.chromium.org/138753005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=338952,325567
Review URL: https://codereview.chromium.org/171163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=338952
Review URL: https://codereview.chromium.org/168113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
remoting_lib_idl generates chromoting_lib.h from IDL, which the
DesktopSessionWin implemenation in remoting_host depends upon.
Review URL: https://codereview.chromium.org/165683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Build a standalone remoting_native_messaging_host.exe. remoting_host.exe is a win32 application (as opposed to console application) thus not suitable as a native messaging host.
2. Initialize the pairing registry reg keys in the native messaging host.
3. GetPairdClients doesn't require elevation.
4. Add the native messaging host binary and manifest and the pairing reg keys to the installer.
Enable pairing registry in Me2Me native messaging host on Windows.
BUG=325567
Review URL: https://codereview.chromium.org/143303007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Right now signaling connector is the only user of OAuth tokens, but if/when we add more authenticated calls, this will allow them to share the cached access token (so that consecutive authenticated calls from different objects don't need to make separate refreshtoken calls).
BUG=
Review URL: https://codereview.chromium.org/141063009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The "true/pm" value is processed correctly on Win8.1 (per-monitor aware), and on previous versions (system dpi aware).
See http://msdn.microsoft.com/en-us/library/windows/desktop/dn469266(v=vs.85).aspx#supporting_dynamic_dpi_changes for details.
BUG=329343
Review URL: https://codereview.chromium.org/147993008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This sets up gyp targets for the various X11 libraries we use and uses
pkg-config to determine the correct cflags/ldflags incantations to use to
link against them instead of listing out -lXfoo lines in libraries sections
in gyp targets throughout the tree. This is more likely to generate the right
lines and makes the dependencies a bit more explicit.
BUG=339518
Review URL: https://codereview.chromium.org/153223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=309844
Review URL: https://codereview.chromium.org/147273003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The webapp implementation of the it2me native messaging is based on the me2me couterpart. But I got rid of the per-message onDone/onError callbacks because unlike me2me, all requests to the it2me host are asynchronous: direct responses to all requests are meaningless. Only the asynchronous callbacks on host state change and nat policy update need to be processed.
I verified that this is fully functional on Linux. Windows and Mac verification haven't been done and are planned after the linux work is completed.
BUG=309844
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248072
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248157
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248255
Review URL: https://codereview.chromium.org/138503009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This broke the official Mac builder. See the details in the original CL.
> It2me native messaging host: webapp implementation.
>
> The webapp implementation of the it2me native messaging is based on the me2me couterpart. But I got rid of the per-message onDone/onError callbacks because unlike me2me, all requests to the it2me host are asynchronous: direct responses to all requests are meaningless. Only the asynchronous callbacks on host state change and nat policy update need to be processed.
>
> I verified that this is fully functional on Linux. Windows and Mac verification haven't been done and are planned after the linux work is completed.
>
> BUG=309844
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248072
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248157
>
> Review URL: https://codereview.chromium.org/138503009
TBR=weitaosu@chromium.org
Review URL: https://codereview.chromium.org/143883015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The webapp implementation of the it2me native messaging is based on the me2me couterpart. But I got rid of the per-message onDone/onError callbacks because unlike me2me, all requests to the it2me host are asynchronous: direct responses to all requests are meaningless. Only the asynchronous callbacks on host state change and nat policy update need to be processed.
I verified that this is fully functional on Linux. Windows and Mac verification haven't been done and are planned after the linux work is completed.
BUG=309844
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248072
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248157
Review URL: https://codereview.chromium.org/138503009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/138503009/)
Reason for revert:
Broke mac build again: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/16217
Original issue's description:
> It2me native messaging host: webapp implementation.
>
> The webapp implementation of the it2me native messaging is based on the me2me couterpart. But I got rid of the per-message onDone/onError callbacks because unlike me2me, all requests to the it2me host are asynchronous: direct responses to all requests are meaningless. Only the asynchronous callbacks on host state change and nat policy update need to be processed.
>
> I verified that this is fully functional on Linux. Windows and Mac verification haven't been done and are planned after the linux work is completed.
>
> BUG=309844
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248072
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248157
TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,sergeyu@chromium.org,weitaosu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=309844
Review URL: https://codereview.chromium.org/150983004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The webapp implementation of the it2me native messaging is based on the me2me couterpart. But I got rid of the per-message onDone/onError callbacks because unlike me2me, all requests to the it2me host are asynchronous: direct responses to all requests are meaningless. Only the asynchronous callbacks on host state change and nat policy update need to be processed.
I verified that this is fully functional on Linux. Windows and Mac verification haven't been done and are planned after the linux work is completed.
BUG=309844
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248072
Review URL: https://codereview.chromium.org/138503009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Use webrtc::MouseCursorMonitor for cursor shapes
>
> Use webrtc::MouseCursorMonitor for cursor shapes instead of
> webrtc::VideoFrameCapturer, in preparation for deprecating cursor shape
> functionality in the latter.
>
> BUG=324033
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247689
>
> Review URL: https://codereview.chromium.org/92473002
This caused errors on a windows memory bot. See bug for details.
TBR=dcaiafa@chromium.org
Review URL: https://codereview.chromium.org/151163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> It2me native messaging host: webapp implementation.
>
> The webapp implementation of the it2me native messaging is based on the me2me couterpart. But I got rid of the per-message onDone/onError callbacks because unlike me2me, all requests to the it2me host are asynchronous: direct responses to all requests are meaningless. Only the asynchronous callbacks on host state change and nat policy update need to be processed.
>
> I verified that this is fully functional on Linux. Windows and Mac verification haven't been done and are planned after the linux work is completed.
>
> BUG=309844
>
> Review URL: https://codereview.chromium.org/138503009
TBR=weitaosu@chromium.org
Review URL: https://codereview.chromium.org/142703009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The webapp implementation of the it2me native messaging is based on the me2me couterpart. But I got rid of the per-message onDone/onError callbacks because unlike me2me, all requests to the it2me host are asynchronous: direct responses to all requests are meaningless. Only the asynchronous callbacks on host state change and nat policy update need to be processed.
I verified that this is fully functional on Linux. Windows and Mac verification haven't been done and are planned after the linux work is completed.
BUG=309844
Review URL: https://codereview.chromium.org/138503009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=337698
Review URL: https://codereview.chromium.org/144853008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use webrtc::MouseCursorMonitor for cursor shapes instead of
webrtc::VideoFrameCapturer, in preparation for deprecating cursor shape
functionality in the latter.
BUG=324033
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247689
Review URL: https://codereview.chromium.org/92473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't plan to use Aura in remoting host. Removed _aura.cc files
and renamed _gtk.cc files to have _linux suffix so that they are
always compiled on Linux.
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/131003010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=
R=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/139283010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247763 0039d316-1c4b-4281-b951-d872f2087c98
|