| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
The reload button is a circular arrow the same size as the spinner graphic.
While the list is being reloaded, the latter is displayed instead.
BUG=273137
Review URL: https://chromiumcodereview.appspot.com/23441022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1. remoting.Error is used now to return errors from remoting.ClientSession.
2. Hid ClientSession members that were previously exposed.
3. Reordered parameters in the constructor
Review URL: https://chromiumcodereview.appspot.com/22926019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The API we use to check the tab type doesn't exist in apps v2, and the check isn't needed there anyway.
BUG=267895
Review URL: https://chromiumcodereview.appspot.com/23150002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For apps v2, the default, "no scroll-bar" behaviour is overridden until a connection to the host is made.
For both apps v1 and apps v2, the in-session behaviour is corrected to work-around crbug.com/240772
BUG=252796,240772
Review URL: https://chromiumcodereview.appspot.com/22006002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/20160004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Signing out is not a concept we support in Apps v2.
BUG=263090
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/20476002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simplifies the task of adding new Apps V2 functionality and should reduce the need to update the patch when JS changes are made.
The change is mostly mechanical, with the exception of a couple of places where the code being patched was run before remoting.init, which is where I've put the isAppsV2 initialization. Since order of execution of code defined at top-level in Javascript is a tricky topic, I've removed most of it, leaving just a 'load' event listener, which is the recommended approach.
BUG=134213
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/19522007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements the HTML UI for displaying and revoking pairings. It was
previously part of https://chromiumcodereview.appspot.com/18225004, but most
of that has now been landed as separate CLs.
BUG=156182
Review URL: https://chromiumcodereview.appspot.com/19824003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
References to remoting.storage have been updated to point to
chrome.storage.
BUG=222785
TEST=Verify webapp preferences persist, no jscompile errors.
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/17385017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=237912
Review URL: https://chromiumcodereview.appspot.com/14803010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
time. Fix: Don't show the error dialog for NOT_AUTHENTICATED error because we will show the auth-dialog anyway.
BUG=225078
Review URL: https://chromiumcodereview.appspot.com/15064002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, this test was based on whether the Me2Me host
plugin was loaded. But if Native Messaging is supported, this
NPAPI instance will not get loaded, so the Share button test
should not depend on it.
BUG=173509
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/15017006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses an OAuth flow on the server to fetch the token and shared secret. There are two implementations for this:
* The current one manually opens a tab and asks for a redirect to a blank page in talkgadget, which we content-script to sendmessage the token/secret back to the extension (fairly similar to our OAuth trampoline)
* Once we're running on appsv2, and identity is out of experimental, we can use launchWebAuthFlow to do this.
This includes an interstitial to ask for an optional permission to the given host. The window.open method doesn't actually need this, but the identity API one does, so I thought I'd leave it in to make its behavior match closely the one of the identity API, which is the one we'll use in the future.
Most of the code is shared between these two versions, the only different pieces are the mechanics to open the window/launchWebFlow, and to send the redirectedUrl back to the webapp for parsing.
BUG=115899
Review URL: https://chromiumcodereview.appspot.com/12905012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This ensures that users don't lose any saved settings when upgrading to M27.
BUG=226488
Review URL: https://chromiumcodereview.appspot.com/13619010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, get rid of the cache of the local host id from HostController. It's only
used to unregister the host, and IMO the code is cleaner if it's re-fetched as
needed in this case. The overhead of doing so should be minimal.
BUG=173509
Review URL: https://chromiumcodereview.appspot.com/12902047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The butter-bar is shown until the user either closes it with the X icon or begins the survey. Once dismissed, a cookie is stored in sync storage to prevent it showing up again for that user on another computer (note that this uses Chrome Sync, so it relies on them being signed in to Chrome).
BUG=191368
Review URL: https://codereview.chromium.org/12566035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=181653
Review URL: https://chromiumcodereview.appspot.com/12667013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=wez
Review URL: https://codereview.chromium.org/12408018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=181263,180939
Review URL: https://chromiumcodereview.appspot.com/12679003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.tabs is not available in Apps v2, but the functionality we use it for
isn't needed anyway. Rather than throwing a null-pointer exception, log an
error message to remind us to remove the code and associated resources once
we're fully Apps v2.
BUG=121771
Review URL: https://chromiumcodereview.appspot.com/12256043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Previously, we were asynchronously reading the manifest at start-up and using
chrome.runtime.getDetails when logging the version string. The latter is more
complicated than it needs to be, and the former doesn't work in Apps v2.
Review URL: https://codereview.chromium.org/12250011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=121771
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10068020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
client_screen.js is a bit of a mixed bag of functions with only a loose
common theme. This CL pulls out the largest single feature, connection setup,
into a separate class, eliminating lots of global state as a result.
As a side-effect, it speeds up connections by parallelizing the WCS driver load
and fixes the referenced bugs.
BUG=173788,174113
Review URL: https://chromiumcodereview.appspot.com/12177003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=170285
Review URL: https://chromiumcodereview.appspot.com/12211003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In C++, they're all passed as optional command line parameters (like google_apis/gaia already allows us to do with the gaia oauth urls). So one can start the host with a monstrosity such as:
out/Debug/remoting_me2me_host out/Debug/remoting_start_host --gaia-host=accounts.google.com --oauth-user-info-url=https://www.googleapis.com/oauth2/v1/userinfo --chromoting-bot-jid=remoting@bot.talk.google.com --chromoting-base-url=https://www.googleapis.com/chromoting/v1 --talk-server-host=talk.google.com --talk-server-port=5222 -[-disable-talk-server-tls] --oauth2-token-url=https://accounts.google.com/o/oauth2/token
In Javascript and IT2Me, unfortunately we don't have a command line, so instead we put all these settings in plugin_settings.js, and the javascript passes them all into the it2me plugin as appropriate. They can then be changed by manually hacking plugin_settings.js and manifest.json in the build output, changing the remoting.settings object at runtime (although any new hosts you configure that are not in the manifest's CSP won't work), or, preferrably, by passing them via environment variables to the build, and letting build-webapp.py do its magic - for example, like with this:
GOOGLE_CLIENT_ID_REMOTING=<clientid> GOOGLE_CLIENT_SECRET_REMOTING=<secret> OAUTH2_ACCOUNTS_HOST=https://accounts.google.com OAUTH2_API_HOST=https://www.googleapis.com CHROMOTING_BOT_JID=remoting@bot.talk.google.com CHROMOTING_API_HOST=https://www.googleapis.com TALK_SERVER_HOST=talk.google.com TALK_SERVER_PORT=5222 TALK_SERVER_USE_TLS=true TALK_GADGET_HOST_SUFFIX=talkgadget.google.com OAUTH2_REDIRECT_HOST_PREFIX=https://chromoting-oauth. TALK_GADGET_HOST_PREFIX=https://chromoting-client. ninja -C out/Debug remoting_webapp
I've tested with me2me (host and client) and it2me (share and access), and verified both that the defaults work as before (without command line parameters), and that I can substitute test server hostnames in all of those parameters.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11346040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This broke the error handling path.
BUG=134213
Review URL: https://chromiumcodereview.appspot.com/12091112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involves the following:
1. Removing chrome extension API calls from wcs.js and wcs_loader.js.
2. Moving those files into a separate <iframe> sandbox.
3. Adding a postMessage-based API to communicate with the rest of the code.
4. Working around miscellaneous sandbox restrictions.
BUG=134213
Review URL: https://chromiumcodereview.appspot.com/12021029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds support for Chrome's identity API, part of the Apps v2 migration effort:
* Add identity.js, wrapping chrome.experimental.identity and handling user consent UI automatically.
* Since the consent UI is now shown on-demand, it's better handled as an explicit overlay rather than as a AppMode, so remove home.auth.
* Move access token and email address functionality out of oauth2.js into identiry.js.
* Add stub code to simplify the transition to using the new code.
* Add patch to enable Apps v2 work-in-progress.
BUG=134213
Review URL: https://codereview.chromium.org/11769002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=155072
Review URL: https://codereview.chromium.org/11663009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
API in preparation for Apps v2 migration.
I haven't changed oauth2.js, since that's going to need to be completely rewritten to make it Apps-v2-compatible.
BUG=134213
Review URL: https://codereview.chromium.org/11638031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removed unused access token parameters.
* Removed email address parameters.
* Removed unnecessary NULL checks for tokens.
* Removed duplicate enum.
BUG=None
Review URL: https://codereview.chromium.org/11446049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In future, when we remove NPAPI we'll be getting host state asynchronously.
This change removes state() method from HostController class. Now the
getLocalHostStateAndId() should be used to get host state. There is still
isInstalled() used by the HostSetupDialog, but it the future it will need
to be removed as well.
Review URL: https://codereview.chromium.org/11418207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously HostController had to update UI when it receives local host ID.
This CL moves that code to HostList class where all other code for
managing host list UI is located.
BUG=132904
Review URL: https://codereview.chromium.org/11360215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=158407
Review URL: https://chromiumcodereview.appspot.com/11336003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
IT2Me to share a computer.
BUG=140386
Review URL: https://chromiumcodereview.appspot.com/10951020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cached host information or client device suspend.
BUG=139389
Review URL: https://chromiumcodereview.appspot.com/10825187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
do this once per login, immediately after getting the OAuth2 refresh token, so failures should be rare, but we've had at least one report of problems, and the current failure mode is to tell the user that the service is unavailable. Specifically, this CL:
* Adds an onError callback so that the caller can be notified of exactly what went wrong.
* Makes sure that a valid email address exists before allowing the user to interact with the app (the alternative is to make accessing the email address asynchronous everywhere, which gets messy very quickly).
BUG=137713
TEST=
Review URL: https://chromiumcodereview.appspot.com/10807026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hosts are cached, then the host list should not display the "no hosts" icon while the host list is being refreshed. This CL fixes a bug related to the asynchronous nature of getting the local host id for the purpose of filtering it from the host list, which caused the cached host list never to be displayed.
Note that if the account has hosts registered, but is accessed from a computer with no cache, then the "no hosts" icon will still flash briefly (although it will generally be hidden behind the infographic).
BUG=135288
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10736020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=131403
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10703034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=129433
TEST=Start the web-app with no hosts registered. There should be no errors on the console.
Review URL: https://chromiumcodereview.appspot.com/10679011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows the app to advise the user to sign back in to Chromoting only when
we believe it will actually help. As a bonus, the unhelpfully-named
ERROR_GENERIC is now gone--apart from OAuth refresh failures, it was being used
for edge-cases where we don't expect anything to go wrong (these now use the
more suitably-named ERROR_UNEXPECTED).
As part of fixing this, I have cleaned up some OAuth call points that were
written before callWithToken existed, and which weren't using it.
BUG=122899,130794
TEST=Corrupt the oauth2-refresh-token value in HTML Local Storage
Review URL: https://chromiumcodereview.appspot.com/10579012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manuel
Review URL: https://chromiumcodereview.appspot.com/10546066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10542030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=126200
TEST=Open and close various modal dialogs (IT2Me client and host, Me2Me host config) and make sure that the control tab ordering is what you would expect.
Review URL: https://chromiumcodereview.appspot.com/10384097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=126309
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10383026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10221021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We have since found a nicer way of implementing this that also works with click-to-play.
BUG=123852
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10149002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=123852
Review URL: https://chromiumcodereview.appspot.com/10114014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Requires the browser's Chromoting client plugin to support the remapKey API.
BUG=105736,121787
TEST=Client running on ChromeOS can copy text on Mac OS X host by pressing right-Ctrl + C.
Review URL: http://codereview.chromium.org/10052034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=122091
Review URL: https://chromiumcodereview.appspot.com/10022001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131371 0039d316-1c4b-4281-b951-d872f2087c98
|