| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Only hyperlink 'share this computer';
* Remove colon after 'Access code';
* Move Connect button to same line as edit field;
* Use right single-arrow quote instead of greater-than;
* Use Droid Sans where available;
* Clean up access code display;
* Improved footer when sharing, including spinner graphic.
BUG=None
TEST=Visual
Review URL: http://codereview.chromium.org/7205045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=82353
TEST=Remoting Viewer plugin provides its scriptable interface; web-app does not complain about bad version.
Review URL: http://codereview.chromium.org/7201030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new adapter will be used to implement protocol on top
of the Transport API.
BUG=51198
TEST=None
Review URL: http://codereview.chromium.org/7200037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles
Review URL: http://codereview.chromium.org/7210025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Allow debug logging from host plugin to JS UI.
* Display error when host is unable to get access token.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7189051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
More details changes made in this patch:
g_profile: 1 -> 2
Will use a more simplified profile similar to H264 base profile
g_threads: 1 -> 2
Use 2 threads for encoding, it was always intended to do this but disabled before due to a bug in libvpx
cpuused: 13->16
Disable half pixel motion vector and use simple loop filtering
Quality for static pictures will stay roughly the same but encoding time will be halved for the most common scenario. Quality of motion picture will suffer with this patch, but not by a large factor due to the fact that we were using real time encoding mode already. So This really trims the parts that we don't need.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7084013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Host shuts down after 5 failed connection attempts
Review URL: http://codereview.chromium.org/7172021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- replaced me2mom with it2me,
- Remove refcounting in HostStatusObserver,
- Cleanup shutdown logic in ChromotingHost,
- Cleanup shutdown logic in host plugin, particularly it now uses main host thread instead of the plugin thread to start/stop the host.
BUG=None
TEST=Don't crash when closing a tab.
Review URL: http://codereview.chromium.org/7182005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7200009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=connection still works.
Review URL: http://codereview.chromium.org/7201018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=86546
TEST=
Review URL: http://codereview.chromium.org/7206004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=82353
TEST=
Review URL: http://codereview.chromium.org/7185026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7210002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initialisation.
Have SSLServerSocket implement the StreamSocket interface, since SSL is stream-oriented. Calling code can then make use of methods not available on the more general Socket interface, such as IsConnected and Disconnect.
BUG=
TEST=Unit tests.
Review URL: http://codereview.chromium.org/7054010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7104122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7184002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7003160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a client.
BUG=85110
TEST=
Review URL: http://codereview.chromium.org/7134023
TBR=wez@chromium.org
Review URL: http://codereview.chromium.org/7189017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85110
TEST=
Review URL: http://codereview.chromium.org/7134023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
possible in target.
BUG=none
TEST=manual on linux
Review URL: http://codereview.chromium.org/7171008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run DisconnectWindow::Show/Hide on correct thread.
This is to ensure that the DisconnectWindow UI actions are carried out on the
proper thread for making platform-native GUI API calls (for example, GTK on
Linux).
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7180001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to ensure that the DisconnectWindow UI actions are carried out on the
proper thread for making platform-native GUI API calls (for example, GTK on
Linux).
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7144010
TBR=lambroslambrou@chromium.org
Review URL: http://codereview.chromium.org/7172024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to ensure that the DisconnectWindow UI actions are carried out on the
proper thread for making platform-native GUI API calls (for example, GTK on
Linux).
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7144010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7149008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7150002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88878
Review URL: http://codereview.chromium.org/7134048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85110
TEST=Connect to Host using an Access Code, then try to re-use the Access Code to connect a second client to it. Second connection should fail.
Review URL: http://codereview.chromium.org/7134100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7089016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is received.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7134048
TBR=jamiewalch@google.com
Review URL: http://codereview.chromium.org/7134099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7134048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Unit-tests still pass
Review URL: http://codereview.chromium.org/7089015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7129034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none.
Review URL: http://codereview.chromium.org/7044066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7108007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run remoting_simple_host --me2mom without cached credentials.
Review URL: http://codereview.chromium.org/7041006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang recently added a warning that warns when invoking 'delete' on a polymorphic non-final class without a virtual destructor. This finds real bugs – see the bug referenced below for a few examples.
However, one common pattern where it fires is this case:
class SomeInterface {
public:
virtual void interfaceMethod() {} // or = 0;
protected:
~SomeInterface() {}
}
class WorkerClass : public SomeInterface {
public:
// many non-virtual functions, but also:
virtual void interfaceMethod() override { /* do actual work */ }
};
void f() {
scoped_ptr<WorkerClass> c(new WorkerClass); // simplified example
}
(See the 2nd half of http://www.gotw.ca/publications/mill18.htm for an explanation of this pattern.)
It is arguably correct to fire the warning here, since someone might make a subclass of WorkerClass and replace |new WorkerClass| with |new WorkerClassSubclass|. This would be broken since WorkerClass doesn't have a virtual destructor.
The solution that the clang folks recommend is to mark WorkerClass as |final| (a c++0x keyword that clang supports as an extension in normal c++ mode – like override). But chrome's base/OWNERS deemed that as too complicated and we decided to make virtual the destructors of leaf classes that implement these interfaces and that are deleted dynamically. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
(For the gtk files, this is necessary because the CHROMEGTK_CALLBACK_ macros add virtual functions.)
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/7087028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Remoting Host plugin successfully loads.
Review URL: http://codereview.chromium.org/7088016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enter key for connect.
BUG=85105
TEST=clicking through the UI, and hitting enter.
Review URL: http://codereview.chromium.org/7120001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7077038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Load the page in a debug build or on a slow computer. The page internals (specifically the access code) should not be visible even momentarily until the correct point in the UX flow.
Review URL: http://codereview.chromium.org/7111040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Clear the OAuth token. Check that the "Get OAuth2 Token..." button appears next to the edit box, not below it.
Review URL: http://codereview.chromium.org/7112036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Use right-click > paste to enter the OAuth2 code. It should now correctly enable the Submit button.
Review URL: http://codereview.chromium.org/7112038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/v8/issues/detail?id=1423
TEST=Click the OAuth and email buttons on a 64-bit Linux machine. Chrome should not crash.
Review URL: http://codereview.chromium.org/7112012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76997
TEST=none
Review URL: http://codereview.chromium.org/7056049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Run Remoting and appreciate it's new shininess.
Review URL: http://codereview.chromium.org/7078022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Host plugin loads and doesn't mysteriously crash trying to call into VPX when a connection is first made.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87534
Review URL: http://codereview.chromium.org/7065026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
patch cuts across modules, as there's only a handful necessary for each,
with the most in chrome/test/. ALSA is enabled on FreeBSD and Solaris, as
libasound has been ported to those two platforms, and I moved resolv.h in
host_resolver_proc.cc, because it depends on headers from sys_addrinfo.h on
FreeBSD.
Patch by ruben (chromium@hybridsource.org)
Review URL: http://codereview.chromium.org/6976055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=84663
TEST=Run two instances of the Host plugin in separate tabs. The second one to start should no longer crash the plugin process.
Review URL: http://codereview.chromium.org/7108004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Unittests.
Review URL: http://codereview.chromium.org/7006029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Host plugin loads and doesn't mysteriously crash trying to call into VPX when a connection is first made.
Review URL: http://codereview.chromium.org/7065026
TBR=wez@chromium.org
Review URL: http://codereview.chromium.org/7108002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87543 0039d316-1c4b-4281-b951-d872f2087c98
|