| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
| |
Note that the first time the user runs Chrome in the virtual session, the profile will be created with whatever default settings that version of Chrome sets. Right now, this is a sign-in request page, which is actually pretty good for our intended use-case (rely on Chrome Sync to keep the console and virtual profiles in sync).
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/25764002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When a complete video frame is decoded, this CL converts the pixels from
BGRA to a format suitable for loading into a Java Bitmap directly. This
removes the need to create a temporary int[] array in Java.
Review URL: https://codereview.chromium.org/23677011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/24788002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
programatically.
BUG=134210
Review URL: https://codereview.chromium.org/24968002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the std::string version of the function and convert all callers
to the GURL version.
BUG=None
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/23625015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Landed previously in r225857, which was reverted in r225859 because it broke android tests.
BUG=103304
R=ben@chromium.org
Review URL: https://codereview.chromium.org/25015003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> gfx: Create a separate gfx component out of ui.
>
> BUG=103304
> R=ben@chromium.org
>
> Review URL: https://codereview.chromium.org/25015003
TBR=sadrul@chromium.org
Review URL: https://codereview.chromium.org/25161002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103304
R=ben@chromium.org
Review URL: https://codereview.chromium.org/25015003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=298654
Review URL: https://codereview.chromium.org/24830002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remove the workaround introduced for 291207.
The chromoting browser tests deal with multiple browser windows by keeping track of and always interacting with the "active" browser window. An observer is added in Authorize() to monitor browser window creation so that the active window can be switched at the right time.
I also fixed a but in ConditionTimeoutWaiter and adjusted the timeout values in various test routines.
BUG=294343
Review URL: https://codereview.chromium.org/24666002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=134210
Review URL: https://codereview.chromium.org/24096025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
R=akalin@chromium.org, jamesr@chromium.org, koz@chromium.org, piman@chromium.org, sergeyu@chromium.org, thestig@chromium.org, vitalybuka@chromium.org
TBR=cpu, dmichael, joi, xhwang
Review URL: https://codereview.chromium.org/24579003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
R=akalin@chromium.org, avi@chromium.org, isherman@chromium.org, jamesr@chromium.org, joi@chromium.org, sergeyu@chromium.org, sky@chromium.org, thestig@chromium.org, xhwang@chromium.org
Review URL: https://codereview.chromium.org/24649002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now DesktopRegion, DesktopRect and DesktopSize are used instead of
corresponding skia types.
R=alexeypa@chromium.org
TBR=reed@google.com (for _moved_ skia dependency)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224101
Review URL: https://codereview.chromium.org/23440046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/24476004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
R=akalin@chromium.org, brettw@chromium.org, sergeyu@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/24616002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was causing remoting_unittests to fail in Release builds.
BUG=297970
TBR=rmsousa@chromium.org
Review URL: https://codereview.chromium.org/24620002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
protocol::MouseEvent.
Review URL: https://chromiumcodereview.appspot.com/24067006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/23995027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ronghuawu@chromium.org, sergeyu@chromium.org
Review URL: https://codereview.chromium.org/24364005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
movements every time a button is pressed.
BUG=132613
R=garykac@chromium.org
Review URL: https://codereview.chromium.org/24138004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This removes some un-needed methods and the DecodeResult enumeration.
Review URL: https://chromiumcodereview.appspot.com/23702056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=281781
R=nfullagar@chromium.org, thakis@chromium.org, yzshen@chromium.org
TBR=cevans@chromium.org
Review URL: https://codereview.chromium.org/23450012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a restriction imposed by Chrome Web Store.
R=garykac@chromium.org
Review URL: https://codereview.chromium.org/23708059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
results rather than using a redirect into the extension.
BUG=291207
Review URL: https://chromiumcodereview.appspot.com/23891005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It caused crbug.com/293068 .
> Make XmppSignalStrategy accept ResolvingClientSocketFactory from outside.
>
> This is necessary to allow passing Pepper-based
> ResolvingClientSocketFactory when using XMPP in the client plugin.
>
> BUG=274652
>
> Review URL: https://chromiumcodereview.appspot.com/23443004
TBR=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/23792010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
step to making this table more accessible from other parts of the codebase.
Currently, the data table and the routines to access it are mixed in the same file, which makes it harder to reference in other places in the code.
Moving it into a separate projects forces it to have a proper separation between the data and the interface and allows it to be added as a dependency without including all of ui/base.
BUG=284774
R=jam@chromium.org, sky@chromium.org, wez@chromium.org
Review URL: https://codereview.chromium.org/23851033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=134210
It is very tedious to simulate a key press event: one needs to find the |code| and |KeyboardCode| corresponding to the character being simulated and then call SimulateKeyPress. This change adds a key code map that translate a char to the corresponding codes assuming US keyboard layout.
This key code map is not suitable for simulating keyboard events originated from a keyboard with a non-us layout. But it is good for the majority of the test scenarios.
It makes keyboard event simulation in the chromoting browser_tests much simpler.
Review URL: https://chromiumcodereview.appspot.com/24233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=242739
Review URL: https://chromiumcodereview.appspot.com/23464086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Remove dependency on Skia from chromoting client.
>
> Now DesktopRegion, DesktopRect and DesktopSize are used instead of
> corresponding skia types.
>
> TBR=reed@google.com (for _moved_ skia dependency)
>
> Review URL: https://chromiumcodereview.appspot.com/23440046
TBR=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/24217003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Now DesktopRegion, DesktopRect and DesktopSize are used instead of
corresponding skia types.
TBR=reed@google.com (for _moved_ skia dependency)
Review URL: https://chromiumcodereview.appspot.com/23440046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=291207
Since chrome doesn't allow us to redirect from cs_oauth_trampoline.js running in the context of the talkgadget page to oauth2_callback.html in the chromoting extension any more, I need to do the redirect manually to unblock browser_tests. This hack will be removed once we make a fix for 291207.
Review URL: https://chromiumcodereview.appspot.com/23939004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
addresses.
Base talk_base::NetworkManager implementation uses combination
of name and "prefix" to identify Network instances. Problem was that
PepperNetworkManager didn't specify prefix when creating Network objects.
As result NetworkManager::MergeNetworkList() was ignoring all but one IP
address for each interface. Client would fail to connect when an IPv6
address was returned first because currently BasicPortAllocator doesn't
allow IPv6 candidates by default (client doesn't specify the flag that
would allow them).
The problem was introduced in r221324.
BUG=293651
R=wez@chromium.org
Review URL: https://codereview.chromium.org/23460049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=134210
Details:
1. Implement Wait* routines using nested message loop.
2. Replace all the busy wait code with the Wait* routines.
3. Refactor NavigateToURLAndWaitForPageLoad: Use a callback to check the currently loaded page in WindowsNotificationObserver.
4. Some other minor refactorings.
5. Move Me2MeBrowserTest in a separate test class. The class is empty right now but me2me specific test routines will be added to it in subsequent CLs.
Review URL: https://chromiumcodereview.appspot.com/23934004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm leaving usb_keycodes_map in ui/base for now.
BUG=none
TEST=none
R=ben@chromium.org, benm@chromium.org, scherkus@chromium.org
TBR=benm@chromium.org, brettw@chromium.org, scherkus@chromium.org
Review URL: https://codereview.chromium.org/23480084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL draws the mouse cursor shape on the client, at the most recent
position of an injected mouse move event (or the center of the screen if
no events have been injected yet).
BUG=270347
TEST=manual, verify mouse cursor appears and moves as expected.
Review URL: https://chromiumcodereview.appspot.com/23532072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should also avoid assert in the linked bug.
BUG=284775
R=wez@chromium.org
Review URL: https://codereview.chromium.org/23477059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Since these icons were attached to the section header, which is shown both
before and after the infographic is displayed, it was partially visible when
the app was initially loaded.
Review URL: https://chromiumcodereview.appspot.com/23637011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=103304
Review URL: https://codereview.chromium.org/23769011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We always use Opus for audio. Removed Speex audio codec.
Also removed non-multiplexed channel configurations for
control, event and audio channels.
R=wez@chromium.org
Review URL: https://codereview.chromium.org/24041005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes warnings from a recent Clang version.
BUG=290204
TBR=thakis
Review URL: https://chromiumcodereview.appspot.com/23484036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The same validation code will be needed for drawing the cursor in the
Android client.
BUG=177559,270347
Review URL: https://chromiumcodereview.appspot.com/23571010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When enabling remote connections, check whether the user is already a
member of the chrome-remote-desktop Unix group before adding the user.
This avoids showing the sudo prompt if it's not needed.
BUG=253608
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/23672032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An alternative mechanism for this was added in https://chromiumcodereview.appspot.com/23609010 but was considered hard to discover and, due to the way that <select> nodes are implemented, hiding it for apps v1 was tricky. This is a simpler UI that just adds a button next to the host name. Together with the app icon context menu option added in https://codereview.chromium.org/23536033/, this is good enough for feature parity with apps v1, although it's unlikely to be the final version.
This CL also adds transparency to the Reload icon, which previously had a white background.
BUG=252881
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/23876010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As well as the specific problem described in the bug, there were some buttons
that weren't using the button-row class, which handles spacing and alignment.
In general, any div with class "box" containing an optional <span> followed by
a "box-spacer" element and some buttons, can be simplified by replacing the
"box" class with "button-row" and removing the "box-spacer".
BUG=288827
R=garykac@chromium.org
Review URL: https://codereview.chromium.org/23568008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add a SimulateKeyPress helper for browser_tests that takes both a UIEvent |code| and a ui::KeyboardCode.
BUG=284754
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222168
Review URL: https://chromiumcodereview.appspot.com/23542008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
- ScopedRefNPObject is wrapped into scoped_ptr<> when passed as a callback between threads since ScopedRefNPObject's ref-counting is not thread-safe.
- Made HostNPScriptObject::DoGenerateKeyPair a static method to make bouncing between threads safe.
- Switched the completion callbacks passed to the daemon controller and pairing registry to use a weak pointer to HostNPScriptObject.
- Clarified threading semantic of DaemonController::Delegate.
BUG=156257,173509
Review URL: https://chromiumcodereview.appspot.com/23578017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves hidpi switch to gfx/switches.h
R=sky@chromium.org
http://crbug.com/103304
Review URL: https://codereview.chromium.org/23451036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Previously, we only had one tool-tip defined in the HTML markup, and its l10n
was hard-coded. This CL adds a generic mechanism, uses it for the local host
edit button and adds a tool-tip to the host list refresh button.
Review URL: https://chromiumcodereview.appspot.com/23923009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UsbKeycodeMap.Basic consistently fails on the Win7 dbg main waterfall bot:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)
base\keycodes\usb_keycode_map_unittest.cc(36): error: Value of: "Unidentified"
Actual: 00890D98
Expected: InvalidKeyboardEventCode()
Which is: 007F90D4
> Add a CodeToNativeKeycode helper that converts UIEvent code to native code.
> Also add a SimulateKeyPress helper for browser_tests that takes both a UIEvent |code| and a ui::KeyboardCode.
>
> issue=284754
>
> Review URL: https://chromiumcodereview.appspot.com/23542008
TBR=weitaosu@chromium.org
Review URL: https://codereview.chromium.org/23451030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222199 0039d316-1c4b-4281-b951-d872f2087c98
|