| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This addresses comments from https://codereview.chromium.org/26336004/
NOTRY=true
Review URL: https://codereview.chromium.org/51243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As of today, FakeURLFetcher takes a boolean "success" parameter, and
returns one of two HTTP response codes: 200 for success and 500 for
failure.
In order to write sync tests for auth errors, we need to be able to fake
arbitrary HTTP response codes.
This patch modifies FakeURLFetcher to return arbitrary HTTP response
codes and fixes all existing call sites. Tests that return arbitrary
error codes will be added in a separate CL.
R=achuith@chromium.org, ajwong@chromium.org, akalin@chromium.org, bengr@chromium.org, nyquist@chromium.org, sergeyu@chromium.org, vitalybuka@chromium.org
TBR=battre, mattm, sky, stevenjb, tim
BUG=313905
TEST=All existing tests pass trybots and waterfall
Review URL: https://codereview.chromium.org/48713008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
3-finger swipe up shows the soft keyboard. 3-finger swipe down shows the
toolbar, and 3-finger tap injects a middle mouse button click.
BUG=293703
Review URL: https://codereview.chromium.org/55613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Add "me2me" to the names of all the me2me specific GYP targets and source files. This makes it easier for my next CL that will add the It2Me native messaging host component.
2. Create a remoting_native_messaging_base GYP target that contains the common native messaging plumbing code shared between remoting_core, remoting_me2me_native_messaging_host and the to-be-created remoting_it2me_native_messaging_host.
3. Clean up some dependencies in remoting.gyp: e.g. the native messaging manifest should be depended on by the archive targets, not the native messaging host binary targets.
4. Rename It2MeImpl to It2MeHost.
BUG=309844
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232331
Review URL: https://codereview.chromium.org/49113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL just gets the DPI information into the DesktopResizer back-ends. They
don't do anything with it yet, and there should be no functional changes.
BUG=172405
Review URL: https://codereview.chromium.org/54273006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> It2Me native messaging: GYP and source refactoring
>
> 1. Add "me2me" to the names of all the me2me specific GYP targets and source files. This makes it easier for my next CL that will add the It2Me native messaging host component.
> 2. Create a remoting_native_messaging_base GYP target that contains the common native messaging plumbing code shared between remoting_core, remoting_me2me_native_messaging_host and the to-be-created remoting_it2me_native_messaging_host.
> 3. Clean up some dependencies in remoting.gyp: e.g. the native messaging manifest should be depended on by the archive targets, not the native messaging host binary targets.
> 4. Rename It2MeImpl to It2MeHost.
>
> BUG=309844
>
> Review URL: https://codereview.chromium.org/49113003
TBR=weitaosu@chromium.org
Review URL: https://codereview.chromium.org/50033003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a gesture-detector for recognizing taps with multiple fingers,
which simplifies the TrackingInputHandler implementation and makes
tap-detection more robust.
BUG=270348
Review URL: https://codereview.chromium.org/51463004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Add "me2me" to the names of all the me2me specific GYP targets and source files. This makes it easier for my next CL that will add the It2Me native messaging host component.
2. Create a remoting_native_messaging_base GYP target that contains the common native messaging plumbing code shared between remoting_core, remoting_me2me_native_messaging_host and the to-be-created remoting_it2me_native_messaging_host.
3. Clean up some dependencies in remoting.gyp: e.g. the native messaging manifest should be depended on by the archive targets, not the native messaging host binary targets.
4. Rename It2MeImpl to It2MeHost.
BUG=309844
Review URL: https://codereview.chromium.org/49113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Security best-practices dictate that the same public key should not
be signed by multiple hash algorithms. This CL prevents that
problem by replacing x509_util::CreateSelfSignedCertificate with
CreateKeyAndSelfSignedCertificate.
This should allow us to change hash functions in x509_utils without
worrying that users may re-sign old keys with the new hash function.
Review URL: https://codereview.chromium.org/27832002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=305951
Review URL: https://codereview.chromium.org/46703003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cs.chromium.org has way fewer hits for
'message'.*\.',?$ file:gyp
than for
'message'.*[^\.]',?$ file:gyp
so standardize on the latter.
BUG=none
TEST=less ocd when watching build output
NOTRY=true
Review URL: https://codereview.chromium.org/51843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If the desktop is smaller than the screen in any direction (left/right
or top/bottom), center the desktop in that direction. This eliminates
wobble as you move the cursor around whilst zoomed out.
Review URL: https://codereview.chromium.org/50373005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Ensure the desktop image never becomes smaller than the screen, and
never becomes unusably big.
Review URL: https://codereview.chromium.org/50193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Using scopers avoids leaking the C++ local references.
BUG=291231
Review URL: https://codereview.chromium.org/37323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes all manually-written JNI interface code and uses the
automatically generated JNI stubs instead.
BUG=304225
R=digit@chromium.org, solb@chromium.org
Review URL: https://codereview.chromium.org/29583003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was coming up in a lot of places, so make it a global include (on
the express toolchain) and remove the individual occurences of the same
pattern.
R=wez@chromium.org
TBR=sky@chromium.org
BUG=308740
Review URL: https://codereview.chromium.org/47363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If the cursor is near the edge of the remote desktop, reposition the
image so that more of it is visible.
Still TODO: Constrain the zoom level.
Review URL: https://codereview.chromium.org/46393002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a first step towards implementing the new gestures:
* Single-finger swipe moves the cursor (and pans the image in the
opposite direction).
* Single-finger tap injects left-click.
* Two-finger tap injects right-click.
* Two-finger pinch to zoom (as before)
* Three-finger tap to show the action-bar (as before)
There are some regressions (to keep this CL simple) but I plan to
address these in follow-up CLs:
* No constraints on image-positioning or zoom-level.
* Cannot do left-button dragging.
* Cannot send middle-button press.
* Removed minimum-scroll constraint, as that makes it difficult to
control the cursor precisely.
BUG=270348
Review URL: https://codereview.chromium.org/26336004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This test verifies that a PIN is required before pairing and is not required
afterwards. It then cleans up the pairing and tries again. The second run
serves to verify that the clean-up worked correctly and also allows us to
test both methods of clearing a pairing.
Review URL: https://codereview.chromium.org/38903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the NPAPI plugin and the it2me native messaging host.
BUG=309844
Review URL: https://codereview.chromium.org/33183006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change break the circular dependency between It2MeImpl and HostNPScriptObject. I will move It2MeImpl to a separate GYP target in a later change.
BUG=309844
Review URL: https://codereview.chromium.org/32643006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These are needed when using 2010 Express.
R=wez@chromium.org
BUG=308740
Review URL: https://codereview.chromium.org/28913004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=260879
Review URL: https://codereview.chromium.org/26921005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also split up breakpad component in more subdirectories and tighten up DEPS
rules
BUG=247431
R=rsesek@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/31243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=260879
Review URL: https://codereview.chromium.org/26888009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=307668
TBR=hans@chromium.org
Review URL: https://codereview.chromium.org/28163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove a bit of dead code.
BUG=247431
R=rsesek@chromium.org
TBR=jln@chromium.org,wez@chromium.org
Review URL: https://codereview.chromium.org/27112003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The changes include:
1. Added support for unpacked extension (in addition to .crx files)
2. Replaced active_browser_ with a stack of WebContents instances to better handle multiple browser windows/tabs.
3. Added a new observer class (PageLoadNotificationObserver) for easy notification handling.
4. Handling of other apps v2 specific issues.
5. WebApp bug fixes.
BUG=134210
Review URL: https://codereview.chromium.org/26414006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in this CL:
- NativeMessagingHost is used only for actual processing the messages.
- NativeMessagingChannel implements receiving and sending messages.
- NativeMessagingChannel takes ownership of the passed inout and output handles.
- Both NativeMessagingChannel and NativeMessagingHost are explicitly
marked as not thread-safe classes.
BUG=173509
Review URL: https://codereview.chromium.org/26313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes, the DesktopView was repainted whilst |JniInterface.sBuffer|
no longer referred to valid frame data. This CL cleans things up by
replacing the ByteBuffer with a Bitmap, and having JniFrameConsumer
copy the completely-decoded data directly into the Java Bitmap.
Review URL: https://codereview.chromium.org/24072012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crash happens when |DaemonControllerDelegateWin::
OnInstallationComplete| runs the |done| callback which was passed as an
argument:
- |done| is passed by reference
- |done| is owned by the caller |installer_| (as a bound
parameter of |done_|)
- |installer_| is destroyed before |done| runs
- |OnInstallationComplete| runs |done|, which now points to released
memory, and crashes
As far as I know, this problem has existed for a while. It should crash
consistently in DEBUG where released memory is wiped out. It might have
been working in RELEASE due to sheer luck.
BUG=305785
TESTED=install host via webapp
Review URL: https://codereview.chromium.org/27042005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/27192007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Libjingle uses RNG from OpenSSL or NSS. In case of OpenSSL builds the RNG
needs to be seeded (while NSS seeds itself from /dev/urandom). Added code
to seed RNG when the remoting plugin is loaded.
Review URL: https://codereview.chromium.org/27183008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving chromoting browser_tests per the suggestion from jam. Chrome is a leaf component thus shouldn't be depended on by remoting.
The code is unchanged except that:
1. The references to the remoting/test paths are updated.
2. I added an OWNERS file
3. chrome entries in the DEPS file are removed.
BUG=
Review URL: https://codereview.chromium.org/26695006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bug was introduced by https://chromiumcodereview.appspot.com/22006002, which
replaced no-scroll with separate no-horizontal-scroll and no-vertical-scroll
classes, but failed to update this spot.
BUG=272348
Review URL: https://codereview.chromium.org/26955003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ScreenCapturer::CreateWithXDamage() is broken in the last webrtc roll,
and it's being deprecated anyway.
R=lambroslambrou@chromium.org, wez@chromium.org
Review URL: https://codereview.chromium.org/27195008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed in order to receive distributed notifications on Mac, which is how we communicate between the pref pane and the daemon controller.
BUG=293036
R=lambroslambrou@chromium.org, sergeyu@chromium.org
Review URL: https://codereview.chromium.org/26860005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=303818
R=wez@chromium.org
Review URL: https://codereview.chromium.org/26539006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32204, 92681
R=dmichael@chromium.org, sergeyu@chromium.org
Review URL: https://codereview.chromium.org/26406002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Seems causing remoting_unittests failure on "Linux ASAN Tests"
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/18265
> Moved all channel-handling logic into separate NativeMessagingChannel class.
>
> Changes in this CL:
> - NativeMessagingHost is used only for actual processing the messages.
> - NativeMessagingChannel implements receiving and sending messages.
> - NativeMessagingChannel takes ownership of the passed inout and output handles.
> - Both NativeMessagingChannel and NativeMessagingHost are explicitly marked as not thread-safe classes.
>
> BUG=173509
>
> Review URL: https://codereview.chromium.org/23903021
TBR=alexeypa@chromium.org
Review URL: https://codereview.chromium.org/26471003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in this CL:
- NativeMessagingHost is used only for actual processing the messages.
- NativeMessagingChannel implements receiving and sending messages.
- NativeMessagingChannel takes ownership of the passed inout and output handles.
- Both NativeMessagingChannel and NativeMessagingHost are explicitly marked as not thread-safe classes.
BUG=173509
Review URL: https://codereview.chromium.org/23903021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test is very similar to Connect_Local_Host.
I also made two changes in the webapp:
1. Added a helper to map a host name to the host id
2. Add an id to the host name cell in the host list for easy retrieval in the test.
BUG=134210
Review URL: https://codereview.chromium.org/26055002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
TBR=mark, acolwell, agl, alexeypa, markus, brettw
Review URL: https://codereview.chromium.org/25849004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=wez@chromium.org
Review URL: https://codereview.chromium.org/25726007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=134210
Review URL: https://codereview.chromium.org/25048007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Note that the first time the user runs Chrome in the virtual session, the profile will be created with whatever default settings that version of Chrome sets. Right now, this is a sign-in request page, which is actually pretty good for our intended use-case (rely on Chrome Sync to keep the console and virtual profiles in sync).
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/25764002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When a complete video frame is decoded, this CL converts the pixels from
BGRA to a format suitable for loading into a Java Bitmap directly. This
removes the need to create a temporary int[] array in Java.
Review URL: https://codereview.chromium.org/23677011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/24788002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226105 0039d316-1c4b-4281-b951-d872f2087c98
|