| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7149008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7150002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88878
Review URL: http://codereview.chromium.org/7134048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85110
TEST=Connect to Host using an Access Code, then try to re-use the Access Code to connect a second client to it. Second connection should fail.
Review URL: http://codereview.chromium.org/7134100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7089016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is received.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7134048
TBR=jamiewalch@google.com
Review URL: http://codereview.chromium.org/7134099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7134048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Unit-tests still pass
Review URL: http://codereview.chromium.org/7089015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7129034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none.
Review URL: http://codereview.chromium.org/7044066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7108007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run remoting_simple_host --me2mom without cached credentials.
Review URL: http://codereview.chromium.org/7041006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang recently added a warning that warns when invoking 'delete' on a polymorphic non-final class without a virtual destructor. This finds real bugs – see the bug referenced below for a few examples.
However, one common pattern where it fires is this case:
class SomeInterface {
public:
virtual void interfaceMethod() {} // or = 0;
protected:
~SomeInterface() {}
}
class WorkerClass : public SomeInterface {
public:
// many non-virtual functions, but also:
virtual void interfaceMethod() override { /* do actual work */ }
};
void f() {
scoped_ptr<WorkerClass> c(new WorkerClass); // simplified example
}
(See the 2nd half of http://www.gotw.ca/publications/mill18.htm for an explanation of this pattern.)
It is arguably correct to fire the warning here, since someone might make a subclass of WorkerClass and replace |new WorkerClass| with |new WorkerClassSubclass|. This would be broken since WorkerClass doesn't have a virtual destructor.
The solution that the clang folks recommend is to mark WorkerClass as |final| (a c++0x keyword that clang supports as an extension in normal c++ mode – like override). But chrome's base/OWNERS deemed that as too complicated and we decided to make virtual the destructors of leaf classes that implement these interfaces and that are deleted dynamically. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs).
(For the gtk files, this is necessary because the CHROMEGTK_CALLBACK_ macros add virtual functions.)
BUG=84424
TEST=none
Review URL: http://codereview.chromium.org/7087028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Remoting Host plugin successfully loads.
Review URL: http://codereview.chromium.org/7088016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enter key for connect.
BUG=85105
TEST=clicking through the UI, and hitting enter.
Review URL: http://codereview.chromium.org/7120001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7077038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Load the page in a debug build or on a slow computer. The page internals (specifically the access code) should not be visible even momentarily until the correct point in the UX flow.
Review URL: http://codereview.chromium.org/7111040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Clear the OAuth token. Check that the "Get OAuth2 Token..." button appears next to the edit box, not below it.
Review URL: http://codereview.chromium.org/7112036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Use right-click > paste to enter the OAuth2 code. It should now correctly enable the Submit button.
Review URL: http://codereview.chromium.org/7112038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/v8/issues/detail?id=1423
TEST=Click the OAuth and email buttons on a 64-bit Linux machine. Chrome should not crash.
Review URL: http://codereview.chromium.org/7112012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76997
TEST=none
Review URL: http://codereview.chromium.org/7056049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Run Remoting and appreciate it's new shininess.
Review URL: http://codereview.chromium.org/7078022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Host plugin loads and doesn't mysteriously crash trying to call into VPX when a connection is first made.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87534
Review URL: http://codereview.chromium.org/7065026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
patch cuts across modules, as there's only a handful necessary for each,
with the most in chrome/test/. ALSA is enabled on FreeBSD and Solaris, as
libasound has been ported to those two platforms, and I moved resolv.h in
host_resolver_proc.cc, because it depends on headers from sys_addrinfo.h on
FreeBSD.
Patch by ruben (chromium@hybridsource.org)
Review URL: http://codereview.chromium.org/6976055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=84663
TEST=Run two instances of the Host plugin in separate tabs. The second one to start should no longer crash the plugin process.
Review URL: http://codereview.chromium.org/7108004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Unittests.
Review URL: http://codereview.chromium.org/7006029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Host plugin loads and doesn't mysteriously crash trying to call into VPX when a connection is first made.
Review URL: http://codereview.chromium.org/7065026
TBR=wez@chromium.org
Review URL: http://codereview.chromium.org/7108002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Host plugin loads and doesn't mysteriously crash trying to call into VPX when a connection is first made.
Review URL: http://codereview.chromium.org/7065026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6849027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Remoting web app works in suitably configured Google Chrome and Chromium browsers.
Review URL: http://codereview.chromium.org/7088003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make thing faster on machines with more than 1 core.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7088002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remoting.
BUG=80245
TEST=Remoting connection still works and doesn't crash.
Review URL: http://codereview.chromium.org/7068030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed to avoid faux dependencies on media/ creeping in to remoting/ code, and creating linker issues.
BUG=
TEST=Everything works as before. Shared component builds certainly don't break.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86971 (Reverted - broke shared builds)
Review URL: http://codereview.chromium.org/7062013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScopedTaskRunner.
This is needed to avoid faux dependencies on media/ creeping in to remoting/ code, and creating linker issues.
BUG=
TEST=Everything works as before.
Review URL: http://codereview.chromium.org/7062013
TBR=wez@chromium.org
Review URL: http://codereview.chromium.org/7062042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed to avoid faux dependencies on media/ creeping in to remoting/ code, and creating linker issues.
BUG=
TEST=Everything works as before.
Review URL: http://codereview.chromium.org/7062013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6979025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The javascript as written had trouble being parsed by the Xcode IDE due to the // in the regexp.
By turning off the height:100% in the css, we don't redraw the entire screen every time we
update the bandwidth stats.
BUG=none
TEST=Make a connection and turn on Quartz Debug on Mac. Turn on Flash screen updates. The entire screen should not flash once per second.
Review URL: http://codereview.chromium.org/7008020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6987029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=can connect w/o ClientLogin token.
Review URL: http://codereview.chromium.org/7008003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6992067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixup order of elements in the ScriptableObject interface header. It's supposed to match the .CC file but had gotten seriously out of sync.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7065036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=83899
TEST=none
Review URL: http://codereview.chromium.org/7031055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
And make them easier to read.
BUG=NONE
TEST=Run remoting.
Review URL: http://codereview.chromium.org/6992069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure user-declared virtual destructors always have the virtual keyword.
The Clang style-check plugin will check for this soon.
No functionality change: virtual is only added
to destructors that are already implicitly virtual.
Also fix a couple of in-line destructor definitions.
BUG=83408
TEST=none
Review URL: http://codereview.chromium.org/7064033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromotingScriptableObject.
It causes PPAPITest.Transport failure on Vista, but sergeyu told me
PPAPITest.Trasnport is flaky and the failure has nothing to do with
the original CL.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7042022
TBR=garykac@chromium.org
Review URL: http://codereview.chromium.org/7069005
Review URL: http://codereview.chromium.org/7068006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromotingScriptableObject.
It causes PPAPITest.Transport failure on Vista
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7042022
TBR=garykac@chromium.org
Review URL: http://codereview.chromium.org/7069005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7042022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=82171
TEST=
Review URL: http://codereview.chromium.org/7040021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=things still work
Review URL: http://codereview.chromium.org/6990028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will help performance on our main thread, and will future proof us.
BUG=NONE
TEST=BUILD
Review URL: http://codereview.chromium.org/6992033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86478 0039d316-1c4b-4281-b951-d872f2087c98
|