summaryrefslogtreecommitdiffstats
path: root/rlz/lib
Commit message (Collapse)AuthorAgeFilesLines
* Merge 263952 "Revert 263828 "Do not reserve an access point code..."hshi@chromium.org2014-04-151-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | > Revert 263828 "Do not reserve an access point code for CHROME_IO..." > > > Do not reserve an access point code for CHROME_IOS_RESERVED > > > > Access point values need to be coordinated with the team using them. Since > > CHROME_IOS_RESERVED is not used, do not reserve an access point for that > > enum, and instead assert if it is ever used. > > > > BUG=360686 > > > > Review URL: https://codereview.chromium.org/237273002 > > TBR=sdefresne@chromium.org > > Review URL: https://codereview.chromium.org/239633002 TBR=hshi@chromium.org Review URL: https://codereview.chromium.org/238063003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@263955 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 263828 "Do not reserve an access point code for CHROME_IOS..."droger@chromium.org2014-04-151-1/+3
| | | | | | | | | | | | | | | | | | > Do not reserve an access point code for CHROME_IOS_RESERVED > > Access point values need to be coordinated with the team using them. Since > CHROME_IOS_RESERVED is not used, do not reserve an access point for that > enum, and instead assert if it is ever used. > > BUG=360686 > > Review URL: https://codereview.chromium.org/237273002 TBR=sdefresne@chromium.org Review URL: https://codereview.chromium.org/236203013 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@263837 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 262679 "Change access point for Chrome on iOS"droger@chromium.org2014-04-152-3/+3
| | | | | | | | | | | | | | | | | | | | | > Change access point for Chrome on iOS > > Use the access point C9* for the Omnibox for Chrome on iOS instead of > the reserved access point RM*. > > Chrome on iOS does not have a notion of homepage, so remove the access > point corresponding to homepage on iOS (CHROME_HOME_PAGE) and the iOS > specific enumeration value (CHROME_IOS_HOME_PAGE). > > BUG=360686 > > Review URL: https://codereview.chromium.org/225293007 TBR=sdefresne@chromium.org Review URL: https://codereview.chromium.org/238293004 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@263835 0039d316-1c4b-4281-b951-d872f2087c98
* Move TrimWhitespace to the base namespace.brettw@chromium.org2014-03-031-3/+3
| | | | | | | | R=viettrungluu@chromium.org, viettrungluu Review URL: https://codereview.chromium.org/183853011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254521 0039d316-1c4b-4281-b951-d872f2087c98
* Removes some unnecessary preprocessor directivescimamoglu@chromium.org2014-01-151-5/+0
| | | | | | | | | The removed conditions are already satisfied through their respective enclosing conditions. Review URL: https://codereview.chromium.org/138213004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245003 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of UTF conversions in ppapi/, printing/, remoting/, rlz/, ↵avi@chromium.org2013-12-251-1/+1
| | | | | | | | | | | | sandbox/, skia/, sql/, sync/, tools/, webkit/, win8/ to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/121123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242502 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: to string16 in rlz/.dbeam@chromium.org2013-12-193-6/+6
| | | | | | | | | R=rogerta@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/102833007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241896 0039d316-1c4b-4281-b951-d872f2087c98
* Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.mark@chromium.org2013-12-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is generally undefined on Mac, but as of r223369, it is incorrect in Chrome on Mac. To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not used with close, and that IGNORE_EINTR is only used with close. Unnecessary #includes of eintr_wrapper.h are also removed. base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc contain non-mechanical changes. Variable naming within the latter is updated per r178174. Missing #includes for <errno.h> in content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were manually added. Mechanical changes were generated by running: sed -E -i '' \ -e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \ -e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \ -e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \ $(git grep -El 'HANDLE_EINTR.*close') sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \ $(grep -EL '(HANDLE|IGNORE)_EINTR' \ $(git grep -El '#include.*eintr_wrapper\.h"')) BUG=269623 R=agl@chromium.org, jln@chromium.org TBR=OWNERS Review URL: https://codereview.chromium.org/100253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
* Use RegistryOverrideManager properly in RLZ tests.grt@chromium.org2013-11-141-0/+16
| | | | | | | | | | | | | | | | | Previously, rlz/test/rlz_test_helpers.cc and chrome/browser/rlz/rlz_unittest.cc each did somewhat different things to prepare the registry for tests. Now, rlz_test_helpers.cc does the prep the right way using RegistryOverrideManager and rlz_unittests.cc uses rlz_test_helpers.cc. This unblocks the refactor in r234367 that was reverted in r234627. BUG=314800 R=rogerta@chromium.org, tommycli@chromium.org Review URL: https://codereview.chromium.org/63153009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235090 0039d316-1c4b-4281-b951-d872f2087c98
* Implements RLZ lib for iOSsdefresne@chromium.org2013-10-232-4/+5
| | | | | | | | | | | Use the OS X implementation of the RlzValueStore and derive the machine identifier from -[UIDevice identifierForVendor]. BUG=309629 Review URL: https://codereview.chromium.org/29873005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230429 0039d316-1c4b-4281-b951-d872f2087c98
* Add periodic check to see if context has been reset.oshima@chromium.org2013-10-173-16/+126
| | | | | | | | | | | | | | | | | | | Context may be set to NULL when shutdown is requested while trying to send ping. With this CL, rlz will cancel the request when it detects the NULL context. non chromeos chrome used to wait even after context is set to NULL, so maybe I should do this only for chromeos. Please let me know what you think. This also fixes the edge race case where the g_context may be set to NULL in the middle of FinancialPing::PingServer. BUG=261377 Review URL: https://codereview.chromium.org/26929004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229114 0039d316-1c4b-4281-b951-d872f2087c98
* Include What You Use: #include <errno.h> where errno is used, or use DPLOGmark@chromium.org2013-09-161-0/+1
| | | | | | | | R=thakis@chromium.org Review URL: https://codereview.chromium.org/23526052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223370 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in ppapi/, printing/, rlz/, ↵avi@chromium.org2013-07-181-1/+1
| | | | | | | | | | | | sync/. BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19627002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212193 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate from googleurl/ includes to url/ ones in the remaining top-level ↵tfarina@chromium.org2013-07-131-1/+1
| | | | | | | | | | | directories. BUG=229660 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/18919005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211572 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in rlz/, skia/, sql/, sync/.avi@chromium.org2013-06-282-3/+3
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18031009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209152 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in rlz/, sandbox/, skia/, sql/, sync/.avi@chromium.org2013-06-116-9/+9
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16358024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205458 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in google_apis/, gpu/, ↵avi@chromium.org2013-06-074-4/+4
| | | | | | | | | | | | ipc/, media/, ppapi/, printing/, remoting/, rlz/, skia/, sql/, sync/, third_party/, tools/, webkit/, win8/. BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15995038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204967 0039d316-1c4b-4281-b951-d872f2087c98
* Detect when chrome is shutting down and don't SendFinacialPingbcwhite@chromium.org2013-04-301-1/+4
| | | | | | | | BUG=160810 Review URL: https://chromiumcodereview.appspot.com/13868016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197214 0039d316-1c4b-4281-b951-d872f2087c98
* rlz: Use base::MessageLoop.xhwang@chromium.org2013-04-292-7/+8
| | | | | | | | | BUG=236029 R=rogerta@chromium.org Review URL: https://chromiumcodereview.appspot.com/14520024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197157 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite scoped_array<T> to scoped_ptr<T[]> in rlz.dcheng@chromium.org2013-04-112-2/+2
| | | | | | | | | | | | This is a manual cleanup pass using sed for files which are not built on Linux. BUG=171111 Review URL: https://chromiumcodereview.appspot.com/14114002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193534 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_path.h to base/files.brettw@chromium.org2013-02-241-3/+3
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Chromium style checker cleanuprsleevi@chromium.org2013-02-201-1/+1
| | | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 TBR=brettw, scherkus Review URL: https://chromiumcodereview.appspot.com/12279015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183469 0039d316-1c4b-4281-b951-d872f2087c98
* Replace FilePath with base::FilePath in some more top level directories.brettw@chromium.org2013-02-101-1/+1
| | | | | | Review URL: https://codereview.chromium.org/12217101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181640 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath to base namespace.brettw@chromium.org2013-02-022-2/+6
| | | | | | | This updates headers that forward-declare it and a few random places to use the namespace explicitly. There us a using declaration in file_path.h that makes the rest compile, which we can do in future passes. Review URL: https://codereview.chromium.org/12163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180245 0039d316-1c4b-4281-b951-d872f2087c98
* Fix CrOS compilation error due to lack of include of unistd.h.posciak@chromium.org2012-12-111-0/+1
| | | | | | | | | | | BUG=none TEST=manual build TBR=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/11486003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172319 0039d316-1c4b-4281-b951-d872f2087c98
* [rlz,cros] RLZ glue for ChromeOS.ivankr@chromium.org2012-12-051-5/+0
| | | | | | | | | BUG=157348,160059 TBR=nirnimesh,sky Review URL: https://chromiumcodereview.appspot.com/11412067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171233 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tautological compare in rlz.hans@chromium.org2012-11-292-3/+3
| | | | | | | | | | | | | | | | | This fixes this warning from a recent version of Clang: rlz/lib/string_utils.cc:14:35: error: comparison of constant 128 with expression of type 'char' is always true [-Werror,-Wtautological-constant-out-of-range-compare] return (letter >= 0x0 && letter < 0x80); ~~~~~~ ^ ~~~~ BUG=163104 Review URL: https://chromiumcodereview.appspot.com/11434029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170265 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] RlzValueStore made protected by a cross-process lock and not ↵ivankr@chromium.org2012-11-299-355/+131
| | | | | | | | | | | | | | | | persisted over browser lifetime (like on Mac). *) Moved RecursiveCrossProcessLock out of .mm file to a common _posix file. *) Added static method to ImportantFileWriter that does blocking write on the current thread. *) Dedicated RLZ thread gone, replaced back with shutdown-blocking worker pool. BUG=157348,62328 Review URL: https://chromiumcodereview.appspot.com/11308196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170179 0039d316-1c4b-4281-b951-d872f2087c98
* [cros,rlz] Financial ping livelock fix and proper shutdown.ivankr@chromium.org2012-11-163-1/+9
| | | | | | | | | | | | | *) Fix the livelock on RLZ thread in FinancialPing *) RlzValueStore on chromeos destroys JsonPrefStore on proper thread. BUG=157348 Review URL: https://chromiumcodereview.appspot.com/11275284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168187 0039d316-1c4b-4281-b951-d872f2087c98
* Move eintr_wrapper.h from base to base/posixbrettw@chromium.org2012-11-141-1/+1
| | | | | | Review URL: https://codereview.chromium.org/11366229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167739 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 167337 - Move url_request_test_util into net namespacejochen@chromium.org2012-11-131-2/+2
| | | | | | | | | | | | | | | This file contains some rather generic names like "TestDelegate". Move it to the net namespace to avoid collisions BUG=none TBR=wtc@chromium.org,darin@chromium.org Original Review URL: https://codereview.chromium.org/11369179 Review URL: https://chromiumcodereview.appspot.com/11365227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167413 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] RlzValueStore implementation for ChromeOS.ivankr@chromium.org2012-11-096-19/+59
| | | | | | | | | BUG=157348 TEST=rlz_unittests Review URL: https://chromiumcodereview.appspot.com/11365107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166891 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Add RecursiveLock for CrOS implementation.ivankr@chromium.org2012-11-063-0/+308
| | | | | | | | | BUG=157348 Review URL: https://chromiumcodereview.appspot.com/11361057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166186 0039d316-1c4b-4281-b951-d872f2087c98
* RLZ: remove hard-coded Win || Mac conditions.ivankr@chromium.org2012-10-293-8/+8
| | | | | | | | | | | | Add enable_rlz GYP variable and rely on ENABLE_RLZ macro instead of hard-coded Win || Mac checks. Also, clean compile by gcc (signed/unsigned mismatch, etc). BUG=157348 Review URL: https://chromiumcodereview.appspot.com/11226060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164681 0039d316-1c4b-4281-b951-d872f2087c98
* mac/rlz: Remove an incorrect checkthakis@chromium.org2012-08-212-0/+22
| | | | | | | | | | | | | | | | | | | As a comment in the ScopedRlzValueStoreLock destructor explains: // Check that "store_ set" => "file_lock acquired". The converse isn't true, // for example if the rlz data file can't be read. So don't CHECK when that happens, instead treat it like lock acquisition failures: Silently drop events when that happens. I added a unit test for this scenario. Also pass O_RDWR to open(), as posix requires one of O_READ, O_WRITE, or O_RDWR. BUG=143950 Review URL: https://chromiumcodereview.appspot.com/10828424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152659 0039d316-1c4b-4281-b951-d872f2087c98
* rlz/mac: Make sure a crashing process doesn't leave a stale lockfile behind.thakis@chromium.org2012-08-151-1/+51
| | | | | | | | | | | | | | | Don't use NSDistributedLock, which uses a lock that isn't cleaned up on unexpected program termination, and which strongly recommends to not call -breakLock (which makes this class fairly pointless). Instead, use a flock(), which is cleaned up by the OS on process exit. Suggested by shess@. BUG=141108 Review URL: https://chromiumcodereview.appspot.com/10823329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151723 0039d316-1c4b-4281-b951-d872f2087c98
* rlz: Change omnibox / homepage access points from C1/C2 to C5/C6 on macthakis@chromium.org2012-07-032-4/+5
| | | | | | | | | BUG=134939 TEST=none Review URL: https://chromiumcodereview.appspot.com/10698024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145337 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 144071 - Add a regenerate button to regenerate the password in Windows.jam@chromium.org2012-06-2626-0/+3882
| | | | | | | | | | | | | BUG=120480 TEST=Not tested. Review URL: https://chromiumcodereview.appspot.com/10642009 TBR=zysxqn@google.com Review URL: https://chromiumcodereview.appspot.com/10659022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144074 0039d316-1c4b-4281-b951-d872f2087c98
* Add a regenerate button to regenerate the password in Windows.zysxqn@google.com2012-06-2626-3882/+0
| | | | | | | | | | BUG=120480 TEST=Not tested. Review URL: https://chromiumcodereview.appspot.com/10642009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144071 0039d316-1c4b-4281-b951-d872f2087c98
* add missing licensejam@chromium.org2012-06-211-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143383 0039d316-1c4b-4281-b951-d872f2087c98
* Check-in rlz code to src\rlz from http://code.google.com/p/rlz/.jam@chromium.org2012-06-2126-0/+3878
Review URL: https://chromiumcodereview.appspot.com/10597002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143381 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-05 14:53:12 +0000