summaryrefslogtreecommitdiffstats
path: root/rlz
Commit message (Collapse)AuthorAgeFilesLines
* Use invalid value for GetAccessPointName for CHROME_IOS_RESERVEDsdefresne@chromium.org2014-04-173-2/+11
| | | | | | | | | | | | | | | | | | | | | | | The team that uses the RLZ access point does not want to reserve two access points for Chrome on iOS since only one is currently used but the enumeration rlz_lib::AccessPoint cannot be changed. Mark the CHROME_IOS_RESERVED access point enumeration value as not supported in IsAccessPointSupported (as we should never reference an access point with enumeration value until the value is reused). This fixes the code that iterates over all values in that enumeration in FinancialPing::FormRequest when no events have been recorded. Return an invalid value in GetAccessPointName if called with the enumeration value rlz_lib::AccessPoint instead of returning NULL to avoid a crash on Chrome OS (constructing a std::string from NULL crash in strlen on Chrome OS). BUG=360686,363700 Review URL: https://codereview.chromium.org/239053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264574 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 263828 "Do not reserve an access point code for CHROME_IO..."hshi@chromium.org2014-04-151-3/+1
| | | | | | | | | | | | | | | | | | > Do not reserve an access point code for CHROME_IOS_RESERVED > > Access point values need to be coordinated with the team using them. Since > CHROME_IOS_RESERVED is not used, do not reserve an access point for that > enum, and instead assert if it is ever used. > > BUG=360686 > > Review URL: https://codereview.chromium.org/237273002 TBR=sdefresne@chromium.org Review URL: https://codereview.chromium.org/239633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263952 0039d316-1c4b-4281-b951-d872f2087c98
* Do not reserve an access point code for CHROME_IOS_RESERVEDsdefresne@chromium.org2014-04-151-1/+3
| | | | | | | | | | | | Access point values need to be coordinated with the team using them. Since CHROME_IOS_RESERVED is not used, do not reserve an access point for that enum, and instead assert if it is ever used. BUG=360686 Review URL: https://codereview.chromium.org/237273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263828 0039d316-1c4b-4281-b951-d872f2087c98
* Change access point for Chrome on iOSsdefresne@chromium.org2014-04-092-3/+3
| | | | | | | | | | | | | | | Use the access point C9* for the Omnibox for Chrome on iOS instead of the reserved access point RM*. Chrome on iOS does not have a notion of homepage, so remove the access point corresponding to homepage on iOS (CHROME_HOME_PAGE) and the iOS specific enumeration value (CHROME_IOS_HOME_PAGE). BUG=360686 Review URL: https://codereview.chromium.org/225293007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262679 0039d316-1c4b-4281-b951-d872f2087c98
* Add RLZ Access points for the app launcher.sammc@chromium.org2014-04-032-6/+8
| | | | | | | | | | | | | Currently, searches using the app launcher search box use the RLZ access point for the omnibox. We want to be able to distinguish between search requests from these two sources. This change adds new RLZ access points to be used for searches via the app launcher. BUG=332996 Review URL: https://codereview.chromium.org/220193005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261550 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetUserName() return more specific error code, so that we could know ↵yiyaoliu@chromium.org2014-03-101-14/+9
| | | | | | | | | | | | how the function failed. However, a lot user at under version 33 or lower, which means they don't auto-update Chrome? I'm not sure if this new piece of code will get to the affected users. BUG=334675 Review URL: https://codereview.chromium.org/177843009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255985 0039d316-1c4b-4281-b951-d872f2087c98
* Move TrimWhitespace to the base namespace.brettw@chromium.org2014-03-031-3/+3
| | | | | | | | R=viettrungluu@chromium.org, viettrungluu Review URL: https://codereview.chromium.org/183853011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254521 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of some uses of base::Create*Valueestade@chromium.org2014-01-301-2/+2
| | | | | | | | | BUG=160586 TBR=finnur, ajuma, thakis, atwilson Review URL: https://codereview.chromium.org/131503015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247922 0039d316-1c4b-4281-b951-d872f2087c98
* Removes some unnecessary preprocessor directivescimamoglu@chromium.org2014-01-151-5/+0
| | | | | | | | | The removed conditions are already satisfied through their respective enclosing conditions. Review URL: https://codereview.chromium.org/138213004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245003 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of UTF conversions in ppapi/, printing/, remoting/, rlz/, ↵avi@chromium.org2013-12-255-9/+12
| | | | | | | | | | | | sandbox/, skia/, sql/, sync/, tools/, webkit/, win8/ to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/121123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242502 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of Value in extensions/, google_apis/, gpu/, media/, net/, ↵avi@chromium.org2013-12-231-1/+2
| | | | | | | | | | | | printing/, remoting/, rlz/, sync/, ui/ to use the base:: namespace. BUG=88666 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/116433007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242410 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: to string16 in rlz/.dbeam@chromium.org2013-12-198-14/+14
| | | | | | | | | R=rogerta@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/102833007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241896 0039d316-1c4b-4281-b951-d872f2087c98
* Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.mark@chromium.org2013-12-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is generally undefined on Mac, but as of r223369, it is incorrect in Chrome on Mac. To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not used with close, and that IGNORE_EINTR is only used with close. Unnecessary #includes of eintr_wrapper.h are also removed. base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc contain non-mechanical changes. Variable naming within the latter is updated per r178174. Missing #includes for <errno.h> in content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were manually added. Mechanical changes were generated by running: sed -E -i '' \ -e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \ -e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \ -e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \ $(git grep -El 'HANDLE_EINTR.*close') sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \ $(grep -EL '(HANDLE|IGNORE)_EINTR' \ $(git grep -El '#include.*eintr_wrapper\.h"')) BUG=269623 R=agl@chromium.org, jln@chromium.org TBR=OWNERS Review URL: https://codereview.chromium.org/100253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more file utils to the base namespace.brettw@chromium.org2013-12-021-2/+2
| | | | | | | | | This also swaps the order of the parameters to GetShmemTempDir so the out parameter is last, and enhances some documentation. Review URL: https://codereview.chromium.org/93263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238144 0039d316-1c4b-4281-b951-d872f2087c98
* Use RegistryOverrideManager properly in RLZ tests.grt@chromium.org2013-11-148-153/+146
| | | | | | | | | | | | | | | | | Previously, rlz/test/rlz_test_helpers.cc and chrome/browser/rlz/rlz_unittest.cc each did somewhat different things to prepare the registry for tests. Now, rlz_test_helpers.cc does the prep the right way using RegistryOverrideManager and rlz_unittests.cc uses rlz_test_helpers.cc. This unblocks the refactor in r234367 that was reverted in r234627. BUG=314800 R=rogerta@chromium.org, tommycli@chromium.org Review URL: https://codereview.chromium.org/63153009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235090 0039d316-1c4b-4281-b951-d872f2087c98
* Implements RLZ lib for iOSsdefresne@chromium.org2013-10-234-4/+32
| | | | | | | | | | | Use the OS X implementation of the RlzValueStore and derive the machine identifier from -[UIDevice identifierForVendor]. BUG=309629 Review URL: https://codereview.chromium.org/29873005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230429 0039d316-1c4b-4281-b951-d872f2087c98
* Drop unused variable in rlz_value_store_chromeos.cc.xhwang@chromium.org2013-10-211-4/+0
| | | | | | | | | | | | | | | | | | ../../rlz/chromeos/lib/rlz_value_store_chromeos.cc:24:12: error: unused variable 'kProductChrome' [-Werror,-Wunused-const-variable] const char kProductChrome[] = "chrome"; ^ ../../rlz/chromeos/lib/rlz_value_store_chromeos.cc:25:12: error: unused variable 'kProductOther' [-Werror,-Wunused-const-variable] const char kProductOther[] = "other"; ^ 2 errors generated. BUG=307668 TEST=none R=thakis@chromium.org Review URL: https://codereview.chromium.org/33373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229874 0039d316-1c4b-4281-b951-d872f2087c98
* Add periodic check to see if context has been reset.oshima@chromium.org2013-10-173-16/+126
| | | | | | | | | | | | | | | | | | | Context may be set to NULL when shutdown is requested while trying to send ping. With this CL, rlz will cancel the request when it detects the NULL context. non chromeos chrome used to wait even after context is set to NULL, so maybe I should do this only for chromeos. Please let me know what you think. This also fixes the edge race case where the g_context may be set to NULL in the middle of FinancialPing::PingServer. BUG=261377 Review URL: https://codereview.chromium.org/26929004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229114 0039d316-1c4b-4281-b951-d872f2087c98
* Include What You Use: #include <errno.h> where errno is used, or use DPLOGmark@chromium.org2013-09-161-0/+1
| | | | | | | | R=thakis@chromium.org Review URL: https://codereview.chromium.org/23526052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223370 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths in rlz for base/process changes.rsesek@chromium.org2013-07-232-2/+2
| | | | | | | | | BUG=242290 R=rogerta@chromium.org Review URL: https://chromiumcodereview.appspot.com/19851004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213171 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in ppapi/, printing/, rlz/, ↵avi@chromium.org2013-07-181-1/+1
| | | | | | | | | | | | sync/. BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19627002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212193 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate from googleurl/ includes to url/ ones in the remaining top-level ↵tfarina@chromium.org2013-07-131-1/+1
| | | | | | | | | | | directories. BUG=229660 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/18919005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211572 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in rlz/, skia/, sql/, sync/.avi@chromium.org2013-06-282-3/+3
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18031009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209152 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Update clients of scoped_nsobject.h.thakis@chromium.org2013-06-241-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | 1.) The header is now in base/mac instead of base/memory 2.) The class is now in namespace base. This CL was created programmatically by running: 1.) git grep -l memory/scoped_nsobject.h | xargs sed -i -e 's/memory\/scoped_nsobject.h/mac\/scoped_nsobject.h/g' for f in $(git diff --name-only origin); do tools/sort-headers.py $f -f; done git commit -a -m headers # manually undo changes to gypi file git cl upload # patch set 1 2.) git grep -l 'scoped_nsobject<' | xargs sed -i -e 's/scoped_nsobject</base::scoped_nsobject</g' # manually undo comment changes in scoped_nsobject.h, tracking_area.h git commit -a -m format git cl upload # patch set 2 # Manually audit all files, file bugs and clean up bad clang-format decisions git cl upload # patch set 3 BUG=251957 TBR=mark@chromium.org Review URL: https://codereview.chromium.org/17593006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208283 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Replace base::mac::ScopedCFTypeRef with base::ScopedCFTypeRef.thakis@chromium.org2013-06-241-5/+6
| | | | | | | | | | | | | | | | | This CL was created fully mechanically by running git grep -l base::mac::ScopedCFTypeRef | xargs sed -i -e 's/base::mac::ScopedCFTypeRef/base::ScopedCFTypeRef/g' git commit -a -m. git clang-format HEAD^ --style=Chromium git commit -a -m. git cl upload -t $TITLE BUG=251957 TBR=mark@chromium.org Review URL: https://codereview.chromium.org/16917011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208245 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in rlz/, sandbox/, skia/, sql/, sync/.avi@chromium.org2013-06-1111-16/+16
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16358024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205458 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in google_apis/, gpu/, ↵avi@chromium.org2013-06-077-8/+8
| | | | | | | | | | | | ipc/, media/, ppapi/, printing/, remoting/, rlz/, skia/, sql/, sync/, third_party/, tools/, webkit/, win8/. BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15995038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204967 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for googleurl. Second try.tfarina@chromium.org2013-06-031-1/+1
| | | | | | | | | | | | | | | - Update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. r184: Fix C++11 compilation on iOS r185: Forward includes to url/ BUG=229660 R=thestig@chromium.org,brettw@chromium.org TBR=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/15421002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203672 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 198844 "Move sequenced_task_runner to base/task"dbeam@chromium.org2013-05-081-1/+1
| | | | | | | | | | | | | | | | | Reverting revisions that rely on r198820 so to unbreak the build. > Move sequenced_task_runner to base/task > > BUG= > R=akalin@chromium.org > > Review URL: https://codereview.chromium.org/14927008 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14985007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198848 0039d316-1c4b-4281-b951-d872f2087c98
* Move sequenced_task_runner to base/taskbrettw@chromium.org2013-05-081-1/+1
| | | | | | | | | BUG= R=akalin@chromium.org Review URL: https://codereview.chromium.org/14927008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198844 0039d316-1c4b-4281-b951-d872f2087c98
* Detect when chrome is shutting down and don't SendFinacialPingbcwhite@chromium.org2013-04-301-1/+4
| | | | | | | | BUG=160810 Review URL: https://chromiumcodereview.appspot.com/13868016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197214 0039d316-1c4b-4281-b951-d872f2087c98
* rlz: Use base::MessageLoop.xhwang@chromium.org2013-04-292-7/+8
| | | | | | | | | BUG=236029 R=rogerta@chromium.org Review URL: https://chromiumcodereview.appspot.com/14520024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197157 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 193992 "Lets try this again."jochen@chromium.org2013-04-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The XP bots are still red, and it's still whining about URL.DLL > Lets try this again. > > Revert 193983 "Revert 193968 "Roll the DEPS for google-url."" > > > Revert 193968 "Roll the DEPS for google-url." > > > > > Roll the DEPS for google-url. > > > > > > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. > > > > > > This also changes googleurl.gyp to reference the files under url/, so that we > > > don't break the Blink tree. > > > > > > BUG=229660 > > > R=brettw@chromium.org > > > TBR=brettw@chromium.org > > > > > > Review URL: https://chromiumcodereview.appspot.com/14089011 > > > > TBR=tfarina@chromium.org > > Review URL: https://codereview.chromium.org/14028012 > > TBR=michaeln@google.com > Review URL: https://codereview.chromium.org/14109014 TBR=michaeln@google.com Review URL: https://codereview.chromium.org/14263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194151 0039d316-1c4b-4281-b951-d872f2087c98
* Lets try this again.michaeln@google.com2013-04-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 193983 "Revert 193968 "Roll the DEPS for google-url."" > Revert 193968 "Roll the DEPS for google-url." > > > Roll the DEPS for google-url. > > > > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. > > > > This also changes googleurl.gyp to reference the files under url/, so that we > > don't break the Blink tree. > > > > BUG=229660 > > R=brettw@chromium.org > > TBR=brettw@chromium.org > > > > Review URL: https://chromiumcodereview.appspot.com/14089011 > > TBR=tfarina@chromium.org > Review URL: https://codereview.chromium.org/14028012 TBR=michaeln@google.com Review URL: https://codereview.chromium.org/14109014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193992 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 193968 "Roll the DEPS for google-url."michaeln@google.com2013-04-121-1/+1
| | | | | | | | | | | | | | | | | | | | > Roll the DEPS for google-url. > > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. > > This also changes googleurl.gyp to reference the files under url/, so that we > don't break the Blink tree. > > BUG=229660 > R=brettw@chromium.org > TBR=brettw@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/14089011 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/14028012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193983 0039d316-1c4b-4281-b951-d872f2087c98
* Roll the DEPS for google-url.tfarina@chromium.org2013-04-121-1/+1
| | | | | | | | | | | | | | | And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. This also changes googleurl.gyp to reference the files under url/, so that we don't break the Blink tree. BUG=229660 R=brettw@chromium.org TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/14089011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193968 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite scoped_array<T> to scoped_ptr<T[]> in rlz.dcheng@chromium.org2013-04-115-5/+5
| | | | | | | | | | | | This is a manual cleanup pass using sed for files which are not built on Linux. BUG=171111 Review URL: https://chromiumcodereview.appspot.com/14114002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193534 0039d316-1c4b-4281-b951-d872f2087c98
* Update the remaining references to sys_string_conversions.h to its new location.tfarina@chromium.org2013-03-302-3/+3
| | | | | | | | | | | | BUG=196305 TBR=isherman@chromium.org,rsleevi@chromium.org,keybuk@chromium.org,fischman@chromium.org, thestig@chromium.org,alexeypa@chromium.org,rogerta@chromium.org,cpu@chromium.org, akalin@chromium.org,ben@chromium.org,tony@chromium.org Review URL: https://chromiumcodereview.appspot.com/13322003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191479 0039d316-1c4b-4281-b951-d872f2087c98
* src/: Update the remaining include paths of string_split.h to its new location.tfarina@chromium.org2013-03-061-1/+1
| | | | | | | | | | BUG=175186 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/12473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186462 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_path.h to base/files.brettw@chromium.org2013-02-245-9/+9
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Chromium style checker cleanuprsleevi@chromium.org2013-02-201-1/+1
| | | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 TBR=brettw, scherkus Review URL: https://chromiumcodereview.appspot.com/12279015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183469 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: qualifiers for FilePath uses.msw@chromium.org2013-02-191-3/+3
| | | | | | | | | | | | | | | Fixing missed FilePath uses from http::crrev.com/183170 http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Win&number=16539 http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=49472 It seems like the bots aren't tree closers, so I'm fixing it live. BUG=NONE TEST=chromium.chrome builders pass compile. TBR=brettw@chromium.org,jar@chromium.org Review URL: https://codereview.chromium.org/12298030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183187 0039d316-1c4b-4281-b951-d872f2087c98
* Make rlz build on Win64 jschuh@chromium.org2013-02-181-0/+4
| | | | | | | | | | | | | Just c4267 build suppressions. BUG=166496 BUG=167187 TBR=rogerta@chromium.org R=rogerta@chromium.org Review URL: https://chromiumcodereview.appspot.com/12299010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183108 0039d316-1c4b-4281-b951-d872f2087c98
* Replace FilePath with base::FilePath in some more top level directories.brettw@chromium.org2013-02-105-10/+11
| | | | | | Review URL: https://codereview.chromium.org/12217101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181640 0039d316-1c4b-4281-b951-d872f2087c98
* [RLZ] Get rid of vista_winnt.hmnaganov@chromium.org2013-02-033-101/+0
| | | | | | | | | | | This file was needed for compiling on pre-Vista SDKs. Since now Chromium requires at least Windows 7 SDK, it should not be needed anymore. BUG=172607 Review URL: https://chromiumcodereview.appspot.com/12092068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180289 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath to base namespace.brettw@chromium.org2013-02-022-2/+6
| | | | | | | This updates headers that forward-declare it and a few random places to use the namespace explicitly. There us a using declaration in file_path.h that makes the rest compile, which we can do in future passes. Review URL: https://codereview.chromium.org/12163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180245 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] RLZ tracking can be turned off via a flag file.ivankr@chromium.org2012-12-171-0/+13
| | | | | | | | | | | | | Also loads brand code from file for previous users. BUG=157348 TBR=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/11506006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173472 0039d316-1c4b-4281-b951-d872f2087c98
* Fix CrOS compilation error due to lack of include of unistd.h.posciak@chromium.org2012-12-111-0/+1
| | | | | | | | | | | BUG=none TEST=manual build TBR=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/11486003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172319 0039d316-1c4b-4281-b951-d872f2087c98
* [rlz,cros] RLZ glue for ChromeOS.ivankr@chromium.org2012-12-051-5/+0
| | | | | | | | | BUG=157348,160059 TBR=nirnimesh,sky Review URL: https://chromiumcodereview.appspot.com/11412067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171233 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tautological compare in rlz.hans@chromium.org2012-11-292-3/+3
| | | | | | | | | | | | | | | | | This fixes this warning from a recent version of Clang: rlz/lib/string_utils.cc:14:35: error: comparison of constant 128 with expression of type 'char' is always true [-Werror,-Wtautological-constant-out-of-range-compare] return (letter >= 0x0 && letter < 0x80); ~~~~~~ ^ ~~~~ BUG=163104 Review URL: https://chromiumcodereview.appspot.com/11434029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170265 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-04 09:00:11 +0000