summaryrefslogtreecommitdiffstats
path: root/sandbox/src
Commit message (Collapse)AuthorAgeFilesLines
* Declare exe_name and cmd_line as const pointers and usewtc@chromium.org2009-07-231-7/+9
| | | | | | | | | | | | | | | const_cast only where necessary. Fix a FORWARD_NULL defect reported by Coverity. Pass cmd_line to sandbox::WideToMultiByte only if cmd_line is not NULL. R=rvargas BUG=http://crbug.com/17101 TEST=none Review URL: http://codereview.chromium.org/155969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21406 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a FORWARD_NULL defect in ExtractModuleName reported by Coverity.wtc@chromium.org2009-07-232-6/+5
| | | | | | | | | | | | | | | | If 'sep' is still NULL after the for loop, ix must be -1, so ix == 0 cannot be true. Update the comment for ExtractModuleName in the header to match the implementation. I don't see any code that checks whether the path is a full path. R=rvargas BUG=http://crbug.com/17101 TEST=none Review URL: http://codereview.chromium.org/155979 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21404 0039d316-1c4b-4281-b951-d872f2087c98
* Fix FORWARD_NULL defects reported by Coverity. We shouldwtc@chromium.org2009-07-222-3/+3
| | | | | | | | | | | also return an error if argv is NULL. R=rvargas BUG=http://crbug.com/17101 TEST=none Review URL: http://codereview.chromium.org/155904 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21292 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Off-by-one error in LowLevelPolicy::Done.yuzo@chromium.org2009-07-031-1/+1
| | | | | | | | | BUG=none TEST=n/a Review URL: http://codereview.chromium.org/150211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19875 0039d316-1c4b-4281-b951-d872f2087c98
* -Fix a wrong commentcpu@google.com2009-07-012-1/+4
| | | | | | | | | | | | | -Put a comment to clarify a behavior See coverity CID 1703 BUG=none TEST=none Review URL: http://codereview.chromium.org/150128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19700 0039d316-1c4b-4281-b951-d872f2087c98
* Fix potential memleak in GetArgs.finnur@chromium.org2009-06-301-6/+6
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/151045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19613 0039d316-1c4b-4281-b951-d872f2087c98
* ZwOpenKeyEx is now documented at ↵nsylvain@chromium.org2009-05-213-8/+8
| | | | | | | | | | | | | | | | http://msdn.microsoft.com/en-us/library/dd535803.aspx The last unknown parameter is OpenOptions. We do not support it at this point, since it involves links, which wont be trivial to secure, and giving "special" privileges. Updating the code accordingly. BUG:7611 TEST:No code change Review URL: http://codereview.chromium.org/115640 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16633 0039d316-1c4b-4281-b951-d872f2087c98
* Add more checks to be able to isolate why chrome cannotnsylvain@chromium.org2009-05-211-1/+22
| | | | | | | | | | | do a GetProcAddress of NtCreateFile. TEST:Nothing to test BUG:11789 Review URL: http://codereview.chromium.org/113659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16599 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for alternate window station.nsylvain@chromium.org2009-05-2011-35/+412
| | | | | | | | | | TEST: Start chrome, make sure it loads pages, then user process explorer to make sure the WindowStation handle name is not the same as the browser process. BUG:10996 Review URL: http://codereview.chromium.org/113190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16483 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in the unittests caused by the fact that the order ofnsylvain@chromium.org2009-05-181-0/+12
| | | | | | | | | | | | | compilation of the files has changed. Some tests were assuming that g_nt was already defined. 2/3 of the tests were calling SetupNtdllImports(), so I made the rest call that too. Review URL: http://codereview.chromium.org/113548 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16309 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the checked-in scons configuration files.sgk@google.com2009-04-011-84/+0
| | | | | | Review URL: http://codereview.chromium.org/53121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
* Fix URL for sandboxing design doc.evan@chromium.org2009-03-276-8/+9
| | | | | | Review URL: http://codereview.chromium.org/55043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12715 0039d316-1c4b-4281-b951-d872f2087c98
* Sync sandbox WriteInto with updated version from basemark@chromium.org2009-03-251-7/+5
| | | | | | Review URL: http://codereview.chromium.org/45049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12456 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect include guards in sandbox/. Guards now match their filename.deanm@chromium.org2009-03-174-8/+8
| | | | | | | Review URL: http://codereview.chromium.org/48073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11868 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files ↵thestig@chromium.org2009-03-135-4/+1
| | | | | | | | to ~400. Review URL: http://codereview.chromium.org/46039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
* Remove logging.h from cc files that don't use it.thestig@chromium.org2009-03-128-8/+0
| | | | | | Review URL: http://codereview.chromium.org/42155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of logging.h in header files.thestig@chromium.org2009-03-122-1/+1
| | | | | | Review URL: http://codereview.chromium.org/43148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-11133-137/+0
| | | | | | | | | Normalize end of file newlines in sandbox/. All files end in a single newline. Review URL: http://codereview.chromium.org/43080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11447 0039d316-1c4b-4281-b951-d872f2087c98
* Slight code change to make some global variables const.maruel@google.com2009-03-101-5/+6
| | | | | | | Fix >80 cols lines. Review URL: http://codereview.chromium.org/42013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11342 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CRLF and trailing white spaces.maruel@chromium.org2009-03-055-5/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
* In windows 7 there is a new Reg call that we need tonsylvain@chromium.org2009-02-134-8/+48
| | | | | | | | | | | | | | | | | hook. NtOpenKeyEx. I don't know what the last parameter is. I suspect it's a reserved flag for "options". (As in RegOpenKeyEx). I do not handle the case where this unknown flag is non-zero. The current unit tests covers this code. bug:7611 Review URL: http://codereview.chromium.org/20287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9762 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Add support for Windows 7 - 64 bit.rvargas@google.com2009-02-031-12/+42
| | | | | | | | | | BUG=4324 TEST=IntegrationTestsTest.* Review URL: http://codereview.chromium.org/20026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9104 0039d316-1c4b-4281-b951-d872f2087c98
* revert r9096. rvargas@google.com2009-02-031-40/+12
| | | | | | | TBD nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9097 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Add support for Windows 7 - 64 bit.rvargas@google.com2009-02-031-12/+40
| | | | | | | | | BUG=4324 TEST=IntegrationTestsTest.* Review URL: http://codereview.chromium.org/20023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9096 0039d316-1c4b-4281-b951-d872f2087c98
* remove chrome dependencies from win sandboxing headers. Wrap sandbox code topinkerton@google.com2009-01-091-6/+0
| | | | | | | make the main routine a little cleaner. Unify the parameters of each of the "main" entry points so we can more easily abstract platform differences in the future. BUG=5323 Review URL: http://codereview.chromium.org/17426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7825 0039d316-1c4b-4281-b951-d872f2087c98
* Mass convert ChromeStaticLibrary -> ChromeLibrary, including pulling the ↵evanm@google.com2008-12-261-1/+1
| | | | | | | | | | | updated ICU dep that uses it as well. Add a SHARED scons command-line flag to build shared libraries. Review URL: http://codereview.chromium.org/16477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7479 0039d316-1c4b-4281-b951-d872f2087c98
* Move a function from controller.cc to sandbox_utils.cc innsylvain@chromium.org2008-12-2315-43/+49
| | | | | | | preparation for the refactoring. Review URL: http://codereview.chromium.org/16225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7445 0039d316-1c4b-4281-b951-d872f2087c98
* Convert from using env['PLATFORM'] directly to using the more flexiblesgk@google.com2008-12-181-1/+1
| | | | | | | | | | | | | | | | | | and better-thought-out Hammer env.Bits() idioms: * env['PLATFORM'] == 'win32' => env.Bit('windows') * env['PLATFORM'] == 'posix' => env.Bit('linux') * env['PLATFORM'] == 'darwin' => env.Bit('mac') New idioms: * env.Bit('posix') => really does mean "any POSIX platform" * env.AnyBits('mac', 'linux') => specifically mac or linux, excluding other POSIX platforms Where we were using compound conditionals (e.g., "env['PLATFORM'] in ('posix', 'darwin')") I tried to take my best shot at translating the intent (i.e., "env.Bits('posix')" for something POSIX, "not env.Bits('mac')" for something not yet ported to Mac, etc.) Review URL: http://codereview.chromium.org/15051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98
* Switch back svn:eol-style=native for .sln, .vcproj and .vsprops files.maruel@chromium.org2008-12-161-650/+650
| | | | | | | Patch fails otherwise on non-Windows platforms. Review URL: http://codereview.chromium.org/14478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7093 0039d316-1c4b-4281-b951-d872f2087c98
* step one of some refactoring to allow other platforms to re-use the app ↵pinkerton@google.com2008-12-091-0/+6
| | | | | | | | initialization code. Review URL: http://codereview.chromium.org/13295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6627 0039d316-1c4b-4281-b951-d872f2087c98
* Changed svn:eol-style of all .sln and .vcproj files to CRLFscherkus@chromium.org2008-12-041-650/+650
| | | | | | Review URL: http://codereview.chromium.org/13133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
* Finish release (opt) builds on Windows, including the parallelsgk@google.com2008-11-201-18/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | build\*.scons structure (mirroring build\*.vsprops files): * Use env.ApplySConscript() instead of env.SConscript with a hand-crafted dictionary defining 'env'. * Move various CPPPATH, CCFLAGS, CPPDEFINES, LIBS and LIBPATH definitions from build/SConscript.main and target-specific *.scons files into the build\*.scons files that mirror the existing build\*.vsprops hierarchy. * Use the new build\{debug,release}.scons files to update the windows_dbg and windows_opt construction environments. * Mirror current support for CHROME_BUILD_TYPE and CHROMIUM_BUILD external environment variables. * Remove hard-coded /TP options. * Massage $CXXFLAGS to remove $CCFLAGS, avoiding duplication of options on command lines. Handle the ripple effect in $PCHCOM by adding $CCFLAGS back to that command line. * Delete hammer's default settings of {CC,LINK}FLAGS_{DEBUG,OPTIMIZED} so they don't pollute our construction environments. * Update chrome config to link against v8 for opt, v8_g for dbg. * Get rid of fragile by-hand order of using_net.scons before other using_*.scons files. We're now using --start-group and --end-group on Linux to deal with dependency cycles in libraries. Review URL: http://codereview.chromium.org/11478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5741 0039d316-1c4b-4281-b951-d872f2087c98
* We need to delete this critical section otherwisensylvain@chromium.org2008-11-181-0/+1
| | | | | | | | application verifier warns all the time. Review URL: http://codereview.chromium.org/11408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5593 0039d316-1c4b-4281-b951-d872f2087c98
* Application Verifier hooks GetProcAddress and returnsnsylvain@chromium.org2008-11-183-5/+12
| | | | | | | | | | | | pointer to functions in its own dll instead. When we try to patch these functions, we fail because the appverif dll is not loaded yet. We need to get the real pointers to the NT functions. Review URL: http://codereview.chromium.org/11412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5591 0039d316-1c4b-4281-b951-d872f2087c98
* Return the right error code when we proxy a callnsylvain@chromium.org2008-11-136-24/+70
| | | | | | | | | | | | | | | | | | | | | to the broker. IIRC we decided to always return access denied because we did not want to leak the real error code, but this is bogus for 2 reasons: 1. The broker will return access denied if it's not allowed in the policy 2. The check to hide the return code is in the renderer, so it would have been possible for a malicious user to see it anyway. I also added a test for it. BUG:3965 Review URL: http://codereview.chromium.org/10615 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5388 0039d316-1c4b-4281-b951-d872f2087c98
* Enforces strong DEP all the time. Use the /NXCOMPAT linker flag on ↵maruel@chromium.org2008-11-041-33/+1
| | | | | | | | chrome.exe so there's no need to call anything on Vista and later to activate it. Review URL: http://codereview.chromium.org/9050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4609 0039d316-1c4b-4281-b951-d872f2087c98
* Set the thread name for the sandbox event thread.deanm@chromium.org2008-11-041-0/+3
| | | | | | Review URL: http://codereview.chromium.org/9263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4581 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SCons build of the sandbox module, splitting out the individualsgk@google.com2008-10-272-259/+100
| | | | | | | targets into the new *.scons file naming scheme. Review URL: http://codereview.chromium.org/8616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4000 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back switch to hammer patterns again.bradnelson@chromium.org2008-10-201-12/+5
| | | | | | Review URL: http://codereview.chromium.org/7530 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3637 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in new hammer patterns. Restored from rollback change 3578.bradnelson@chromium.org2008-10-181-5/+12
| | | | | | Review URL: http://codereview.chromium.org/7656 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3597 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back CL 3578, discovered hammer.bat had not been updated yet.bradnelson@chromium.org2008-10-181-12/+5
| | | | | | Review URL: http://codereview.chromium.org/7507 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3582 0039d316-1c4b-4281-b951-d872f2087c98
* Applying software construction toolkit patterns in scons build.bradnelson@chromium.org2008-10-171-5/+12
| | | | | | Review URL: http://codereview.chromium.org/6569 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3578 0039d316-1c4b-4281-b951-d872f2087c98
* Klocwork bug. The dtor of Win2kThreadpool needs to be virtual sincecpu@google.com2008-10-083-23/+14
| | | | | | | | | | | the object is destroyed thru the base. - Removed UnRegisterWait loop in dtor. BUG=3108 Review URL: http://codereview.chromium.org/6247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3057 0039d316-1c4b-4281-b951-d872f2087c98
* One more header guard fix to trigger the build.nsylvain@chromium.org2008-09-281-3/+3
| | | | | | Review URL: http://codereview.chromium.org/4320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2663 0039d316-1c4b-4281-b951-d872f2087c98
* One more simple change to trigger the buildbots.nsylvain@chromium.org2008-09-281-3/+3
| | | | | | | This is just fixing the header guard Review URL: http://codereview.chromium.org/4319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2662 0039d316-1c4b-4281-b951-d872f2087c98
* I'm testing the buildbots, I needed a small change to triggernsylvain@chromium.org2008-09-281-3/+3
| | | | | | | them. Review URL: http://codereview.chromium.org/4318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2661 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SCons sandbox builds to parallel accumulated VS changes:sgk@google.com2008-09-231-9/+8
| | | | | | | | | * Add CHROMIUM_BUILD and _SECURE_ATL defines. * No /Wp64. * Add unload_dll_test.cc. Review URL: http://codereview.chromium.org/4224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2505 0039d316-1c4b-4281-b951-d872f2087c98
* Use of null string on DLLMatch happens on the botscpu@google.com2008-09-201-1/+2
| | | | | | | | | | - Not in my machine unless I incredibuild. - But change makes sense. Review URL: http://codereview.chromium.org/4006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2436 0039d316-1c4b-4281-b951-d872f2087c98
* Redo change 2413 that I had to back out beforecpu@google.com2008-09-2014-66/+339
| | | | | | | | | | | - CL is identical and was already lgtm TBR=rvargas Review URL: http://codereview.chromium.org/3179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory corruption when EAT patching in sandboxcpu@google.com2008-09-191-9/+9
| | | | | | Review URL: http://codereview.chromium.org/3174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2425 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-09-06 09:42:18 +0000