summaryrefslogtreecommitdiffstats
path: root/sandbox
Commit message (Collapse)AuthorAgeFilesLines
* sandbox: Fix uninitialized data in non-jumping bpf instructionsleecam2014-10-032-23/+22
| | | | | | | | | | | | | Non-jumping BPF instructions ignore the jt/jf fields and should be set to zero. This CL corrects an issues where these fields were left uninitialized, resulting in non-zero values. BUG=406116 TEST=sandbox_linux_unittests Linux & Android Review URL: https://codereview.chromium.org/607473002 Cr-Commit-Position: refs/heads/master@{#298039}
* Cleanup sandbox/ in advance of re-enabling some MSVC warnings.pkasting2014-10-0210-116/+67
| | | | | | | | | | | In most files this means removing unused variables/code. BUG=none TEST=none Review URL: https://codereview.chromium.org/614813002 Cr-Commit-Position: refs/heads/master@{#297931}
* Rename all isolate_dependency_* to files.maruel2014-10-012-2/+1
| | | | | | | | | | | | | Merges the lists when relevant. This simplify the management significantly. Remove the .isolate from the '*_run' target 'includes' section. TBR=vadimsh@chromium.org BUG=swarming:148 Review URL: https://codereview.chromium.org/614923005 Cr-Commit-Position: refs/heads/master@{#297633}
* Linux sandbox: Restrict sched_* syscalls on the GPU and ppapi processes.rickyz2014-09-293-10/+14
| | | | | | | | BUG=399473,413855 Review URL: https://codereview.chromium.org/598203004 Cr-Commit-Position: refs/heads/master@{#297248}
* Linux sandbox: Allow restricting sched_* on other processes.rickyz2014-09-265-0/+160
| | | | | | | | | | | | | | | | Adds a RestrictSchedTarget parameter restriction which only allows sched_* syscalls if the pid argument is the sandboxed process's pid or if the pid is 0, which means the current thread. glibc's pthread implementation sometimes calls these syscalls with pid equal to the current tid. On these calls, the policy triggers a SIGSYS, and the SIGSYS handler reruns the syscall with a pid argument of 0. R=jln@chromium.org BUG=413855 Review URL: https://codereview.chromium.org/590213003 Cr-Commit-Position: refs/heads/master@{#297059}
* Linux sandbox: fill all parameters when detecting seccomp syscall.Julien Tinnes2014-09-251-12/+9
| | | | | | | | | | BUG=417888 R=keescook@google.com TBR=rsesek Review URL: https://codereview.chromium.org/604123002 Cr-Commit-Position: refs/heads/master@{#296836}
* Remove implicit HANDLE conversions from sandbox.rvargas2014-09-258-23/+24
| | | | | | | | | BUG=416722 R=wfh@chromium.org Review URL: https://codereview.chromium.org/606443002 Cr-Commit-Position: refs/heads/master@{#296580}
* sandbox: Avoid ~(flag1 | flag2 | ...) expressionsmdempsky2014-09-232-15/+14
| | | | | | | | BUG=416948 Review URL: https://codereview.chromium.org/600583002 Cr-Commit-Position: refs/heads/master@{#296262}
* sandbox: Convert remaining legacy tests to use policy classesMatthew Dempsky2014-09-2310-186/+169
| | | | | | | | | BUG=414363 R=jln@chromium.org Review URL: https://codereview.chromium.org/588143007 Cr-Commit-Position: refs/heads/master@{#296212}
* Linux sandbox: Remove CodeGen::JoinInstructions.rickyz2014-09-183-65/+25
| | | | | | | | | | Recent refactoring has made this function unnecessary. BUG=414363 Review URL: https://codereview.chromium.org/565713004 Cr-Commit-Position: refs/heads/master@{#295423}
* [MIPS] Fix seccomp-bpf compile error for MIPSGordana.Cmiljanovic2014-09-171-0/+5
| | | | | | | | | | | | This change fixes the seccomp-bpf compile error introduced by change: https://chromium.googlesource.com/chromium/src/+/ab2d46af89c657ab4fd01ab00de1ba2a6ad73f8d BUG=408845 Review URL: https://codereview.chromium.org/569333003 Cr-Commit-Position: refs/heads/master@{#295291}
* fix sandbox memory leakcpu2014-09-171-11/+20
| | | | | | | | | | | | | | | The memory allocated by AllocAndCopyName was not being freed if the in-process policy engine did not allow the request to query the broker. This was nicely reported by typo.pl@gmail.com TEST=see bug BUG=414039 Review URL: https://codereview.chromium.org/575623004 Cr-Commit-Position: refs/heads/master@{#295220}
* Decouple CodeGen from ErrorCodemdempsky2014-09-174-46/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | CodeGen's only dependency on ErrorCode was one MakeInstruction() overload, which can be removed by making the caller responsible for converting the ErrorCode to a BPF_RET'able value. Fortunately, there are only two uses of this function: 1. SandboxBPF::RetExpression() which is easily fixed by simply calling ErrorCode::err() to get the ErrorCode's error value. 2. codegen_unittest.cc which is merely testing the BPF code generator, and so any return values will do: no need to be seccomp-bpf return values... so just replace them with simple integer values. (While here, change a few bare "BPF_RET" arguments to "BPF_RET + BPF_K" just to be consistent.) After this CL, CodeGen focuses solely on assembling programs for the abstract BPF machine, while higher-level abstractions (primarily SandboxBPF) are responsible for using it in a way that's semantically meaningful for seccomp-bpf. BUG=414363 Review URL: https://codereview.chromium.org/576673003 Cr-Commit-Position: refs/heads/master@{#295192}
* Large IWYU cleanup for seccomp-bpfmdempsky2014-09-1621-41/+67
| | | | | | | | | | | | | | | | | | | | | I'm reasonably confident that all of the seccomp-bpf/*.h files are now IWYU clean. There might still be some missing/superfluous #include lines in some of the .cc files, but it should overall be much better than before. Two particular changes to note: 1. "base/basictypes.h" is deprecated in favor of <stdint.h> (for standard *int*_t types) and/or "base/macros.h" for DISALLOW_*() macros. 2. This also moves the #include "foo.h" lines to the top of each foo.cc file, per style guide. BUG=408845 Review URL: https://codereview.chromium.org/570163003 Cr-Commit-Position: refs/heads/master@{#295161}
* Decouple Trap from ErrorCodemdempsky2014-09-166-103/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | This CL makes a few changes in the direction of removing dependencies on ErrorCode by pushing them up a layer: - Trap now simply uses TrapKeys directly to store trap function and metadata instead of needlessly encoding them as ErrorCode. - MakeTrap returns a bare trap ID and it's instead the caller's responsibility to encode in an ErrorCode if needed, which is now handled by ErrorCode's trap constructor. - Also, ErrorCodeFromTrapId() is replaced by IsSafeTrapId() to answer the one question that SandboxBPF was interested in knowing about existing traps. - Change a few SandboxBPF trap-constructing functions into static functions since they don't depend on any SandboxBPF instance member variables. BUG=414363 Review URL: https://codereview.chromium.org/572753002 Cr-Commit-Position: refs/heads/master@{#295121}
* Split AssembleFilter into comprehensible chunksmdempsky2014-09-162-149/+205
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously SandboxBPF constructed the CodeGen Instruction sequence primarily in one large, complex function. Additionally, it made extensive use of the CodeGen::JoinInstructions() function to conditionally arrange various bits of instructions, which made it harder to follow. This CL splits the Instruction assembly code into 5 mostly distinct functions and eliminates all use of JoinInstruction() in favor of function composition. E.g., instead of foo = gen->MakeInstruction(...); bar = gen->MakeInstruction(...); gen->JoinInstructions(foo, bar); this CL favors writing MakeFoo(MakeBar()) with the convention that Instruction-constructing functions should arrange for control to transfer to the Instruction sequence argument when complete. (I.e., "continuation-passing style": http://en.wikipedia.org/wiki/Continuation-passing_style) BUG=414363 Review URL: https://codereview.chromium.org/568053005 Cr-Commit-Position: refs/heads/master@{#295015}
* Linux sandbox: Disallow get_robust_list and set_robust_list.rickyz2014-09-162-1/+3
| | | | | | | | | These are only used for futexes that are shared between processes, which should not be happening in Chromium. BUG=413855 Review URL: https://codereview.chromium.org/569713004 Cr-Commit-Position: refs/heads/master@{#294986}
* Linux sandbox: restrict clock_gettime() and clock_getres()jln2014-09-133-1/+14
| | | | | | | | | | | | | | In the baseline policy, we restrict the |clk_id| parameter allowed in clock_gettime(). This applies to all sandboxed process types. In the renderer policy, we similarly restrict the |clk_id| parameter for clock_getres(). BUG=413469, 413855 Review URL: https://codereview.chromium.org/566083002 Cr-Commit-Position: refs/heads/master@{#294751}
* Convert sandbox_bpf_unittest.cc to use bpf_dslmdempsky2014-09-137-419/+461
| | | | | | | | | | | | | | | | | | | This unfortunately means converting what are currently sandbox_bpf unit tests into effectively integration tests for bpf_dsl, as they now test both bpf_dsl + sandbox_bpf. However, this is a necessary step towards eliminating dependencies on the current sandbox_bpf API so that we can more freely evolve it to fit bpf_dsl's needs. For ease of review, this only converts tests that were already using SandboxBPFPolicy (i.e., BPF_TEST()s are left alone), and some of the conversions are slightly non-idiomatic in the interest of mimicking the existing test structure. Both of these will be addressed further in followup CLs so that this CL can be reviewed as a mere translation of policies from the sandbox_bpf API to bpf_dsl. Review URL: https://codereview.chromium.org/559653004 Cr-Commit-Position: refs/heads/master@{#294723}
* Make "rt" library Linux-only in GN build.Brett Wilson2014-09-121-1/+4
| | | | | | | | | | | This was added to fix the component build on Linux, but Android doesn't have this library. R=jamesr@chromium.org TBR=jamesr Review URL: https://codereview.chromium.org/567073002 Cr-Commit-Position: refs/heads/master@{#294680}
* Add "rt" to libs of GN build linux sandbox unittests.Brett Wilson2014-09-121-0/+2
| | | | | | | | | | This is causing a compile failure in component mode. TBR=dpranke Review URL: https://codereview.chromium.org/566023003 Cr-Commit-Position: refs/heads/master@{#294658}
* Remove --find-inode-switch hack from chrome-sandboxmdempsky2014-09-126-194/+3
| | | | | | | | | | | | Chrome was modified back in May 2014 to use SCM_CREDENTIALS instead of --find-inode-switch and we haven't any heard any negative feedback, so it's time to remove --find-inode-switch entirely. BUG=357670 Review URL: https://codereview.chromium.org/569533002 Cr-Commit-Position: refs/heads/master@{#294649}
* Linux sandbox: fix MIPS Android compilation bug.jln2014-09-121-0/+5
| | | | | | | | | | | third_party/lss includes headers that are broken on Android. Don't use LSS on Android and disable the corresponding test. BUG=413635 Review URL: https://codereview.chromium.org/569633002 Cr-Commit-Position: refs/heads/master@{#294607}
* Cleanup: Use base/files/file_util.h instead of base/file_util.h in [r-t]*/thestig2014-09-127-7/+7
| | | | | | | | TBR=sergeyu@chromium.org,cpu@chromium.org,thakis@chromium.org,jamesr@chromium.org,zea@chromium.org,nduca@chromium.org Review URL: https://codereview.chromium.org/560883003 Cr-Commit-Position: refs/heads/master@{#294543}
* Linux sandbox: move RestrictClockID() to sandbox/jln2014-09-126-0/+165
| | | | | | | | | | | | We move RestrictClockID() from the NaCl NonSFI sandbox to the main helpers in sandbox/. BUG=413469 TBR=brettw Review URL: https://codereview.chromium.org/563043005 Cr-Commit-Position: refs/heads/master@{#294533}
* Enable futex tests on Android.jln2014-09-122-5/+12
| | | | | | | | | | Also fix the type of death messages expected in these tests. BUG=398611 Review URL: https://codereview.chromium.org/563913002 Cr-Commit-Position: refs/heads/master@{#294497}
* Linux sandbox: allow sigaltstack in Android baseline policy.jln2014-09-111-4/+3
| | | | | | | | | | | Allow sigaltstack on Android as it is needed for thread creation. On AARCH64, we now restrict setpriority() like on any architecture. BUG=398611 Review URL: https://codereview.chromium.org/568533002 Cr-Commit-Position: refs/heads/master@{#294486}
* Linux sandbox: restrict {set,get}priority() in baseline policy.Julien Tinnes2014-09-114-1/+54
| | | | | | | | | | | | | | | In the baseline policy, we restrict setpriority() to |which| == PRIO_PROCESS and (|who| == 0) || (|who| == current_pid). This doesn't affect most policies which allow setpriority() unconditionally but allows baseline unittests to pass on Android. BUG=398611, 399473 R=mdempsky@chromium.org Review URL: https://codereview.chromium.org/430363003 Cr-Commit-Position: refs/heads/master@{#294422}
* Fix sbox_validation_tests for Server 2012R2drbasic2014-09-111-1/+1
| | | | | | | | | | | | Windows Server 2012 returns code 1285L instead of ERROR_ACCESS_DENIED. So sbox_validation_tests fails on Windows Server 2012 R2. R=cpu@chromium.org BUG=411859 Review URL: https://codereview.chromium.org/543003002 Cr-Commit-Position: refs/heads/master@{#294335}
* GN: Enable blink and (nearly) all of content in android buildJames Robinson2014-09-101-29/+33
| | | | | | | | | | | | | This enables all blink targets and nearly all content targets in the android build. This produces a content shell APK, but not a fully operational one yet. This also flips on a bunch of other targets pulled in by deps. R=brettw@chromium.org Review URL: https://codereview.chromium.org/561623002 Cr-Commit-Position: refs/heads/master@{#294247}
* Reorganize sandbox operator new, add a comment.Nico Weber2014-09-101-8/+14
| | | | | | | | | | | | | | | | Now that NT_PAGE is gone, rewrite the function to be single-return and add a comment pointing out that what the function is doing is incomplete. No intended behavior change, should fix 2 clang warnings of the form ..\..\sandbox\win\src\sandbox_nt_util.cc(560,3) : warning(clang): 'operator new' should not return a null pointer unless it is declared 'throw()' or 'noexcept' [-Wnew-returns-null] return NULL; ^ BUG=82385 R=rvargas@chromium.org Review URL: https://codereview.chromium.org/556293002 Cr-Commit-Position: refs/heads/master@{#294246}
* bpf_dsl: fix argument-dependent lookup of BoolExpr operatorsmdempsky2014-09-102-5/+8
| | | | | | Review URL: https://codereview.chromium.org/543333002 Cr-Commit-Position: refs/heads/master@{#294127}
* Remove NT_PLACE, it's not really used.thakis2014-09-103-3/+10
| | | | | | | | | | | | | | | | | operator new(size_t size, void* buffer, sandbox::AllocationType type) just returns buffer, which is what the default placement new operator does too. No intended behavior change. (The motivation is to get rid of the two "return NULL"s in `operator delete(void* memory, sandbox::AllocationType type)`, as they are undefined behavior.) BUG=none Review URL: https://codereview.chromium.org/544333002 Cr-Commit-Position: refs/heads/master@{#294119}
* Sandbox: Don't CloseHandle after calling DuplicateHandlervargas2014-09-101-4/+0
| | | | | | | | | | | DuplicateHandle closes the handle even if there's an error. BUG=412200 R=cpu@chromium.org Review URL: https://codereview.chromium.org/554163002 Cr-Commit-Position: refs/heads/master@{#294078}
* sandbox: remove seccomp-bpf demo programmdempsky2014-09-093-574/+0
| | | | | | | | | The demo program has served its purpose, and it's no longer necessary to demonstrate how to use seccomp-bpf. Review URL: https://codereview.chromium.org/554743006 Cr-Commit-Position: refs/heads/master@{#293901}
* Mark gtest and gmock as testonly in GN.Brett Wilson2014-09-081-0/+1
| | | | | | | | | | | This updates the targets that depend on these to also be test-only. BUG=http://crbug.com/412064 R=jamesr@chromium.org, tfarina@chromium.org Review URL: https://codereview.chromium.org/551933002 Cr-Commit-Position: refs/heads/master@{#293808}
* NonSFI sandbox: restrict futex(2) operations.jln2014-09-081-2/+0
| | | | | | | | | | | We restrict futex operations to everything but "priority inheritance". BUG=408847 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32 Review URL: https://codereview.chromium.org/549653002 Cr-Commit-Position: refs/heads/master@{#293776}
* win: Don't use precision with %wZ, it's ignored.Nico Weber2014-09-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | Found by clang, which says: ..\..\sandbox\win\sandbox_poc\pocdll\handles.cc(156,34) : warning(clang): precision used with 'Z' conversion specifier, resulting in undefined behavior [-Wformat] "Type: %-13.13wZ Path: %wZ\r\n", ~~~~^~~~~ "undefined behavior" is a bit too strong language for a vendor-defined type, but http://msdn.microsoft.com/en-us/library/0ecbz014.aspx doesn't document what precision does for %Z, and in practice it seems to be ignored (see http://llvm.org/PR20876). So don't use it. No intended behavior change. BUG=82385 R=scottmg@chromium.org TBR=cpu Review URL: https://codereview.chromium.org/552663004 Cr-Commit-Position: refs/heads/master@{#293757}
* Added logging in PolicyBase::AddRule.vitalybuka2014-09-072-78/+93
| | | | | | | | | | | Should help to investigate sandbox failures on user side. Logs from the attached bug have records about failed start of utility process, but without clues about cause. BUG=408184 Review URL: https://codereview.chromium.org/546903002 Cr-Commit-Position: refs/heads/master@{#293647}
* bpf_dsl: support Switch/Case expressionsMatthew Dempsky2014-09-064-28/+202
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds support for expressions like Switch(arg) .Case(1, result1) .CASES((2, 3), result2) .Default(result3) Currently these expressions are compiled simply as short-hand for If(arg == 1, result1) .ElseIf(arg == 2 || arg == 3, result2) .Else(result3) but in the future we should be able to optimize it better. The CASES macro ugliness is unfortunately necessary until we're allowed to use C++11. Later we'll be able to change it to real C++ code like "Cases({2, 3}, result2)" (which clang-format will then format a bit more nicely too). BUG=408845 R=jln@chromium.org, jorgelo@chromium.org Review URL: https://codereview.chromium.org/438683004 Cr-Commit-Position: refs/heads/master@{#293599}
* Linux sandbox: whitelist allowed Futex operations.Julien Tinnes2014-09-053-19/+75
| | | | | | | | | | | | | Remove the existing blacklist and whitelist allowed futex operations instead. The semantics change a little bit as none of the "priority inheritance" operations are allowed. BUG=408847 R=mdempsky@chromium.org Review URL: https://codereview.chromium.org/550473002 Cr-Commit-Position: refs/heads/master@{#293589}
* More compiler whack-a-mole.Nico Weber2014-09-051-28/+14
| | | | | | | | | | | | | | | | | | | | clang didn't like the reinterpret_cast either: ..\..\sandbox\win\sandbox_poc\pocdll\registry.cc(24,10) : error(clang): case value is not a constant expression case reinterpret_cast<LONG_PTR>(HKEY_USERS): ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ..\..\sandbox\win\sandbox_poc\pocdll\registry.cc(24,10) : note(clang): reinterpret_cast is not allowed in a constant expression Since this function doesn't prevent any duplication, just kill it and pass the string to Try() manually. No behavior change. BUG=82385 R=cpu@chromium.org Review URL: https://codereview.chromium.org/543153002 Cr-Commit-Position: refs/heads/master@{#293580}
* Add more casts.thakis2014-09-051-6/+6
| | | | | | | | | | | | | | | | Fixes several clang/win errors like ..\..\sandbox\win\sandbox_poc\pocdll\registry.cc(24,10) : error(clang): value of type 'HKEY' (aka 'HKEY__ *') is not implicitly convertible to 'LONG_PTR' (aka 'long') case HKEY_USERS: ^~~~~~~~~~ Also fix a format string warning while here. No intended behavior change. BUG=82385 Review URL: https://codereview.chromium.org/542863002 Cr-Commit-Position: refs/heads/master@{#293540}
* win/clang: Fix all remaining -Wformat warnings.Nico Weber2014-09-055-23/+23
| | | | | | | | | | | | | | | We recently switched from building chromium_builder_tests to building everything, this fixes almost all warnings in the ~1000 translation units we weren't compiling before. No behavior change. BUG=82385 R=scottmg@chromium.org TBR=cpu Review URL: https://codereview.chromium.org/543923002 Cr-Commit-Position: refs/heads/master@{#293393}
* bpf_dsl: support arbitrary (arg & mask) == val expressionsMatthew Dempsky2014-09-049-372/+457
| | | | | | | | | | | | | | | | | | | | | Rework the seccomp_bpf compiler internals to work in terms of a single general masked-equality condition instead of the variety of limited condition operators previously supported. All of the peephole optimizations previously applied continue to be supported so similar instructions should be emitted, but the handling of upper/lower words is more cleanly structured now. The old sandbox->Cond() interface continues to be supported for now so that the old seccomp_bpf_unittests continue to give us assurances that the new code generator is still correct. Meanwhile, we provide a new lower-level sandbox->CondMaskedEqual() method that bpf_dsl can now use. BUG=408845 R=jln@chromium.org Review URL: https://codereview.chromium.org/530133003 Cr-Commit-Position: refs/heads/master@{#293347}
* sandbox: Fix RedirectToUserSpacePolicyWrapperleecam2014-09-033-24/+112
| | | | | | | | | | | | | This fixes RedirectToUserSpacePolicyWrapper to handle ERRNO ErrorCodes that are behind Conditional ErrorCodes. BUG=408953 TEST=sandbox_linux_unittests: Added new test Review URL: https://codereview.chromium.org/524603002 Cr-Commit-Position: refs/heads/master@{#293116}
* Revert of Revert of clang/win: Fix a few warnings in targets not in ↵thakis2014-08-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium_builder_tests. (patchset #1 id:1 of https://codereview.chromium.org/519463003/) Reason for revert: Reland, wasn't the reason for the redness. (https://codereview.chromium.org/521703002/ was.) Original issue's description: > Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) > > Reason for revert: > Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 > > InstallerStateTest.InitializeTwice (run #1): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) > > InstallerStateTest.InitializeTwice (run #2): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) > > > Original issue's description: > > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > > > Also don't use "default" as a variable name, as it's a keyword. > > Also fix a bug where a wstring was passed to %ls. > > > > No real behavior change. > > > > BUG=82385 > > R=hans@chromium.org > > TBR=cpu, vitalybuka > > > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 > > TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=82385 > > Committed: https://chromium.googlesource.com/chromium/src/+/dae20dafcfd3ccc439ccc5b3d5e21ad611d13c23 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/525013003 Cr-Commit-Position: refs/heads/master@{#292818}
* Revert of clang/win: Fix a few warnings in targets not in ↵thakis2014-08-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) Reason for revert: Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 InstallerStateTest.InitializeTwice (run #1): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) InstallerStateTest.InitializeTwice (run #2): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) Original issue's description: > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > Also don't use "default" as a variable name, as it's a keyword. > Also fix a bug where a wstring was passed to %ls. > > No real behavior change. > > BUG=82385 > R=hans@chromium.org > TBR=cpu, vitalybuka > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/519463003 Cr-Commit-Position: refs/heads/master@{#292809}
* clang/win: Fix a few warnings in targets not in chromium_builder_tests.Nico Weber2014-08-291-1/+1
| | | | | | | | | | | | | | | Also don't use "default" as a variable name, as it's a keyword. Also fix a bug where a wstring was passed to %ls. No real behavior change. BUG=82385 R=hans@chromium.org TBR=cpu, vitalybuka Review URL: https://codereview.chromium.org/526513002 Cr-Commit-Position: refs/heads/master@{#292699}
* sandbox: style cleanupMatthew Dempsky2014-08-293-52/+96
| | | | | | | | | | Based on readability review by Dean Berris at Google. R=jln@chromium.org Review URL: https://codereview.chromium.org/511993005 Cr-Commit-Position: refs/heads/master@{#292698}
generated by cgit v1.1 at 2025-03-18 00:16:09 +0000